GE_BLKNO, ExclusiveLock))
return;
workMemory = work_mem;
}
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_ginInsertCleanup.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
On Wed, Nov 8, 2017 at 5:41 AM, Robert Haas wrote:
> On Mon, Nov 6, 2017 at 4:42 AM, Masahiko Sawada wrote:
>>>> I suggest that a good thing to do more or less immediately, regardless
>>>> of when this patch ends up being ready, would be to insert an
>>>>
On Wed, Nov 8, 2017 at 11:20 AM, Michael Paquier
wrote:
> On Wed, Nov 8, 2017 at 1:58 AM, Alexander Korotkov
> wrote:
>> On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada
>> wrote:
>>> I understood the necessity of this patch and reviewed two patches.
>>
>>
On Wed, Nov 8, 2017 at 6:36 AM, Robert Haas wrote:
> On Mon, Nov 6, 2017 at 11:22 PM, Masahiko Sawada
> wrote:
>> Attached the patch for $subject.
>
> Committed.
>
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software
Hi,
I found that EXTRA_INSTALL is doubly set at both top and bottom of the
src/test/recovery/Makefile. Is it necessary?
Attached patch fixes this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
remove_duplicate_setting.patch
Description
heck.patch, it looks good to me. I found no
problem. But for wal-check-on-bloom-check.patch, if you want to run
wal-check even when running 'make check' or 'make check-world', we can
just add wal-check test as follows?
diff --git a/contrib/bloom/Makefile b/contrib/bloom/Makefile
in
Hi,
Attached the patch for $subject.
s/reamin/remain/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_dsm_impl_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Mon, Oct 30, 2017 at 3:17 PM, Masahiko Sawada wrote:
> On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas wrote:
>> On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada
>> wrote:
>>> Since the previous patch conflicts with current HEAD, I attached the
>>> updated pa
On Sat, Nov 4, 2017 at 7:04 AM, Alexander Korotkov
wrote:
> On Wed, Nov 1, 2017 at 5:55 AM, Masahiko Sawada
> wrote:
>>
>> On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov
>> wrote:
>> > On Tue, Oct 31, 2017 at 5:16 AM, Masahiko Sawada
>> > wrote:
ecially for VACUUM VERBOSE log, since the log
messages could be very long when the table has multiple indices this
patch would be useful for users.
Since the previous patch conflicts with current HEAD, attached the
updated patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEP
On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov
wrote:
> On Tue, Oct 31, 2017 at 5:16 AM, Masahiko Sawada
> wrote:
>>
>> On Mon, Oct 30, 2017 at 10:16 PM, Robert Haas
>> wrote:
>> > On Tue, Oct 24, 2017 at 1:26 PM, Ivan Kartyshov
>> > wrote:
>
0801753 in BackendRun (port=0x240) at postmaster.c:4357
> #21 0x00800e5f in BackendStartup (port=0x240) at
> postmaster.c:4029
> #22 0x007fd398 in ServerLoop () at postmaster.c:1753
> #23 0x007fc92f in PostmasterMain (argc=3, argv=0x244d6e0) at
> postmaster.c:1361
> #24 0x00734f08 in main (argc=3, argv=0x244d6e0) at main.c:228
>
>
>
> The reason of this deadlock seems to be clear: ALTER SUBSCRIPTION starts
> transaction at one node and tries to create slot at other node, which
> waiting for completion of all active transaction while building scnapshpot.
> Is there any way to avoid this deadlock?
I think that there is no way to avoid this deadlock except for
refreshing subscriptions sequentially. One solution I came up with is
to change ALTER TABLE REFRESH so that we can specify replication slot
names used for table sync, or can accord the ERRCODE_DUPLICATE_OBJECT
error when creating a replication slot. These are obviously poor
solutions, though.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ster server to a block that has been truncated on the old master,
the WAL apply on the new standby will fail? I guess there are such
corner cases causing failures of WAL replay after switch-over.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
On Mon, Oct 30, 2017 at 5:48 PM, Ashutosh Bapat
wrote:
> On Thu, Oct 26, 2017 at 7:41 PM, Masahiko Sawada
> wrote:
>>
>> Because I don't want to break the current user semantics. that is,
>> currently it's guaranteed that the subsequent reads can see the
>
On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas wrote:
> On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada
> wrote:
>> Since the previous patch conflicts with current HEAD, I attached the
>> updated patch for next CF.
>
> I think we should back up here and ask ourselv
On Thu, Oct 26, 2017 at 2:36 PM, Ashutosh Bapat
wrote:
> On Wed, Oct 25, 2017 at 3:15 AM, Masahiko Sawada
> wrote:
>>
>> Foreign Transaction Resolver
>> ==
>> I introduced a new background worker called "foreign transaction
>> resolve
On Fri, Sep 8, 2017 at 4:32 AM, Masahiko Sawada wrote:
> On Fri, Sep 8, 2017 at 7:24 AM, Thomas Munro
> wrote:
>> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada
>> wrote:
>>> The previous patch conflicts with current HEAD, I rebased the patch to
>>>
On Mon, Oct 23, 2017 at 10:43 AM, Amit Langote
wrote:
> On 2017/10/22 5:25, Thomas Munro wrote:
>> On Sun, Oct 22, 2017 at 5:09 AM, Robert Haas wrote:
>>> On Tue, Sep 19, 2017 at 3:31 AM, Masahiko Sawada
>>> wrote:
>>>>> Down at the bottom of the buil
e of a table bloat. The same
> discussion could be applied to analyze but it might be the
> another issue.
>
> There may be a better way to indicate the vacuum soundness. Any
> opinions and suggestions are welcome.
>
> I'm going to make a patch to do the 'forma
Hi,
Attached a patch for $subject.
s/RAIDUS/RADIUS/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_auth_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
On Tue, Sep 5, 2017 at 3:41 PM, Kyotaro HORIGUCHI
wrote:
> Thank you for the opinions.
>
> At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada
> wrote in
>> On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas wrote:
>> > On Mon, Aug 28, 2017 at 5:26 AM, Ky
gt;
> The patch needs a rebase in the documentation because of the xml-ilization
> of the sgml doc.
>
Thank you for the notification! Attached rebased patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
pgbench_custom_initializati
ke FROZEN, and hide COMMITTED|INVALID. Similar for other
> combos.
>
FWIW, I agree with this direction. ISTM the showing the raw flags by
default and having an option to show combined flags would be a right
way.
I sometimes wanted to have the same mechanism for lp_flags but maybe
it should be
that I really
wanted to skip.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Oct 12, 2017 at 11:30 PM, Robert Haas wrote:
> On Thu, Oct 12, 2017 at 6:55 AM, Petr Jelinek
> wrote:
>> Thanks for the patch, looks correct to me.
>
> Committed and back-patched to v10.
>
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE
On Thu, Oct 12, 2017 at 5:02 AM, Robert Haas wrote:
> On Mon, Oct 9, 2017 at 10:59 PM, Masahiko Sawada
> wrote:
>> Attached a patch for $subject. ISTM these are mistakes of copy-and-paste.
>
> Committed, but isn't the code itself wrong as well in the DELETE case?
>
send at least the begin and commit data to all subscriptions and
then wait for the reply from them but can we skip to wait them, for
example, when the walsender actually didn't send any data modified by
the transaction?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATI
On Tue, Oct 10, 2017 at 11:29 AM, Masahiko Sawada wrote:
> On Mon, Oct 9, 2017 at 11:13 PM, Aleksander Alekseev
> wrote:
>> Hi hackers,
>>
>> I've found something that looks like a bug.
>>
>> Steps to reproduce
>> --
>>
>&
Hi,
Attached a patch for $subject. ISTM these are mistakes of copy-and-paste.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_comment_in_execReplication_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql
`
> k | v
> +---
> k1 | v1;v4
> ```
>
> This is what would happen if all insert/update queries would have been
> executed on one instance.
>
> Actual result
> -
>
> Replication fails, log contains:
>
> ```
> [3227] ERROR: duplic
On Tue, Sep 19, 2017 at 4:31 PM, Masahiko Sawada wrote:
> On Tue, Sep 19, 2017 at 3:33 PM, Thomas Munro
> wrote:
>> On Fri, Sep 8, 2017 at 10:37 PM, Masahiko Sawada
>> wrote:
>>> Since v4 patch conflicts with current HEAD I attached the latest version
>
;> We have locked the same tuple in RelationFindReplTupleByIndex() just
>> before this gets called and didn't get the same error. I guess we do
>> something wrong with snapshots. Will need to investigate more.
>>
>
> Okay, so it's not snapshot. It's the fact tha
d I found no problems in this
patch. I've marked it as Ready for Committer.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sat, Sep 30, 2017 at 12:42 AM, Robert Haas wrote:
> On Wed, Sep 27, 2017 at 11:15 PM, Masahiko Sawada
> wrote:
>> I think that making a resolver process have connection caches to each
>> foreign server for a while can reduce the overhead of connection to
>> foreign se
On Wed, Sep 27, 2017 at 4:05 PM, Ashutosh Bapat
wrote:
> On Wed, Sep 27, 2017 at 12:11 PM, Masahiko Sawada
> wrote:
>> On Tue, Sep 26, 2017 at 9:50 PM, Robert Haas wrote:
>>> On Tue, Sep 26, 2017 at 5:06 AM, Masahiko Sawada
>>> wrote:
>>>> Ba
On Tue, Sep 26, 2017 at 9:50 PM, Robert Haas wrote:
> On Tue, Sep 26, 2017 at 5:06 AM, Masahiko Sawada
> wrote:
>> Based on the review comment from Robert, I'm planning to do the big
>> change to the architecture of this patch so that a backend process
>> w
On Tue, Sep 26, 2017 at 6:57 PM, Pavel Stehule wrote:
>
>
> 2017-09-26 11:56 GMT+02:00 Pavel Stehule :
>>
>>
>>
>> 2017-09-26 11:51 GMT+02:00 Masahiko Sawada :
>>>
>>> On Tue, Sep 26, 2017 at 2:50 AM, Pavel Stehule
>>> wrot
>> of pg_stat_replication should only be empty if there is nothing running.
>>
>
> I did some inserts, updates, ..
>
> I can recheck it - it was done on 10 RC
I guess CREATE SUBSCRIPTION failed for whatever reason (e.g, wal_level
< logical on the master). Didn't you get errors from CREATE
SUBSCRIPTION?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Iterate fdw_xact entries using the index, and resolve the foreign
transactions.
3-a. If even one foreign transaction failed to resolve, raise an error.
4. Change the waiting backend state to FDWXACT_COMPLETED and release it.
Also, the resolver process scans over the array of fdw_xact entry
periodical
t;Catchup".
>
> And, I don't find any issues with code and patch to me is ready for
> committer, marked the same in cf entry.
>
Thank you for the reviewing the patch!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
On Mon, Sep 25, 2017 at 8:22 PM, Michael Paquier
wrote:
> On Mon, Sep 25, 2017 at 7:57 PM, Masahiko Sawada
> wrote:
>> FWIW, the same thing can happen when specifying an invalid replication
>> origin name to pg_replication_origin_advance() and
>> pg_replication_origin_pr
nch. The test_sub can start the
replication by ALTER SUBSCRIPTION test_sub ENABLE.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Sep 25, 2017 at 5:36 AM, Erik Rijkers wrote:
> comments improvements
>
For triggers.sql.20170924.diff file, you need to update
expected/triggers.out file as well.
--
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Se
s would mean a few more cycles in lock management, but since this
>> only applies to a manual VACUUM or ANALYZE that specifies a table
>> name, I'm not too concerned about that.
>
> I think that I am +1 on that. Testing such a thing I am not seeing
> anything wrong either. The call
On Fri, Sep 22, 2017 at 5:31 PM, Kyotaro HORIGUCHI
wrote:
> At Fri, 22 Sep 2017 17:21:04 +0900, Masahiko Sawada
> wrote in
>> On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI
>> wrote:
>> > At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada
>> > wrote
On Sat, Sep 23, 2017 at 4:06 AM, Peter Eisentraut
wrote:
> On 9/21/17 04:43, Masahiko Sawada wrote:
>>> Once we got this patch, DROP SUBSCRIPTION is not transactional either
>>> if dropping a replication slot or if the subscription got disabled in
>>> a transactio
On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI
wrote:
> At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada
> wrote in
>> On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI
>> wrote:
>> > I was just looking the thread since it is found left alone for a
&
On Fri, Sep 22, 2017 at 3:46 PM, Michael Paquier
wrote:
> On Fri, Sep 22, 2017 at 3:24 PM, Masahiko Sawada
> wrote:
>> I have a question. Since WALInsertLockRelease seems not to call
>> LWLockWaitForVar I thought you wanted to mean LWLockReleaseClearVar
>> instead, is th
On Fri, Sep 22, 2017 at 3:00 PM, Michael Paquier
wrote:
> On Fri, Sep 22, 2017 at 11:34 AM, Masahiko Sawada
> wrote:
>> You're right. I updated the patch so that it exits do_pg_abort_backup
>> if the state is NONE and setting the state to NONE in
>> do_pg_stop_ba
reund wrote:
>> > Hi,
>> >
>> > On 2017-04-01 03:05:07 +0900, Masahiko Sawada wrote:
>> >> On Fri, Mar 31, 2017 at 11:44 PM, Robert Haas
>> >> wrote:
>> >> [ lots of valuable discussion ]
>> >
>> > I think this patch clearly
uier
> wrote:
>> On Thu, Sep 21, 2017 at 4:40 PM, Masahiko Sawada
>> wrote:
>>> On Thu, Sep 21, 2017 at 2:25 PM, Michael Paquier
>>> wrote:
>>>> +- Assert(XLogCtl->Insert.nonExclusiveBackups >= 0);
>>>> + if (XLogCtl->Insert.n
On Sun, Sep 17, 2017 at 2:01 AM, Masahiko Sawada wrote:
> On Sat, Sep 16, 2017 at 9:52 PM, Peter Eisentraut
> wrote:
>> On 9/15/17 13:35, Arseny Sher wrote:
>>> Peter Eisentraut writes:
>>>
>>>> Here is a simple patch that fixes this, based on my
> easy to invoke, easy to extend as well, which I'm planning to do once it
> gets in.
>
> I switched the patch to "Ready for Committers". No doubt they will have
> their own opinions about it. Let's wait and see.
Thank you for the reviewing this patch!!
Regar
On Thu, Sep 21, 2017 at 2:25 PM, Michael Paquier
wrote:
> On Thu, Sep 21, 2017 at 1:07 AM, Masahiko Sawada
> wrote:
>> The bug can happen in PostgreSQL 9.1 or higher that non-exclusive
>> backup has been introduced, so we should back-patch to the all
>> supported versi
e data generation message check.
>
Thank you, fixed it.
> Otherwise all is well for me.
>
Attached the updated version patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
pgbench_custom_initialization_v15.patch
Description: Bi
s.
I changed do_pg_abort_backup() so that it decrements
nonExclusiveBackups only if > 0. Feedback is very welcome.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/x
rs once. I do not think that it is worth trying to check for the v
> repetition, so I suggest to remove one from the first test. Repetition of '
> ' is checked with the second test.
Agreed.
> Maybe you could check that the data generation message is there.
Added the check.
On Tue, Sep 19, 2017 at 2:48 PM, Masahiko Sawada wrote:
> On Tue, Sep 19, 2017 at 8:33 AM, David Steele wrote:
>> On 9/18/17 7:26 PM, Michael Paquier wrote:
>>> On Tue, Sep 19, 2017 at 8:14 AM, David Steele wrote:
>>>> On 8/31/17 11:56 PM, Michael Paquier wrote:
backend themselves, so that's a reliable source. In Postgres
> 10, pg_stat_activity is also able to show to users what are the
> backends waiting for a change to be flushed/applied on the standby
> using the wait event called SyncRep. You could make some use of that
> as well.
Re
On Tue, Sep 19, 2017 at 3:33 PM, Thomas Munro
wrote:
> On Fri, Sep 8, 2017 at 10:37 PM, Masahiko Sawada
> wrote:
>> Since v4 patch conflicts with current HEAD I attached the latest version
>> patch.
>
> Hi Sawada-san,
>
> Here is an interesting failure with th
e
>> still written to disk, so my take on the matter is to keep the code
>> simple.
>
> I'm OK with that.
>
> I'll give Masahiko some time to respond before marking it RFC.
>
Thanks, I'll review it and send a comment by this Wednesday.
--
Regard
On Fri, Sep 8, 2017 at 9:52 AM, Masahiko Sawada wrote:
> On Thu, Sep 7, 2017 at 4:15 PM, Fabien COELHO wrote:
>>
>>>> Very very minor comments that I should have noticed before, sorry for
>>>> this
>>>> additional round trip.
>>>
>>&g
hange as well.
>
Agreed. Thanks, again.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
on-transactional behaviour. Since these behaviours would
be complex for users I attached the documentation patch explaining it.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
diff --git a/doc/src/sgml/ref/drop_subscription.sgml b/do
On Thu, Sep 14, 2017 at 12:04 AM, Masahiko Sawada wrote:
> On Wed, Sep 13, 2017 at 8:00 PM, Arseny Sher wrote:
>> Peter Eisentraut writes:
>>> We can break this in any number of ways:
>>>
>>> - (your patch) Kill workers right away after ALTER SUBSCRI
given up here. One more idea that was not yet
> mentioned is to abandon attempts to drop subs and ROs simultenously and
> just garbage-collect replication origins periodically, but that doesn't
> sound as an elegant solution.
>
>
> Masahiko Sawada writes:
>
>>> I don't t
On Wed, Sep 13, 2017 at 12:48 AM, Arseny Sher wrote:
> Masahiko Sawada writes:
>
>> FWIW, perhaps we can change the replication origin management so that
>> DROP SUBSCRIPTION doesn't drop the replication origin and the apply
>> worker itself removes it when exit.
On Wed, Sep 6, 2017 at 3:28 PM, Masahiko Sawada wrote:
> On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher wrote:
>> Arseny Sher writes:
>>
>>> Attached patch fixes this by stopping workers before RO drop, as
>>> already done in case when we drop replication slo
On Tue, Aug 15, 2017 at 10:13 AM, Masahiko Sawada wrote:
> On Wed, Jul 26, 2017 at 5:38 PM, Masahiko Sawada
> wrote:
>> On Sun, Mar 5, 2017 at 4:09 PM, Masahiko Sawada
>> wrote:
>>> On Sun, Mar 5, 2017 at 12:14 PM, David Steele wrote:
>>>> On 3/4/17 9
On Fri, Sep 8, 2017 at 7:24 AM, Thomas Munro
wrote:
> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada
> wrote:
>> The previous patch conflicts with current HEAD, I rebased the patch to
>> current HEAD.
>
> Hi Masahiko-san,
>
> FYI this doesn't build anymore.
On Fri, Sep 8, 2017 at 8:25 AM, Thomas Munro
wrote:
> On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro
> wrote:
>> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada
>> wrote:
>>> The previous patch conflicts with current HEAD, I rebased the patch to
>>> current
atch get through, it should be tap tested.
>
Thank you for the remainder, I'll add tap tests once the patch got committed.
--
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to put short options in
> alphabetical and decreasing importance order. On this line, also add the
> information about the default, something like:
>
> -i, --ini...
> -I, --custom=[...]+ (default "ctgvp")
> ...
Agreed. Attached l
;s a bug. Added this to the open item.
The cause of this is commit 7e174fa7 which make subscription ddls kill
the apply worker only when transaction commit. I didn't look the patch
deeply yet but I'm not sure the approach that kills apply worker
before commit would be good.
Regards
misinterpreted the diff file. My apology if it is the case.
>
I understood. It looks ugly in the patch but can be applied properly
by git apply command. Attached latest patch incorporated the comments
I got so far.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source
initialize_cmds,
+ sizeof(char) * n_cmds + 1);
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Sep 5, 2017 at 12:24 PM, Michael Paquier
wrote:
> On Tue, Sep 5, 2017 at 12:05 PM, Masahiko Sawada
> wrote:
>> In get_rel_oids() we often switch the memory context to vac_context
>> and switch back. As a result almost code in get_rel_oids() is working
>> in v
get_rel_oids() we often switch the memory context to vac_context
and switch back. As a result almost code in get_rel_oids() is working
in vac_context. Maybe we can switch memory context before and after
the calling get_rel_oids?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORA
ory, pgbench_branches, pgbench_tellers,
> pgbench_accounts;"
Agreed, and fixed.
>
> In passing, I think that the documentation should tell explicitely what the
> default value is (aka "ctgvp").
Agreed.
Attached the latest patch. Please review it.
Regards,
test passed. Thanks.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
action, and truncate both (or all?) tables
> together.
Attached latest patch incorporated the comments I got so far. Please review it.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
pgbench_custom_initialization_v9.patch
Description: Binary data
lks_total,
- s.param5 AS heap_blks_scanned
-FROM (pg_stat_get_progress_info('CLUSTER'::text) s(pid, datid,
relid, param1, param2, param3, param4, param5)
- LEFT JOIN pg_database d ON ((s.datid = d.oid)));
pg_stat_replication| SELECT s.pid,
s.usesysid,
u.rolname AS usename,
--- 1866,1871
==
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
le is categorized in Permissions
Management. I think the adding new default roles can be categorized in
the same category to not confuse users and personally it's more
suitable.
"Add default monitoring roles (Dave Page)"
Thought?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHO
t.
Currently TRUNCATE pgbench_accounts command is executed within a
transaction started immediately before it. If we move it out of the
transaction, the table data will be truncated even if the copying data
failed. Maybe we can do TRUNCATE pgbench_accounts, pgbench_history
instead. Thought?
tables in reverse foreign key dependencies
> order"?
Fixed.
>
> case 'I': ISTM that initialize_cmds is necessarily already allocated, thus I
> would not bother to test before pg_free.
Agreed, fixed.
Attached latest patch. Please review it.
Regards,
--
Masahiko Sawada
small typo in dedupe_vacuum_relations_v2.patch.
+ /* if already procesed or not equal, skip */
+ if (list_member_int(duplicates, i) ||
relation->oid != nth_rel->oid)
+ continue;
s/procesed/processed/g
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
bout "u", though. Unlogged, like tablespace, is an orthogonal
> option: other table creation options (I intend to submit one which conforms
> to the TPC-B standard, that is use an INT8 balance as INT4 is not wide
> enough per spec, and always use an INT8 aid) may be also unlogged or
&g
uum
>
> I think it is mostly okay, but it is the last time to think about it. Using
> "d" for cleanup (drop) would mean finding another letter for filling in
> data... maybe "g" for data generation? "c" may have been chosen for "create
> table"
ges to separate log files by error level or purpose (server log
and SQL log etc).
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
On Thu, Aug 24, 2017 at 4:27 PM, Masahiko Sawada wrote:
> On Thu, Aug 24, 2017 at 3:11 AM, Josh Berkus wrote:
>> On 08/22/2017 11:04 PM, Masahiko Sawada wrote:
>>> WARNING: what you did is ok, but you might have wanted to do something else
>>>
>>> First of a
how aggressive if it's
> aggressive and not insert anything at all otherwise. That'd probably
> require two separate translatable strings in each case, but maybe
> that's OK.
>
> What do other people think?
FWIW I prefer the Robert's idea; not insert anything if norma
of
> returning false.
Agreed, fixed.
After more thought, I'm bit inclined to not have a short option for
--custom-initialize because this option will be used for not primary
cases. It would be better to save short options for future
enhancements of pgbench. Thought?
Attached latest pat
will trigger another fprintf and error above... ISTM that you should
> either take into account previous comments or explain why you disagree with
> them, but not send the same code without addressing them in any way.
Sorry, I didn't mean to ignore, I'd just missed the comm
er even if -j option is
specified.
I sometimes search a particular table/index from the logs but also in
that case it was hard to distinguish logs. This is still not primary
case though.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
-
On Fri, Aug 25, 2017 at 4:27 PM, vinayak
wrote:
>
>
> On 2017/08/25 16:18, Masahiko Sawada wrote:
>>
>> On Fri, Aug 25, 2017 at 2:57 PM, vinayak
>> wrote:
>>>
>>> Hi Sawada-san,
>>>
>>>
>>> On 2017/08/25 11:07, Masahiko Sawa
On Fri, Aug 25, 2017 at 2:57 PM, vinayak
wrote:
> Hi Sawada-san,
>
>
> On 2017/08/25 11:07, Masahiko Sawada wrote:
>>
>> On Fri, Aug 18, 2017 at 5:20 PM, vinayak
>> wrote:
>>>
>>> On 2017/06/20 17:35, vinayak wrote:
>>>>
>>>
On Fri, Aug 18, 2017 at 5:20 PM, vinayak
wrote:
>
> On 2017/06/20 17:35, vinayak wrote:
>>
>> Hi Sawada-san,
>>
>> On 2017/06/20 17:22, Masahiko Sawada wrote:
>>>
>>> On Tue, Jun 20, 2017 at 1:51 PM, vinayak
>>> wrote:
>>>>
>
On Thu, Aug 24, 2017 at 3:11 AM, Josh Berkus wrote:
> On 08/22/2017 11:04 PM, Masahiko Sawada wrote:
>> WARNING: what you did is ok, but you might have wanted to do something else
>>
>> First of all, whether or not that can properly be called a warning is
>> highly
o we expect that the length of
initialization steps would not long. Using malloced string would less
the work. Ok, I changed the patch so.
Attached latest v4 patch. Please review it.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
.
Feedback and comment are very welcome.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
1 - 100 of 730 matches
Mail list logo
