Re: [HACKERS] Pluggable storage

2017-08-01 Thread Haribabu Kommi
On Sun, Jul 23, 2017 at 4:10 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 11:33 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > I am finding out that eliminating the HeapTuple usage in the upper layers > >

Re: [HACKERS] Pluggable storage

2017-08-13 Thread Haribabu Kommi
On Sun, Aug 13, 2017 at 5:21 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Aug 12, 2017 at 10:34 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > On Tue, Aug 8, 2017 at 2:21 PM, Amit Kapila <amit.kapil...@gmail.com> > wrote: >

Re: [HACKERS] parallelize queries containing initplans

2017-08-13 Thread Haribabu Kommi
On Fri, Aug 11, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 6:51 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > > > + if (IsA(plan, Gather)) > > + ((Gather *) plan)->initParam = bms_interse

Re: [HACKERS] Pluggable storage

2017-08-11 Thread Haribabu Kommi
On Tue, Aug 8, 2017 at 2:21 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Jun 13, 2017 at 7:20 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera < > alvhe...@2ndquadrant.com>

Re: [HACKERS] Pluggable storage

2017-08-11 Thread Haribabu Kommi
On Mon, Aug 7, 2017 at 11:12 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Aug 1, 2017 at 1:56 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > > > On Sun, Jul 23, 2017 at 4:10 PM, Amit Kapila <amit.kapil...@gmail.com> > &

[HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

2017-07-13 Thread Haribabu Kommi
On Fri, Jul 14, 2017 at 2:54 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 05/03/2017 07:32 AM, Haribabu Kommi wrote: > >> [Adding -hackers mailing list] >> >> On Fri, Apr 28, 2017 at 6:28 PM, <henry_boehl...@agilent.com> wrote: >> >>

Re: [HACKERS] Pluggable storage

2017-07-19 Thread Haribabu Kommi
On Sat, Jul 15, 2017 at 12:30 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Jul 14, 2017 at 8:35 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > To replace tuple with slot, I took trigger and SPI calls as the first > step > > in modifyi

Re: [HACKERS] Pluggable storage

2017-06-27 Thread Haribabu Kommi
; wrote: >> > On Tue, Jun 13, 2017 at 4:50 AM, Haribabu Kommi < >> kommi.harib...@gmail.com> >> > wrote: >> >> >> >> On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera < >> alvhe...@2ndquadrant.com> >> >> wrote: >&g

Re: [HACKERS] parallelize queries containing initplans

2017-08-08 Thread Haribabu Kommi
On Mon, Jul 17, 2017 at 10:53 PM, Amit Kapila wrote: > On Tue, Mar 28, 2017 at 7:25 AM, Amit Kapila > wrote: > > On Thu, Mar 16, 2017 at 2:34 AM, Kuntal Ghosh > > wrote: > >> On Tue, Mar 14, 2017 at 3:20 PM, Amit

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Haribabu Kommi
On Wed, Aug 9, 2017 at 9:26 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > For the following query the parallel plan is not chosen. The query > contains >

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Haribabu Kommi
On Wed, Aug 9, 2017 at 8:54 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > I tested the latest patch and the parallel plan is getting choose for > most > &

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-08-20 Thread Haribabu Kommi
On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/4/17 01:06, Haribabu Kommi wrote: > > Both pg_dump and pg_upgrade tests are passed. Updated patch attached > > I will add this patch to the next commitfest. > > Thi

Re: [HACKERS] Pluggable storage

2017-08-22 Thread Haribabu Kommi
On Tue, Aug 15, 2017 at 4:53 PM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > > On 2017-06-13 11:50:27 +1000, Haribabu Kommi wrote: > > Here I attached WIP patches to support pluggable storage. The patch > series > > are may not work individuall

Re: [HACKERS] Pluggable storage

2017-08-22 Thread Haribabu Kommi
On Mon, Aug 21, 2017 at 7:25 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 21, 2017 at 12:58 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > On Sun, Aug 13, 2017 at 5:17 PM, Amit Kapila <amit.kapil...@gmail.com> > > wrote:

Re: [HACKERS] pg_stat_wal_write statistics view

2017-09-11 Thread Haribabu Kommi
On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Wed, Sep 6, 2017 at 9:16 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > Attached the latest patch and performance report. > > > While looking into the patc

Re: [HACKERS] utility commands benefiting from parallel plan

2017-09-15 Thread Haribabu Kommi
On Thu, Sep 14, 2017 at 2:42 PM, Rafia Sabih <rafia.sa...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 2:29 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Wed, Sep 13, 2017 at 4:17 PM, Rafia Sabih < > rafia.sa...@enterprise

Re: [HACKERS] visual studio 2017 build support

2017-09-21 Thread Haribabu Kommi
On Fri, Sep 22, 2017 at 7:03 AM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 08/25/2017 11:29 PM, Haribabu Kommi wrote: > > > > > > On Fri, Aug 25, 2017 at 11:27 PM, Christian Ullrich > > <ch...@chrullrich.net <mailto:ch...@chrull

Re: [HACKERS] Windows warnings from VS 2017

2017-09-21 Thread Haribabu Kommi
On Thu, Sep 21, 2017 at 12:26 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 09/20/2017 08:18 PM, Andrew Dunstan wrote: > > > > On 09/20/2017 07:54 PM, Tom Lane wrote: > >> Andrew Dunstan writes: > >>> It's also warning that it will copy 16

Re: [HACKERS] SERIALIZABLE with parallel query

2017-09-18 Thread Haribabu Kommi
On Tue, Sep 19, 2017 at 11:42 AM, Thomas Munro < thomas.mu...@enterprisedb.com> wrote: > On Fri, Sep 1, 2017 at 5:11 PM, Thomas Munro > wrote: > > On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro > > wrote: > >> [ssi-parallel-v5.patch]

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-10-04 Thread Haribabu Kommi
On Sat, Sep 30, 2017 at 3:31 AM, Robert Haas wrote: > On Fri, Sep 29, 2017 at 12:44 AM, Vaishnavi Prabakaran > wrote: > > Option name "--enable-pgdumpall-behaviour" is very generic > > Yeah, that's a terrible name, at least in my opinion. >

Re: [HACKERS] Commitfest 201709 is now closed

2017-10-02 Thread Haribabu Kommi
On Tue, Oct 3, 2017 at 3:12 AM, Robert Haas wrote: > On Mon, Oct 2, 2017 at 11:57 AM, Tom Lane wrote: > > Daniel Gustafsson writes: > >> Thanks to everyone who participated, and to everyone who have responded > to my > >> nagging via

Re: [HACKERS] utility commands benefiting from parallel plan

2017-10-11 Thread Haribabu Kommi
On Fri, Oct 6, 2017 at 2:43 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Sep 15, 2017 at 2:22 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Thanks for the review. > > I committed this patch with some cosmetic changes. I think the fact &g

Re: [HACKERS] Pluggable storage

2017-10-12 Thread Haribabu Kommi
On Fri, Oct 13, 2017 at 8:23 AM, Robert Haas wrote: > On Thu, Oct 12, 2017 at 4:38 PM, Alexander Korotkov > wrote: > > It's probably that we imply different meaning to "MVCC implementation". > > While writing "MVCC implementation" I meant that,

Re: [HACKERS] Pluggable storage

2017-10-13 Thread Haribabu Kommi
On Fri, Oct 13, 2017 at 11:55 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Oct 12, 2017 at 8:00 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Currently I added a snapshot_satisfies API to find out whether the tuple > > satisfies the visibili

Re: [HACKERS] pg_stat_wal_write statistics view

2017-09-05 Thread Haribabu Kommi
On Tue, Aug 15, 2017 at 7:39 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/29/17 22:10, Haribabu Kommi wrote: > > Updated patch to use shared counter instead of adding pg_stat_ calls to > send > > the statistics from each background process/work

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2017-09-06 Thread Haribabu Kommi
On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra wrote: > On 7/25/17 12:55 AM, Tom Lane wrote: > >> Tomas Vondra writes: >> >>> It seems to me that VACUUM and ANALYZE somewhat disagree on what >>> exactly reltuples means. VACUUM seems to

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2017-09-05 Thread Haribabu Kommi
On Mon, Aug 14, 2017 at 6:48 AM, Marko Tiikkaja wrote: > On Fri, Jul 1, 2016 at 2:12 AM, I wrote: > >> Currently the tuple returned by INSTEAD OF triggers on DELETEs is only >> used to determine whether to pretend that the DELETE happened or not, which >> is often not helpful

Re: [HACKERS] utility commands benefiting from parallel plan

2017-09-13 Thread Haribabu Kommi
On Wed, Sep 13, 2017 at 4:17 PM, Rafia Sabih <rafia.sa...@enterprisedb.com> wrote: > On Fri, Sep 1, 2017 at 12:31 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > Hi All, > > > > Attached a rebased patch that supports parallelism for t

Re: [HACKERS] pg_stat_wal_write statistics view

2017-09-12 Thread Haribabu Kommi
On Tue, Sep 12, 2017 at 3:14 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Tue, Sep 12, 2017 at 9:06 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh < > kuntalghosh.2...@gmail.

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-09-08 Thread Haribabu Kommi
On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Mon, Aug 21, 2017 at 4:35 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut > > <peter.eisentr...@2ndquadrant

Re: [HACKERS] Pluggable storage

2017-09-11 Thread Haribabu Kommi
On Sat, Sep 9, 2017 at 1:23 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > I rebased the patch to the latest master and also fixed the duplicate OID > and some slot fixes. Updated patches are attached. > While analyzing the removal of HeapScanDesc usage other

Re: [HACKERS] SERIALIZABLE with parallel query

2017-09-26 Thread Haribabu Kommi
On Mon, Sep 25, 2017 at 6:57 PM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Mon, Sep 25, 2017 at 8:37 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > After I tune the GUC to go with sequence scan, still I am not getting the > > error &

Re: [HACKERS] visual studio 2017 build support

2017-09-26 Thread Haribabu Kommi
On Mon, Sep 25, 2017 at 10:12 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > On 09/25/2017 12:25 AM, Haribabu Kommi wrote: > > > > Thanks for pointing it out, I missed to check the Build tools support > > section. > > Here I attach

Re: [HACKERS] visual studio 2017 build support

2017-09-24 Thread Haribabu Kommi
On Fri, Sep 22, 2017 at 10:40 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 09/21/2017 08:16 PM, Haribabu Kommi wrote: > > > > > > I was about to commit this after a good bit of testing when I > > noticed this: > > >

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2017-09-24 Thread Haribabu Kommi
On Mon, Sep 25, 2017 at 4:39 AM, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > > > On 09/06/2017 09:45 AM, Haribabu Kommi wrote: > > > > > > On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra > > <tomas.von...@2ndquadrant.com <mailto:tomas.von...@2

Re: [HACKERS] SERIALIZABLE with parallel query

2017-09-25 Thread Haribabu Kommi
On Thu, Sep 21, 2017 at 4:13 PM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Tue, Sep 19, 2017 at 1:47 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > During testing of this patch, I found some behavior difference > > with the su

Re: [HACKERS] Pluggable storage

2017-08-21 Thread Haribabu Kommi
On Sun, Aug 13, 2017 at 5:17 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Aug 12, 2017 at 10:31 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > >> > >> Why do we need to store handler function in TupleDesc? As of now, the >

Re: [HACKERS] parallelize queries containing initplans

2017-08-21 Thread Haribabu Kommi
On Mon, Aug 14, 2017 at 8:41 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Aug 13, 2017 at 6:49 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Fri, Aug 11, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> > > wrote: >

Re: [HACKERS] visual studio 2017 build support

2017-08-25 Thread Haribabu Kommi
On Fri, Aug 25, 2017 at 11:27 PM, Christian Ullrich <ch...@chrullrich.net> wrote: > * On 2017-06-21 02:06, Haribabu Kommi wrote: > > Thanks for the review. Here I attached an updated patch with README update. >> > > Hello, > Thanks for the review. > the most

Re: [HACKERS] Pluggable storage

2017-08-25 Thread Haribabu Kommi
On Wed, Aug 23, 2017 at 11:59 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 23, 2017 at 11:05 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Mon, Aug 21, 2017 at 7:25 PM, Amit Kapila <amit.kapil...@gmail.com> >

Re: [HACKERS] Visual Studio 2017 Build Support

2017-09-01 Thread Haribabu Kommi
On Fri, Sep 1, 2017 at 11:06 AM, Tanay Varma <tanay.va...@microsoft.com> wrote: > > > Hello, > > > > This is with respect to the original thread on “visual studio 2017 build > support” created by Haribabu Kommi (kommi.harib...@gmail.com). > > >

Re: [HACKERS] utility commands benefiting from parallel plan

2017-09-01 Thread Haribabu Kommi
Hi All, Attached a rebased patch that supports parallelism for the queries that are underneath of some utility commands such as CREATE TABLE AS and CREATE MATERIALIZED VIEW. Note: This patch doesn't make the utility statement (insert operation) to run in parallel. It only allows the select query

Re: [HACKERS] pg_stat_wal_write statistics view

2017-09-27 Thread Haribabu Kommi
On Fri, Sep 22, 2017 at 5:46 PM, Julien Rouhaud <rjuju...@gmail.com> wrote: > Hello, > > On Wed, Sep 13, 2017 at 3:01 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > I ran the latest performance tests with and without IO times, there is an > > overhe

Re: [HACKERS] pg_stat_wal_write statistics view

2017-11-07 Thread Haribabu Kommi
On Wed, Sep 27, 2017 at 6:58 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Updated patch attached. > Patch rebased. Regards, Hari Babu Fujitsu Australia pg_stat_walwrites-statistics-view_v10.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 11:11 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 9:04 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > The commit 98267e missed to check the empty SGML tag, attached

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-11-07 Thread Haribabu Kommi
On Thu, Oct 26, 2017 at 10:01 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Oct 23, 2017 at 7:36 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Apologies for not providing much details. > > > > pg_dumpall is used to produce t

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-11-07 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 8:48 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 4:35 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > The newly added option is not recommended to be used in normal cases and > > it is used only for upgra

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 3:03 AM, Simon Riggs wrote: > On 5 November 2017 at 11:55, Magnus Hagander wrote: > > On Sat, Nov 4, 2017 at 4:04 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> > >> On Fri, Nov 3, 2017 at 4:04 PM, Petr

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-10-20 Thread Haribabu Kommi
On Fri, Oct 6, 2017 at 12:29 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Oct 4, 2017 at 3:40 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > There are some differences in handling database objects > > between pg_dump and pg_d

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-10-22 Thread Haribabu Kommi
On Sun, Oct 22, 2017 at 3:08 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Sat, Oct 21, 2017 at 1:30 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Before refactoring, pg_dumpall doesn't print "create database" commands > >

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-16 Thread Haribabu kommi
On 14 August 2013 Rushabh Lathia wrote: postgres=# create table test ( a timestamptz); CREATE TABLE -- Date with year 1000 postgres=# insert into test values ( 'Sat Mar 11 23:58:48 1000 IST'); INSERT 0 1 -- Now try with year 1 it will return error postgres=# insert into test values ( 'Sat

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-17 Thread Haribabu kommi
On Tue, 17 September 2013 14:33 Rushabh Lathia wrote: On Mon, Sep 16, 2013 at 7:22 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 August 2013 Rushabh Lathia wrote: postgres=# create table test ( a timestamptz); CREATE TABLE -- Date with year 1000

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-27 Thread Haribabu kommi
On 27 September 2013 15:04 Rushabh Lathia wrote: On Tue, Sep 17, 2013 at 6:23 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: I feel changing the year value to accept the length (4) is not simple. So many places the year length crossing more than length 4

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-10-04 Thread Haribabu kommi
On 03 October 2013 19:30 Bruce Momjian wrote: On Thu, Oct 3, 2013 at 11:54:14AM +0530, Rushabh Lathia wrote: Thanks Bruce. Yes for me main problem was to make assumption that a 5-digit number is a year, as was bit worried about side effect of that assumption in the date/time module. I

Re: [HACKERS] Compression of full-page-writes

2013-10-08 Thread Haribabu kommi
On 08 October 2013 15:22 KONDO Mitsumasa wrote: (2013/10/08 17:33), Haribabu kommi wrote: The checkpoint_timeout and checkpoint_segments are increased to make sure no checkpoint happens during the test run. Your setting is easy occurred checkpoint in checkpoint_segments = 256. I don't know

Re: [HACKERS] Compression of full-page-writes

2013-10-11 Thread Haribabu kommi
On 10 October 2013 23:06 Fujii Masao wrote: On Wed, Oct 9, 2013 at 1:35 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Thread-1 Threads-2 Head code FPW

[HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-11 Thread Haribabu kommi
vacuum is not happening on a heavily modified big table even if the dead tuples are more than configured threshold. This is because during at the end of vacuum, the number of dead tuples of the table is reset as zero, because of this reason the dead tuples which are occurred during the vacuum

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-15 Thread Haribabu kommi
On 12 October 2013 11:30 Tom Lane wrote: Haribabu kommi haribabu.ko...@huawei.com writes: To handle the above case instead of directly resetting the dead tuples as zero, how if the exact dead tuples are removed from the table stats. With this approach vacuum gets triggered frequently thus

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-20 Thread Haribabu kommi
On 20 October 2013 12:06 Amit Kapila wrote: On Tue, Oct 15, 2013 at 3:37 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 12 October 2013 11:30 Tom Lane wrote: Haribabu kommi haribabu.ko...@huawei.com writes: To handle the above case instead of directly resetting the dead tuples as zero

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-22 Thread Haribabu kommi
On 22 October 2013 10:15 Amit Kapila wrote: On Mon, Oct 21, 2013 at 10:54 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Yes, it's correct. nkeep counter have the dead tuples which are recently dead and are not vacuumed. The removal of tuples vacuumed from dead tuples should

[HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-10-24 Thread Haribabu kommi
Here I have added some more regression tests to improve the missing function coverage of schemacmds.c, user.c and tablespace.c. The added tests are mainly RENAME TO and OWNER TO support. patches are attached in the mail. please check and provide your suggestions. Regards, Hari babu.

[HACKERS] Ident context leak during reloading of conf files when no ident information is present in the file

2013-10-24 Thread Haribabu kommi
There is an ident context leak which is occurs during reload of configuration files when there is no ident configuration items are present in the configuration file. In function load_ident(), New context is allocated to store the new_parsed_lines and deletes the old context when

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-07 Thread Haribabu kommi
On 07 November 2013 09:42 Amit Kapila wrote: On Tue, Oct 22, 2013 at 2:09 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 22 October 2013 10:15 Amit Kapila wrote: On Mon, Oct 21, 2013 at 10:54 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Actually what I had in mind

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-11 Thread Haribabu kommi
On 08 November 2013 18:35 Amit Kapila wrote: On Fri, Nov 8, 2013 at 10:56 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 07 November 2013 09:42 Amit Kapila wrote: I am not sure whether the same calculation as done for new_rel_tuples works for new_dead_tuples, you can once check

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-12 Thread Haribabu kommi
On 12 November 2013 08:47 Amit Kapila wrote: On Mon, Nov 11, 2013 at 3:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 08 November 2013 18:35 Amit Kapila wrote: On Fri, Nov 8, 2013 at 10:56 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 07 November 2013 09:42 Amit

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-13 Thread Haribabu kommi
On 01 October 2013 00:56 Amit Kapila wrote: On Mon, Sep 30, 2013 at 9:07 PM, Peter Eisentraut pete...@gmx.net wrote: On 9/28/13 3:05 AM, Amit Kapila wrote: Now as we have an agreement, I had updated patch for below left issues: Regression tests are failing. Thanks for informing. I

[HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-14 Thread Haribabu kommi
Please find attached the patch, for adding a new option for pg_basebackup, to specify a different directory for pg_xlog. Design A new option: xlogdir is added to the list of options for pg_basebackup. The new option is not having an equivalent short option letter. This option will allow the

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-14 Thread Haribabu kommi
On 15 November 2013 10:00 Amit Kapila wrote: On Wed, Nov 13, 2013 at 12:02 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 12 November 2013 08:47 Amit Kapila wrote: On Mon, Nov 11, 2013 at 3:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 08 November 2013 18:35 Amit

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Please find attached the patch, for adding a new option for pg_basebackup, to specify a different directory for pg_xlog. Sounds good! Here are the review comments

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-16 Thread Haribabu kommi
On 16 November 2013 09:43 Amit Kapila wrote: On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 2:50 AM, Amit Kapila wrote: Find the rebased version attached with this mail. Doesn't build: openjade -wall -wno-unused-param -wno-empty

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-17 Thread Haribabu kommi
On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 11:19 Haribabu kommi wrote: On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Haribabu kommi
On 18 October 2013 13:35 KONDO Mitsumasa wrote: Hi, I submit improvement of pg_stat_statement usage patch in CF3. In pg_stat_statement, I think buffer hit ratio is very important value. However, it is difficult to calculate it, and it need complicated SQL. This patch makes it more simple

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-18 Thread Haribabu kommi
On 17 November 2013 12:25 Amit Kapila wrote: On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 16 November 2013 09:43 Amit Kapila wrote: On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 2:50 AM, Amit Kapila wrote

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 18:45 Fujii Masao wrote: On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 11:19 Haribabu kommi wrote: On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-18 Thread Haribabu kommi
On 18 November 2013 20:01 Amit Kapila wrote: On Mon, Nov 18, 2013 at 6:28 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 17 November 2013 12:25 Amit Kapila wrote: On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi Find the rebased version attached with this mail

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 23:25 Andres Freund wrote: On 2013-11-18 15:01:42 +, Haribabu kommi wrote: /* + * Returns the malloced string of containing current working directory. + * The caller has to take care of freeing the memory. + * On failure exits with error code. + */ +static

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-19 Thread Haribabu kommi
On 19 November 2013 09:59 Amit Kapila wrote: On Mon, Nov 18, 2013 at 8:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 20:01 Amit Kapila wrote: Code changes are fine. If two or three errors are present in the configuration file, it prints the last error

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Haribabu kommi
On 18 November 2013 23:30 Fujii Masao wrote: On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 18:45 Fujii Masao wrote: On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 11:19

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
On 19 November 2013 19:12 Fujii Masao wrote: On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 23:30 Fujii Masao wrote: On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Thanks for newer version

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
on 20 November 2013 23:44 Gavin Flower wrote: On 20/11/13 23:43, Haribabu kommi wrote: I tried using of stat'ing in two directories, which is having a problem in windows. So modified old approach to detect limited errors. Updated patch attached. This will detect and throw an error

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-21 Thread Haribabu kommi
On 19 November 2013 10:33 Amit Kapila wrote: If I understood correctly, then your patch's main intention is to correct the estimate of dead tuples, so that it can lead to Vacuum cleaning the table/index which otherwise is not happening as per configuration value (autovacuum_vacuum_threshold)

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-26 Thread Haribabu kommi
On 24 November 2013 03:04 David Rowley wrote: I've done a quick benchmark on this this morning. Note that I'm using windows here and I used powershell to time the regression run with the following command: PS D:\Postgres\b\src\tools\msvc Measure-Command { .\vcregress.bat check } I ran the tests

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-26 Thread Haribabu kommi
On 25 November 2013 10:43 Amit Kapila wrote: On Fri, Nov 22, 2013 at 12:12 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 19 November 2013 10:33 Amit Kapila wrote: If I understood correctly, then your patch's main intention is to correct the estimate of dead tuples, so that it can

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-26 Thread Haribabu kommi
On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two directories, which is having a problem in windows. So modified old approach to detect limited errors. Updated patch attached

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-28 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-29 Thread Haribabu kommi
On 29 November 2013 12:00 Amit Kapila wrote: On Tue, Nov 26, 2013 at 7:26 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 25 November 2013 10:43 Amit Kapila wrote: On Fri, Nov 22, 2013 at 12:12 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 19 November 2013 10:33 Amit

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-30 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2013-12-05 Thread Haribabu kommi
On 05 December 2013 21:16 Amit Kapila wrote: Note - a. Performance is data is taken on my laptop, needs to be tested on some better m/c b. Attached Patch is just a prototype of chunkwise concept, code needs to be improved and decode handling/test is pending. I ran the performance test

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-11 Thread Haribabu kommi
On 10 December 2013 19:55 Alvaro Herrera wrote: Haribabu kommi escribió: To detect provided data and xlog directories are same or not, I reused the Existing make_absolute_path() code as follows. 1. Moved the make_absolute_path() function from miscinit.c to path.c and Changed all

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-12-11 Thread Haribabu kommi
On 06 December 2013 11:57 Amit Kapila wrote: On Fri, Nov 29, 2013 at 6:55 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 29 November 2013 12:00 Amit Kapila wrote: On Tue, Nov 26, 2013 at 7:26 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Few questions about your latest

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-18 Thread Haribabu kommi
On 19 December 2013 05:31 Bruce Momjian wrote: On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: The make_absolute_path() function moving to port is changed in similar way as Bruce Momjian approach. The psprintf is used to store the error string which Occurred

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-20 Thread Haribabu kommi
On 20 December 2013 02:02 Bruce Momjian wrote: On Thu, Dec 19, 2013 at 05:14:50AM +, Haribabu kommi wrote: On 19 December 2013 05:31 Bruce Momjian wrote: On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: The make_absolute_path() function moving to port is changed

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-01-29 Thread Haribabu Kommi
On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: On 11/30/13, 6:59 AM, Haribabu kommi wrote: To detect provided data and xlog directories are same or not, I reused the Existing make_absolute_path() code as follows. I note that initdb does not detect whether the data and xlog

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-09 Thread Haribabu Kommi
On Sat, Feb 8, 2014 at 12:10 PM, Peter Eisentraut pete...@gmx.net wrote: On 1/29/14, 7:37 PM, Haribabu Kommi wrote: On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: On 11/30/13, 6:59 AM, Haribabu kommi wrote: To detect provided data and xlog directories are same

Re: contrib/cache_scan (Re: [HACKERS] What's needed for cache-only table scan?)

2014-02-11 Thread Haribabu Kommi
On Sat, Feb 8, 2014 at 1:09 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Hello, Because of time pressure in the commit-fest:Jan, I tried to simplifies the patch for cache-only scan into three portions; (1) add a hook on heap_page_prune for cache invalidation on vacuuming a particular page.

Re: contrib/cache_scan (Re: [HACKERS] What's needed for cache-only table scan?)

2014-02-12 Thread Haribabu Kommi
On Thu, Feb 13, 2014 at 2:42 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: 2014-02-12 14:59 GMT+09:00 Haribabu Kommi kommi.harib...@gmail.com: 7. In ccache_find_tuple function this Assert(i_min + 1 cchunk-ntups); can go wrong when only one tuple present in the block with the equal item

Re: [HACKERS] Per table autovacuum vacuum cost limit behaviour strange

2014-02-14 Thread Haribabu Kommi
On Feb 15, 2014 9:19 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Haribabu Kommi escribió: I changed the balance cost calculations a little bit to give priority to the user provided per table autovacuum parameters. If any user specified per table vacuum parameters exists and those

  1   2   3   4   5   6   >