Re: [HACKERS] Spread checkpoint sync

2011-02-03 Thread Michael Banck
On Sat, Jan 15, 2011 at 05:47:24AM -0500, Greg Smith wrote: For example, the pre-release Squeeze numbers we're seeing are awful so far, but it's not really done yet either. Unfortunately, it does not look like Debian squeeze will change any more (or has changed much since your post) at this

Re: [HACKERS] Bug tracker tool we need (was: Last gasp)

2012-04-16 Thread Michael Banck
On Mon, Apr 16, 2012 at 06:29:47PM +0200, Magnus Hagander wrote: FWIW, I think the closest thing we've found so far would be debbugs - which IIRC doesn't have any kind of reasonable database backend, which would be a strange choice for a project like ours :) And makes many things harder...

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Michael Banck
On Thu, Feb 10, 2011 at 06:04:46PM -0500, Tom Lane wrote: Less narrow-minded interpretation of GPL requirements, perhaps. (And yes, we have real lawyers on staff considering these issues.) Is their opinion public/can be made public? This might possibly lead to a re-evaluation of the situation

Re: [HACKERS] Debian readline/libedit breakage

2011-02-13 Thread Michael Banck
On Sun, Feb 13, 2011 at 12:56:03PM +0100, Dimitri Fontaine wrote: Magnus Hagander mag...@hagander.net writes: Yes, since according to a comment somewhere the same issue will bubble into ubuntu soon. At this point, definitely 8.04 and 10.04, and probably 10.10. If things can be easily

Re: [HACKERS] Commitfest II CLosed

2013-10-23 Thread Michael Banck
On Mon, Oct 21, 2013 at 11:10:09AM -0400, Tom Lane wrote: Heikki Linnakangas hlinnakan...@vmware.com writes: On 21.10.2013 16:15, Peter Eisentraut wrote: What is the alternative? If no-one really cares enough about a patch to review it, mark it as rejected, because no-one but the patch

[HACKERS] docs: additional subsection for page-level locks in explicit-locking section

2014-07-02 Thread Michael Banck
this was deliberate and/or rejected before (though I couldn't find prior discussion off-hand). Proposed patch attached. Cheers, Michael -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH, HRB

Re: [HACKERS] Is there a way to temporarily disable a index

2014-07-11 Thread Michael Banck
On Fri, Jul 11, 2014 at 11:07:21AM -0400, Tom Lane wrote: David G Johnston david.g.johns...@gmail.com writes: Benedikt Grundmann wrote That is it possible to tell the planner that index is off limits i.e. don't ever generate a plan using it? Catalog hacking could work but not

Re: [HACKERS] Proposal for updating src/timezone

2014-07-19 Thread Michael Banck
Hi, On Sat, Jul 19, 2014 at 09:28:25AM -0400, John Cochran wrote: Agreed. Right now, I'm seeing about updating zic.c to match the IANA code combined with the modifications that postgres did to it. So far, it doesn't look like many functional changes have been done, but due to the use of

[HACKERS] Log notice that checkpoint is to be written on shutdown

2014-10-02 Thread Michael Banck
, as this particular checkpoint might be important information. I've attached a trivial patch for this, should it be added to the next commitfest? Cheers, Michael -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH

Re: [HACKERS] Log notice that checkpoint is to be written on shutdown

2014-10-02 Thread Michael Banck
Hi, Am Donnerstag, den 02.10.2014, 08:17 -0700 schrieb David G Johnston: Michael Banck-2 wrote I've attached a trivial patch for this, should it be added to the next commitfest? Peeking at this provokes a couple of novice questions: While apparently it is impossible to have

Re: [HACKERS] Log notice that checkpoint is to be written on shutdown

2014-10-04 Thread Michael Banck
Am Freitag, den 03.10.2014, 12:07 -0300 schrieb Alvaro Herrera: Michael Banck wrote: diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 5a4dbb9..f2716ae 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c

Re: [HACKERS] Log notice that checkpoint is to be written on shutdown

2014-10-08 Thread Michael Banck
Hi, Am Samstag, den 04.10.2014, 15:05 -0500 schrieb Jim Nasby: On 10/4/14, 1:21 PM, Jeff Janes wrote: On Thu, Oct 2, 2014 at 6:21 AM, Michael Banck wrote: we have seen repeatedly that users can be confused about why PostgreSQL is not shutting down even though they requested

Re: [HACKERS] Log notice that checkpoint is to be written on shutdown

2014-10-16 Thread Michael Banck
Hi, Am Donnerstag, den 02.10.2014, 15:21 +0200 schrieb Michael Banck: we have seen repeatedly that users can be confused about why PostgreSQL is not shutting down even though they requested it. Usually, this is because `log_checkpoints' is not enabled and the final checkpoint is being

Re: [HACKERS] CREATE INDEX CONCURRENTLY?

2014-10-31 Thread Michael Banck
error (fair enough), or whether something could be done about this? Michael -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Hohenzollernstr. 133

Re: [HACKERS] Let's drop two obsolete features which are bear-traps for novices

2014-11-03 Thread Michael Banck
-on-postgresql-part-1.html [2] http://vitessedata.com/benchmark/ -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach

Re: [HACKERS] TODO request: log_long_transaction

2014-11-07 Thread Michael Banck
\d. Thoughts? Michael -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach Geschäftsführung: Dr. Michael

Re: [HACKERS] controlling psql's use of the pager a bit more

2014-11-13 Thread Michael Banck
at the beginning of the new output in order to retain current behaviour), so one could scroll up in the pager window. That would rock. Michael -- Michael Banck Tel.: +49 (0) 2161 / 4643-171 credativ GmbH, HRB Mönchengladbach 12080 Hohenzollernstr. 133, 41061 Mönchengladbach Geschäftsführung: Dr

Re: [HACKERS] Disabling trust/ident authentication configure option

2015-05-20 Thread Michael Banck
On Wed, May 20, 2015 at 07:03:26PM -0400, Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Michael Banck wrote: The other set of users I could think of are those who, for whatever reason, tend to always compile PostgreSQL from source for their company/organization. Maybe

Re: [HACKERS] Disabling trust/ident authentication configure option

2015-05-20 Thread Michael Banck
On Wed, May 20, 2015 at 02:10:30PM -0400, Tom Lane wrote: One reason why it would not be, if it's a build-time decision, is that it's quite unlikely that any popular packagers would build that way. So this would only be applicable to custom-built binaries, which is a pretty small class of

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-30 Thread Michael Banck
On Tue, Sep 29, 2015 at 12:08:56PM +1300, Gavin Flower wrote: > Linux kernel project uses bugzilla (https://bugzilla.kernel.org) AIUI this is not mandatory for kernel hackers, and more opt-in from a some/many/a few(?) subsystem maintainers. Some parts use it more, some less or not at all. > and

Re: [HACKERS] PostgreSQL Auditing

2016-02-02 Thread Michael Banck
aging pgaudit for Debian. However, then another question comes up: Should the 2nd Quadrant or the Crunchy Data codebase be added to the distribution? Who gets to decide? Alternatively, both could be added, but that will likely confuse users. Michael -- Michael Banck Projektleiter / Berater Tel

Re: [HACKERS] PostgreSQL Auditing

2016-02-02 Thread Michael Banck
rubber-stamp requirements is a different story, but at least I think it would be quite useful to ship auditing capabilites in the distribution. Michael -- Michael Banck Projektleiter / Berater Tel.: +49 (2161) 4643-171 Fax: +49 (2161) 4643-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mö

Re: [HACKERS] So, can we stop supporting Windows native now?

2016-04-01 Thread Michael Banck
On Thu, Mar 31, 2016 at 09:04:35AM +0800, Craig Ringer wrote: > If we eventually get a CMake build system conversion that'll mostly go > away too. Well, maybe the good message about this new development is that autotools will start working much better on Windows and could be eventually used for

Re: [HACKERS] Academic help for Postgres

2016-05-12 Thread Michael Banck
On Thu, May 12, 2016 at 08:57:34AM +0800, Craig Ringer wrote: > On 11 May 2016 at 22:20, Bruce Momjian wrote: > > I am giving a keynote at an IEEE database conference in Helsinki next > > week (http://icde2016.fi/). (Yes, I am not attending PGCon Ottawa > > because I accepted

Re: [HACKERS] 10.0

2016-05-14 Thread Michael Banck
On Fri, May 13, 2016 at 05:31:00PM -0400, David G. Johnston wrote: > The underlying premise, for me, of choosing .4 or .5 was that presently we > discontinue support after 5 years/releases. A new .0 would come out just > as we discontinue the previous .0 Well maybe the 5 year support cycle

Re: [HACKERS] 10.0

2016-05-14 Thread Michael Banck
On Fri, May 13, 2016 at 08:55:20PM -0400, David G. Johnston wrote: > The opinion seems to be that major.0 is some kind of magic incantation in > the broader world of users... >From my reading of the thread, while certainly that is the general definition of a .0, having infrequent .0 releases is

Re: [HACKERS] Is there a way around function search_path killing SQL function inlining?

2016-08-10 Thread Michael Banck
should be reconsidered in the light of the use case with materialized views during restore. Best regards, Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
ast), and if that is the case, whether we could mention that to our users as guidance for how to check for index corruption? Michael [1] https://github.com/petergeoghegan/amcheck -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de creda

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
hen rows that were updated by transactions running at the same time as the CREATE INDEX CONCURRENTLY command could have been index incorrectly." That sounds off to me, shouldn't it be "indexed incorrectly" or something? Michael -- Michael Banck Projektleiter / Senior Berater Tel.

Re: [HACKERS] Checksums by default?

2017-01-21 Thread Michael Banck
ession testing harder, as not all codepaths would get exercised all the time. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompete

Re: [HACKERS] Superowners

2017-01-26 Thread Michael Banck
database, but don't delete it) make sense/be useful for that maybe? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108,

[HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-02-21 Thread Michael Banck
sent, one for the main data directory and one for each additional tablespace other than pg_default and pg_global.", which makes it sound like the main data directory is first, but in my testing, this is not the case. -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax:

Re: [HACKERS] Change in "policy" on dump ordering?

2017-02-22 Thread Michael Banck
this comment is overly specific: any materialized view that references a view or table in a different schema (pg_catalog or not) will likely not refresh on pg_restore AIUI, so singling out system views doesn't look right to me. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax:

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-11 Thread Michael Banck
Hi, Am Samstag, den 11.02.2017, 11:25 +0100 schrieb Michael Banck: > Am Samstag, den 11.02.2017, 11:07 +0100 schrieb Magnus Hagander: > > As for the code, while I haven't tested it, isn't the "checkpoint > > completed" message in the wrong place? Doesn't PQsendQuery()

[HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-11 Thread Michael Banck
hen --verbose is used and adds a paragraph about the checkpoint being run to the Notes section of the documentation. Michael [1]https://about.gitlab.com/2017/02/10/postmortem-of-database-outage-of-january-31/ -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-11 Thread Michael Banck
messages are prepended with "pg_basebackup: " and which are translatable; I guess all messages printed on --verbose should be translatable? Also, as almost all messages have a "pg_basebackup: " prefix, I've added it to the rest. Michael -- Michael Banck Projektleiter / Senior

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-13 Thread Michael Banck
Hi, Am Montag, den 13.02.2017, 09:31 +0100 schrieb Magnus Hagander: > On Mon, Feb 13, 2017 at 3:29 AM, Jim Nasby <jim.na...@bluetreble.com> > wrote: > On 2/11/17 4:36 AM, Michael Banck wrote: > I guess you're right, I've mov

Re: [HACKERS] Change in "policy" on dump ordering?

2017-02-27 Thread Michael Banck
restored, and the owner revokes, which you would run last." > Patches for head attached. FWIW, Keven Grittner had proposed a more involved patch in https://www.postgresql.org/message-id/CACjxUsNmpQDL58zRm3EFS9atqGT8%2BX_2%2BFOCXpYBwWZw5wgi-A%40mail.gmail.com Michael -- Michael Ba

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-02-26 Thread Michael Banck
Hi, Am Sonntag, den 26.02.2017, 22:25 +0530 schrieb Robert Haas: > On Tue, Feb 21, 2017 at 3:47 PM, Michael Banck > <michael.ba...@credativ.de> wrote: > > So I am proposing the attached patch, which sends the base tablespace > > first, and then all the other external tabl

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-26 Thread Michael Banck
topic. So attached are two patches, I've split it up in the documentation and the code output part. I'll add it as one commitfest entry in the "Clients" section though, as it's not really a big patch, unless somebody thinks it should have a secon entry in "Documentation"? Mic

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-26 Thread Michael Banck
Hi, Am Sonntag, den 26.02.2017, 21:32 +0100 schrieb Magnus Hagander: > On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck > <michael.ba...@credativ.de> wrote: > Agreed, and applied as one patch. Except I noticed you also fixed a > couple of entries which were missing the progna

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-09-01 Thread Michael Banck
rstand where this is coming from, but wouldn't "standby", "replication" or something be more generally understood than "recover"? Streaming replication got bolted on to recovery, but that seems like an implementation detail by now. Michael -- Michael Banck Projektleiter /

Re: [HACKERS] Exclude schema during pg_restore

2016-09-02 Thread Michael Banck
Am Donnerstag, den 01.09.2016, 21:39 -0400 schrieb Peter Eisentraut: > On 8/31/16 4:10 AM, Michael Banck wrote: > > attached is a small patch that adds an -N option to pg_restore, in order > > to exclude a schema, in addition to -n for the restriction to a schema. > > I thin

[HACKERS] Exclude schema during pg_restore

2016-08-31 Thread Michael Banck
Hi, attached is a small patch that adds an -N option to pg_restore, in order to exclude a schema, in addition to -n for the restriction to a schema. In principle, this could be extended to -t etc., but I think having this for schemas would be the most useful with the least effort. One use case

Re: [HACKERS] Exclude schema during pg_restore

2016-08-31 Thread Michael Banck
Hi, Am Mittwoch, den 31.08.2016, 07:59 -0300 schrieb Fabrízio de Royes Mello: > Please add it to the next open commitfest. I had done so already: https://commitfest.postgresql.org/10/762/ Regards, Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax:

Re: [HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-05 Thread Michael Banck
On Wed, Oct 05, 2016 at 04:39:39PM +0200, Michael Banck wrote: > if pg_rewind is told to fetch data via a libpq connection > (--source-server), synchronous replication is enabled and there is only > one sync standby (pilot error, but sill); pg_rewinding the old master > hangs a

[HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-05 Thread Michael Banck
eat should be documented? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Me

[HACKERS] pg_rewind: Should abort if both --source-pgdata and --source-server are specified

2016-10-07 Thread Michael Banck
? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg

Re: [HACKERS] Exclude schema during pg_restore

2016-09-19 Thread Michael Banck
Hi, sorry, it took me a while to find time to look at this. On Thu, Sep 01, 2016 at 09:39:56PM -0400, Peter Eisentraut wrote: > On 8/31/16 4:10 AM, Michael Banck wrote: > > attached is a small patch that adds an -N option to pg_restore, in order > > to exclude a schema, in

Re: [HACKERS] Exclude schema during pg_restore

2016-09-22 Thread Michael Banck
Hi, On Tue, Sep 20, 2016 at 08:59:37PM -0400, Peter Eisentraut wrote: > On 9/19/16 3:23 PM, Michael Banck wrote: > > Version 2 attached. > > Committed, thanks. Thanks! > I added the new option to the help output in pg_restore. Oh, sorry I missed that. Michael

Re: [HACKERS] [PATCH] Reload SSL certificates on SIGHUP

2016-11-08 Thread Michael Banck
s I am not familiar with the Windows port at all I've marked it Ready for Committer for now. Thanks, Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-

Re: [HACKERS] [PATCH] Reload SSL certificates on SIGHUP

2016-11-22 Thread Michael Banck
gt; > >2) Rebased on master > > And here with a fix to a comment. Michael, as you brought up the issues with the SSL tests, do you plan to review the latest version (and add yourself as reviewer)? Michael -- Michael Banck Projektleiter / Senior Berater Tel: +49 2166 9901-171 F

Re: [HACKERS] [PATCH] Reload SSL certificates on SIGHUP

2016-11-03 Thread Michael Banck
This hunk baffled me at first because two lines below your added secure_destroy() declaration, the same line is already present. I did some digging and it turns out we had a secure_destroy() in the ancient past, but its implementation got removed in 2008 in 4e8162865 as there were no (more) users of it, howe

Re: [HACKERS] Replication/backup defaults

2017-01-05 Thread Michael Banck
thread, but I wonder whether the name "*max*_wal_senders" really conveys that dependence on wal_level (there's no comment to that end in the postgresql.conf sample) and/or whether maybe the admin should just be notified that WAL streaming is turned off cause wal_level < 'replica'? Mic

Re: [HACKERS] Reporting planning time with EXPLAIN

2016-12-28 Thread Michael Banck
On Wed, Dec 28, 2016 at 02:08:55PM +0100, Michael Banck wrote: > On Tue, Dec 27, 2016 at 09:26:21AM -0500, Stephen Frost wrote: > > * Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote: > > > We report planning and execution time when EXPLAIN ANALYZE is issued. > > &

Re: [HACKERS] Reporting planning time with EXPLAIN

2016-12-28 Thread Michael Banck
clearer than 'summary' to me. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung

Re: [HACKERS] Logical replication existing data copy

2017-03-23 Thread Michael Banck
aster.c:1337 #15 0x00477f27 in main (argc=3, argv=0xf9c420) at /home/mba/Projekte/OSS/PostgreSQL/git/postgresql/build/../src/backend/main/main.c:228 The TAP tests in src/test/subscriber pass for me, going back to 707576b571f05ec5b89adb65964d55f3bd1b also makes the above chai

Re: [HACKERS] Logical replication existing data copy

2017-03-24 Thread Michael Banck
eep 6 + psql -c SELECT application_name, state FROM pg_stat_replication; application_name | state --+--- sub1 | streaming (1 row) + psql --port=5433 -c SELECT COUNT(*) FROM t1; count --- 0 (1 row) --8<-- I would have assumed the inserted value to be

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-24 Thread Michael Banck
mer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer >From 4e37e110ac402e67874f729832b330a837284d4b Mon Sep 17 00:00:00 2001 From: Michael Banck <michael.ba...@credativ.de> Date: Fri, 24 Mar 2017 18:27:47 +0100 Subject: [

Re: [HACKERS] Logical replication existing data copy

2017-03-24 Thread Michael Banck
Am Freitag, den 24.03.2017, 14:57 -0400 schrieb Peter Eisentraut: > On 3/24/17 05:22, Michael Banck wrote: > > However, replication also seems to not work, I'm using the following > > script right now: > > The problem is that your publication does not include any tab

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2017-03-29 Thread Michael Banck
ot; sounds a bit awkward, maybe "actually using the same" would be better. > + /* > + * Last thing to do is to release the session-level lock on the parent > table > + * and the indexes of table. "and on the indexes of the table"? Or what exactly is meant with the last bit? >

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-03-29 Thread Michael Banck
The reason one might not want to run pg_basebackup directly is that this way one can pipe the output to an external program, e.g. to better compress it; this is not possible with pg_basebackup if you additional tablespaces. So I think that has some merit on its own. Michael -- Michael Banck P

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-03-29 Thread Michael Banck
nd, or is this still an open item? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführu

[HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-19 Thread Michael Banck
ecovery-conf --slot=pg2 $ echo $? 0 $ psql -c "DROP_REPLICATION_SLOT pg2" "host=127.0.0.1 port=5432 replication=database user=mba dbname=postgres" SELECT $ This would get us somewhat closer to near zero-config replication, in my opinion. Pardon me if that was discu

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-19 Thread Michael Banck
Hi, On Sun, Mar 19, 2017 at 05:01:23PM +0100, Magnus Hagander wrote: > On Sun, Mar 19, 2017 at 11:21 AM, Michael Banck <michael.ba...@credativ.de> > wrote: > > So I propose the attached tiny patch to just create the slot (if it does > > not exist already) in pg_base

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-03-17 Thread Michael Banck
Hi, Am Freitag, den 17.03.2017, 20:46 +0900 schrieb Michael Paquier: > On Fri, Mar 17, 2017 at 7:18 PM, Michael Banck > <michael.ba...@credativ.de> wrote: > > Am Freitag, den 17.03.2017, 10:50 +0900 schrieb Michael Paquier: > >> The comment block format is incor

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-20 Thread Michael Banck
slots. If you want to drop the slot after basebackup finishes you'd just use a temporary slot (i.e. the default), or am I understanding your use-case incorrectly? I assumed the primary use-case for creating a non-temporary slot is to keep it around while the standby is active. Michael

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-03-16 Thread Michael Banck
guarantee any ordering of tablespaces (to wit, Bernd was pretty sure it was the other way around all the time), neither do I think having the main tablespace be the first for non-WAL/stream and the last for WAL/fetch would be confusing personally, though I understand this is debatable. So I've

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-03-17 Thread Michael Banck
ry first, so that the |backup_label file is the first file to be sent. > FWIW, I have no issue with changing the ordering of backups the way > you are proposing here as long as the comment of this code path is > clear. OK, great, let's see what the committers think then. Michael -- Michael Banck P

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-21 Thread Michael Banck
Hi, Am Mittwoch, den 22.03.2017, 00:40 +0100 schrieb Michael Banck: > I guess if we decide (physical) slots should not be created implicitly, > then using the same UI as pg_receivewal makes sense for the sake of > consistency, i.e. "--slot=name --create-slot [--if-not-exists]"

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-21 Thread Michael Banck
ists is great UX, but maybe there is some use-case for erroring out if a slot already exists that I haven't thought of. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 120

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-21 Thread Michael Banck
Am Dienstag, den 21.03.2017, 12:52 +0100 schrieb Michael Banck: > New patches attached. On second though, there was a superfluous whitespace change in t/010_pg_basebackup.pl, and I've moved the check-for-hex regex fix to the second patch as it's cosmetic and not related to changing the --s

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-21 Thread Michael Banck
Hi, Am Dienstag, den 21.03.2017, 11:03 +0900 schrieb Michael Paquier: > On Tue, Mar 21, 2017 at 1:32 AM, Michael Banck > <michael.ba...@credativ.de> wrote: > /* > + * Try to create a permanent replication slot if one is specified. Do > + * not error out if th

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-04-09 Thread Michael Banck
Hi, Am Freitag, den 24.03.2017, 19:32 +0100 schrieb Michael Banck: > On Thu, Mar 23, 2017 at 12:41:54PM +0100, Magnus Hagander wrote: > > On Tue, Mar 21, 2017 at 8:34 PM, Robert Haas <robertmh...@gmail.com> wrote: > > > So I tend to think that there should alwa

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-04-03 Thread Michael Banck
Am Samstag, den 01.04.2017, 17:29 +0200 schrieb Magnus Hagander: > I've applied a backpatch to 9.4. Prior to that pretty much the entire > patch is a conflict, so it would need a full rewrite. Thanks! Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax

Re: [HACKERS] A note about debugging TAP failures

2017-04-23 Thread Michael Banck
up/t TAP tests took up several hundred megabytes (IIRC) when I ran them, so if other tests are similar, it might make a few animals run out of diskspace as soon as this is deployed without a heads-up to the operators. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166

Re: [HACKERS] Statement-level rollback

2017-03-07 Thread Michael Banck
ub.com/pgjdbc/pgjdbc/commit/adc08d57d2a9726309ea80d574b1db835396c1c8 Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108,

Re: [HACKERS] Parallel Index Scans

2017-03-06 Thread Michael Banck
er way to drive parallel scans and I > hope many more queries can use parallelism. Shouldn't the chapter 15.3 "Parallel Plans" in the documentation be updated for this as well, or is this going to be taken care as a batch at the ned of the development cycle, pending other added parallizat

Re: [HACKERS] Change in "policy" on dump ordering?

2017-03-06 Thread Michael Banck
uld emphasize this change by assigning > > DO_REFRESH_MATVIEW a higher number, like 100? > > Since there wasn't any interest in that idea, I have committed Jim's > patch as is. Would this be a candidate for backpatching, or is the behaviour change in pg_dump trumping the issues it solv

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-03-31 Thread Michael Banck
On Fri, Mar 31, 2017 at 02:11:44PM +0900, Kyotaro HORIGUCHI wrote: > At Fri, 31 Mar 2017 13:37:38 +0900, Michael Paquier > wrote in >

Re: [HACKERS] Change in "policy" on dump ordering?

2017-08-03 Thread Michael Banck
the back-branches before v11. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsfü

Re: [HACKERS] New partitioning - some feedback

2017-07-07 Thread Michael Banck
+1. Or maybe just 'partition' is enough if 'partition table' would widen the column output unnecessarily. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Numme

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-08-18 Thread Michael Banck
Hi, On Tue, Aug 15, 2017 at 02:14:58PM -0700, Jeff Janes wrote: > On Sun, Apr 9, 2017 at 4:22 AM, Michael Banck <michael.ba...@credativ.de> > wrote: > > Rebased, squashed and slighly edited version attached. I've added this > > to the 2017-07 commitfest no

Re: [HACKERS] [PostgreSQL 10] default of hot_standby should be "on"?

2017-05-03 Thread Michael Banck
inking this? If that is indeed the case, maybe it should be mentioned more prominently in the documentation and/or get highlighted in the release notes? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ Gmb

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-09-13 Thread Michael Banck
_rewind's mechanism could be partially reused for this as it seems to accomplish something vaguely similar AIUI? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 US

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-08 Thread Michael Banck
Hi, Am Mittwoch, den 06.09.2017, 12:22 -0400 schrieb Peter Eisentraut: > On 8/18/17 05:28, Michael Banck wrote: > > > > Rebased, squashed and slighly edited version attached. I've added this > > > > to the 2017-07 commitfest now as well: > > > > > >

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-11 Thread Michael Banck
Hi, On Fri, Sep 08, 2017 at 10:30:20AM -0700, Jeff Janes wrote: > On Wed, Sep 6, 2017 at 9:22 AM, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > > > On 8/18/17 05:28, Michael Banck wrote: > > >>> Rebased, squashed and slighly

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-11 Thread Michael Banck
Hi, On Fri, Sep 08, 2017 at 08:41:56AM +0200, Michael Banck wrote: > Am Mittwoch, den 06.09.2017, 12:22 -0400 schrieb Peter Eisentraut: > > On 8/18/17 05:28, Michael Banck wrote: > > > > > Rebased, squashed and slighly edited version attached. I've added this > > &

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-07 Thread Michael Banck
re should be some pg_dropstandby command or similar, which cleans everything (what exactly?) up? That might go some way to ensure this does not happen. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-12 Thread Michael Banck
Hi, Am Dienstag, den 12.09.2017, 08:53 -0400 schrieb Peter Eisentraut: > On 9/11/17 03:11, Michael Banck wrote: > > > Is there a race condition here? The slot is created after the checkpoint > > > is completed. But you have to start streaming from the LSN where the > &g

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-27 Thread Michael Banck
Hi, Am Mittwoch, den 27.09.2017, 10:10 -0400 schrieb Peter Eisentraut: > On 9/11/17 03:11, Michael Banck wrote: > > So my patch only moves the slot creation slightly further forward, > > AFAICT. > > I have committed this patch, along with some associated cleanup. T

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

2017-08-24 Thread Michael Banck
ile src/interfaces/libpq/libpq-int.h Hunk #1 succeeded at 361 (offset 1 line). Hunk #2 succeeded at 421 (offset -1 lines). Can you rebase it, please? Best Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ