Re: [PATCHES] pg_config

2004-07-31 Thread Bruce Momjian
Patch applied. Thanks. I made all the changes you suggested and the additions to path.c for the new parameters. --- Andrew Dunstan wrote: > > There are a couple of things that need adjustment: > > 1. typo in the makefil

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-31 Thread Bruce Momjian
Patch applied. Thanks. I made small adjustment for configure. --- Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >Andrew Dunstan wrote: > > > > > >>>I wanted to keep a solution that was as native to the OS as p

Re: [PATCHES] initdb authentication

2004-07-31 Thread Bruce Momjian
Patch applied. Thanks. I just cleaned up some of the code formatting. --- Magnus Hagander wrote: > Ok, here is another one. > > Doc patches coming up if/when this one is approved. > > //Magnus > > > >-Original Mes

Re: [PATCHES] [subxacts] Last try before beta

2004-07-31 Thread Tom Lane
Alvaro Herrera Munoz <[EMAIL PROTECTED]> writes: >> The patch seems to intend to add three reference-page sgml files, >> but those files are missing? > No, the files are embedded in the patch ... I avoided using cvs diff > to create the patch -- rather I diff'd two source trees, which includes >

[PATCHES]Traditional Chinese pgscripts-zh_TW.po for 7.5

2004-07-31 Thread Zhenbang Wei
Can't find this one on mailing list so I resend this. All messages are translated. Thank you. pgscripts-zh_TW.po Description: Binary data ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresq

Re: [PATCHES] [subxacts] Last try before beta

2004-07-31 Thread Alvaro Herrera Munoz
On Sat, Jul 31, 2004 at 09:50:07PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Here is the last patch before beta for subtransactions. It fixes the > > following outstanding issues: > > > - Add (some) user savepoint documentation > > The patch seems to intend to add t

Re: [PATCHES] [subxacts] Last try before beta

2004-07-31 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Here is the last patch before beta for subtransactions. It fixes the > following outstanding issues: > - Add (some) user savepoint documentation The patch seems to intend to add three reference-page sgml files, but those files are missing?

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Bruce Momjian
This logging issue has drained a lot of time during feature freeze when we should be getting existing patches in and completed. I am willing to apply a perfect patch but I am not willing to spend anymore time on this than I have to. This is all something that shouldn't be happening during featur

Re: [PATCHES] Another transation fix

2004-07-31 Thread Joe Conway
Joe Conway wrote: Bruce Momjian wrote: Here is another try at fixing the translation message. Instead of removing the backslashes in the message, I escaped them. Per discussion with Joe Conway. Now I'm getting three errors instead of one: msgfmt -o po/zh_TW.mo po/zh_TW.po po/zh_TW.po:199: `msgid

Re: [PATCHES] win32 version info - try 2

2004-07-31 Thread Magnus Hagander
>> It's platform specific, therefor it should go in port/. > >The criterion for port/ is not whether something is >platform-specific. >It's whether it's a module that helps porting source code. Which this >is not. Maybe we should add a new directory that contains icons and >other random auxi

Re: [PATCHES] win32 version info - try 2

2004-07-31 Thread Peter Eisentraut
Magnus Hagander wrote: > It's platform specific, therefor it should go in port/. The criterion for port/ is not whether something is platform-specific. It's whether it's a module that helps porting source code. Which this is not. Maybe we should add a new directory that contains icons and ot

Re: [PATCHES] Another transation fix

2004-07-31 Thread Peter Eisentraut
Joe Conway wrote: > FWIW, I can compile with the attached patch. That looks awfully close to what we started from... :-/ -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] win32 version info - try 2

2004-07-31 Thread Magnus Hagander
>> * Just two files to add - both go in src/port. (Moved the icon there >> per discussion on IM with Bruce) > >Can you post the rationale? It seem an odd place for it. We might want to link it into other binaries in the future, therefor it should not go under psql/. It's platform specific, there

Re: [PATCHES] win32 version info - try 2

2004-07-31 Thread Peter Eisentraut
Magnus Hagander wrote: > * Just two files to add - both go in src/port. (Moved the icon there > per discussion on IM with Bruce) Can you post the rationale? It seem an odd place for it. But it still holds that we a) should not put binary files in our CVS b) cannot put binary files without sour

[PATCHES] win32 version info - try 2

2004-07-31 Thread Magnus Hagander
Here's another attempt at adding version info to win32 stuff. Lots of changes since last try :-) * Build rules in Makefile.global builds the .o or .rc file required. Each makefile defines PGFILEDESC with a file description that gets imported. * Full version number is pulled from pg_config.h. The

Re: [PATCHES] Another transation fix

2004-07-31 Thread Joe Conway
Bruce Momjian wrote: Here is another try at fixing the translation message. Instead of removing the backslashes in the message, I escaped them. Per discussion with Joe Conway. Now I'm getting three errors instead of one: msgfmt -o po/zh_TW.mo po/zh_TW.po po/zh_TW.po:199: `msgid' and `msgstr' ent

[PATCHES] Another transation fix

2004-07-31 Thread Bruce Momjian
Here is another try at fixing the translation message. Instead of removing the backslashes in the message, I escaped them. Per discussion with Joe Conway. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life

Re: [PATCHES] win32 timezone map

2004-07-31 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Per discussion off-list with Tom, here is a patch to redo the way the > system timezone is detected on win32. Applied, along with some marginal hacking on the non-Windows case. I extended the search back to 1904, which should serve to eliminate those

Re: [PATCHES] bootstrap does not init paths

2004-07-31 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > This patch adds the required call to bootstrapmain(), and initdb works > again for me. Code itself directly copied from postgresmain(). Applied, except I moved it up a little bit. In the PostgresMain case this is done before InitializeGUCOptions(),

Re: [PATCHES] correct docbook version

2004-07-31 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > I saw some inconsistence in the docbook version. Here is a patch that > just correct it. These files are obsolete. I've removed them. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--

[PATCHES] correct docbook version

2004-07-31 Thread Euler Taveira de Oliveira
Hi, I saw some inconsistence in the docbook version. Here is a patch that just correct it. -- Euler Taveira de Oliveira euler (at) ufgnet.ufg.br Desenvolvedor Web e Administrador de Sistemas UFGNet - Universidade Federal de Goiás docbook.diff Description: Binary data -

[PATCHES] bootstrap does not init paths

2004-07-31 Thread Magnus Hagander
Seems bootstrapmain() never called find_my_exec(), and therefor never manged to fill in the path to the timezone directory. With the new timezone code that actully picks up a decent timezone on my system, that causes initdb to fail because it can't find any acceptable timezone at all. This patch a

Re: [PATCHES] win32 timezone map

2004-07-31 Thread Magnus Hagander
>> Per discussion off-list with Tom, here is a patch to redo the way the >> system timezone is detected on win32. > >Er ... no patch attached? Heh. Oops. //Magnus tz_map.patch Description: tz_map.patch ---(end of broadcast)--- TIP 2: you can get

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Tom Lane wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows.

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Tom Lane
>> Do people want the server file logging/rotating patch applied if it is >> Unix-only? Right now the patch is ifdef'ed so Win32 use of it is >> disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows. Person

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Dave Page
It's better than no patch I think. /D -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Sat 7/31/2004 5:33 AM To: Dave Page Cc: Tom Lane; Andreas Pflug; PostgreSQL Patches Subject: Re: [PATCHES] Admin functions contrib Do people want the server file logging/rotati

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Peter Eisentraut wrote: Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. How is logging typically handled on Windows? It is done using the eventlog service (which is supported as

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Peter Eisentraut
Bruce Momjian wrote: > Do people want the server file logging/rotating patch applied if it > is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is > disabled. How is logging typically handled on Windows? -- Peter Eisentraut http://developer.postgresql.org/~petere/ --

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. Andreas is asking. Please commit ASAP. Is I stated several times, I'll do the win32 as soon as I get a chance to. It's not a logge