Re: [PATCHES] plpython improvements

2006-09-02 Thread Bruce Momjian
Sven Suursoho wrote: > Hi, > > > Quoting Bruce Momjian <[EMAIL PROTECTED]>: > > > Great. Please supply documentation and it will be applied. Thanks. > > Here it comes, including src+doc patches. > Updated sources according to Michael Fuhr's comments and fixed one FIXME. > > Please check docu

Re: [PATCHES] plpython improvements

2006-08-27 Thread Sven Suursoho
Hi, Quoting Bruce Momjian <[EMAIL PROTECTED]>: > Great. Please supply documentation and it will be applied. Thanks. Here it comes, including src+doc patches. Updated sources according to Michael Fuhr's comments and fixed one FIXME. Please check documentation patch thoroughly as I'm not nativ

Re: [PATCHES] plpython improvements

2006-08-25 Thread Bruce Momjian
Sven Suursoho wrote: > Quoting Sven Suursoho <[EMAIL PROTECTED]>: > > > > On Sat, 17 Jun 2006 18:47:46 +0300, Tom Lane <[EMAIL PROTECTED]> wrote: > > > > > Obviously we should document the problem in the plpython documentation > > > ("don't try to use this feature with python versions before XXX

Re: [PATCHES] plpython improvements

2006-06-21 Thread Sven Suursoho
On Sat, 17 Jun 2006 18:47:46 +0300, Tom Lane <[EMAIL PROTECTED]> wrote: Obviously we should document the problem in the plpython documentation ("don't try to use this feature with python versions before XXX"), but I'm not any longer convinced that we have to reject this patch on security grounds

Re: [PATCHES] plpython improvements

2006-06-17 Thread Tom Lane
Sven <[EMAIL PROTECTED]> writes: > If this approach is not satisfactionary and assertion predetection is > still requested, only solution I see is to catch signal SIGABRT, set > flag, longjmp back and report error. > But I really don't like it. No, ignoring SIGABRT is surely right out. It suddenl

Re: [PATCHES] plpython improvements

2006-06-16 Thread Sven
Quoting Bruce Momjian : > > Added to TODO: > >o Allow PL/python to composite types and result sets > once buggy assert-enabled versions of python can be detected I actually tried to work other way around -- get all known buggy systems fixed: 1) Debugging Python version:

Re: [PATCHES] plpython improvements

2006-06-16 Thread Bruce Momjian
Added to TODO: o Allow PL/python to composite types and result sets once buggy assert-enabled versions of python can be detected http://archives.postgresql.org/pgsql-patches/2006-04/msg00087$ ---

Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sun, 07 May 2006 15:58:49 +0300, Bruce Momjian : Unfortunately, this is not case for Fedora Core 4, where assertions are used unconditionally. And to make things worse, there is no runtime symbol at all to indicate whether Python is compiled with debugging/assertions enabled (Py_DEBUG & NDEBU

Re: [PATCHES] plpython improvements

2006-05-07 Thread Bruce Momjian
Sven Suursoho wrote: > Sat, 06 May 2006 20:38:48 +0300, Bruce Momjian : > > > I still do not know why we can't do some kind of runtime test in python > > and disable this feature for 2.4 builds that have debugging enabled. > > Can we do a dynamic function load test from plpython? There must be >

Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sun, 07 May 2006 12:36:59 +0300, Sven Suursoho <[EMAIL PROTECTED]>: Btw, we developed returning compose types further. Basically did same as for SETOF functions -- allow to return any Python object that conforms to mapping protocol. Currently only dict as previously, though. But still, read

Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sat, 06 May 2006 20:38:48 +0300, Bruce Momjian : I still do not know why we can't do some kind of runtime test in python and disable this feature for 2.4 builds that have debugging enabled. Can we do a dynamic function load test from plpython? There must be some function that is only visible in

Re: [PATCHES] plpython improvements

2006-05-06 Thread Bruce Momjian
Sven Suursoho wrote: > Fri, 05 May 2006 19:20:55 +0300, Joshua D. Drake <[EMAIL PROTECTED]>: > > >> I think that a less confusing way of saying it would be : > >> "Generators crash if python version used is 2.4.x and it is compiled > >> with asserts. Currently only known linux distributions

Re: [PATCHES] plpython improvements

2006-05-06 Thread Hannu Krosing
Ühel kenal päeval, R, 2006-05-05 kell 09:20, kirjutas Joshua D. Drake: > > > > I think that a less confusing way of saying it would be : > > > > "Generators crash if python version used is 2.4.x and it is compiled > > with asserts. > > > > Currently only known linux distributions to distibut

Re: [PATCHES] plpython improvements

2006-05-05 Thread Joshua D. Drake
As an example of absurdity of this problem: let's assume there is known distribution with buggy gethostbyname(). Fact, that we know about this, shouldn't stop us developing TCP/IP applications. Especially, if there is also patch for this bug :) It would be real shame to prevent using gener

Re: [PATCHES] plpython improvements

2006-05-05 Thread Sven Suursoho
Fri, 05 May 2006 19:20:55 +0300, Joshua D. Drake <[EMAIL PROTECTED]>: I think that a less confusing way of saying it would be : "Generators crash if python version used is 2.4.x and it is compiled with asserts. Currently only known linux distributions to distibute such python.so files

Re: [PATCHES] plpython improvements

2006-05-05 Thread Joshua D. Drake
I think that a less confusing way of saying it would be : "Generators crash if python version used is 2.4.x and it is compiled with asserts. Currently only known linux distributions to distibute such python.so files are Fedora and possibly other RedHat distributions, while Gentoo, Ubun

Re: [PATCHES] plpython improvements

2006-05-05 Thread Hannu Krosing
Ühel kenal päeval, N, 2006-05-04 kell 18:21, kirjutas Sven Suursoho: > Hi, > > > Sun, 30 Apr 2006 19:14:28 +0300, Tom Lane <[EMAIL PROTECTED]>: > > > "Sven Suursoho" <[EMAIL PROTECTED]> writes: > >> Unfortunately, there is still one problem when using unpatched python, > >> caused by too aggress

Re: [PATCHES] plpython improvements

2006-05-04 Thread Sven Suursoho
Hi, Sun, 30 Apr 2006 19:14:28 +0300, Tom Lane <[EMAIL PROTECTED]>: "Sven Suursoho" <[EMAIL PROTECTED]> writes: Unfortunately, there is still one problem when using unpatched python, caused by too aggressive assert. http://mail.python.org/pipermail/python-checkins/2005-August/046571.html. I

Re: [PATCHES] plpython improvements

2006-05-03 Thread Hannu Krosing
Ühel kenal päeval, P, 2006-04-30 kell 14:43, kirjutas Tom Lane: > "Sven Suursoho" <[EMAIL PROTECTED]> writes: > > So, what about this in configure: > > if --with-python && test_iterator_app_crashes > ># errcode(FEATURE_NOT_SUPPORTED), errmsg(patch your python) > >disable_iterator_feature >

Re: [PATCHES] plpython improvements

2006-04-30 Thread Sven Suursoho
Sun, 30 Apr 2006 21:43:03 +0300, Tom Lane <[EMAIL PROTECTED]>: "Sven Suursoho" <[EMAIL PROTECTED]> writes: So, what about this in configure: if --with-python && test_iterator_app_crashes # errcode(FEATURE_NOT_SUPPORTED), errmsg(patch your python) disable_iterator_feature fi Testing it i

Re: [PATCHES] plpython improvements

2006-04-30 Thread Tom Lane
"Sven Suursoho" <[EMAIL PROTECTED]> writes: > So, what about this in configure: > if --with-python && test_iterator_app_crashes ># errcode(FEATURE_NOT_SUPPORTED), errmsg(patch your python) >disable_iterator_feature > fi Testing it in configure is wrong, because there's no guarantee the sam

Re: [PATCHES] plpython improvements

2006-04-30 Thread Sven Suursoho
Sun, 30 Apr 2006 20:48:48 +0300, Bruce Momjian : Sun, 30 Apr 2006 19:14:28 +0300, Tom Lane <[EMAIL PROTECTED]>: > "Sven Suursoho" <[EMAIL PROTECTED]> writes: >> Unfortunately, there is still one problem when using unpatched python, >> caused by too aggressive assert. >> http://mail.python.

Re: [PATCHES] plpython improvements

2006-04-30 Thread Bruce Momjian
Sven Suursoho wrote: > Sun, 30 Apr 2006 19:14:28 +0300, Tom Lane <[EMAIL PROTECTED]>: > > > "Sven Suursoho" <[EMAIL PROTECTED]> writes: > >> Unfortunately, there is still one problem when using unpatched python, > >> caused by too aggressive assert. > >> See > >> http://mail.python.org/pipermail/p

Re: [PATCHES] plpython improvements

2006-04-30 Thread Sven Suursoho
Sun, 30 Apr 2006 19:14:28 +0300, Tom Lane <[EMAIL PROTECTED]>: "Sven Suursoho" <[EMAIL PROTECTED]> writes: Unfortunately, there is still one problem when using unpatched python, caused by too aggressive assert. See http://mail.python.org/pipermail/python-checkins/2005-August/046571.html. I gues

Re: [PATCHES] plpython improvements

2006-04-30 Thread Tom Lane
"Sven Suursoho" <[EMAIL PROTECTED]> writes: > Unfortunately, there is still one problem when using unpatched python, > caused by too aggressive assert. > See > http://mail.python.org/pipermail/python-checkins/2005-August/046571.html. > I guess there should be warning somewhere as Hannu said b

Re: [PATCHES] plpython improvements

2006-04-30 Thread Sven Suursoho
Hi, Thu, 27 Apr 2006 17:17:36 +0300, Bruce Momjian : Sorry, I have to revert this patch because it is causing crashes in the plpython regression tests. Would you please run those tests, fix the bug, and resubmit. Thanks. Found and fixed two problems: 1) named parameters handling if there w

Re: [PATCHES] plpython improvements

2006-04-27 Thread Bruce Momjian
Hannu Krosing wrote: > ?hel kenal p?eval, N, 2006-04-27 kell 10:17, kirjutas Bruce Momjian: > > Sorry, I have to revert this patch because it is causing crashes in the > > plpython regression tests. Would you please run those tests, fix the > > bug, and resubmit. Thanks. > > Where exactly does i

Re: [PATCHES] plpython improvements

2006-04-27 Thread Hannu Krosing
Ühel kenal päeval, N, 2006-04-27 kell 10:17, kirjutas Bruce Momjian: > Sorry, I have to revert this patch because it is causing crashes in the > plpython regression tests. Would you please run those tests, fix the > bug, and resubmit. Thanks. Where exactly does it crash ? Please tell us the ver

Re: [PATCHES] plpython improvements

2006-04-27 Thread Bruce Momjian
Sorry, I have to revert this patch because it is causing crashes in the plpython regression tests. Would you please run those tests, fix the bug, and resubmit. Thanks. --- pgman wrote: > > Patch applied. Thanks. > > ---

Re: [PATCHES] plpython improvements

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Sven Suursoho wrote: > Hi, > > > Mon, 17 Apr 2006 19:20:38 +0300, Bruce Momjian : > > >> > Hannu Krosing wrote: > >> > > >> >> > 1) named parameters additionally to args[] > >> >> > 2) return

Re: [PATCHES] plpython improvements

2006-04-17 Thread Sven Suursoho
Hi, Mon, 17 Apr 2006 19:20:38 +0300, Bruce Momjian : > Hannu Krosing wrote: > >> > 1) named parameters additionally to args[] >> > 2) return composite-types from plpython as dictionary >> > 3) return result-set from plpython as list, iterator or generator >> > >> > Test script attached (patch-

Re: [PATCHES] plpython improvements

2006-04-17 Thread Bruce Momjian
Hannu Krosing wrote: > ?hel kenal p?eval, L, 2006-04-15 kell 17:59, kirjutas Sven Suursoho: > > 1) named parameters additionally to args[] > > 2) return composite-types from plpython as dictionary > > 3) return result-set from plpython as list, iterator or generator > > > > Test script attached (p

Re: [PATCHES] plpython improvements

2006-04-17 Thread Hannu Krosing
Ühel kenal päeval, L, 2006-04-15 kell 17:59, kirjutas Sven Suursoho: > 1) named parameters additionally to args[] > 2) return composite-types from plpython as dictionary > 3) return result-set from plpython as list, iterator or generator > > Test script attached (patch-test.sql) but not integrated

[PATCHES] plpython improvements

2006-04-15 Thread Sven Suursoho
1) named parameters additionally to args[] 2) return composite-types from plpython as dictionary 3) return result-set from plpython as list, iterator or generator Test script attached (patch-test.sql) but not integrated to plpython test-suite. -- Sven Suursoho patch-test.sql Description: Bi