Re: [PATCHES] [pgsql-hackers-win32] make fails if path has spaces

2004-08-14 Thread Bruce Momjian
OK, patch attached and applied. I am not sure if there are going to be other place that need fixing so I added a comment. --- Andreas Pflug wrote: > Bruce Momjian wrote: > > >>> > >> > >>It could be fixed in both places, b

[PATCHES] Translation updates for 8.0: psql-ru

2004-08-14 Thread Serguei Mokhov
Hello, Please install this one. It fixes up 8 strings I missed last time due to working on older version of downloaded .po file. Thanks, -s psql-ru.po.gz psql-ru.po.gz Description: GNU Zip compressed data ---(end of broadcast)--- TIP 6: Have yo

Re: [PATCHES] Minor psql reference fix

2004-08-14 Thread Tom Lane
Andreas Seltenreich <[EMAIL PROTECTED]> writes: > I just stumbled across a strange looking sentence in the psql > reference. I'm not sure if I fixed it correctly, since English isn't > my native language. Patch attached. Yup, it's wrong, and your fix is perfect. Patch applied --- thanks!

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The patch is not platform-specific. It simply makes psql accept the same > line endings on COPY FROM that the backend will accept - in effect it > makes it line-end agnostic - this is a Good Thing (tm). Strictly speaking it's not there yet --- psql st

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Here's the diff with 7.4 line numbers - tests fine for me. Patch applied. Thanks for double-checking it. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading thro

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >One issue is that pre-8.0, psql files were opened in Win32 text mode, so > >we wouldn't have seen this bug on Win32, but we would on Linux. > >Because we open them on Win32 now in binary mode so we see control-Z it > >will show up on Win32

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Andrew Dunstan
Bruce Momjian wrote: One issue is that pre-8.0, psql files were opened in Win32 text mode, so we wouldn't have seen this bug on Win32, but we would on Linux. Because we open them on Win32 now in binary mode so we see control-Z it will show up on Win32 too. true, *BUT* The patch is not platfo

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Tom Lane wrote: > > >"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > > > > > >>No, I think 7.4 should do. 7.3 users will still have the dos2unix workaround > >>available. Are you going to do the 7.4 patch, or do you need me to? I > >>normally only keep a HEAD tree ch

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Bruce Momjian
Sorry, I now see I should add the patch to the 8.1 queue. --- Bruce Momjian wrote: > > TODO here? > > --- > > Tom Lane wrote: > > Michael Glaesemann

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Bruce Momjian
TODO here? --- Tom Lane wrote: > Michael Glaesemann <[EMAIL PROTECTED]> writes: > > On Aug 15, 2004, at 1:19 AM, Tom Lane wrote: > >> There was however another patch submitted recently that seemed to > >> duplicate yours fun

[PATCHES] Minor psql reference fix

2004-08-14 Thread Andreas Seltenreich
Hi, I just stumbled across a strange looking sentence in the psql reference. I'm not sure if I fixed it correctly, since English isn't my native language. Patch attached. Thanks Andreas Index: psql-ref.sgml === RCS file: /projects/

Re: [PATCHES] Translation updates for 7.4.4(!!) / 8.0: postgres-ru

2004-08-14 Thread Peter Eisentraut
Serguei Mokhov wrote: > Another chunk of translated backend messages. > It'd be cool if it makes into 7.4.4 before it > is rolled out. Please also apply to 8.0. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)-

Re: [PATCHES] Translation updates for 8.0: initdb-ru, psql-ru

2004-08-14 Thread Peter Eisentraut
Serguei Mokhov wrote: > Please install the next cut on Russian translations > for 8.0. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

[PATCHES] psql tab-complete patch #3

2004-08-14 Thread Stefan Kaltenbrunner
Hi all! Attached is the third version of my patch that adds/fixes several things to/in the psql-tabcomplete code. This diff includes the still missing tab-complete support for TABLESPACE I already sent earlier. New in this version of the patch is a small adaption of the tab-complete code to supp

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Tom Lane
Michael Glaesemann <[EMAIL PROTECTED]> writes: > On Aug 15, 2004, at 1:19 AM, Tom Lane wrote: >> There was however another patch submitted recently that seemed to >> duplicate yours functionally but used a different syntax --- I think > Other than Chris' suggestion of extract(timestamp from epoch

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Michael Glaesemann
On Aug 15, 2004, at 1:19 AM, Tom Lane wrote: There was however another patch submitted recently that seemed to duplicate yours functionally but used a different syntax --- I think the guy had started by looking at extract(epoch from timestamp) rather than to_timestamp. Other than Chris' suggestion

[PATCHES] pg_restore recognizing $-quotes

2004-08-14 Thread Philip Warner
Not sure if this is the desired approach, but since it works, I thought I'd send it. This patch allows pg_restore to recognize $-quotes in SQL queries. It will treat any unquoted string that starts with a $ and has no preceding identifier chars as a potential $-quote tag, it then makes sure tha

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Tom Lane
Michael Glaesemann <[EMAIL PROTECTED]> writes: > On Aug 14, 2004, at 6:50 PM, Christopher Kings-Lynne wrote: >> Maybe you don't need to override to_timestamp, and you can just add a >> new code to the format string that to_timestamp understands, ie 'e' or >> something or 'u' that means 'unix time

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Andrew Dunstan
Andrew Dunstan wrote: Tom Lane wrote: If you're sure the code in that routine hasn't changed since 7.4, then I can just apply the patch to that branch. It has - the prompt changes in version 1.37. But I don't think that conflict with this patch. I'll have a look this morning. As expected: Hunk

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Michael Glaesemann
On Aug 14, 2004, at 6:50 PM, Christopher Kings-Lynne wrote: Maybe you don't need to override to_timestamp, and you can just add a new code to the format string that to_timestamp understands, ie 'e' or something or 'u' that means 'unix timestamp'? Thanks for looking at the code! I know people are

Re: [PATCHES] [HACKERS] [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

2004-08-14 Thread Andrew Dunstan
Tom Lane wrote: "Andrew Dunstan" <[EMAIL PROTECTED]> writes: No, I think 7.4 should do. 7.3 users will still have the dos2unix workaround available. Are you going to do the 7.4 patch, or do you need me to? I normally only keep a HEAD tree checked out. A quick look at the cvsweb diffs suggests t

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2004-08-14 Thread Christopher Kings-Lynne
I wonder... Maybe you don't need to override to_timestamp, and you can just add a new code to the format string that to_timestamp understands, ie 'e' or something or 'u' that means 'unix timestamp'? Chris Michael Glaesemann wrote: Please find attached a patch (diff -c against cvs HEAD) to add a