Re: [PATCHES] still alive?

2008-10-01 Thread Peter Eisentraut
Simon Riggs wrote: On Thu, 2008-09-11 at 15:39 +0300, Peter Eisentraut wrote: Bruce Momjian wrote: Abhijit Menon-Sen wrote: I thought -patches was supposed to die. What happened? I was wondering the same thing. Peter? Hmm, let's try this: Anyone who thinks the patches list should remain

Re: [PATCHES] still alive?

2008-09-11 Thread Peter Eisentraut
Bruce Momjian wrote: Abhijit Menon-Sen wrote: I thought -patches was supposed to die. What happened? I was wondering the same thing. Peter? Hmm, let's try this: Anyone who thinks the patches list should remain as separate from hackers, shout now (with rationale)! -- Sent via

Re: [PATCHES] Explain XML patch v2

2008-07-04 Thread Peter Eisentraut
Am Freitag, 4. Juli 2008 schrieb Tom Raney: Regarding the XML datum, in order to support that, will all users need   to compile with libxml?  Are there any lighter weight solutions to   serialize other than libxml? You can create XML without libxml. -- Sent via pgsql-patches mailing list

[PATCHES] Regression test database name

2008-07-02 Thread Peter Eisentraut
For some experiments I wanted to run the regression tests using a different database (possibly using pg_regress --dbname=), but the name regression is hardcoded in a few places. It's trivial to fix, see attached patch. Quick explanation: The fact that psql's \z prints the database name has

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread Peter Eisentraut
Am Mittwoch, 2. Juli 2008 schrieb Tom Raney: This is an update to my EXPLAIN XML patch submitted a few days ago. Could you explain how you came up with the XML schema design? I suppose you just made something up that went along with the existing XML output. I would like to see more

Re: [PATCHES] Updatable views

2008-05-08 Thread Peter Eisentraut
Am Donnerstag, 8. Mai 2008 schrieb Simon Riggs:  CREATE RULE somename AS ON INSERT TO x WHERE where-clause DO INSERT ... which seems straightforward, no? Double evaluation is the key word. The conclusion was more or less that you can't implement check constraints using the rules system. You

Re: [PATCHES] column level privileges

2008-05-07 Thread Peter Eisentraut
Am Mittwoch, 7. Mai 2008 schrieb Tom Lane: 1.1 Add a column named 'attrel' in pg_attribute catalog to store column privileges. Now all column privileges are stored, no matter whether they could be implied from table-level privilege. What this actually means, but doesn't say, is that

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Peter Eisentraut
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have developed the attached patch which fixes 0 ^ 123.3. Did you actually read the wikipedia entry you cited? Considering that 0::float8 ^ 0::float8 yields 1, making the numeric operator do the same might not be completely

Re: [PATCHES] [COMMITTERS] pgsql: Sigh ...

2008-05-03 Thread Peter Eisentraut
Andrew Dunstan wrote: This patch should fix things for both sets of changes. And it demonstrates pretty much what you need to do for config options for MSVC. Btw., it is quite easily possible to use the autom4te tracing facility to parse the configure.ac file, in case you are interested in

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Peter Eisentraut
Dave Page wrote: Perhaps use a separate string for machine parse (say R, T, C, U), and let the string be translatable. I considered that, but wasn't sure if folks would like the redundancy. It's trivial to do of course - any objections? Is there anything useful you would do with this

Re: [PATCHES] Coding standards

2008-04-20 Thread Peter Eisentraut
Alvaro Herrera wrote: The developer's FAQ is supposed to contain this kind of thing, but I think it's rather thin on actual details.  (Some time ago it was proposed to create a style guide, but people here thought it was a waste of time and it will not cover what's really important, so we're

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-17 Thread Peter Eisentraut
Bruce Momjian wrote: I checked the use of COLUMNS and it seems bash updates the environment variable when a window is resized.  I added ioctl(TIOCGWINSZ) if COLUMNS isn't set.  We already had a call in print.c for detecting the number of rows on the screen to determine if the pager should be

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Peter Eisentraut
Am Donnerstag, 3. April 2008 schrieb Gregory Stark: To be more explicit what I meant was someone doing #= \alias old select version(); ... #= \oldd oops #= \old #= select 'where is all my output going?' #= select 'what happened to my ldd file?' This is a valid concern, but it is

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Peter Eisentraut
Am Donnerstag, 3. April 2008 schrieb Gregory Stark: \old means something *today*. In the proposed syntax by creating the alias you're changing what it means. Yes. There are two complementary responses to that: 1. That's an intentional, useful feature of aliases. 2. If you don't like it, don't

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Peter Eisentraut
Am Donnerstag, 3. April 2008 schrieb Brendan Jurd: psql allows you to omit the space between the command and argument? Does anybody else find that weird? What is the virtue of allowing such a syntax in the first place? Combatability with hysterial practice. -- Sent via pgsql-patches mailing

[PATCHES] Changes to building dynamically loadable modules

2008-04-02 Thread Peter Eisentraut
The attached patch implements a few changes to how shared libraries and dynamically loadable modules are built. Foremost, it creates a solid distinction between these two types of targets based on what had already been implemented and duplicated in ad hoc ways before. Specifically, -

Re: [PATCHES] psql command aliases support

2008-04-01 Thread Peter Eisentraut
Am Dienstag, 1. April 2008 schrieb Tom Lane: Do we really want such a thing? Yes! The space of backslash command names is so densely populated already that it's hard to imagine creating aliases without conflicting with existing (or future) command names --- as indeed your example does. It

Re: [HACKERS] [PATCHES] Fix for large file support (nonsegment mode support)

2008-03-19 Thread Peter Eisentraut
Zdenek Kotala wrote: But how it was mentioned in this thread maybe somethink like this CREATE TABLESPACE name LOCATION '/my/location' SEGMENTS 10GB should good solution. If segments is not mentioned then default value is used. I think you would need a tool to resegmentize a table or

Re: [PATCHES] Minimum selectivity estimate for LIKE 'prefix%'

2008-03-17 Thread Peter Eisentraut
Am Donnerstag, 6. März 2008 schrieb Tom Lane: I attach a proposed patch against HEAD for this.  It's a bit long but most of the bulk is refactoring eqsel() to make it easy to use from prefix_selectivity().  The intellectual content is just in the last diff hunk. Looking at the patch as

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-03-17 Thread Peter Eisentraut
Am Donnerstag, 6. März 2008 schrieb Robert Lor: Attached is the updated patch which addressed all the concerns from Peter and Tom. * The header file containing the probe macros is now included only in the .c files that need it. * All probe macro names now start with TRACE_ (eg:

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-14 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: DWORD is an alias for 'unsigned long' in 32bit Windows. Then try using %lu and no casts. That should get rid of the warnings the proper way. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription:

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: - Cast DWORD to unsigned integer explicitly. DWORD is always 32bit integer on both 32bit and 64bit Windows. I think if that is so, you wouldn't need to add any casts. Instead you would only need to use the right format specifier. -- Sent via pgsql-patches mailing

Re: [HACKERS] [PATCHES] Fix for large file support (nonsegment mode support)

2008-03-11 Thread Peter Eisentraut
Tom Lane wrote: I think this needs to be treated as experimental until it's got a few more than zero miles under its belt. OK, then maybe we should document that. I wouldn't be too surprised to find that we have to implement it as a run-time switch instead of compile-time, in order to not

Re: [HACKERS] [PATCHES] Fix for large file support (nonsegment mode support)

2008-03-11 Thread Peter Eisentraut
Zdenek Kotala wrote: Yes, agree. It seems only ZFS is OK at this moment and if somebody sets 32TB he gets nonsegment mode anyway. Surely if you set the segment size to INT64_MAX, you will get nonsegmented behavior anyway, so two code paths might not be necessary at all. I looked into posix

Re: [HACKERS] [PATCHES] Fix for large file support (nonsegment mode support)

2008-03-10 Thread Peter Eisentraut
Tom Lane wrote: Zdenek Kotala [EMAIL PROTECTED] writes: There is latest version of nonsegment support patch. I changed LET_OS_MANAGE_FILESIZE to USE_SEGMENTED_FILES and I added -disable-segmented-files switch to configure. I kept tuplestore behavior and it still split file in both mode.

Re: [PATCHES] Minimum selectivity estimate for LIKE 'prefix%'

2008-03-07 Thread Peter Eisentraut
Am Donnerstag, 6. März 2008 schrieb Tom Lane: To help out Peter's client, who's running 8.1.x, we'd have to backpatch at least that far.  We backpatched the last round of LIKE selectivity fixes to 8.1, so I don't have too much hesitation about doing the same here. Thanks for the offer.

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-29 Thread Peter Eisentraut
Am Freitag, 29. Februar 2008 schrieb Robert Lor: My concern is that when we start adding more probes (not just the backend), we will have to add the following 5 lines in .c files that use the Dtrace macros. I had already solved this in my intermediate patch I sent you by symlinking

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-29 Thread Peter Eisentraut
Am Freitag, 29. Februar 2008 schrieb Robert Lor: Currently, pg_trace.h is included in c.h, and I feel strongly that it should remains there because by design I'd like to 1) have the tracing feature be available both in the frontend and backend without having to do anything extra, I think

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Peter Eisentraut
Robert Lor wrote: dtrace call in src/Makefile is to generate probes.h before any file is compiled so it can be used in c.h to avoid probes.h not found error. The dtrace call in src/backend/Makefile is only needed for Solaris. Is c.h the right place to include this? The probes are only in the

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Peter Eisentraut
Robert Lor wrote: Please find the patch attached per this thread http://archives.postgresql.org/pgsql-hackers/2008-02/msg00912.php Another thing that is concerning me about this new approach is the way the probes are named. For example, we'd now have a call POSTGRESQL_LWLOCK_ACQUIRE() in

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-27 Thread Peter Eisentraut
support could be helpful. :) -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-27 Thread Peter Eisentraut
as well, so the old one could be dropped? Btw., probes_null.h is missing in your patch. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you searched our list archives? http

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-27 Thread Peter Eisentraut
. This should fix the troubles you describe and others. -- Peter Eisentraut http://developer.postgresql.org/~petere/ Index: src/backend/Makefile === RCS file: /cvsroot/pgsql/src/backend/Makefile,v retrieving revision 1.127 diff -u -3 -p

Re: [PATCHES] DTrace not working after SUBSYS.o reorg

2008-02-26 Thread Peter Eisentraut
Am Dienstag, 26. Februar 2008 schrieb Magne Mæhre: I noticed that the dtrace code wouldn't build after the recent SUBSYS.o reorganization. Fixed. Is there no buildfarm coverage of dtrace? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end

Re: [PATCHES] lc_time and localized dates

2008-02-26 Thread Peter Eisentraut
, and standardized, export sprintf and strftime to PostgreSQL. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] Avahi support for Postgresql

2008-02-25 Thread Peter Eisentraut
instances. I don't see how this can be useful in a PostgreSQL setting, at least not based on the parameters server version and protocol version that you implemented. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast

Re: [PATCHES] Avahi support for Postgresql

2008-02-25 Thread Peter Eisentraut
variety of platforms. One thing I found curious: The Bonjour code uses service type _postgresql._tcp. whereas your code uses _postgresql._tcp (note the dot). Is that an expected difference? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast

Re: [PATCHES] Avahi support for Postgresql

2008-02-25 Thread Peter Eisentraut
and some refactoring) and published them here: http://git.postgresql.org/?p=~petere/postgresql.git;a=shortlog;h=avahi-support -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: explain analyze is your friend

[PATCHES] Shlib exports file refactoring

2008-02-25 Thread Peter Eisentraut
them. Just see if it builds and runs correctly. Thanks. -- Peter Eisentraut http://developer.postgresql.org/~petere/ diff -ur ../cvs-pgsql/src/interfaces/ecpg/compatlib/Makefile ./src/interfaces/ecpg/compatlib/Makefile --- ../cvs-pgsql/src/interfaces/ecpg/compatlib/Makefile 2008-02-17 16:30

Re: [PATCHES] Avahi support for Postgresql

2008-02-23 Thread Peter Eisentraut
include or point to your actual patch. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] fix in --help output

2008-02-22 Thread Peter Eisentraut
Am Freitag, 22. Februar 2008 schrieb Zdenek Kotala: Peter Eisentraut napsal(a): Zdenek Kotala wrote: However, I get following error on Solaris: bash-3.2$ /usr/postgres/8.2/bin/postgres -D /tmp/db --share_buffers=16000 /usr/postgres/8.2/bin/postgres: illegal option -- share_buffers

Re: [PATCHES] fix in --help output

2008-02-21 Thread Peter Eisentraut
Zdenek Kotala wrote: I attach fix for --help output. I replaced --NAME... with -NAME But that is wrong. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 5: don't forget to increase your free space map

Re: [PATCHES] fix in --help output

2008-02-21 Thread Peter Eisentraut
/postgres/8.2/bin/postgres -D /tmp/db -c shared_buffers=16000 share_buffers is not the same as shared_buffers. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project

[PATCHES] Backend makefile refactoring

2008-02-18 Thread Peter Eisentraut
. This should not change any functionality of the build system at the moment. -- Peter Eisentraut http://developer.postgresql.org/~petere/ diff --git a/src/backend/access/Makefile b/src/backend/access/Makefile index 4753eac..df05f8e 100644 --- a/src/backend/access/Makefile +++ b/src/backend/access

Re: [PATCHES] WIP: plpgsql source code obfuscation

2008-01-29 Thread Peter Eisentraut
system tables with source code or can use debugger). Have you thought about a solution that applies the regular access privileges to pg_proc in order to hide some content from less privileged users? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end

Re: [PATCHES] WIP: plpgsql source code obfuscation

2008-01-29 Thread Peter Eisentraut
be a hazard. PostgreSQL already has built-in support for SSL and Kerberos, so it is already infested with enough weaponized code to fail most applicable regulations. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast

[PATCHES] NUMERIC key word

2008-01-29 Thread Peter Eisentraut
In 8.3, it appears that NUMERIC doesn't need to be a key word any longer. See attached patch. Was there a reason this was kept in the parser? Otherwise we could remove it in 8.4. -- Peter Eisentraut http://developer.postgresql.org/~petere/ diff -ur ../cvs-pgsql/src/backend/parser/gram.y

Re: [PATCHES] Friendly help for psql

2008-01-20 Thread Peter Eisentraut
Greg Sabino Mullane wrote: Why not run help when someone enters help (or HELP ME!) on the command line? \? is hardly an easy thing to remember (and some people can't be bothered to actually read the screen...) Then surely the help output won't be of use to them either. -- Peter Eisentraut

Re: [PATCHES] Friendly help for psql

2008-01-20 Thread Peter Eisentraut
how to get help when you log in. Now I have actually thought for a while whether we could get rid of the login text altogether. I would support trading that for extended help options. But if the login note is there, then we don't need more help options. -- Peter Eisentraut http

Re: [PATCHES] [HACKERS] SSL over Unix-domain sockets

2008-01-18 Thread Peter Eisentraut
there also need to be prudent users, but that is the case for any security system. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating

Re: [PATCHES] [HACKERS] SSL over Unix-domain sockets

2008-01-18 Thread Peter Eisentraut
certificate installed. How would a client check whether the socket file is in a secure location? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http

Re: [PATCHES] [HACKERS] SSL over Unix-domain sockets

2008-01-18 Thread Peter Eisentraut
around of files by the server will ever solve the problem. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org

Re: [PATCHES] [HACKERS] SSL over Unix-domain sockets

2008-01-18 Thread Peter Eisentraut
to servers that can prove their identity. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] [GENERAL] Forgot to dump old data before re-installing machine

2008-01-18 Thread Peter Eisentraut
didn't follow how the user got into this mess, so I don't know whether the suggestion you need to initdb is appropriate. -- Peter Eisentraut http://developer.postgresql.org/~petere/ diff -ur ../cvs-pgsql/src/backend/access/transam/xlog.c ./src/backend/access/transam/xlog.c --- ../cvs-pgsql/src/backend

Re: [PATCHES] [HACKERS] SSL over Unix-domain sockets

2008-01-17 Thread Peter Eisentraut
Bruce Momjian wrote: I have written the following documentation addition suggesting the use of external_pid_file. How does that prevent spoofing? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 1

Re: [PATCHES] Auto create (top level) directory for create tablespace

2007-12-16 Thread Peter Eisentraut
behavior of the Red Hat RPMs that automatically performed initdb if the data directory is missing. Thankfully, that has been abolished. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9

Re: [PATCHES] [HACKERS] Is postgres.gif missing in cvs?

2007-12-14 Thread Peter Eisentraut
Am Freitag, 14. Dezember 2007 schrieb Bruce Momjian: I have applied the attached patch to give a helpful message if you try to create postgres.ps or postgres.pdf. I have corrected this to use $(MAKE) instead of gmake, because the latter might not be available. -- Peter Eisentraut http

Re: [PATCHES] [HACKERS] fulltext parser strange behave

2007-11-19 Thread Peter Eisentraut
be valid as an HTML tag. (As opposed to the fact that an XML document is not a superset of an HTML document.) SGML might be too broad. It would require us to recognize / and and perhaps a few other odd things. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] Hibernate Dialects for PostgreSQL

2007-11-13 Thread Peter Eisentraut
Am Montag, 12. November 2007 schrieb Simon Riggs: On Mon, 2007-11-12 at 14:28 +0100, Peter Eisentraut wrote: Simon Riggs wrote: I enclose 3 Dialects for PostgreSQL, as discussed on -hackers. There is no such thing as PostgreSQL 8. Please don't do that; it would confuse users about

Re: [PATCHES] Hibernate Dialects for PostgreSQL

2007-11-12 Thread Peter Eisentraut
Simon Riggs wrote: I enclose 3 Dialects for PostgreSQL, as discussed on -hackers. There is no such thing as PostgreSQL 8. Please don't do that; it would confuse users about the versioning scheme. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end

Re: [PATCHES] mingw autoconf again

2007-10-29 Thread Peter Eisentraut
Am Montag, 29. Oktober 2007 schrieb Magnus Hagander: 1) does it look ok? yes 2) is it ok to put checks for win32-only this way? Well, the available replacement implementation only works on win32, so this is about as correct as we should care to be at the moment. -- Peter Eisentraut http

[PATCHES] Using system time zone database

2007-08-17 Thread Peter Eisentraut
the regression tests exercise the specifics of the time zone data, but when you specify something totally wrong some tests fail, so it would be easy to catch that. -- Peter Eisentraut http://developer.postgresql.org/~petere/ diff -ur cvs-pgsql/configure pgsql/configure --- cvs-pgsql/configure 2007-08-11

Re: [PATCHES] Using system time zone database

2007-08-17 Thread Peter Eisentraut
also pg_config to show where TZ files are stored. pg_config --configure would show it. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] Using system time zone database

2007-08-17 Thread Peter Eisentraut
that the build environment is the same as the run environment. Anyway, just run make check and you will know. Anything else would be much too complicated. This patch just provides direct access to the process that people already use anyway. -- Peter Eisentraut http://developer.postgresql.org

Re: [PATCHES] Default location for docbook stylesheets in Gentoo

2007-08-08 Thread Peter Eisentraut
Brendan Jurd wrote: This patch adds the default location for the DocBook DSSSL stylesheets in gentoo's package system to the configure script. Uh, could you please send a diff with -u or -c, so we know where to put the change? -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Peter Eisentraut
Am Dienstag, 24. Juli 2007 17:24 schrieb Gregory Stark: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. That was my thought. -- Peter Eisentraut http

Re: [PATCHES] configure.in / xml / quoting trouble

2007-07-20 Thread Peter Eisentraut
Am Freitag, 20. Juli 2007 13:28 schrieb Patrick Welche: Also, why did postgresql choose not to use automake? The was never such a choice made. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 1

Re: [PATCHES] execl() sentinel

2007-07-18 Thread Peter Eisentraut
a sufficient sentinel for variadic functions, as explained here: http://c-faq.com/null/null2.html. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you searched our list archives? http

Re: [PATCHES] Async Commit, v21 (now: v22)

2007-07-18 Thread Peter Eisentraut
that the risk of a loss due to asynchronous commit happening is larger than fsync off. I *think* I know what this is trying to say, but I suspect that the average user might not be able to make a good choice of settings. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] execl() sentinel

2007-07-18 Thread Peter Eisentraut
Am Mittwoch, 18. Juli 2007 16:16 schrieb Tom Lane: You should *not* have to inform the machine that NULL is a pointer. For variadic functions, that expectation is invalid, AFAIK. It might be good to check the actual definition of NULL in this case, however, before wondering further. -- Peter

Re: [PATCHES] execl() sentinel

2007-07-18 Thread Peter Eisentraut
Am Mittwoch, 18. Juli 2007 17:16 schrieb Alvaro Herrera: Peter Eisentraut wrote: Am Mittwoch, 18. Juli 2007 16:16 schrieb Tom Lane: You should *not* have to inform the machine that NULL is a pointer. For variadic functions, that expectation is invalid, AFAIK. No, what's invalid

Re: [PATCHES] script binaries renaming

2007-07-06 Thread Peter Eisentraut
Am Mittwoch, 4. Juli 2007 17:04 schrieb Zdenek Kotala: I attach complete patch which renames following binaries createdb createlang createuser dropdb droplang dropuser clusterdb vacuumdb reindexdb I just want to say I dislike this idea. -- Peter Eisentraut http://developer.postgresql.org

Re: [PATCHES] script binaries renaming

2007-07-06 Thread Peter Eisentraut
disk space is really a concern, is it? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-06-01 Thread Peter Eisentraut
wanna check.) Since we're not going to put new features into earlier releases, and contrib modules are not necessarily source backward-compatible, I don't think this patch has a place in a future PostgreSQL release. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] boolean = text explicit casts

2007-05-30 Thread Peter Eisentraut
of upper case, except for it looks nicer. Is there a technical reason? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] Synchronized Scan

2007-05-21 Thread Peter Eisentraut
Am Montag, 21. Mai 2007 00:01 schrieb Jeff Davis: Here is the latest version of my patch that's revised according to my discussions with Heikki and Simon: This patch was apparently done against 8.2.4, but it doesn't apply to CVS head. -- Peter Eisentraut http://developer.postgresql.org

Re: [PATCHES] Concurrent psql patch

2007-05-21 Thread Peter Eisentraut
Am Montag, 21. Mai 2007 15:21 schrieb Gregory Stark: Also, I forgot to mention previously there is an unrelated trivial hunk in here. I noticed we free the password early, presumably for security reasons, No, to save memory. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] xpath_array with namespaces support

2007-05-21 Thread Peter Eisentraut
. (bugfix) Work with fragments with prologue: select xpath('/a', '?xml version=1.0?a /b /'); // now XML datum is always wrapped with dummy x.../x, XML prologue simply goes away (if any). 7. Some cleanup. Applied. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] On patching without write access to CVS

2007-05-14 Thread Peter Eisentraut
Am Montag, 14. Mai 2007 03:56 schrieb David Fetter: +For those things which productnameCVS/productname does not do +by itself, such as letting you create patches without write access, I don't think that is accurate. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] [WIP] GUC for temp_tablespaces

2007-05-09 Thread Peter Eisentraut
? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] small patch for guc issues

2007-05-08 Thread Peter Eisentraut
Am Freitag, 4. Mai 2007 18:21 schrieb Joachim Wieland: The appended patch addresses the outstanding issues of the recent guc patch. It makes PGCLIENTENCODING work again and uses bsearch() instead of iterating over the array of guc variables in guc_get_index(). Applied. -- Peter Eisentraut

Re: [PATCHES] [WIP] GUC for temp_tablespaces

2007-05-08 Thread Peter Eisentraut
all along in these patches is an explanation for what it means to list multiple temporary tablespaces. Are they used in order, or the first one that exists, or what? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast

Re: [PATCHES] Diagnostic functions

2007-05-07 Thread Peter Eisentraut
suggestion was pgforensics. pgdiagfuncs and pginspect were also suggested, among others. I'm still open to suggestions, though. Have any? Something involving page would at least explain what you can diagnose. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] Diagnostic functions

2007-05-05 Thread Peter Eisentraut
Heikki Linnakangas wrote: Here's an update of Simon's Heap Page Diagnostic Functions. I now consider it ready to commit. How is this better than pg_filedump? diagnostics is an awfully general name, too. -- Peter Eisentraut http://developer.postgresql.org/~petere

Re: [PATCHES] SPI_psprintf and SPI_pstrdup

2007-04-24 Thread Peter Eisentraut
and copies an existing string into it. How is that different from pstrdup()? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] build/install xml2 when configured with libxml

2007-04-15 Thread Peter Eisentraut
and might be useful even for 8.3. But I don't really know how to label that. Having a contrib/xslt alongside contrib/xml2 would probably be confusing. Ideas? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7

Re: [PATCHES] build/install xml2 when configured with libxml

2007-04-14 Thread Peter Eisentraut
a feature, then it's built, or you don't, then it's not. So the only options we really have are adding another switch for libxslt, or including it with libxml. I'm not sure which is better. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast

Re: [PATCHES] xpath_array with namespaces support

2007-04-10 Thread Peter Eisentraut
XML? I though only documents could have prologs. It's not a legal XML document, but it's a legal XML content fragment, specified by SQL/XML. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: explain

Re: [PATCHES] [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries

2007-04-08 Thread Peter Eisentraut
implementation and don't know what it means. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries

2007-04-08 Thread Peter Eisentraut
documentation. That doesn't mean this one isn't useful. Please revert this. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org

Re: [PATCHES] Correct the spelling of SYMMETRIC

2007-04-08 Thread Peter Eisentraut
not to backpatch this? OK, fixed in 8.2.X. We don't patch documentation past the most recent major release. Why not? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL

Re: [PATCHES] xpath_array with namespaces support

2007-04-04 Thread Peter Eisentraut
one, but what the xpath() code does it totally wrong nevertheless. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] xpath_array with namespaces support

2007-04-04 Thread Peter Eisentraut
cannot be evaluated with certainty. If no namespace mapping is to be passed, then you should pass a list(/array/...) of length zero. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked

Re: [PATCHES] xpath_array with namespaces support

2007-04-04 Thread Peter Eisentraut
? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] xpath_array with namespaces support

2007-04-04 Thread Peter Eisentraut
; ?column? -- t (1 row) pei=# select xml 'foobar/foofoobar/foo' IS DOCUMENT; ?column? -- f (1 row) -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] build/install xml2 when configured with libxml

2007-04-04 Thread Peter Eisentraut
Andrew Dunstan wrote: Since contrib/xml2 seems to be staying with us at least for now, this small patch enables it to be built and installed from the contrib Makefile when --with-libxml is given to configure. contrib/xml2 also requires libxslt. -- Peter Eisentraut http

Re: [PATCHES] build/install xml2 when configured with libxml

2007-04-04 Thread Peter Eisentraut
the individual module Makefiles instead), or . change the xml2 Makefile Any of these could be worth considering, but it needs to be thought through first. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you

Re: [PATCHES] Logging checkpoints and other slowdown causes

2007-04-03 Thread Peter Eisentraut
are for debugging, not for very high verbosity. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's

Re: [PATCHES] COPY-able sql log outputs

2007-03-30 Thread Peter Eisentraut
Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL: Attached is the completed patch for the COPY-able sql log outputs. Could you please remove random whitespace changes from this patch? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end

Re: [PATCHES] Current enums patch

2007-03-30 Thread Peter Eisentraut
your patch. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

  1   2   3   4   5   6   7   8   >