Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-21 Thread Klaus Naumann
On Wed, 21 Jul 2004, Tom Lane wrote: Hi Tom, Simon doesn't mean the recovery part. Instead he means the "normal" startup of the server. It has to be absolutely clear (in the logfile!) if the server was started in archive mode or not. Otherwise you always have to guess. On server startup there sho

Re: [PATCHES] win32 readline

2004-07-21 Thread Magnus Hagander
Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? Peter - what OS are you on, and what mingw version? And what locale? I've done my tests on Win XP, and it elcearly does not work (locale = Swedish). I've also talked to Merlin, and he had the sam

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-21 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: OK, new idea. Forget about modifying pg_dir_ls(). Instead add pg_file_stat the returns the file size, times. You can then easily use that for file size and times. Also, if you want, add an is_dir boolean so people can write functions that walk the dir

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Cave-Ayland
FYI: I've been using a CVS pull from the middle of May with readline under Win32 without any problems. Firing up the database and doing a 'show all' shows all lc_* vars set to English_United Kingdom.1252. This was compiled using MingW-3.1.0-1 and MSYS-1.0.10, running under Windows XP Pro. The only

Re: [PATCHES] win32 readline

2004-07-21 Thread Magnus Hagander
The locale that's interesting is the Windows locale, not the pg one. And I assume you are on english locale? Then you don't need Alt-Gr for backslash at least, but you're saying other Alt-Gr-key based combinations did work? (I've also had reports of history problems, which in at least one case ha

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Cave-Ayland
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Magnus Hagander > Sent: 21 July 2004 11:49 > To: Mark Cave-Ayland > Cc: [EMAIL PROTECTED] > Subject: Re: [PATCHES] win32 readline > > > The locale that's interesting is the Windows locale, not the

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T

2004-07-21 Thread David F. Skoll
Hi, This is a response to several messages: 1) Copyright notice: I have no problem having this removed, although it would be nice to credit me somewhere in a comment. 2) I put most of the code in a separate file so that if the patch is rejected, it's easy for me to maintain a forked copy. If t

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-21 Thread Bruce Momjian
David F. Skoll wrote: > Hi, > > This is a response to several messages: > > 1) Copyright notice: I have no problem having this removed, although it > would be nice to credit me somewhere in a comment. We credit in the commit message, and in the release notes so it will always be seen. > 2) I p

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T

2004-07-21 Thread David F. Skoll
On Wed, 21 Jul 2004, Bruce Momjian wrote: > Even though I suggested it, I am afraid this is just too confusing an API. How about this: pg_dump -t t1 -- Dump table t1 in any schema pg_dump -n s1 -- Dump all of schema s1 pg_dump -t t1 -n s1

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-21 Thread Bruce Momjian
Andreas Pflug wrote: > Bruce Momjian wrote: > > Andreas Pflug wrote: > > > > > > > > > OK, new idea. Forget about modifying pg_dir_ls(). Instead add > > pg_file_stat the returns the file size, times. You can then easily use > > that for file size and times. Also, if you want, add an is_dir

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-21 Thread Tom Lane
"David F. Skoll" <[EMAIL PROTECTED]> writes: > How about this: > pg_dump -t t1 -- Dump table t1 in any schema > pg_dump -n s1 -- Dump all of schema s1 > pg_dump -t t1 -n s1-- Dump t1 in s1 > pg_dump -t t1 -t t2 -n s1

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T

2004-07-21 Thread David F. Skoll
On Wed, 21 Jul 2004, Tom Lane wrote: > pg_dump -t s1.t1 -t s2.t2 -- Dump s1.t1 and s2.t2 That's a good idea, but then it's questionable whether we need the -n switch at all. It might be simpler to extend the -t switch to accept: pg-dump -t 's1.*' rather than using a -n swi

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-21 Thread Tom Lane
Klaus Naumann <[EMAIL PROTECTED]> writes: > Simon doesn't mean the recovery part. Instead he means the "normal" > startup of the server. It has to be absolutely clear (in the logfile!) if > the server was started in archive mode or not. Otherwise you always have > to guess. Why would you guess? "

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-21 Thread Tom Lane
"David F. Skoll" <[EMAIL PROTECTED]> writes: > On Wed, 21 Jul 2004, Tom Lane wrote: >> pg_dump -t s1.t1 -t s2.t2 -- Dump s1.t1 and s2.t2 > That's a good idea, but then it's questionable whether we need the -n > switch at all. Sure we do --- for backwards compatibility if nothing else

Re: [PATCHES] Show tablespace name in pg_tables and pg_indexes

2004-07-21 Thread Bruce Momjian
Patch applied and catalog version updated. We now have: test=> select * from pg_tables; schemaname |tablename| tablespace | tableowner | hasindexes | hasrules | hastriggers +-++++--+

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-21 Thread Andreas Pflug
Bruce Momjian wrote: I now replaced pg_logfile_length, instead pg_logfile_stat(text) will return a record (len int8, ctime timestamp, atime timestamp, mtime timestamp, isdir bool). You mean pg_file_stat(text), right? Of course. For convenience, I'd like to have the function CREATE FUNCTION pg

Re: [PATCHES] pg_config

2004-07-21 Thread Andrew Dunstan
There are a couple of things that need adjustment: 1. typo in the makefile - ((X) should be $(X) 2. these cases need to be fixed: else if (strcmp(argv[i],"--includedir-server") ==0) get_pkginclude_path(mypath,otherpath); else if (strcmp(argv[i

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-21 Thread Simon Riggs
On Wed, 2004-07-21 at 15:53, Tom Lane wrote: > Klaus Naumann <[EMAIL PROTECTED]> writes: > > Simon doesn't mean the recovery part. Instead he means the "normal" > > startup of the server. It has to be absolutely clear (in the logfile!) if > > the server was started in archive mode or not. Otherwise

Re: [PATCHES] autovacuum integration attempt #3

2004-07-21 Thread Bruce Momjian
I am having problem applying this. I don't think we can just move pg_autovacuum.[ch] right into the backend code. There are issues with include files and there is no definition for autovacuum_vacuum_base and other variables, and there is no AutoVacMain(). I can try guessing on those but I think

Re: [PATCHES] Docs for PL/Perl

2004-07-21 Thread Bruce Momjian
Patch applied. Thanks. --- David Fetter wrote: > Kind people, > > Please find enclosed a patch that matches the PL/Perl documentation > (fairly closely, I hope) to the current PL/Perl implementation. > > Cheers, > D > --

Re: [PATCHES] plperl return single composite

2004-07-21 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > The attached patch allows 'select foo()' as well as 'select * from > foo()' where foo() is a plperl function that returns a single composite. > > cheers > > andrew >

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Kirkwood
- CVS HEAD from approx 19 Jul - locale is 'English_New Zealand.1252' Magnus Hagander wrote: Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? ---(end of broadcast)--- TIP 5: Have you checked our e

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Kirkwood
Sorry - I have done it too: Windows Locale is : English (New Zealand) Mark Kirkwood wrote: - CVS HEAD from approx 19 Jul - locale is 'English_New Zealand.1252' Magnus Hagander wrote: Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? ---

Re: [PATCHES] autovacuum integration attempt #3

2004-07-21 Thread Matthew T. O'Connor
Sorry, perhaps my initial instructions weren't clear. You have to move the pg_autovacuum.[ch] files then apply the patch. The patch alters them considerably. Should I submit the patch in a different way? Thanks, Matthew > > I am having problem applying this. I don't think we can just move >

Re: [PATCHES] autovacuum integration attempt #3

2004-07-21 Thread Bruce Momjian
Matthew T. O'Connor wrote: > Sorry, perhaps my initial instructions weren't clear. > > You have to move the pg_autovacuum.[ch] files then apply the patch. The > patch alters them considerably. Should I submit the patch in a different > way? I don't see any modifications to pg_autovacuum.[ch] in

Re: [PATCHES] autovacuum integration attempt #3

2004-07-21 Thread Matthew T. O'Connor
Ack! I sent the wrong patch... Sorry I will resend it tonight. > Matthew T. O'Connor wrote: >> Sorry, perhaps my initial instructions weren't clear. >> >> You have to move the pg_autovacuum.[ch] files then apply the patch. The >> patch alters them considerably. Should I submit the patch in a >>

Re: [PATCHES] autovacuum integration attempt #3

2004-07-21 Thread Bruce Momjian
Patch withdrawn by author. Will resubmit. --- Matthew T. O'Connor wrote: > Ok, here is a new patch for to integrate pg_autovacuum into the backend. > > This patch adds the following to that last patch: > * updated to lates

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-21 Thread Bruce Momjian
Andreas Pflug wrote: > > or something like that. However, I don't think you can have a function > > call returning multiple values in the target list, and I can't figure > > out how to pass an argument to the function if it is in the target list. > > Ideas? > > I thought of > SELECT filename, len

Re: [PATCHES] win32 readline

2004-07-21 Thread Peter Eisentraut
Magnus Hagander wrote: > Hmm. And this is a cvs pull that was before Bruce actually disabled > readline? What locale are you in? Actually, I just just typed away in the bash shell, which uses readline as well. > Peter - what OS are you on, and what mingw version? And what locale? Windows XP Pro