Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Michael Paesold
anyone else feel inclined to fix this? Best Regards, Michael Paesold ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-20 Thread Michael Paesold
Tom Lane wrote: It is now fixed in the attached patch. Applied with some additional cleanup (the code wasn't multibyte-aware, and so could get fooled in some Far Eastern encodings). I am very pleased to hear. This was my first patch submitted. :-) Best Regards, Michael Paesold

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-21 Thread Michael Paesold
Tom Lane wrote: It is now fixed in the attached patch. Applied with some additional cleanup (the code wasn't multibyte-aware, and so could get fooled in some Far Eastern encodings). Looking at your cleanup is a good for learning more about C. :-) But I have one another question, you

[PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Michael Paesold
, or should pg_strcasecmp be used here? Best Regards, Michael Paesold psql-autocommit.diff Description: Binary data ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Michael Paesold
I wrote: Patch attached. Is strcasecmp ok, or should pg_strcasecmp be used here? I don't know how I did it, but this was the wrong patch. Correct patch attached now. Best Regards, MIchael Paesold variables.c.diff Description: Binary data ---(end of broadcast

[PATCHES] psql: rollback only last query on error

2004-09-21 Thread Michael Paesold
to oracle, mssql etc. At least at the interactive level, the patch would give them the option to have their accustomed way of handling e.g. typos. Thank you for your time and thank you for any response! Best Regards, Michael Paesold P.S. attached is a version of the patch with more/better comments

Re: [PATCHES] psql: rollback only last query on error

2004-09-23 Thread Michael Paesold
Alvaro Herrera wrote: On Tue, Sep 21, 2004 at 02:30:17PM +0200, Michael Paesold wrote: http://archives.postgresql.org/pgsql-hackers/2004-09/msg00576.php One potential problem I see with the patch is that it opens lots of savepoints but does not release any. In this mode, given autocommit

Re: [PATCHES] psql: rollback only last query on error

2004-09-24 Thread Michael Paesold
Michael Paesold [EMAIL PROTECTED] writes: Alvaro Herrera wrote: One potential problem I see with the patch is that it opens lots of savepoints but does not release any. Well, given that EXCEPTION blocks in Pl/pgSQL and the like also never release savepoints That statement is flat

Re: [PATCHES] Casting INT4 to BOOL...

2004-10-11 Thread Michael Paesold
not using it, would it? Best Regards, Michael Paesold ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Michael Paesold
. ISTM that there is also no distinction between VACUUM and VACUUM FULL, but I think pg_autovacuum never does a vacuum full, so there is no problem with that. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 8: explain analyze is your

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Michael Paesold
, but replaying the logs from the whole benchmark session) Best Regards, Michael Paesold ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread Michael Paesold
ITAGAKI Takahiro wrote: I think that there is room for improvement in WAL. Here is a patch for it. I think you should resend your patch as a context diff (diff -c). Otherwise it's hard to see what your patch does. Best Regards, Michael Paesold ---(end of broadcast

Re: [PATCHES] dbsize patch

2005-01-26 Thread Michael Paesold
Neil Conway wrote: On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote: The attached dbsize patch: + makes relation_size(relname) include toast tables; + adds aggregate_relation_size(relname) to count table data and indices; + adds indices_size(relname) to report the size of indices for a relation;

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Michael Paesold
the server and query that before every release. What do you think? Best Regards, Michael Paesold ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

Re: [PATCHES] Continue transactions after errors in psql

2005-01-29 Thread Michael Paesold
Greg Sabino Mullane wrote: Michael Paesold wrote: 2) Implement a server-side function to get the savepoints from the server and query that before every release. I could not find a way to do this. Is there any interface to the list? Alvaro suggested to implement such a function. It is not there yet

Re: [PATCHES] Continue transactions after errors in psql

2005-03-07 Thread Michael Paesold
\reseterror in .psqlrc. I previously suggested an AUTO setting (additional to ON/OFF) that disables \reseterror when reading from a non-tty. So putting \reseterror AUTO in .psqlrc would be save. Otherwise, I could not find a way to break it. :-) Best Regards, Michael Paesold

Re: [PATCHES] Continue transactions after errors in psql

2005-03-07 Thread Michael Paesold
at the moment. I still think there is a better way (parsing statements like it's already done for no-transaction-allowed-statements), but hey, as soon as your patch will be applied, I can myself propose another patch to improve this. ;-) Best Regards, Michael Paesold ---(end

Re: [PATCHES] Continue transactions after errors in psql

2005-04-25 Thread Michael Paesold
Bruce Momjian wrote: Michael Paesold wrote: Some suggestions in random order: * I think you should use PSQLexec instead of using PQexec directly. PSQLexec is used by all \-commands and prints out queries with -E, which is very helpful for debugging. -E display queries that internal

Re: [HACKERS] [PATCHES] Continue transactions after errors in psql

2005-04-26 Thread Michael Paesold
off in my .psqlrc file, too, and I know I am not the only one) * another one that will also work in scripts I hope you understand and accept the issue here. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 1: subscribe and unsubscribe

Re: [HACKERS] [PATCHES] Continue transactions after errors in psql

2005-04-26 Thread Michael Paesold
Richard Huxton wrote: Michael Paesold wrote: But people (like me for example) will want to enable this behaviour by default. So they (me too) will put the option in .psqlrc. It is then enabled by default. But then many of my scripts will destroy data instead of just erroring out. I just don't

Re: [PATCHES] [HACKERS] patches for items from TODO list

2005-05-29 Thread Michael Paesold
that's outside any spec anyway, but I do think we ought to think twice about adding this to SQL literal handling. +1 from me on this for Tom -- please don't break spec compliance! Best Regards, Michael Paesold ---(end of broadcast)--- TIP 7: don't

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Michael Paesold
to pg_dump is certainly easier) You forgot to document the long option, I think. Are the man pages generated from the sgml docs? Have never had a look at that. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 3: if posting/reading through

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Michael Paesold
it's not too far off. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] Disable page writes when fsync off, add GUC

2005-07-06 Thread Michael Paesold
the former. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] [HACKERS] Autovacuum loose ends

2005-07-30 Thread Michael Paesold
it turns cost-based vacuum delay on or off. I believe not many will have vacuum_cost_delay enabled in postgresql.conf, but will want to enable it for autovacuum. At least I do. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 3: Have

Re: [PATCHES] [HACKERS] Autovacuum loose ends

2005-08-01 Thread Michael Paesold
for our and many other production databases. I suggest that should be a plain VACUUM. Otherwise I think you have done great job finally integrating auto vacuum into the backend. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 1

Re: [PATCHES] Autovacuum docs

2005-09-13 Thread Michael Paesold
. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

[PATCHES] Bug in psql (on_error_rollback)

2005-09-16 Thread Michael Paesold
tests for AUTOCOMMIT and ON_ERROR_ROLLBACK and possibly others. There are currently no regression tests specifically for psql features, but since the regression tests are executed via psql, there would be no problem in creating a set of such tests, right?. I could write some. Best Regards, Michael

Re: [PATCHES] Proposed patch for sequence-renaming problems

2005-10-02 Thread Michael Paesold
. The missing dependencies for sequences were a bug in the first place, IMHO. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Michael Paesold
://cnswww.cns.cwru.edu/~chet/readline/rltop.html IMHO libreadline does not sound good. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your

Re: [PATCHES] running script on server shutdown (TODO)

2005-12-11 Thread Michael Paesold
wants to step up to maintain such a list, not as detailed as the release notes probably. Just my two (Euro)cents. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 4: Have you searched our list archives? http

Re: [PATCHES] TODO item: list prepared queries

2005-12-13 Thread Michael Paesold
or not. This comment is based on my assumption -- hopefully correct -- that the querytree has indeed changed from the original query. E.g. removed redundant parenthesis, added casts, etc. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 9

Re: [PATCHES] Constraint trigger doc patch

2006-10-16 Thread Michael Paesold
of DROP TRIGGER. Thanks again. Best Regards, Michael Paesold ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through

Re: [PATCHES] Constraint trigger doc patch

2006-10-17 Thread Michael Paesold
. Best Regards, Michael Paesold For quick reference: http://momjian.us/main/writings/pgsql/sgml/sql-createconstraint.html Index: create_constraint.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/create_constraint.sgml,v

Re: [PATCHES] Feature: POSIX Shared memory support

2007-02-06 Thread Michael Paesold
Regards Michael Paesold ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-15 Thread Michael Paesold
waiting on update from author: http://archives.postgresql.org/pgsql-patches/2007-04/msg00331.php Any updates on this? Best Regards Michael Paesold ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] WIP: rewrite numeric division

2007-06-19 Thread Michael Paesold
problem, perhaps because we round to very few digits, but well. Please apply this patch. I can accept the performance drop, as long as there won't be bad surprises with correctness. Best Regards Michael Paesold ---(end of broadcast)--- TIP 1

Re: [PATCHES] WIP: rewrite numeric division

2007-07-17 Thread Michael Paesold
is really unsafe? We usually *round* all values to at maximum 4 decimal places -- are we on the save side? Does this only affect high precision division, or any divisions? Best Regards Michael Paesold Bruce Momjian wrote: Because this has not been applied, this has been saved for the 8.4

Re: [PATCHES] [DOCS] Partition: use triggers instead of rules

2007-11-29 Thread Michael Paesold
about *why* the recommendation was changed. We have one rule-based setup here, and it has been working flawlessly for us,... so personally I don't even know the reasons. Best Regards Michael Paesold ---(end of broadcast)--- TIP 1: if posting/reading

Re: [PATCHES] [DOCS] Partition: use triggers instead of rules

2007-11-29 Thread Michael Paesold
Joshua D. Drake wrote: Michael Paesold wrote: I would also add another sentence about *why* the recommendation was changed. We have one rule-based setup here, and it has been working flawlessly for us,... so personally I don't even know the reasons. Rules are extremely slow in comparisons