Tom Lane napsal(a):
Zdenek Kotala <[EMAIL PROTECTED]> writes:
Thank your for Your and Alvaro's comments. I attached updated patch
version only with YYSTYPE definition.
Applied with minor revisions. I fixed pg_conversion.h as well; the only
remaining special inclusions in the catalog header fi
Zdenek Kotala <[EMAIL PROTECTED]> writes:
> Thank your for Your and Alvaro's comments. I attached updated patch
> version only with YYSTYPE definition.
Applied with minor revisions. I fixed pg_conversion.h as well; the only
remaining special inclusions in the catalog header files are of
pg_list.
Tom Lane napsal(a):
(a) it wasn't "to build at all", it was to allow "inline" to be enabled
on Sun Studio's compiler, which apparently is too dumb to not generate
copies of an unreferenced inline function.
I don't think that you have right. inline is just optimizer hint and Sun Studio
perfor
Zdenek Kotala wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> >>> Huh, I think the point is to be able to build 8.3 at all on certain
> >>> Solaris releases. I think it qualifies as a portability fix.
> >> (a) it wasn't "to build at all", it was
Bruce Momjian wrote:
Tom Lane wrote:
Alvaro Herrera <[EMAIL PROTECTED]> writes:
Huh, I think the point is to be able to build 8.3 at all on certain
Solaris releases. I think it qualifies as a portability fix.
(a) it wasn't "to build at all", it was to allow "inline" to be enabled
on Sun Studi
Bruce Momjian wrote:
> Tom Lane wrote:
> > Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > > Huh, I think the point is to be able to build 8.3 at all on certain
> > > Solaris releases. I think it qualifies as a portability fix.
> >
> > (a) it wasn't "to build at all", it was to allow "inline" to b
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Huh, I think the point is to be able to build 8.3 at all on certain
> > Solaris releases. I think it qualifies as a portability fix.
>
> (a) it wasn't "to build at all", it was to allow "inline" to be enabled
> on Sun Studio's compi
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Huh, I think the point is to be able to build 8.3 at all on certain
> Solaris releases. I think it qualifies as a portability fix.
(a) it wasn't "to build at all", it was to allow "inline" to be enabled
on Sun Studio's compiler, which apparently is too
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> >
> > This has been saved for the 8.4 release:
> >
> > http://momjian.postgresql.org/cgi-bin/pgpatches_hold
>
> Huh, I think the point is to be able to build 8.3 at all on certain
> Solaris releases. I think it qualifies as a portability fix.
Bruce Momjian wrote:
>
> This has been saved for the 8.4 release:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches_hold
Huh, I think the point is to be able to build 8.3 at all on certain
Solaris releases. I think it qualifies as a portability fix.
> -
This has been saved for the 8.4 release:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Zdenek Kotala wrote:
> Tom Lane wrote:
>
>
> >
> > AFAICT, therefore, the proposed patch should only define YYSTYP
Zdenek Kotala <[EMAIL PROTECTED]> writes:
> TYPE_IS_DECLARED was my mistake. It should be YYSTYPE_IS_DECLARED. It
> works because YYSTYPE is also defined and #ifdef checks both. Copy and
> paste :( error. Sorry for confusion. I'm going to send new version.
[ after further review... ]
It looks t
Tom Lane wrote:
Alvaro Herrera <[EMAIL PROTECTED]> writes:
Zdenek Kotala wrote:
What do you mean "not very portable"? What could be problem there?
I'm not sure. My point is that it seems your parse.h requires
TYPE_IS_DECLARED, but mine doesn't. What else could be lurking in there
that requ
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Zdenek Kotala wrote:
>> What do you mean "not very portable"? What could be problem there?
> I'm not sure. My point is that it seems your parse.h requires
> TYPE_IS_DECLARED, but mine doesn't. What else could be lurking in there
> that requires a spec
Alvaro Herrera wrote:
Zdenek Kotala wrote:
Alvaro Herrera wrote:
3) Put following fake into keyword.c before include "parse.h" line. It
is easiest way.
#define TYPE_IS_DECLARED 1
#define YYLTYPE_IS_DECLARED 1
#define YYLTYPE void*
#define YYSTYPE void*
New version of patch is attached. I sel
Zdenek Kotala wrote:
> Alvaro Herrera wrote:
3) Put following fake into keyword.c before include "parse.h" line. It
is easiest way.
#define TYPE_IS_DECLARED 1
#define YYLTYPE_IS_DECLARED 1
#define YYLTYPE void*
#define YYSTYPE void*
>>> New version of patch is attach
Alvaro Herrera wrote:
Zdenek Kotala wrote:
Zdenek Kotala wrote:
Zdenek Kotala wrote:
Attached patch removes pg_dump dependency on postgres.h. The main reason
for that was discussed there:
http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
I found two problems there. One is th
Zdenek Kotala wrote:
> Zdenek Kotala wrote:
>> Zdenek Kotala wrote:
>>> Attached patch removes pg_dump dependency on postgres.h. The main reason
>>> for that was discussed there:
>>>
>>> http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
>>>
>> I found two problems there. One is tha
Zdenek Kotala wrote:
Attached patch removes pg_dump dependency on postgres.h. The main reason
for that was discussed there:
http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
I found two problems there. One is that I forgot postgres.h include in
common.c. it is easy to fix. H
Zdenek Kotala wrote:
> Alvaro Herrera wrote:
>>> 1) I removed sugar word from postgres.h and put them closer to consumer
>>> :-). I created include/catalog/genbki.h which contains sugar words -
>>> macros for correct catalog data processing. All catalogs file now include
>>> this header.
>> Wha
Alvaro Herrera wrote:
Zdenek Kotala wrote:
Attached patch removes pg_dump dependency on postgres.h. The main reason
for that was discussed there:
http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
This fix contains several steps:
1) I removed sugar word from postgres.h and put
Zdenek Kotala wrote:
> Attached patch removes pg_dump dependency on postgres.h. The main reason
> for that was discussed there:
>
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
>
> This fix contains several steps:
>
> 1) I removed sugar word from postgres.h and put them closer
22 matches
Mail list logo
