Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/soap/php_sdl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/soap/php_sdl.c trunk/ext/soap/php_sdl.c

2012-03-05 Thread Hannes Magnusson
On Mon, Mar 5, 2012 at 13:59, Dmitry Stogov wrote: > dmitry                                   Mon, 05 Mar 2012 12:59:01 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=323909 > > Log: > Fixed bug #60887 (SoapClient ignores user_agent option and sends no > User-Agent header) >

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/streams/bug60106.phpt branches/PHP_5_3/main/streams/xp_socket.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/st

2012-03-04 Thread Ilia Alshanetsky
The operation can continue on-successfully so E_NOTICE seemed appropriate, I don't see a problem with escalating this to E_WARNING. On Sat, Mar 3, 2012 at 9:34 PM, Laruence wrote: > Hi: >   is a WARNING better?  :) > > thanks > > On Sun, Mar 4, 2012 at 4:36 AM, Ilia Alshanetsky wrote: >> iliaa  

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/streams/bug60106.phpt branches/PHP_5_3/main/streams/xp_socket.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/st

2012-03-03 Thread Laruence
Hi: is a WARNING better? :) thanks On Sun, Mar 4, 2012 at 4:36 AM, Ilia Alshanetsky wrote: > iliaa                                    Sat, 03 Mar 2012 20:36:14 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=323852 > > Log: > Fixed bug #60106 (stream_socket_server silent

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 10:38 AM, Xinchen Hui wrote: > On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: >> I initially looked at the final fix when I discovered the issue. >> Follow me out on this.  This is the current code as-implemented in >> r323563: >> >>    265                 zval *o

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: > I initially looked at the final fix when I discovered the issue. > Follow me out on this.  This is the current code as-implemented in > r323563: > >    265                 zval *obj; >    266                 MAKE_STD_ZVAL(obj); >    267    

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
I initially looked at the final fix when I discovered the issue. Follow me out on this. This is the current code as-implemented in r323563: 265 zval *obj; 266 MAKE_STD_ZVAL(obj); 267 if (Z_OBJ_HANDLER_P(*arg, cast_object)(*arg, obj, type

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
Sent from my iPad 在 2012-2-28,0:10,Anthony Ferrara 写道: > Out of curiosity, why are you changing it to copy the object for the > result of the cast operation? cast_object should init the result > zval, so why go through the step of copying the starting object to plz look at the final fix: r32356

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
Out of curiosity, why are you changing it to copy the object for the result of the cast operation? cast_object should init the result zval, so why go through the step of copying the starting object to it? Wouldn't it be easier just to do: if (Z_OBJ_HANDLER_PP(arg, cast_object)) {

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Richard Lynch
On Mon, February 27, 2012 2:31 am, Laruence wrote: > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov > wrote: >> Hi Laruence, >> >> The attached patch looks wired. The patch on top of it (r323563) >> makes it >> better. However, in my opinion it fixes a common problem just in a >> single >> place.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Pierre Joye
On Mon, Feb 27, 2012 at 11:17 AM, Derick Rethans wrote: > You can't break extension APIs between 5.4.0 and 5.4.1 either, API > changes can only into trunk. And ABI neither. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/)

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Derick Rethans
On Mon, 27 Feb 2012, Laruence wrote: > On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: > > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: > >> > >> The attached patch looks wired. The patch on top of it (r323563) makes it > >> better. However, in my opinion it fixes a common problem just

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Dmitry Stogov
On 02/27/2012 12:37 PM, Laruence wrote: On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: Hi Laruence, The attached patch looks wired. The patch on top of it (r323563) makes it better. However, in my opinion it fixes a common problem just

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Laruence
On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: >> Hi Laruence, >> >> The attached patch looks wired. The patch on top of it (r323563) makes it >> better. However, in my opinion it fixes a common problem just in a single >> place. Each call

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Laruence
On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: > Hi Laruence, > > The attached patch looks wired. The patch on top of it (r323563) makes it > better. However, in my opinion it fixes a common problem just in a single > place. Each call to __toString() that makes "side effects" may cause the

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Dmitry Stogov
Hi Laruence, The attached patch looks wired. The patch on top of it (r323563) makes it better. However, in my opinion it fixes a common problem just in a single place. Each call to __toString() that makes "side effects" may cause the similar problem. It would be great to make a "right" fix in

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-24 Thread Laruence
Dmitry: you might want to review this fix. let me explain why crash before this fix. when doing parse_parameter, then convert the object to string by calling the ce->cast_object, and passed the same pointer(although there was a separation), to the cast_object.. then if __toStrin

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/reflection/php_reflection.c branches/PHP_5_3/ext/reflection/tests/bug60367.phpt trunk/NEWS trunk/ext/reflection/php_reflecti

2012-02-04 Thread Laruence
Hi bjori: On Sat, Feb 4, 2012 at 8:33 PM, Hannes Magnusson wrote: > On Fri, Feb 3, 2012 at 17:27, Xinchen Hui wrote: >> laruence                                 Fri, 03 Feb 2012 16:27:35 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=323045 >> >> Log: >> Fixed bug #60968

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/reflection/php_reflection.c branches/PHP_5_3/ext/reflection/tests/bug60367.phpt trunk/NEWS trunk/ext/reflection/php_reflecti

2012-02-04 Thread Hannes Magnusson
On Fri, Feb 3, 2012 at 17:27, Xinchen Hui wrote: > laruence                                 Fri, 03 Feb 2012 16:27:35 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=323045 > > Log: > Fixed bug #60968 (Late static binding doesn't work with > ReflectionMethod::invokeArgs()) >

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-25 Thread Stas Malyshev
Hi! Considering this little fix, it is no harm to commit to RC. :) Anyway it also okey for me to commit after release, since this is really a trivial bug and there are already one patche for me need to be remembered ci after 5.4.0 released. :) OK, it looks like we're going to have another R

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-25 Thread Pierre Joye
to be more specific: If we do not want to delay 5.4 any further (and I think we should not delay it any longer after this RC). We should simply stop any kind of commits after it, to follow the golden release rule. Only very critical security issues should be allowed, after approvals. It is also e

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-25 Thread Pierre Joye
hi! we need another RC anyway. There is another trait segfault and that openssl security bug. Cheers, On Wed, Jan 25, 2012 at 8:29 AM, Stas Malyshev wrote: > Hi! > > >> Now it looks fine. >> I think it should be committed into 5.4 as well. >> Stas? > > > That would probably require new RC, i.e

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-25 Thread Xinchen Hui
Sent from my iPhone 在 2012-1-25,15:49,Dmitry Stogov 写道: > On 01/25/2012 11:36 AM, Rasmus Lerdorf wrote: >> Still a known crash bug though. This is what our RCs are supposed to >> catch, right? > > This is not a single way to crash PHP with especially prepared code. > Some of these ways are never

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Dmitry Stogov
On 01/25/2012 11:36 AM, Rasmus Lerdorf wrote: Still a known crash bug though. This is what our RCs are supposed to catch, right? This is not a single way to crash PHP with especially prepared code. Some of these ways are never going to be fixed. For me it doesn't mater if this patch will be co

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Stas Malyshev
Hi! Still a known crash bug though. This is what our RCs are supposed to catch, right? Right, but judging by current patten we're pushing the release further and further without any obvious end in sight. If we will wait with the release until we have 0 bugs in PHP (or even 0 possibility of s

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Rasmus Lerdorf
Still a known crash bug though. This is what our RCs are supposed to catch, right? On 01/24/2012 11:34 PM, Dmitry Stogov wrote: > Hi Stas, > > Not a big problem, just yet another way to crash PHP locally with tricky > code. It may be committed after release as well. > > Thanks. Dmitry. > > On 0

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Dmitry Stogov
Hi Stas, Not a big problem, just yet another way to crash PHP locally with tricky code. It may be committed after release as well. Thanks. Dmitry. On 01/25/2012 11:29 AM, Stas Malyshev wrote: Hi! Now it looks fine. I think it should be committed into 5.4 as well. Stas? That would probabl

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Stas Malyshev
Hi! Now it looks fine. I think it should be committed into 5.4 as well. Stas? That would probably require new RC, i.e. release will have to be pushed back. How serious is the problem we're talking about? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Dmitry Stogov
Hi, Now it looks fine. I think it should be committed into 5.4 as well. Stas? Thanks. Dmitry. On 01/24/2012 06:43 PM, Laruence wrote: HI Dmitry: could you please review this improved fix? thanks On Tue, Jan 24, 2012 at 10:39 PM, Xinchen Hui wrote: laruence

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60825.phpt branches/PHP_5_3/Zend/zend_vm_def.h branches/PHP_5_3/Zend/zend_vm_execute.h trunk/NEWS trunk/Zend/tests

2012-01-24 Thread Laruence
HI Dmitry: could you please review this improved fix? thanks On Tue, Jan 24, 2012 at 10:39 PM, Xinchen Hui wrote: > laruence                                 Tue, 24 Jan 2012 14:39:45 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=322678 > > Log: > Re-fixed bug #60825

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-12-18 Thread Pierre Joye
On Sun, Dec 18, 2011 at 9:03 PM, Scott MacVicar wrote: > It's not worth adding a test for, it's never going to re-occur and it only > affects 4 year old versions of OpenSSL. Basically RHEL 5 is the only thing > with a problem. > > I wrote one but don't want to add a somewhat useless test. Attach

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-12-18 Thread Christopher Jones
I'm +1 on adding it for several reasons, one of which is there are plenty of RHEL 5 (and OL 5) sites out there. Chris PS the testcase wasn't attached to your email. On 12/18/2011 12:03 PM, Scott MacVicar wrote: It's not worth adding a test for, it's never going to re-occur and it only affec

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-12-18 Thread Scott MacVicar
It's not worth adding a test for, it's never going to re-occur and it only affects 4 year old versions of OpenSSL. Basically RHEL 5 is the only thing with a problem. I wrote one but don't want to add a somewhat useless test. Attached, but the extra second to test running isn't worth it. - Sco

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-12-18 Thread Pierre Joye
hi, do you have a test case for this crash? Cheers, On Sun, Dec 18, 2011 at 6:14 AM, Scott MacVicar wrote: > scottmac                                 Sun, 18 Dec 2011 05:14:32 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=321094 > > Log: > Fix segfault in older versions o

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS main/main.c main/php_globals.h main/php_variables.c

2011-12-15 Thread Pierre Joye
hi Dmitry, As of yesterday, please add it to php.ini and to the UPGRADING guide :) Thanks! On Thu, Dec 15, 2011 at 9:47 AM, Dmitry Stogov wrote: > dmitry                                   Thu, 15 Dec 2011 08:47:03 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=321038 > > L

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/date/lib/parse_date.c branches/PHP_5_3/ext/date/lib/parse_date.re branches/PHP_5_3/ext/date/tests/bug54851.phpt branches/PHP

2011-12-04 Thread Derick Rethans
On Sun, 4 Dec 2011, Hannes Magnusson wrote: > On Sat, Nov 26, 2011 at 17:44, Derick Rethans wrote: > > derick                                   Sat, 26 Nov 2011 16:44:21 + > > > > Revision: http://svn.php.net/viewvc?view=revision&revision=319960 > > > > Log: > > - Fixed bug #54851 (DateTime::

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/date/lib/parse_date.c branches/PHP_5_3/ext/date/lib/parse_date.re branches/PHP_5_3/ext/date/tests/bug54851.phpt branches/PHP

2011-12-04 Thread Hannes Magnusson
On Sat, Nov 26, 2011 at 17:44, Derick Rethans wrote: > derick                                   Sat, 26 Nov 2011 16:44:21 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319960 > > Log: > - Fixed bug #54851 (DateTime::createFromFormat() doesn't interpret "D"). > > Bug: https:/

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pgsql/pgsql.c branches/PHP_5_3/ext/pgsql/tests/bug60244.phpt branches/PHP_5_4/ext/pgsql/pgsql.c branches/PHP_5_4/ext/pgsql/t

2011-11-16 Thread Ilia Alshanetsky
Previous, missing news entry. On Tue, Nov 15, 2011 at 1:06 PM, Felipe Pena wrote: > 2011/11/15 Ilia Alshanetsky : >> iliaa                                    Tue, 15 Nov 2011 18:02:58 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=319259 >> >> Log: >> Fixed bug #60244 (pg_

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pgsql/pgsql.c branches/PHP_5_3/ext/pgsql/tests/bug60244.phpt branches/PHP_5_4/ext/pgsql/pgsql.c branches/PHP_5_4/ext/pgsql/t

2011-11-15 Thread Felipe Pena
2011/11/15 Ilia Alshanetsky : > iliaa                                    Tue, 15 Nov 2011 18:02:58 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319259 > > Log: > Fixed bug #60244 (pg_fetch_* functions do not validate that row param is >0). > > Bug: https://bugs.php.net/60244

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/apache/mod_php5.c branches/PHP_5_3/sapi/apache2filter/sapi_apache2.c branches/PHP_5_3/sapi/apache2handler/sapi_apache2.c br

2011-11-03 Thread Laruence
sorry for wrong bug id, should be: Fixed bug #60205 (possible integer overflow in content_length) thanks On Thu, Nov 3, 2011 at 3:26 PM, Xinchen Hui wrote: > laruence                                 Thu, 03 Nov 2011 07:26:09 + > > Revision: http://svn.php.net/viewvc?view=revision&revision

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug60139.phpt branches/PHP_5_3/Zend/zend_closures.c branches/PHP_5_4/Zend/tests/bug60139.phpt branches/PHP_5_4/Zend/z

2011-11-02 Thread Pierre Joye
hi Dmitry! Thanks for this fix :) Can you add a note to the UPGRADING.INTERNALS please? About the new get_gc handler? Thanks! On Wed, Nov 2, 2011 at 7:31 AM, Dmitry Stogov wrote: > dmitry                                   Wed, 02 Nov 2011 06:31:33 + > > Revision: http://svn.php.net/viewvc?

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/xsl/php_xsl.c ext/xsl/php_xsl.h ext/xsl/xsltprocessor.c

2011-10-06 Thread Christian Stocker
Fixed chregu On 06.10.11 16:31, Hannes Magnusson wrote: > On Wed, Oct 5, 2011 at 11:56, Christian Stocker wrote: >> chregu Wed, 05 Oct 2011 09:56:01 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=317759 >> >> Log: >> Added xsl.security_pr

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/xsl/php_xsl.c ext/xsl/php_xsl.h ext/xsl/xsltprocessor.c

2011-10-06 Thread Hannes Magnusson
On Wed, Oct 5, 2011 at 11:56, Christian Stocker wrote: > chregu                                   Wed, 05 Oct 2011 09:56:01 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=317759 > > Log: > Added xsl.security_prefs ini option to define forbidden operations within XSLT > styles

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-09-26 Thread Rasmus Lerdorf
On 09/26/2011 03:03 PM, Hannes Magnusson wrote: > Where is that discussion? > > Would be nice to have this officially known, as it often becomes > really weird during 5.3.42 and 5.4.3 development.. is bugfix XYZ > including in that or that release :] We had it a while ago. It makes perfect sense

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-09-26 Thread Hannes Magnusson
Where is that discussion? Would be nice to have this officially known, as it often becomes really weird during 5.3.42 and 5.4.3 development.. is bugfix XYZ including in that or that release :] -Hannes On Mon, Sep 26, 2011 at 15:00, Pierre Joye wrote: > that's changes since last 5.4 releases an

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-09-26 Thread Pierre Joye
that's changes since last 5.4 releases and will be cleaned up in final. There was a discussion about that and it was told to do so. On Mon, Sep 26, 2011 at 2:32 PM, Hannes Magnusson wrote: > On Mon, Sep 26, 2011 at 10:56, Pierre Joye wrote: >> pajoye                                   Mon, 26 Sep

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-09-26 Thread Hannes Magnusson
On Mon, Sep 26, 2011 at 10:56, Pierre Joye wrote: > pajoye                                   Mon, 26 Sep 2011 08:56:56 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=317307 > > Log: > - update news > > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS >    U   php/php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_4/NEWS trunk/NEWS

2011-09-17 Thread Laruence
Hi: done~ :) thanks 2011/9/17 Kalle Sommer Nielsen : > Hi > > 2011/9/17 Xinchen Hui : >> laruence                                 Sat, 17 Sep 2011 03:23:38 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=316897 >> >> Log: >> Update NEWS >> >> Changed paths: >>    U   php/p

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_4/NEWS trunk/NEWS

2011-09-17 Thread Kalle Sommer Nielsen
Hi 2011/9/17 Xinchen Hui : > laruence                                 Sat, 17 Sep 2011 03:23:38 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316897 > > Log: > Update NEWS > > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS >    U   php/php-src/branches/PHP_5_4/NEW

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS Zend/zend_builtin_functions.c

2011-09-15 Thread Johannes Schlüter
On Thu, 2011-09-15 at 12:28 +0200, Ferenc Kovacs wrote: > so we are now reverting back to the old behavior? > I didn't expected that by the discussion on the mailing list. ack, we shouldn't have changed the behavior in the fist place. But going back and forth is creating an even bigger mess. joha

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS Zend/zend_builtin_functions.c

2011-09-15 Thread Ferenc Kovacs
On Thu, Sep 15, 2011 at 11:58 AM, Dmitry Stogov wrote: > dmitry                                   Thu, 15 Sep 2011 09:58:33 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316810 > > Log: > Fixed bug #55475 (is_a() triggers autoloader). (alan at akbkhome dot com) > > Bug: http

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug55509.phpt branches/PHP_5_3/Zend/zend_alloc.c branches/PHP_5_4/Zend/tests/bug55509.phpt branches/PHP_5_4/Zend/zend

2011-09-13 Thread Laruence
Hi: anyone has Zend karma, plz help dmitry to fix this litte bug. specifically, change the expect warning to : Fatal error: Allowed memory size of %d bytes exhausted at %s (tried to allocate %d bytes) in %s/bug55509.php on line %d thanks 2011/9/14 Christopher Jones : > > Dmitry, > > T

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug55509.phpt branches/PHP_5_3/Zend/zend_alloc.c branches/PHP_5_4/Zend/tests/bug55509.phpt branches/PHP_5_4/Zend/zend

2011-09-13 Thread Christopher Jones
Dmitry, This is diffing for me in 5.4 (I've haven't looked at 5.3 or trunk): 007+ Fatal error: Allowed memory size of 3221225472 bytes exhausted at /home/cjones/phpsrc/php/php-src/branches/PHP_5_4/ext/standard/string.c:4636 (tried to allocate 536870913 bytes) in /home/cjones/phpsrc/php/php-src

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-09-13 Thread Hannes Magnusson
On Tue, Sep 13, 2011 at 15:11, Xinchen Hui wrote: > laruence                                 Tue, 13 Sep 2011 13:11:42 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316622 > > Log: > update news > > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS >    U   php/php-s

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/crypt.c branches/PHP_5_3/ext/standard/tests/strings/crypt_variation1.phpt branches/PHP_5_4/ext/standard/crypt.c bra

2011-09-12 Thread Stas Malyshev
Hi! On 9/12/11 3:04 AM, Hannes Magnusson wrote: Shouldn't this be merged to trunk too? Thanks, somehow I forgot to merge it. Done now. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubsc

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/crypt.c branches/PHP_5_3/ext/standard/tests/strings/crypt_variation1.phpt branches/PHP_5_4/ext/standard/crypt.c bra

2011-09-12 Thread Hannes Magnusson
On Tue, Jul 5, 2011 at 01:38, Stanislav Malyshev wrote: > stas                                     Mon, 04 Jul 2011 23:38:09 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=312919 > > Log: > fix crypt() issue with overlong salt > > Changed paths: >    U   php/php-src/branches/

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/curl/interface.c branches/PHP_5_3/ext/curl/tests/bug48203.phpt branches/PHP_5_3/ext/curl/tests/bug54798.phpt branches/PHP_5_

2011-09-09 Thread Hannes Magnusson
On Thu, Sep 8, 2011 at 21:53, Alexey Shein wrote: > Hello, Hannes! > It seems your fix is wrong, bug54798 still fails on my machine on > trunk, 5.4 and 5.3 branches (ubuntu x64). > IMO you should move your patch one line upper, i.e. before call to > _php_curl_cleanup_handle(ch); since error is ras

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/curl/interface.c branches/PHP_5_3/ext/curl/tests/bug48203.phpt branches/PHP_5_3/ext/curl/tests/bug54798.phpt branches/PHP_5_

2011-09-08 Thread Alexey Shein
Hello, Hannes! It seems your fix is wrong, bug54798 still fails on my machine on trunk, 5.4 and 5.3 branches (ubuntu x64). IMO you should move your patch one line upper, i.e. before call to _php_curl_cleanup_handle(ch); since error is rasing there. I've also made some patches for this, could you r

Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/NEWS PHP_5_4/NEWS

2011-08-30 Thread Kalle Sommer Nielsen
Hi 2011/8/30 Arpad Ray : > arpad                                    Tue, 30 Aug 2011 14:01:35 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=315784 > > Log: > fix news entries > > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS >    U   php/php-src/branches/PHP_5_4/

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS

2011-08-30 Thread Hannes Magnusson
On Mon, Aug 29, 2011 at 23:45, Arpad Ray wrote: > arpad                                    Mon, 29 Aug 2011 21:45:42 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=315747 > > Log: > news entry for r66021 Log: > > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS > > M

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_

2011-07-08 Thread Daniel Convissor
Hi Folks: On Thu, Jul 07, 2011 at 02:20:50PM -0700, Stas Malyshev wrote: > > In fact, I'm not sure why would we need such warning at all. Unknown > class - return false, who cares? +1 Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intens

Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_fu

2011-07-07 Thread Stas Malyshev
Hi! On 7/7/11 2:08 PM, Johannes Schlüter wrote: On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: what kind of troubles do they see? https://pear.php.net/bugs/bug.php?id=18656 Even if the Warning is good it's questionable for 5.3, especially during RC. Yes, I had problem with it too in

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functi

2011-07-07 Thread Johannes Schlüter
On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: > what kind of troubles do they see? https://pear.php.net/bugs/bug.php?id=18656 Even if the Warning is good it's questionable for 5.3, especially during RC. (note that warnings not only cause the error being reported, which can be switched off

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functi

2011-07-07 Thread Pierre Joye
what kind of troubles do they see? 2011/7/7 Johannes Schlüter : > Hi, > > I was told (didn't verify) that this causes lots of trouble with PEAR > and other applications. We're in final RC phase of 5.3.7. I don't think > it is critical for 5.3.7 and I wonder whether we need it for 5.3 at all. > > j

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_3/e

2011-07-07 Thread Johannes Schlüter
Hi, I was told (didn't verify) that this causes lots of trouble with PEAR and other applications. We're in final RC phase of 5.3.7. I don't think it is critical for 5.3.7 and I wonder whether we need it for 5.3 at all. johannes On Mon, 2011-07-04 at 14:55 +, Dmitry Stogov wrote: > dmitry

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/config.m4 branches/PHP_5_3/sapi/fpm/fpm/fpm.c branches/PHP_5_3/sapi/fpm/fpm/fpm_atomic.h branches/PHP_5_3/sapi/fpm/fpm/

2011-06-26 Thread Jérôme Loyet
> This looks like a rather big change. Is that needed for 5.3.7? Even if it looks big, it's not that big. I've extended the SHM usage and renamed it to scoreboard. It's not necessary needed for 5.3.7. ++ Jerome -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/config.m4 branches/PHP_5_3/sapi/fpm/fpm/fpm.c branches/PHP_5_3/sapi/fpm/fpm/fpm_atomic.h branches/PHP_5_3/sapi/fpm/fpm/

2011-06-26 Thread Johannes Schlüter
On Sun, 2011-06-26 at 15:48 +, Jérôme Loyet wrote: > fat Sun, 26 Jun 2011 15:48:11 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=312496 > > Log: > - Replaced shm_slots with a real scoreboard > - Added several improvements to the stat

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/intl/php_intl.c branches/PHP_5_3/ext/intl/tests/intl_icu_version_constant.phpt branches/PHP_5_4/ext/intl/php_intl.c branches

2011-06-03 Thread Hannes Magnusson
It seems the bug reporter preferred the data version.. I'd say include it too, doesn't hurt atleast :) -Hannes On Thu, Jun 2, 2011 at 19:09, Ilia Alshanetsky wrote: > The version is already printed in phpinfo(), I am not sure we need to > bring the data version... What do you think? > > On Thu,

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/intl/php_intl.c branches/PHP_5_3/ext/intl/tests/intl_icu_version_constant.phpt branches/PHP_5_4/ext/intl/php_intl.c branches

2011-06-02 Thread Ilia Alshanetsky
The version is already printed in phpinfo(), I am not sure we need to bring the data version... What do you think? On Thu, Jun 2, 2011 at 11:37 AM, Hannes Magnusson wrote: > On Wed, Jun 1, 2011 at 18:26, Ilia Alshanetsky wrote: >> iliaa                                    Wed, 01 Jun 2011 16:26:2

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/intl/php_intl.c branches/PHP_5_3/ext/intl/tests/intl_icu_version_constant.phpt branches/PHP_5_4/ext/intl/php_intl.c branches

2011-06-02 Thread Hannes Magnusson
On Wed, Jun 1, 2011 at 18:26, Ilia Alshanetsky wrote: > iliaa                                    Wed, 01 Jun 2011 16:26:21 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=311714 > > Log: > Implemented FR #54561 (Expose ICU Version & ICU Data Version info). > > Bug: http://bugs

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_stmt.c branches/PHP_5_4/ext/pdo/pdo_stmt.c trunk/ext/pdo/pdo_stmt.c

2011-06-01 Thread Ilia Alshanetsky
Johannes, As the bug report mentions the current behaviour is un-expected and this change does not necessarily make the error fatal, since it'll abide by the error emitting config the user specifies for PDO as opposed to ignoring it.. 2011/6/1 Johannes Schlüter : > Hi, > > this might be a good th

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_stmt.c branches/PHP_5_4/ext/pdo/pdo_stmt.c trunk/ext/pdo/pdo_stmt.c

2011-06-01 Thread Johannes Schlüter
Hi, this might be a good thing for consistency and maybe reflect expectations more, but changing a warning to (possibly) an exception, which is fatal is a quite big change. Isn't it? johannes On Wed, 2011-06-01 at 13:23 +, Ilia Alshanetsky wrote: > iliaaWe

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug54910.phpt branches/PHP_5_3/Zend/zend_API.c trunk/Zend/tests/bug54910.phpt trunk/Zend/zend_API.c

2011-05-31 Thread Ilia Alshanetsky
Please merge into 5.4 branch as well. Thanks On Tue, May 31, 2011 at 11:20 AM, Dmitry Stogov wrote: > dmitry                                   Tue, 31 May 2011 09:20:51 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=311635 > > Log: > Fixed bug #54910 (Crash when calling cal

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/streams/bug54623.phpt branches/PHP_5_3/main/streams/streams.c trunk/ext/standard/tests/streams/bug54623.phpt

2011-05-02 Thread Antony Dovgal
The test segfaults here. And Valgrind shows this: ==21439== Invalid read of size 8 ==21439==at 0x8EDC69: _php_stream_write (streams.c:1085) ==21439==by 0x826C0A: zif_fwrite (file.c:1294) ==21439==by 0x97C392: zend_do_fcall_common_helper_SPEC (zend_vm_execute.h:320) ==21439==by 0x

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/spl/spl_directory.c ext/spl/spl_iterators.c ext/spl/tests/bug54384.phpt ext/spl/tests/iterator_031.phpt

2011-04-25 Thread Gustavo Lopes
On Mon, 25 Apr 2011 12:32:04 +0100, Hannes Magnusson wrote: 2011/4/4 Gustavo André dos Santos Lopes : cataphract Mon, 04 Apr 2011 02:50:27 + Revision: http://svn.php.net/viewvc?view=revision&revision=309929 Log: - Fixed bug #54384 (Dual iterators, GlobIter

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/spl/spl_directory.c ext/spl/spl_iterators.c ext/spl/tests/bug54384.phpt ext/spl/tests/iterator_031.phpt

2011-04-25 Thread Hannes Magnusson
2011/4/4 Gustavo André dos Santos Lopes : > cataphract                               Mon, 04 Apr 2011 02:50:27 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=309929 > > Log: > - Fixed bug #54384 (Dual iterators, GlobIterator, SplFileObject and >  SplTempFileObject crash when u

Re: [PHP-CVS] svn: / php/php-src/branches/PHP_5_3/NEWS php/php-src/branches/PHP_5_3/configure.in php/php-src/branches/PHP_5_3/main/build-defs.h.in php/php-src/branches/PHP_5_3/main/main.c php/php-src/

2011-04-18 Thread Hannes Magnusson
2011/4/18 Johannes Schlüter : > On 04/18/11 11:50 AM, Hannes Magnusson wrote: >> >> Expose PHP_MANDIR >> Useful for apps (like the pear installer, phd, .. etc) to install their >> manpages into the same dir as php did :] > > Shouldn't that be done via php-config? Why? These are .php apps, I don't

Re: [PHP-CVS] svn: / php/php-src/branches/PHP_5_3/NEWS php/php-src/branches/PHP_5_3/configure.in php/php-src/branches/PHP_5_3/main/build-defs.h.in php/php-src/branches/PHP_5_3/main/main.c php/php-src/

2011-04-18 Thread Johannes Schlüter
On 04/18/11 11:50 AM, Hannes Magnusson wrote: Expose PHP_MANDIR Useful for apps (like the pear installer, phd, .. etc) to install their manpages into the same dir as php did :] Shouldn't that be done via php-config? johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visi

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/string.c branches/PHP_5_3/ext/standard/tests/strings/bug54238.phpt trunk/ext/standard/string.c trunk/ext/standard/t

2011-04-13 Thread Pierre Joye
hi Stas, please add the CVE to the news entry. On Wed, Apr 13, 2011 at 8:32 AM, Stanislav Malyshev wrote: > stas                                     Wed, 13 Apr 2011 06:32:41 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=310194 > > Log: > fix bug #54238 (use-after-free in

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/Zend/zend_API.c

2011-04-01 Thread Antony Dovgal
On 04/01/2011 03:47 AM, Pierre Joye wrote: > Hi Tony, > > This commit breaks the build, see: > Oh, sorry about that. For some reason I was 100% sure this structure is the same in HEAD, but apparently it isn't. -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP C

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/Zend/zend_API.c

2011-03-31 Thread Pierre Joye
Hi Tony, This commit breaks the build, see: http://windows.php.net/downloads/snaps/trunk-ts-windows-vc9-x86/logs/r309857/compile.txt Not sure yet why it fails. Does it work for you? On Thu, Mar 31, 2011 at 1:59 PM, Antony Dovgal wrote: > tony2001                                 Thu, 31 Mar 201

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/json/JSON_parser.c trunk/ext/json/JSON_parser.c

2011-02-11 Thread Christopher Jones
Scott, Are there any tests for this? Chris On 02/09/2011 12:05 AM, Scott MacVicar wrote: scottmac Wed, 09 Feb 2011 08:05:00 + Revision: http://svn.php.net/viewvc?view=revision&revision=308155 Log: Fix Bug #53963, error code isn't always set in certain err

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS UPGRADING ext/spl/spl_directory.c ext/spl/tests/DirectoryIterator_getExtension_basic.phpt ext/spl/tests/SplFileInfo_getExtension_basic.phpt

2011-02-11 Thread Pierre Joye
hi, Please add it to UPGRADING too :) Cheers, On Fri, Feb 11, 2011 at 11:07 PM, Peter Cowburn wrote: > salathe                                  Fri, 11 Feb 2011 22:07:22 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=308264 > > Log: > MFH - Added SplFileInfo::getExtension(

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/serialize/precision.phpt branches/PHP_5_3/main/main.c trunk/ext/standard/tests/serialize/precision.phpt trunk

2011-02-08 Thread Gustavo Lopes
On Wed, 09 Feb 2011 00:05:39 -, Christopher Jones wrote: Can you update php.ini-* too - and ideally also update the doc? Try using edit.php.net. Done. Thanks for bringing this to my attention. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/serialize/precision.phpt branches/PHP_5_3/main/main.c trunk/ext/standard/tests/serialize/precision.phpt trunk

2011-02-08 Thread Christopher Jones
On 02/08/2011 01:40 PM, Gustavo André dos Santos Lopes wrote: cataphract Tue, 08 Feb 2011 21:40:51 + Revision: http://svn.php.net/viewvc?view=revision&revision=308150 Log: - Changed default serialize_precision from 100 to 17, as discussed in internals. Chang

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/filter/tests/015.phpt branches/PHP_5_3/ext/standard/url.c trunk/ext/filter/tests/015.phpt trunk/ext/standard/url.c

2011-02-06 Thread Ilia Alshanetsky
Missing news entry from a previous bug fix. On Fri, Feb 4, 2011 at 10:37 PM, Adam Harvey wrote: > On 5 February 2011 05:41, Ilia Alshanetsky wrote: >> Log: >> Fixed bug #53924 (FILTER_VALIDATE_URL doesn't validate port number). >> >> Modified: php/php-src/branches/PHP_5_3/NEWS >> ===

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/filter/tests/015.phpt branches/PHP_5_3/ext/standard/url.c trunk/ext/filter/tests/015.phpt trunk/ext/standard/url.c

2011-02-04 Thread Adam Harvey
On 5 February 2011 05:41, Ilia Alshanetsky wrote: > Log: > Fixed bug #53924 (FILTER_VALIDATE_URL doesn't validate port number). > > Modified: php/php-src/branches/PHP_5_3/NEWS > === > --- php/php-src/branches/PHP_5_3/NEWS   2011-02-04

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/fpm/fpm_php.c branches/PHP_5_3/sapi/fpm/fpm/fpm_php.h branches/PHP_5_3/sapi/fpm/fpm/fpm_request.c branches/PHP_5_3/sapi

2011-01-30 Thread Antony Dovgal
On 01/30/2011 04:52 PM, Jérôme Loyet wrote: > 2011/1/30 Antony Dovgal : >> On 01/29/2011 02:38 PM, Jérôme Loyet wrote: >>> + if (request_uri) { >>> + cpystrn(slot->request_uri, request_uri, >>> sizeof(slot->request_uri)); >>> + } >>> + >> >> No need to use/have private string f

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/fpm/fpm_php.c branches/PHP_5_3/sapi/fpm/fpm/fpm_php.h branches/PHP_5_3/sapi/fpm/fpm/fpm_request.c branches/PHP_5_3/sapi

2011-01-30 Thread Jérôme Loyet
2011/1/30 Antony Dovgal : > On 01/29/2011 02:38 PM, Jérôme Loyet wrote: >> +     if (request_uri) { >> +             cpystrn(slot->request_uri, request_uri, >> sizeof(slot->request_uri)); >> +     } >> + > > No need to use/have private string funcs for that, we have strlcpy() & > strlcat() in PHP

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/fpm/fpm_php.c branches/PHP_5_3/sapi/fpm/fpm/fpm_php.h branches/PHP_5_3/sapi/fpm/fpm/fpm_request.c branches/PHP_5_3/sapi

2011-01-30 Thread Antony Dovgal
On 01/29/2011 02:38 PM, Jérôme Loyet wrote: > + if (request_uri) { > + cpystrn(slot->request_uri, request_uri, > sizeof(slot->request_uri)); > + } > + No need to use/have private string funcs for that, we have strlcpy() & strlcat() in PHP. See main/strlcpy.c and main/strlcat.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/zip/php_zip.c branches/PHP_5_3/ext/zip/tests/bug53854.phpt trunk/UPGRADING trunk/ext/zip/php_zip.c trunk/ext/zip/tests/bug53

2011-01-28 Thread Adam Harvey
2011/1/28 Johannes Schlüter : > On Fri, 2011-01-28 at 04:19 +, Adam Harvey wrote: >> >> Modified: php/php-src/trunk/UPGRADING >> === >> --- php/php-src/trunk/UPGRADING 2011-01-28 04:17:08 UTC (rev 307806) >> +++ php/php-src/trunk/U

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/zip/php_zip.c branches/PHP_5_3/ext/zip/tests/bug53854.phpt trunk/UPGRADING trunk/ext/zip/php_zip.c trunk/ext/zip/tests/bug53

2011-01-28 Thread Johannes Schlüter
Hi, On Fri, 2011-01-28 at 04:19 +, Adam Harvey wrote: > > Modified: php/php-src/trunk/UPGRADING > === > --- php/php-src/trunk/UPGRADING 2011-01-28 04:17:08 UTC (rev 307806) > +++ php/php-src/trunk/UPGRADING 2011-01-28 04:19:40 UT

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/readline/readline.c trunk/ext/readline/readline.c

2011-01-10 Thread Christopher Jones
Hi Ilia, What about adding a phpt? Chris On 01/10/2011 10:19 AM, Ilia Alshanetsky wrote: iliaaMon, 10 Jan 2011 18:19:02 + Revision: http://svn.php.net/viewvc?view=revision&revision=307343 Log: Fixed bug #53630 (Fixed parameter handling inside readline

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/mysql/tests/bug53649.phpt branches/PHP_5_3/ext/mysqli/mysqli_nonapi.c branches/PHP_5_3/ext/mysqli/tests/bug53503.phpt branch

2011-01-08 Thread Antony Dovgal
On 01/07/2011 05:22 PM, Andrey Hristov wrote: > A php/php-src/branches/PHP_5_3/ext/mysql/tests/bug53649.phpt Is this test supposed to fail? # cat /local/qa/5_3_non-ZTS/ext/mysql/tests/bug53649.diff 001+ bug 001- done -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Gustavo Lopes
On Tue, 21 Dec 2010 18:52:07 -, Christopher Jones wrote: On 12/21/2010 10:47 AM, Gustavo Lopes wrote: On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the t

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Gustavo Lopes
On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug was bogus. I did. The de

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Christopher Jones
On 12/21/2010 10:47 AM, Gustavo Lopes wrote: On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definitio

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Christopher Jones
Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug was bogus. Chris On 12/21/2010 09:29 AM, Gustavo André dos Santos Lopes wrote: cataphract

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/zip/lib/zip_dirent.c trunk/ext/zip/lib/zip_dirent.c

2010-12-17 Thread Pierre Joye
2010/12/18 Kalle Sommer Nielsen : > Hi > > 2010/12/18 Gustavo André dos Santos Lopes : >> Changed paths: >>    U   php/php-src/branches/PHP_5_3/NEWS >>    U   php/php-src/branches/PHP_5_3/ext/zip/lib/zip_dirent.c >>    U   php/php-src/trunk/ext/zip/lib/zip_dirent.c > > I think that fix should go up

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/zip/lib/zip_dirent.c trunk/ext/zip/lib/zip_dirent.c

2010-12-17 Thread Kalle Sommer Nielsen
Hi 2010/12/18 Gustavo André dos Santos Lopes : > Changed paths: >    U   php/php-src/branches/PHP_5_3/NEWS >    U   php/php-src/branches/PHP_5_3/ext/zip/lib/zip_dirent.c >    U   php/php-src/trunk/ext/zip/lib/zip_dirent.c I think that fix should go upstream instead of have a .patch file like ext/

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/zip/zip_stream.c trunk/ext/zip/zip_stream.c

2010-12-10 Thread Hannes Magnússon
On Wed, Nov 3, 2010 at 22:48, Pierre Joye wrote: > pajoye                                   Wed, 03 Nov 2010 21:48:08 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=305063 > > Log: > - add stat support for zip:// does that mean filesize(zip://archive.zip#foobar) and file_ex

  1   2   >