[Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

Exposes a bug in the i965 driver. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82991 --- tests/shaders/glsl-deriv-varyings.c | 131 +++- 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/tests/shaders/glsl-deriv-varyings.c

[Piglit] [PATCH] glsl-deriv-varyings: Fixes recently introduced compilation warnings

--- tests/shaders/glsl-deriv-varyings.c | 86 - 1 file changed, 86 deletions(-) diff --git a/tests/shaders/glsl-deriv-varyings.c b/tests/shaders/glsl-deriv-varyings.c index fa72eec..33511de 100644 --- a/tests/shaders/glsl-deriv-varyings.c +++

[Piglit] [PATCH] Fix recently introduced GCC warnings in glsl-deriv-varyings

these 2 tests temporarily while I'm working in this new bug. I will re-introduce them once I have a solution for mesa. Andres Gomez (1): glsl-deriv-varyings: Fixes recently introduced compilation warnings tests/shaders/glsl-deriv-varyings.c | 86 - 1 file

Re: [Piglit] [PATCH] Fix recently introduced GCC warnings in glsl-deriv-varyings

On Tue, 2014-12-16 at 20:18 +0100, Andres Gomez wrote: Previous patch at: http://lists.freedesktop.org/archives/piglit/2014-December/013648.html Introduced a couple of GCC warnings in the last 2 newly introduced tests. After correcting the warnings I'm realizing these tests are exposing

[Piglit] [PATCH] glsl-deriv-varyings: Migrated to shader_runner and corrected test expectations on deriv + abs cases

://bugs.freedesktop.org/show_bug.cgi?id=87407 Signed-off-by: Andres Gomez ago...@igalia.com --- tests/all.py | 1 - tests/shaders/CMakeLists.gl.txt| 1 - tests/shaders/glsl-deriv-varyings.c| 375 - tests

Re: [Piglit] [PATCH] glsl-deriv-varyings: Migrated to shader_runner and corrected test expectations on deriv + abs cases

I'd like to land this next week if nobody says otherwise. Br. On Tue, 2015-04-28 at 16:35 +0300, Andres Gomez wrote: Old glsl-deriv-varyings test has been migrated to shader_runner and, also, splitted in four different tests: * glsl-derivs-varyings * glsl-derivs-sign * glsl-derivs-abs

Re: [Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

FFull) { > > ^^^ > > ^^ > > with this check removed, the series corrects all 32 bit failures > > introduced by b7eb469, and is > > > > Tested-by: Mark Janes <mar

[Piglit] [PATCH 1/4] util: Wrapper to load exact hex patterns for ints

For some cases we want to have shaders where we load an exact bit pattern into a signed int. This fixes the errno-based range validation that was broken when the integer vbo attribute parsing on 32-bit systems was recently fixed. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/s

[Piglit] [PATCH 0/4] More additional tests for ARB_vertex_attrib_64bit extension

. With this support, the double vertex inputs generator has been extended to create tests that use byte and short sized types. In addition, the series provide a fix for passing exact hex patterns values for int. Andres Gomez (4): util: Wrapper to load exact hex patterns for ints util/gl

Re: [Piglit] [PATCH 0/4] More additional tests for ARB_vertex_attrib_64bit extension

Forgot to mention that this series is meant to be applied on top of the following series by Dylan Baker: https://lists.freedesktop.org/archives/piglit/2016-June/019949.html Br. On Fri, 2016-06-10 at 00:27 +0300, Andres Gomez wrote: > This series provides some more additional te

[Piglit] [PATCH 3/4] util: Add u/byte, u/short and half support to [vertex data]

generator has been also adapted to the new syntax. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/gen_vs_in_fp64.py | 266 +--- .../gen_vs_in_fp64/columns.shader_test.mako| 20 +- .../gen_vs_in_fp64/regular.shader_test.mako

[Piglit] [PATCH 2/4] util/gl: Wrapper to load hex values for half floats

For some cases we want to have shaders where we load an exact bit pattern into a half float. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/util/piglit-util-gl.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/util/piglit-util-gl.h b/test

Re: [Piglit] [PATCH 0/6] make gen_vs_in_fp64 run faster

Nice optimizations, Dylan. I'm quite impressed/surprised on the gain through avoiding the inheritance/include mechanisms in the mako templates. This series is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Tue, 2016-06-07 at 14:15 -0700, Dylan Baker wrote: > This recently i

Re: [Piglit] [PATCH 1/2] generators/modules: Add GLSL types representations

  contains=contains) I would be passing columns=1 for the same reason than above. In any case, consider this a nit pick. You can ignore freely. Other than that, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/4] util: Add u/byte, u/short and half support to [vertex data]

On Fri, 2016-06-10 at 16:45 -0700, Dylan Baker wrote: [snip] > This is two pretty big changes together in one patch. I'd like the > see > the C changes and the generator changes split into separate patches. Originally, I had the patch split in 2 because of this. In the end, I decided to

Re: [Piglit] [PATCH 2/2] generators/gen_vs_in_fp64: Use modules.types

Other than my comment in the previous patch about (type.columns or 1) and (type.rows or 1), consider this: Reviewed-by: Andres Gomez <ago...@igalia.com> On Fri, 2016-06-10 at 16:42 -0700, Dylan Baker wrote: > This removes a significant amount of string parsing from both the

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: emit GS output for every vertex

On Mon, 2016-06-13 at 19:50 +0200, Samuel Pitoiset wrote: [snip] > Thanks for the reviews. > > I don't have commit access for piglit, could you please push both  > patches for me? > > Feel free to amend this one before pushing. Amended and pushed. -- Br, Andres

Re: [Piglit] [PATCH] util: Fix piglit-vbo.cpp tautological-compare warning.

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Tue, 2016-06-14 at 21:58 +, Vinson Lee wrote: > piglit-vbo.cpp:310:26: warning: comparison of unsigned expression < 0 > is always false [-Wtautological-compare] > if (this->matrix_index < 0 |

Re: [Piglit] [PATCH 0/2] Make gen_vs_in_fp64 even faster

On Fri, 2016-06-10 at 16:42 -0700, Dylan Baker wrote: [snip] > > I've had this plan to add additional helpers for generator writers > for > representing GLSL type information, and this seemed like the right > time > to add them. This looks very good. I'm also repeating some value arrays for

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: fix GS tests generator

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Mon, 2016-06-06 at 23:43 +0200, Samuel Pitoiset wrote: > In order to emit a color for each vertex, we need to move fs_color > inside the loop because EmitVertex() will invalidate all previous > output writes, and there is

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: emit GS output for every vertex

n = vertex_to_gs[i]; >   EmitVertex(); >   } I'd rather have just the "if" parts that modify fs_color in the "for" loop and not the whole code. In any case, this is a minor thing so feel free to ignore. Other than that, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/5] util: Wrapper to load exact hex patterns for ints

For some cases we want to have shaders where we load an exact bit pattern into a signed int. This fixes the errno-based range validation that was broken when the integer vbo attribute parsing on 32-bit systems was recently fixed. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/s

[Piglit] [PATCH 4/5] generators/gen_vs_in_fp64: Adds support to specify the GL type in the VBO

Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/gen_vs_in_fp64.py | 266 + .../gen_vs_in_fp64/regular.shader_test.mako| 21 +- 2 files changed, 222 insertions(+), 65 deletions(-) diff --git a/generated_tests/gen_vs_in_fp64

[Piglit] [PATCH 2/5] util/gl: Wrapper to load hex values for half floats

For some cases we want to have shaders where we load an exact bit pattern into a half float. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/util/piglit-util-gl.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/util/piglit-util-gl.h b/test

[Piglit] [PATCH 0/5] More additional tests for ARB_vertex_attrib_64bit extension (v2)

provide a fix for passing exact hex patterns values for int. Andres Gomez (5): util: Wrapper to load exact hex patterns for ints util/gl: Wrapper to load hex values for half floats util: Add u/byte, u/short and half support to [vertex data] generators/gen_vs_in_fp64: Adds support to specify

[Piglit] [PATCH 3/5] util: Add u/byte, u/short and half support to [vertex data]

has been also adapted to the new syntax. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../gen_vs_in_fp64/columns.shader_test.mako| 4 +- .../gen_vs_in_fp64/regular.shader_test.mako| 16 +- tests/util/piglit-dispatch.h | 1 + tests/util/

[Piglit] [PATCH 5/5] generators/gen_vs_in_fp64: Adds u/byte and u/short tests

Added more test cases combinations by including u/byte and u/short GL types in the VBO so the stride is smaller than a word. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/gen_vs_in_fp64.py | 31 +++ 1 file changed, 31 insertions(+) diff

Re: [Piglit] [PATCH 0/5] More additional tests for ARB_vertex_attrib_64bit extension (v2)

at 00:36 +0300, Andres Gomez wrote: > The main difference in this second version is that the original patch > 3/4 has been split in 2. The reason to have it together in the first > version was to avoid a regression due to failures when running the > patches when only the piglit-vbo c

[Piglit] [PATCH 0/2] Explicit conversion from double to float

, this is enforced. Hence, some existent tests had to be corrected and, in addition, the implicit-conversion-bad.vert test has been fixed and split to allow tracking specific failures per type. Andres Gomez (2): generators: Typo correction arb_gpu_shader_fp64: Explicit conversion from double

[Piglit] [PATCH 2/2] arb_gpu_shader_fp64: Explicit conversion from double to float

Double and float derived types also need explicit conversions. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../gen_constant_array_size_tests_fp64.py | 2 +- .../compiler/double-loop-iterator.vert | 4 +-- .../compiler/implicit-conversion-bad.vert

[Piglit] [PATCH 1/2] generators: Typo correction

Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/gen_constant_array_size_tests.py | 2 +- generated_tests/gen_constant_array_size_tests_fp64.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_constant_array_size_tests

[Piglit] [PATCH] gen_constant_array_size_tests_fp64.py: Added missing abstract method

Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/gen_constant_array_size_tests_fp64.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/generated_tests/gen_constant_array_size_tests_fp64.py b/generated_tests/gen_constant_array_size_tests_fp64.py index 72407c6..3

[Piglit] [PATCH 3/8] arb_gpu_shader_fp64: test glGetUniformdv interface

From: "Juan A. Suarez Romero" <jasua...@igalia.com> Tests this function when reading uniforms from vertex/fragment/geometry shaders. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/all.py | 4 +- .../execu

[Piglit] [PATCH 7/8] arb_gpu_shader_fp64: add tests for UBOs

From: "Juan A. Suarez Romero" <jasua...@igalia.com> Add several tests for double-precision usage inside UBOs. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../uniform_buffers/fs-array-copy.shader_test | 40 +++ .../uniform_buffers/fs-dmat4-row-

[Piglit] [PATCH 4/8] arb_gpu_shader_fp64: gl_FragColor is deprecated in glsl >= 1.30

From: "Juan A. Suarez Romero" <jasua...@igalia.com> An explicit output vec4 in the FS must be defined. Contributed by Andres Gomez. Signed-off-by: Juan A. Suarez Romero <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../execution/f

[Piglit] [PATCH 2/8] arb_gpu_shader_fp64: Adds uniform buffers VS tests

. * Test for uniform dmat4. * Tests for uniform of array of doubles. * Test to copy uniform dvec4 array. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../uniform_buffers/vs-array-copy.shader_test | 51 .../uniform_buffers/vs-dmat4-row-major.shader_tes

[Piglit] [PATCH 6/8] arb_gpu_shader_fp64: use generator to test in/out attributes

int vectors, signed or unsigned integers or integer vectors, or arrays of these. ..." Contributed by Andres Gomez. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/CMakeLists.txt | 8 + generated_tests/gen_inout_fp64.py

[Piglit] [PATCH 5/8] arb_gpu_shader_fp64: add tests for SSBO

single-precision values, and both in std430 and std140 layouts. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/all.py | 8 + tests/spec/arb_gpu_shader_fp64/CMakeLists.txt | 1 + .../shader_storage/CMakeLists.gl.txt | 15

[Piglit] [PATCH 8/8] arb_gpu_shader_fp64: add more tests for this spec

From: "Juan A. Suarez Romero" <jasua...@igalia.com> Miscellaneus set of tests that checks different aspects of GL_ARB_gpu_shader_fp64 spec. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/all.py | 1 + .../execu

[Piglit] [PATCH 1/8] arb_gpu_shader_fp64: Adds GS preprocessor define test

Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../spec/arb_gpu_shader_fp64/preprocessor/define.geom | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom diff --git a/tests/spec/arb_gpu_shade

[Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

s/mesa-dev/2016-March/110038.html Cheers, Andres (on behalf of the team that worked on this). -- Andres Gomez (2): arb_gpu_shader_fp64: Adds GS preprocessor define test arb_gpu_shader_fp64: Adds uniform buffers VS tests Juan A. Suarez Romero (6): arb_gpu_shader_fp64: test glGetUniformdv

Re: [Piglit] [PATCH 2/8] framework: sort imports in piglit-print-commands.py

Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2016-03-30 at 11:18 -0700, Dylan Baker wrote: > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > --- >  piglit-print-commands.py | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Piglit] [PATCH 5/8] framework: cleanup a bunch of style problems in piglit-print-commands

Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2016-03-30 at 11:18 -0700, Dylan Baker wrote: > Add docstrings, and stuff like that. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > --- >  piglit-print-commands.py | 4 +++- >  1 file change

Re: [Piglit] [PATCH 3/8] framework: simplify imports in piglit-print-commands.py

Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2016-03-30 at 11:18 -0700, Dylan Baker wrote: > --- >  piglit-print-commands.py | 9 - >  1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/piglit-print-commands.py b/piglit-print-commands.py >

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

Dave, continuing with your request at: https://lists.freedesktop.org/archives/piglit/2016-April/019350.html Tested with the needed patch at mesa-dev landed: https://lists.freedesktop.org/archives/mesa-dev/2016-April/111842.html Tested with llvmpipe FAIL: None. SKIP: * All

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

On Wed, 2016-04-06 at 08:03 +1000, Dave Airlie wrote: > On 5 April 2016 at 18:09, Andres Gomez <ago...@igalia.com> wrote: > > > > Hi, > > > > this series is, for the most of it, still unreviewed. > > > > We'd welcome some help to get this into piglit

Re: [Piglit] [PATCH 6/8] arb_gpu_shader_fp64: use generator to test in/out attributes

On Tue, 2016-03-15 at 09:38 -0700, Dylan Baker wrote: > Quoting Andres Gomez (2016-03-15 08:50:47) > > From: "Juan A. Suarez Romero" <jasua...@igalia.com> > > > > Vertex shader inputs and fragment shader outputs can only be > > single-precision values

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

Hi, this series is, for the most of it, still unreviewed. We'd welcome some help to get this into piglit with guarantees that the tests added are OK :) Br. On Tue, 2016-03-15 at 17:50 +0200, Andres Gomez wrote: > This series provides additional tests for the ARB_gpu_shader_fp64 > ext

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

. On Mon, 2016-04-04 at 20:00 +0300, Andres Gomez wrote: > Generator for error checking on "flat" keyword. > > This generator adds, additionally, checks for variables inside > structs > and interface blocks, which weren't explicitly mentioned in the GLSL > specs and, par

[Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

esktop.org/archives/mesa-dev/2016-March/109117.html and Khronos bug #15671. Also, removed 8 redundant tests replaced by the generator. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/CMakeLists.txt | 7 + .../gen_flat_interpolation_qualifier.py

[Piglit] [PATCH] arb_gpu_shader_fp64: Adds conversion tests generator

Also, removed 5 redundant tests replaced by the generator. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/CMakeLists.txt | 24 + generated_tests/gen_conversion_fp64.py | 604 + .../templates/gen_conversion_fp64/bas

[Piglit] [PATCH] Additional conversion tests for the ARB_gpu_shader_fp64 extension

://bugs.freedesktop.org/show_bug.cgi?id=92760 Br. Andres Gomez (1): arb_gpu_shader_fp64: Adds conversion tests generator generated_tests/CMakeLists.txt | 24 + generated_tests/gen_conversion_fp64.py | 604 + .../templates/gen_conversion_fp64/base.mako

[Piglit] [PATCH] util: Wrappers to load hex values for floats

For some cases we want to have shaders where we load an exact bit pattern into a float or double. We already have this in place for uniforms. Now, the methods have been refactorized so they can be used in VBOs too. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/shaders/shader_ru

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

On Tue, 2016-04-19 at 07:12 +1000, Dave Airlie wrote: > On 18 April 2016 at 23:01, Andres Gomez <ago...@igalia.com> wrote: > > > > Hi Dave, > > > > can I, then, assume a "ack-b" from you for the all the patches but > > the > > 3/8 and 5/8

[Piglit] [PATCH] util: Add array_index support to [vertex data]

line is the GLSL corresponding one, not just "float", "double", "int" or "uint". In any case, the extended syntax is backward compatible so it is still possible to specify a vec3 attribute like: attname/float/3 In addition to the now recommended format: att

[Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements

Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/shaders/shader_runner.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 239735c..2f6bec8 100644 --- a/tests/shaders/shader_ru

[Piglit] [PATCH] shader_runner: Same method to get u/int based type uniforms

u/ivec* was already support to read hexadecimals. Now, this is also supported for u/int uniforms. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/shaders/shader_runner.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/shaders/shader_runner.c b

Re: [Piglit] [PATCH 6/8] arb_gpu_shader_fp64: use generator to test in/out attributes

Dylan, do you think we can get an R-b or Ack-b from you for this second version of the patch? Thanks! On Wed, 2016-03-16 at 17:39 +0200, Andres Gomez wrote: > From: "Juan A. Suarez Romero" <jasua...@igalia.com> > > Vertex shader inputs and fragment shader outputs can o

Re: [Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements

On Tue, 2016-04-26 at 11:00 +0200, Marek Olšák wrote: > On Mon, Apr 25, 2016 at 4:03 PM, Andres Gomez <ago...@igalia.com> > wrote: > > > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > >  tests/shaders/shader_runner.c | 17

[Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements (v2)

v2: Just use the same query for GL or GLS 2.0 and 3.0 as noted by Marek Olšák. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/shaders/shader_runner.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_ru

Re: [Piglit] [PATCH] Additional conversion tests for the ARB_gpu_shader_fp64 extension

will assume that all is OK and will proceed to land them. On Thu, 2016-04-14 at 12:48 +0300, Andres Gomez wrote: > Dave, continuing with your request at: > https://lists.freedesktop.org/archives/piglit/2016-April/019350.html > > Tested with llvmpipe > >

[Piglit] [PATCH 1/4] arb_vertex_attrib_64bit: Adds double vertex input tests generator (v2)

array members or columns in the same matrix (Alejandro). Also, removed one redundant test. Acked-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/CMakeLists.txt | 9 + generated_tests/gen_v

Re: [Piglit] [PATCH 1/4] arb_vertex_attrib_64bit: Adds double vertex input tests generator (v2)

On Fri, 2016-05-20 at 10:00 +0200, Alejandro Piñeiro wrote: > On 20/05/16 01:25, Andres Gomez wrote: > Really nitpicky nitpick: when v2 patches are sent to the list, "v2" > is > included on the prefix on blocks. So "[PATCH 1/4 v2]", not a "(v2)" > su

[Piglit] [PATCH 4/4] arb_vertex_attrib_64bit: add overlapping locations test

From: Antia Puentes <apuen...@igalia.com> Verifies that aliasing can be used successfully for vertex attributes with 64-bit floating-point components, being aliasing the act to bind more than one attribute name to the same location. Contributed by Andres Gomez. --- tests/

[Piglit] [PATCH 0/4] Additional tests for ARB_vertex_attrib_64bit extension

/show_bug.cgi?id=94442 Cheers, Andres (on behalf of the team that worked on this). Alejandro Piñeiro (2): arb_vertex_attrib_64bit: add getactiveattrib test arb_vertex_attrib_64bit: add MAX_VERTEX_ATTRIB test Andres Gomez (1): arb_vertex_attrib_64bit: Adds double vertex input tests generator

[Piglit] [PATCH 2/4] arb_vertex_attrib_64bit: add getactiveattrib test

btests for the new functionality defined on a specification is really common. Contributed by Andres Gomez. --- tests/all.py | 1 + .../execution/CMakeLists.gl.txt| 1 + .../execution/getactiveattrib.c| 345 ++

[Piglit] [PATCH 3/4] arb_vertex_attrib_64bit: add MAX_VERTEX_ATTRIB test

olated subtests for the new functionality defined on a specification is really common. Contributed by Andres Gomez. --- tests/all.py | 1 + .../execution/CMakeLists.gl.txt| 1 + .../execution/max-vertex-attrib.c

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: Add tests to check non-uniform-control-flow writes

On Thu, 2016-05-12 at 09:31 +0200, Samuel Iglesias Gonsálvez wrote: > They are use to detect if a bug in i965 driver related to > operations working with doubles under non-uniform control flow > is still happening. > > Signed-off-by: Samuel Iglesias Gonsálvez > --- >  

[Piglit] [PATCH 1/2] util: Add array_index support to [vertex data] (v2)

/vec3/3 v2: Added more verbose comments and documentation as requested by Alejandro Piñeiro. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/util/piglit-vbo.cpp | 167 -- 1 file changed, 133 insertions(+), 34 deletions(-) diff

Re: [Piglit] [PATCH] builtin_function*py: more test data for "trunc"

On Tue, 2016-05-03 at 12:39 -0700, Eric Anholt wrote: > Andres Gomez <ago...@igalia.com> writes: > > > > > When performing a trunc op in a float value there is, basically, > > three > > scenarios: when the exponent is < 0, when it is > bitsize of the >

[Piglit] [PATCH 1/2] builtin_function*py: Corrected single to double conversions

is no need for additional conversions. For the double precision module, we don't really need to do any conversion since the calculations are already done in double precision. Additionally, we removed custom functions that are not used any more. Signed-off-by: Andres Gomez <ago.

[Piglit] [PATCH 2/2] builtin_function*py: more test data for "trunc"

A trunc op in a float value may be implemented through a roundtrip cast to a int based type. We add now some additional values beyond each bitsize edge to check also these cases. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/builtin_function.py

[Piglit] [PATCH] builtin_function*py: more test data for "trunc"

a couple of values in that range and also the interesting 0.0 special value. Signed-off-by: Andres Gomez <ago...@igalia.com> --- generated_tests/builtin_function.py | 8 +++- generated_tests/builtin_function_fp64.py | 8 +++- 2 files changed, 14 insertions(+), 2 deletions

Re: [Piglit] [PATCH] util: Add array_index support to [vertex data]

On Mon, 2016-05-02 at 11:07 +0200, Alejandro Piñeiro wrote: > On 25/04/16 15:56, Andres Gomez wrote: [snip] > > In addition to the now recommended format: > > attname/vec3/3 > Nitpick: Are you sure that is the recommended instead of just the > extended one?

[Piglit] [PATCH] dir-locals.el: Added emacs setup based (v2)

Based on current conventions at .editorconfig v2: Changed automatic deletion of trailing white spaces in python files upon saving for just highlighting them in any format, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 11

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

Hi Dave, can I asume an "ack-by" from you for this patch, then? On Wed, 2016-04-06 at 15:39 +0300, Andres Gomez wrote: > Dave, continuing with your request at: > https://lists.freedesktop.org/archives/piglit/2016-April/019350.html > > Tested with the needed patch at me

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

Hi, this patch is still unreviewed. We'd welcome some help to get this into piglit with guarantees that the tests added are OK :) Br. On Mon, 2016-04-04 at 20:05 +0300, Andres Gomez wrote: > This patch provides additional tests for the patch under review at: > https://lists.freedeskt

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

Hi Dave, can I, then, assume a "ack-b" from you for the all the patches but the 3/8 and 5/8? Br. On Wed, 2016-04-06 at 15:12 +0300, Andres Gomez wrote: > On Wed, 2016-04-06 at 08:03 +1000, Dave Airlie wrote: > > > > On 5 April 2016 at 18:09, Andres Gomez

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

Hi, we are still in need of reviews for this series. If we don't manage to get explicit reviews by the end of this week we will assume that all is OK and will proceed to land them. Br. On Tue, 2016-04-05 at 11:09 +0300, Andres Gomez wrote: > Hi, > > this series is, for the most of

Re: [Piglit] [PATCH] dir-locals.el: Added emacs setup based

Hi, anyone with some emacs-fu can review this? Thanks! :) On Thu, 2016-04-14 at 00:51 +0300, Andres Gomez wrote: > Based on current conventions at .editorconfig > > Signed-off-by: Andres Gomez <ago...@igalia.com> > --- >  .dir-locals.el | 12 >  1 fil

Re: [Piglit] [PATCH] dir-locals.el: Added emacs setup based

On Mon, 2016-04-18 at 09:22 -0400, Ilia Mirkin wrote: > On Apr 13, 2016 5:52 PM, "Andres Gomez" <ago...@igalia.com> wrote: > > + (python-mode . > > + ((indent-tabs-mode . nil) > > +  (tab-width . 4) > > +  (eval

Re: [Piglit] [PATCH] Additional conversion tests for the ARB_gpu_shader_fp64 extension

Dave, continuing with your request at: https://lists.freedesktop.org/archives/piglit/2016-April/019350.html Tested with llvmpipe FAIL: * All the tests for conversions from a double derived type to a float derived type. In addition conversions from dvec3 and dvec4 to

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: Adds conversion tests generator

On Thu, 2016-04-14 at 11:20 -0700, Dylan Baker wrote: ... > diff --git a/generated_tests/gen_conversion_fp64.py > > b/generated_tests/gen_conversion_fp64.py > > new file mode 100644 > > index 000..5fe0bf2 > > --- /dev/null > > +++ b/generated_tests/gen_conversion_fp64.py > > @@ -0,0 +1,604 @@

Re: [Piglit] [PATCH] dir-locals.el: Added emacs setup based (v2)

On Mon, 2016-04-18 at 12:47 -0400, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> > > Seems fine to me. I assume you tested this :) Thanks! Yes. At least, for me it is working as expected :) > > On Mon, Apr 18, 2016 at 12:37 PM, Andres Gomez <ag

[Piglit] [PATCH] dir-locals.el: Added emacs setup based

Based on current conventions at .editorconfig Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 12 1 file changed, 12 insertions(+) create mode 100644 .dir-locals.el diff --git a/.dir-locals.el b/.dir-locals.el new file mode 100644 index 000..d

Re: [Piglit] [PATCH 0/4] Additional tests for ARB_vertex_attrib_64bit extension

ries. On Wed, 2016-05-18 at 02:31 +0300, Andres Gomez wrote: > This series provides additional tests for the ARB_vertex_attrib_64bit > extension: > > https://www.opengl.org/registry/specs/ARB/vertex_attrib_64bit.txt > > This work is complemented with the corresponding b

[Piglit] [PATCH] dir-locals.el: whitespace support

Highlight bogus indentation and long lines. v2: python-mode inherits from prog-mode Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 3bdca17..5

Re: [Piglit] [PATCH 1/2] glslparsertest: Added some few more struct construction tests

On Tue, 2016-08-09 at 13:14 +1000, Timothy Arceri wrote: > On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote: > > This set focus on checking invalid structs construction. > > Specifically, > > adds a test to check that only implicit conversions are perform and &

Re: [Piglit] [PATCH 2/2] arb_shading_language_420pack: Added some few more struct initializing tests

On Tue, 2016-08-09 at 13:18 +1000, Timothy Arceri wrote: > On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote: > > This set focus on checking invalid structs > > initializations. Specifically, adds a test to check that only > > implicit > > conversions are per

Re: [Piglit] [PATCH] generators/gen_vs_in_fp64: Different VBO values per vertex

at 14:40 +0300, Andres Gomez wrote: > Before, in every drawing we were having the same VBO values per vertex > to be compared against the values in the uniforms. Now, we also have > different values per vertex so we can be sure that it is truly its own > data. > > Signed-off-by:

[Piglit] [PATCH] generators/gen_vs_in_fp64: Different VBO values per vertex

Before, in every drawing we were having the same VBO values per vertex to be compared against the values in the uniforms. Now, we also have different values per vertex so we can be sure that it is truly its own data. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .../gen_vs_i

[Piglit] [PATCH] dir-locals.el: whitespace support

Highlight bogus indentation and long lines. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 3bdca17..56fc226 100644 --- a/.dir-locals.el +++

Re: [Piglit] [PATCH] arb_texture_barrier: count of elements need to be multiple of three

Makes sense. Reviewed-by: Andres Gomez <ago...@igalia.com> On Fri, 2016-07-08 at 21:15 +0200, Alejandro Piñeiro wrote: > glDrawRangeElements is used to draw triangles so the count of elements > needs to be a multiple of three, so we need to be careful when > dividing by the numbe

Re: [Piglit] [PATCH] arb_texture_barrier: add an arb_texture_barrier test

t; +if (argc != 6) { > +print_usage(); > +piglit_report_result(PIGLIT_FAIL); > +} > + > +width = height = atoi(argv[1]); > +if (width < 1 || width > 1024) { > +fprintf(stderr, "Wro

Re: [Piglit] [PATCH 3/5] util: Add u/byte, u/short and half support to [vertex data]

On Wed, 2016-06-29 at 14:33 -0700, Dylan Baker wrote: > I swear I sent your review comments this morning, but they don't seem > to > have made it to the list I received it, though. > > [snip] > > >    return (glsl_version, glsl_version_int) > > + > > +  def _glsl_to_gl(glsl_type): > > +

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: emit GS output for every vertex

On Fri, 2016-07-01 at 00:28 +0200, Samuel Pitoiset wrote: [snip] > Andres, maybe you can push this one? Sorry, I thought I had already do it. Thanks for the heads up! -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH 3/5] util: Add u/byte, u/short and half support to [vertex data]

On Wed, 2016-06-29 at 16:29 +0200, Alejandro Piñeiro wrote: > On 14/06/16 23:36, Andres Gomez wrote: [snip] > > diff --git a/tests/util/piglit-vbo.cpp b/tests/util/piglit-vbo.cpp > > index 274779f..6744b1e 100644 > > --- a/tests/util/piglit-vbo.cpp > > +++ b/tests

Re: [Piglit] [PATCH 4/5] generators/gen_vs_in_fp64: Adds support to specify the GL type in the VBO

On Thu, 2016-06-30 at 11:22 -0700, Dylan Baker wrote: > Quoting Andres Gomez (2016-06-30 02:30:31) [snip] > > I think you are quite right on this. > > > > In any case, this patch is not adding more tests than the ones that > > are > > already there before it.

Re: [Piglit] [PATCH 1/5] util: Wrapper to load exact hex patterns for ints

On Fri, 2016-07-01 at 16:02 +0100, Emil Velikov wrote: > On 30 June 2016 at 10:19, Andres Gomez <ago...@igalia.com> wrote: > > On Wed, 2016-06-29 at 17:46 +0100, Emil Velikov wrote: > > > On 14 June 2016 at 22:36, Andres Gomez <ago...@igalia.com> wrote: > >

[Piglit] [PATCH 2/2] arb_shader_atomic_counters: check different binding points

must be equal for a uniform variable of the same name." Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Francisco Jerez <curroje...@riseup.net> Cc: Kenneth Graunke <kenn...@whitecape.org> --- .../different-bindings-atomic-counter.shader_test | 50 ++

  1   2   >