Anuj,
Your genmipmap-errors test checks if glGenerateMipmaps raises
GL_INVALID_OPERATION for integer and depth/stencil texture formats.
Can you tell me which version of the GL spec or extension describes this?
genmipmap-errors fails with NVIDIA's OpenGL 4.2 since it does not raise
any error
The valid_formats[] list includes formats supported either by
GL 3.0 or GL_EXT_texture_float and GL_EXT_texture_rg.
---
tests/spec/arb_internalformat_query/minmax.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/spec/arb_internalformat_query/minmax.c
b/tests/spec/arb_internalf
We obviously should require this extension.
---
tests/spec/ext_texture_array/compressed.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/spec/ext_texture_array/compressed.c
b/tests/spec/ext_texture_array/compressed.c
index c964fd7..7f87b62 100644
--- a/tests/spec/ext_texture_array/c
This fixes some misleading fs-op-div-* failures when the driver does
integer arithmetic with floating point. When we compute the reciprocal
of some integers we wind up with inexact floating point results. So
expressions like X/X result in 0. or such.
This patch tweaks the generator code to u
silences "tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not
a string literal and no format arguments [-Wformat-security]"
---
A number of tests are generating this warning. If there's no objection,
I'll clean up the other tests too.
---
tests/fbo/fbo-alphatest-formats.c |6 +++---
silences a bunch of warnings such as:
"tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not
a string literal and no format arguments [-Wformat-security]"
---
tests/fbo/fbo-alphatest-formats.c|6 +++---
tests/fbo/fbo-blending-formats.c |
---
tests/glean/tshaderapi.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/glean/tshaderapi.cpp b/tests/glean/tshaderapi.cpp
index 5111c30..fcd6547 100644
--- a/tests/glean/tshaderapi.cpp
+++ b/tests/glean/tshaderapi.cpp
@@ -440,6 +440,7 @@ ShaderAPITest::test_uniform_neg_location
---
tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c
b/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c
index 88a2bfa..71fc249 1006
---
tests/fbo/fbo-gl_pointcoord.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/fbo/fbo-gl_pointcoord.c b/tests/fbo/fbo-gl_pointcoord.c
index b2a1ccf..e5392d1 100644
--- a/tests/fbo/fbo-gl_pointcoord.c
+++ b/tests/fbo/fbo-gl_pointcoord.c
@@ -42,14 +42,16
---
tests/texturing/max-texture-size.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/texturing/max-texture-size.c
b/tests/texturing/max-texture-size.c
index cb0c399..7b6b3fc 100644
--- a/tests/texturing/max-texture-size.c
+++ b/tests/texturing/max-texture-size.c
@
Test error checking for width != height and depth % 6 != 0 for cube arrays.
---
tests/spec/arb_texture_storage/texture-storage.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/tests/spec/arb_texture_storage/texture-storage.c
b/tests/spec/arb_texture_storage/texture-
On 10/15/2013 05:49 AM, Topi Pohjolainen wrote:
Signed-off-by: Topi Pohjolainen
---
tests/shaders/shader_runner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index ba76cd0..5731985 100644
--- a/tests/shaders
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view and validity of input parameters.
Use both valid and invalid parameters, although mostly invalid
parameters are tested since other tests will use valid parameters.
Only the parameters "texture", "origtexture", "minlevel", "nu
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
When calling glTextureView() only certain formats are valid based on the format
of the original texture. This tests valid/invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
te
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
The new target supplied with textureView must be compatible with the
original textures target. This tests valid and invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
tests/s
On 10/17/2013 12:42 PM, Ian Romanick wrote:
On 10/17/2013 07:29 AM, Brian Paul wrote:
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
+/* skip compressed internal formats for now including extensions */
+assert(format_class == GL_VIEW_CLASS_128_BITS ||
+ format_class
On 10/17/2013 12:14 PM, Carl Worth wrote:
It is legal to gen and delete a new object while another object is active.
It is also legal to delete the currently active object.
Ensure that both of these operations can be performed without any error.
---
tests/all.tests
On 10/18/2013 05:06 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view and validity of input parameters.
Use both valid and invalid parameters, although mostly invalid
parameters are tested since other tests will use valid parameters.
Only the parameters "texture", "origtexture", "minlevel", "nu
The same formatting nitpicks from patch 1 apply to this patch and #3.
More below.
On 10/18/2013 05:06 PM, Jon Ashburn wrote:
When calling glTextureView() only certain formats are valid based on the format
of the original texture. This tests valid/invalid combinations.
Tested on Nvidia Quadro 6
On 10/17/2013 12:14 PM, Carl Worth wrote:
It is legal to gen and delete a new object while another object is active.
s/object/query/ ??
It is also legal to delete the currently active object.
Ensure that both of these operations can be performed without any error.
---
tests/all.tests
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests texture views with data format changes. 1D textures only.
Uses multiple simultaneous views with different lifetimes and
check results via glGetTexImage().
Tested on Nvidia Quadro 600, all subtests pass.
---
tests/all.tests
Another quick review. Minor things below.
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various layers and levels.
Creates texture maps with different solid colors for each level or layer,
reads the framebuffer to ensure the rendered color is correct.
In the subject, space after colon.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
texture_view");
+ piglit_require_extension("GL_EXT_texture_integer");
+ piglit_require_extension("GL_ARB_texture_float");
+ piglit_require_extension("GL_EXT_texture_array");
+
+ X(invalid_texture_param(), "Invalid texture or origtexture");
+ X(invalid_layer_param(GL_TEXTURE_1D_ARRAY), "Invalid layer param 1D");
+ X(invalid_layer_param(GL_TEXTURE_2D_ARRAY), "Invalid layer param 2D");
+ X(invalid_level_param(), "Invalid level param");
+ X(levels_clamping(), "Minlevel range and numlevel clamp");
+ X(layers_clamping(), "Minlayer range and numlayer clamp");
+
+ pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
With those changes,
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
I didn't really study this test, but some things jumped out...
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various texture targets.
Creates texture maps with different solid colors for each level or layer
reads the framebuffer to ensure the rendered color
_arrays(GLenum *valid, GLenum *invalid,
+unsigned int numInvalid, ... )
unsigned int
update_valid_arrays(GLenum *valid, GLenum *invalid,
unsigned int numInvalid, ... )
Same thing in header file.
OK otherwise.
Reviewed-by: Brian Paul
___
On 10/25/2013 10:41 AM, Jon Ashburn wrote:
RE your comment:
+config.window_width = 128;
+config.window_height = 128;
"Is 128 special? Can you just go with the defaults? In the past we've
had trouble on Windows when the width is < 130 or so pixels. Long story. "
128 isn't special
query does generate
an error).
Reviewed-by: Brian Paul
Tested-by: Brian Paul
NVIDIA's 325.15 driver fails on the error check on line 96, but that
looks like their bug.
Thanks for making all the changes, Carl.
-Brian
___
Piglit mailing list
P
On 10/28/2013 05:53 PM, Zack Rusin wrote:
Increase the subpixel precision to 8 bits. This requires
changing some of the code to 64 bits to avoid overflows.
Signed-off-by: Zack Rusin
---
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit
On 10/28/2013 12:16 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various texture targets.
Creates texture maps with different solid colors for each level or layer
reads the framebuffer to ensure the rendered color is correct.
Tested on Nvidia Quadro 600, all subtests pass.
S
On 10/28/2013 12:16 PM, Jon Ashburn wrote:
Tests texture views with data format changes. 1D textures only.
Uses multiple simultaneous views with different lifetimes and
check results via glGetTexImage().
Tested on Nvidia Quadro 600, all subtests pass.
Signed-off-by: Jon Ashburn
---
tests/al
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ program = piglit_build_simple_program_multiple_shaders(
+ GL_VERTEX_SHADER, vsSource,
+ GL_GEOMETRY_SHADER, gsSource,
+ GL_FRAGMENT_SHADER, fsSource,
+ 0);
+ glUseProgram(program);
+ colorLoc = glGetUniformLocation(program, "color");
+ vpIndexLoc = glGetUniformLocation(program, "idx");
+}
With above fixes: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
\
+ } while (0)
Insert a couple blank lines here.
+void
+piglit_init(int argc, char **argv)
+{
+ bool pass= true;
+ GLint maxVP;
+
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ glGetIntegerv(GL_MAX_VIEWPORTS, &maxVP);
+
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array regarding the validity for the indices.
Use both valid and invalid parameters (index, first, count) for these new
API entry points:
glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v.
Also test that w
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor rectangle for viewport
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tested GLenums are GL_MAX_VIEWPORT_DIMS, GL_MAX_VIEWPORTS,
GL_VIEWPORT_SUBPIXEL_BITS, GL_VIEWPORT_BOUNDS_RANGE, GL_LAYER_PROVOKING_VERTEX,
GL_VIEWPORT_INDEX_PROVOKING_VERTEX.
Tested on Nvidia Quadro 600, test passes.
---
tests/all.tests
+
+void
+piglit_init(int argc, char **argv)
+{
+ GLuint program;
+
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ program = piglit_build_simple_program_multiple_shaders(
+ GL_VERTEX_SHADER, vsSource,
+
printf("mismatched valf and vali for %s\n",
+ piglit_get_gl_enum_name(indexedTokens[i]));
+ printf("valf[0-3]= %f %f %f %f\n", valf[0], valf[1],
+
+ reportError("Error generated when DeleteQueries called "
+ "in the progress of another.");
pass = false;
}
}
Reviewed-by: Brian Paul
__
Exercises an NVIDIA driver bug.
---
tests/all.tests |1 +
tests/texturing/CMakeLists.gl.txt |1 +
tests/texturing/cubemap-getteximage-pbo.c | 157 +
3 files changed, 159 insertions(+)
create mode 100644 tests/texturing/cubemap
Exercises an NVIDIA driver bug related to glGetTexImage and sRGB
texture views.
---
tests/all.tests|1 +
tests/spec/arb_texture_view/CMakeLists.gl.txt |1 +
tests/spec/arb_texture_view/getteximage-srgb.c | 119
3 files changed, 121
I've tried to describe Piglit's coding style and conventions in more
detail. Hopefully, new contributors will read this and it'll save
some some time and effort for the reviewers.
Please feel free to add/update this info.
---
HACKING | 57 ---
On 11/02/2013 09:02 PM, Dylan Baker wrote:
Could you add a note about python code?
Just something like: "All python code should conform to python's PEP8
standard, using only spaces and no tabs" would be great.
Go for it!
-Brian
___
Piglit mailing
This passes w/ Mesa but crashes NVIDIA's driver.
---
.../declarations/bad-variable-redeclaration.frag | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl-1.10/compiler/declarations/bad-variable-redeclaration.frag
diff --git
a/tests/spec/glsl-1.10/
Before, the test always drew green rects for all the target buffers.
Now we draw a different color into each buffer to be more thorough.
Plus, replace 16 with MAX_TARGETS, add some comments, etc.
Note: the test now fails with Mesa's swrast because swrast errantly
writes the same color to all rend
Just some formatting issues on this one and the same for patch 3/4.
On 11/01/2013 04:51 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array validity for indices. Use both valid and
invalid parameters (index, first, count) for all these new API entry points:
glDepthRangeArrayv, glDepthRangeInde
th, height).
Tested with Nvidia Quadro 600. All tests pass except Scissor Box with a
negative height fails to return a gl error.
Reviewed-by: Brian Paul
Signed-off-by: Jon Ashburn
---
tests/all.tests | 1 +
tests/spec/arb_viewport_array/CMakeLists.gl.txt | 1
Typos below.
On 11/04/2013 08:15 AM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor rectangl
On 11/08/2013 01:40 PM, Jon Ashburn wrote:
The "targets" test is extended to include testing of
GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY.
This will test making valid and invalid texture views of these two
multisample targets and ensuring the correct GL error is set.
---
te
extension("GL_ARB_draw_elements_base_vertex");
> }
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ror is set.
Reviewed-by: Brian Paul
Signed-off-by: Jon Ashburn
---
tests/spec/arb_texture_view/targets.c | 53 +++
1 file changed, 41 insertions(+), 12 deletions(-)
diff --git a/tests/spec/arb_texture_view/targets.c
b/tests/spec/arb_texture_view/targets.c
index 2c2e5c
ter discussed in real time, many piglit
+developers can also be found in the #dri-devel channel on Freenode
+IRC.
Thanks, Paul! Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
If we build waffle w/out ES support and we run all.tests, quick.tests,
etc. we get lots of 'fail' results for the ES tests. This change causes
those tests to be reported as 'skip' instead.
---
tests/util/piglit-util-waffle.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
On 11/18/2013 04:02 PM, Dylan Baker wrote:
On Monday, November 18, 2013 03:33:34 PM Marek Olšák wrote:
From: Marek Olšák
The usefulness of this is questionable to say the least.
---
framework/core.py | 72
--- framework/exectest.py |
2 --
Since the test is in the spec/gl-3.0/ directory, we should probably
require GL 3.0 or later.
The check for GL_ARB_texture_float for GL_DEPTH32F_STENCIL8 was
incorrect. The format is part of GL 3.0, not GL_ARB_texture_float.
---
tests/spec/gl-3.0/api/genmipmap-errors.c |4 ++--
1 file changed
**argv)
if (piglit_get_gl_version() < 32) {
piglit_require_extension("GL_ARB_draw_elements_base_vertex");
+ piglit_require_GLSL_version(130);
}
/* Create program */
Reviewed-b
GL_DEPTH24_STENCIL8 is defined by GL_EXT_packed_depth_stencil.
GL_DEPTH32F_STENCIL8 is from GL_ARB_depth_buffer_float, not
GL_ARB_texture_float.
---
tests/spec/gl-3.0/api/genmipmap-errors.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/gl-3.0/api/genmipmap-e
On 11/19/2013 11:54 AM, Eric Anholt wrote:
Brian Paul writes:
Since the test is in the spec/gl-3.0/ directory, we should probably
require GL 3.0 or later.
The check for GL_ARB_texture_float for GL_DEPTH32F_STENCIL8 was
incorrect. The format is part of GL 3.0, not GL_ARB_texture_float.
Or
On 11/18/2013 01:59 PM, Brian Paul wrote:
If we build waffle w/out ES support and we run all.tests, quick.tests,
etc. we get lots of 'fail' results for the ES tests. This change causes
those tests to be reported as 'skip' instead.
---
tests/util/piglit-util-waffle.c
To get more reasonable run times.
---
framework/gleantest.py |1 +
1 file changed, 1 insertion(+)
diff --git a/framework/gleantest.py b/framework/gleantest.py
index 88432e0..7bfc62e 100644
--- a/framework/gleantest.py
+++ b/framework/gleantest.py
@@ -35,6 +35,7 @@ class GleanTest(ExecTest):
---
tests/glean/tblend.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/glean/tblend.cpp b/tests/glean/tblend.cpp
index 6611729..a0f67b7 100644
--- a/tests/glean/tblend.cpp
+++ b/tests/glean/tblend.cpp
@@ -800,7 +800,7 @@ BlendFuncTest::runOne(BlendFuncResult& r, Wi
---
tests/glean/tpointatten.cpp | 16
1 file changed, 16 insertions(+)
diff --git a/tests/glean/tpointatten.cpp b/tests/glean/tpointatten.cpp
index 08076ca..0dee922 100644
--- a/tests/glean/tpointatten.cpp
+++ b/tests/glean/tpointatten.cpp
@@ -169,11 +169,19 @@ PointAttenuation
NG
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Check for a glScissorIndexed() bug found in MacOS AMD driver.
+ * Passes with NVIDIA's Linux driver.
+ *
+ * Brian Paul and others at VMware
+ * 15 Nov 2013
+ */
+
+
+
---
tests/spec/gl-1.0/rendermode-feedback.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/spec/gl-1.0/rendermode-feedback.c
b/tests/spec/gl-1.0/rendermode-feedback.c
index 8691c96..eb48bce 100644
--- a/tests/spec/gl-1.0/rendermode-feedback.c
+++ b/tests/
---
tests/glean/tpixelformats.cpp | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/tests/glean/tpixelformats.cpp b/tests/glean/tpixelformats.cpp
index 3518ed1..27881bf 100644
--- a/tests/glean/tpixelformats.cpp
+++ b/tests/glean/tpixelformats.cpp
@@ -156
Passing a negative value for GL_UNPACK_SKIP_PIXELS raises a GL error
that we don't want. Just pass 0 for both SKIP_PIXELS and SKIP_ROWS.
---
tests/texturing/s3tc-errors.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/texturing/s3tc-errors.c b/tests/texturing/s3t
If we're running an ARB_vertex/fragment_program test, there will be
no GLSL shader program and 'prog' will be zero. Return early to avoid
generating an error from the GL_ACTIVE_UNIFORM_BLOCKS query.
---
tests/shaders/shader_runner.c |5 +
1 file changed, 5 insertions(+)
diff --git a/test
On two Mint systems I'm seeing this problem:
$ ./piglit-run.py -t kil tests/all.tests results/kil
Traceback (most recent call last):
File "./piglit-run.py", line 148, in
main()
File "./piglit-run.py", line 118, in main
json_writer.write_dict_item(key, value)
File "/home/brian/pigli
try:
Tested-by: Brian Paul
Thanks, Dylan!
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
---
tests/all.tests |1 +
tests/spec/gl-1.0/CMakeLists.gl.txt |1 +
tests/spec/gl-1.0/long-dlist.c | 92 +++
3 files changed, 94 insertions(+)
create mode 100644 tests/spec/gl-1.0/long-dlist.c
diff --git a/tests/all.tests b/tests
Looks OK to me. Tested on NVIDIA (fails some cases due to apparent
driver bug). Pushed with minor whitespace change.
-Brian
On 12/02/2013 10:15 AM, Jon Ashburn wrote:
Can anyone review this patch from a week ago?
Thanks,
Jon Ashburn
On 11/25/13, 5:43 PM, Jon Ashburn wrote:
Add test case f
@@
+include_directories (
+ ${GLEXT_INCLUDE_DIR}
+ ${OPENGL_INCLUDE_PATH}
+)
+
link_libraries (
piglitutil_${piglit_target_api}
${OPENGL_gl_LIBRARY}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
ion, page 332:
+ * "Depth texture mode - DEPTH_TEXTURE_MODE. Section 3.8.15 is to be
+ * changed so that r is returned to texture samplers directly, and
+ * the OpenGL Shading Language 1.30 Specification is to be changed
+ * so that (r,r,r,1) is alwa
On 12/05/2013 10:55 AM, Marek Olšák wrote:
From: Marek Olšák
Only 0 to MAX_DRAW_BUFFERS-1 is allowed. If you want to clear GL_BACK,
call glDrawBuffers(GL_BACK) and then glClearBuffer(GL_COLOR, 0, ..).
---
For the series:
Reviewed-by: Brian Paul
On 12/05/2013 06:56 PM, Eric Anholt wrote:
---
tests/spec/arb_sync/sync-initialize.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On 12/12/2013 07:42 AM, Huang Jun wrote:
---
tests/all.tests|4 +
tests/spec/CMakeLists.txt |1 +
tests/spec/oes_query_matrix/CMakeLists.gles1.txt |7 +
tests/spec/oes_query_matrix/CMakeLists.txt |1 +
te
On 12/14/2013 10:02 AM, Pi Tabred wrote:
- clear-buffer-sub: test if buffer subregions are correctly cleared
- clear-buffer: test if entire buffer is correctly cleared
- negative-already-mapped: test if buffer or buffer range is already mapped
- negative-bad-format-type: test - combinat
On 12/17/2013 07:06 PM, Huang, JunX A wrote:
Hi Paul,
Thanks for your correcting!
But I still can not follow your following saying, could you be more specific?
"Also, maybe it should be structured so that the floating point matrix is first
constructed from the mantisa & exponent arrays first.
On 12/19/2013 12:37 PM, Ian Romanick wrote:
From: Ian Romanick
Signed-off-by: Ian Romanick
---
tests/texturing/depthstencil-render-miplevels.cpp | 5 +
1 file changed, 5 insertions(+)
For the series, quick review, LGTM.
Reviewed-by: Brian Paul
be on the alert for any regressions here.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
est_result(subtest_result, "%s",
all_subtests[i].name);
piglit_merge_result(&result, subtest_result);
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
i-errors.c
@@ -48,7 +48,9 @@
* implementation is not overly aggressive in flagging errors.
*/
+#ifndef _GNU_SOURCE
#define _GNU_SOURCE
+#endif
#include "piglit-util-gl-common.h"
PIGLIT_GL_TEST_CONFIG_BEGIN
Reviewed-by: Brian Paul
___
On 12/20/2013 04:33 PM, Brian Paul wrote:
On 12/19/2013 05:39 PM, Vinson Lee wrote:
MinGW provides asprintf in stdio.h.
Bugzilla:
https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D72556&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp
On 12/21/2013 05:01 PM, Marek Olšák wrote:
This test is wrong. The section 3.8.7 (page 160) of the GL 3.2 core
specification says:
"Depth textures and the depth components of depth/stencil textures can
be treated as RED textures during texture filtering and application
(see section 3.8.15). The
xtures and the depth components of depth/stencil textures can
+ * be treated as RED textures during texture filtering and application
+ * (see section 3.8.15). The initial state for depth and depth/stencil
+ * textures treats them as RED textures."
*
* Brian Paul
* 5 Dec 2013
@@ -181,14 +175
On 12/21/2013 05:01 PM, Marek Olšák wrote:
This test is wrong. The section 3.8.7 (page 160) of the GL 3.2 core
specification says:
"Depth textures and the depth components of depth/stencil textures can
be treated as RED textures during texture filtering and application
(see section 3.8.15). The
1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=B9FQT9xPZisThoztsRIIsb2v4JD4DAjsVwrD7xgTBvg%3D%0A&s=4d821799162f254b69415e626d846674a60f45ae0fc42617cc5a630985b94365
#ifndef INFINITY
That seems to work on my system.
L_INCLUDES
${CMAKE_CURRENT_BINARY_DIR}
${CMAKE_CURRENT_SOURCE_DIR}
Thanks. This fixes a problem I saw on one of my systems. I'll push
this patch soon.
Tested-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freed
basetype)
type = GL_FLOAT;
} else {
assert(0);
+ format = GL_NONE;
+ type = GL_NONE;
}
} else {
tex = piglit_rgbw_
exture_cube_map_array")
&& piglit_get_gl_version() < 40) {
- piglit_report_subtest_result(PIGLIT_SKIP, subtest_name);
+ piglit_report_subtest_result(PIGLIT_SKIP, "%s", subtest_name);
return true;
}
Reviewed
xt
index df2ea70..6745a2f 100644
--- a/tests/util/CMakeLists.txt
+++ b/tests/util/CMakeLists.txt
@@ -1,6 +1,6 @@
add_definitions(-DSOURCE_DIR="${piglit_SOURCE_DIR}/")
-if(PIGLIT_HAS_POSIX_CLOCK_MONOTONIC)
+if(PIGLIT_HAS_POSIX_CLOCK_MONOTONIC AND HAVE_LIBRT)
link_libraries(rt)
endi
Just minor nits below but looks good otherwise.
Reviewed-by: Brian Paul
On 01/08/2014 10:17 AM, Marek Olšák wrote:
From: Marek Olšák
---
tests/all.tests| 8 +
.../spec/arb_framebuffer_object/CMakeLists.gl.txt | 1 +
.../arb_framebuffer_object/fbo
t_init(int argc, char **argv)
{
- GLenum internal_format;
+ GLenum internal_format = GL_NONE;
const char *fmt;
if ((argc == 1) || (strncmp(argv[1], "GL_R", 4) != 0))
This and the other 6 piglit patches look fine to me.
Rev
Reviewed-by: Brian Paul
On 01/13/2014 02:34 PM, Ilia Mirkin wrote:
ping^2?
On Fri, Dec 20, 2013 at 3:04 PM, Ilia Mirkin wrote:
ping?
On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
tests/texturing/array-texture.c | 12
1 file changed
TexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, width, height, depth,
0,
For both: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
bo.c
+++ b/tests/texturing/cubemap-getteximage-pbo.c
@@ -38,6 +38,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
PIGLIT_GL_TEST_CONFIG_END
+#undef NUMCOLORS
#define NUMCOLORS7
#define TEX_WIDTH32
#define TEX_HEIGHT 32
Reviewed-by:
pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
return pass ? PIGLIT_PASS : PIGLIT_FAIL;
}
For all six patches: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
#define WIN32_LEAN_AND_MEAN
+#endif
#include
#endif
All 7 patches look OK to me.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
eck_gl_error(GL_NO_ERROR);
> + if (!piglit_check_gl_error(GL_NO_ERROR)) {
> + piglit_report_result(PIGLIT_FAIL);
> + }
>
> return vbo;
> }
>
I think I had those calls in there just as sanity checks during
development. They coul
ite this
test too but never carried through on it.
Reviewed-by: Brian Paul
One issue I recall is the width*height*depth calculation overflowing a
32-bit int/size_t somewhere, causing invalid results on 32-bit systems.
That might still need to be addressed.
-Brian
___
1 - 100 of 1411 matches
Mail list logo
