Signed-off-by: Anuj Phogat
---
tests/all.tests| 7 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-num-samples.cpp | 228 +
3 files changed, 236 insertions(+)
create mode 100644
tests
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5 ++
tests/spec/CMakeLists.txt | 1 +
tests/spec/arb_sample_shading/CMakeLists.txt | 1 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 14 +
.../arb_sample_shading
Signed-off-by: Anuj Phogat
---
tests/all.tests| 6 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-sample-id.cpp | 239 +
3 files changed, 246 insertions(+)
create mode 100644
tests
Signed-off-by: Anuj Phogat
---
tests/all.tests| 6 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-sample-position.cpp | 240 +
3 files changed, 247 insertions(+)
create mode 100644
tests
Signed-off-by: Anuj Phogat
---
tests/all.tests | 4
tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag | 12
tests/spec/arb_sample_shading/compiler/gl_SampleID.frag | 12
tests/spec/arb_sample_shading
Signed-off-by: Anuj Phogat
---
tests/all.tests| 6 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-sample-mask.cpp | 245 +
3 files changed, 252 insertions(+)
create mode 100644
tests
, Oct 15, 2013 at 6:19 AM, Anuj Phogat wrote:
>> Signed-off-by: Anuj Phogat
>> ---
>> tests/all.tests| 6 +
>> .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
>> .../execution/builtin-gl-sample-position.cpp | 240
On Mon, Oct 14, 2013 at 12:35 PM, Chris Forbes wrote:
> The projection seems spurious. Just set gl_Position = vec4(pos, 0.0,
> 1.0) in your VS and lose the matrix and supporting machinery?
I'll get rid of projection matrix.
>
> On Tue, Oct 15, 2013 at 6:19 AM, Anuj Phogat wro
V2: Get rid of redundant projection matrix.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 6 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-num-samples.cpp | 220 +
3 files changed, 227
Tests basic functionality of function:
MinSampleShadingARB()
and enums:
SAMPLE_SHADING_ARB
MIN_SAMPLE_SHADING_VALUE_ARB
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5 ++
tests/spec/CMakeLists.txt | 1 +
tests/spec
V2: Get rid of redundant projection matrix.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-sample-id.cpp | 230 +
3 files changed, 236
V2: Get rid of redundant projection matrix.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl-sample-mask.cpp | 236 +
3 files changed, 242
Tests gl_SamplePosition,
gl_SampleID,
gl_NumSamples,
gl_SampleMask[]
Signed-off-by: Anuj Phogat
---
tests/all.tests | 4
tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag | 12
tests/spec
V2: Use better technique to verify sample positions in fragment shader.
Get rid of redundant projection matrix.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/builtin-gl
40,7 @@ piglit_display()
> glBindFramebuffer(GL_DRAW_FRAMEBUFFER, dst_fbo.handle);
> glBlitFramebuffer(0, 0, pattern_width, pattern_height,
> 0, 0, pattern_width, pattern_height,
> - buffer_to_test, GL_NEAREST);
> + buffer_to_test, filter_mode);
>
> /* If necessary, manifest the depth/stencil image in dst_fbo
> * into a color image. This ensures that the blit that
> --
> 1.8.4.1
>
Thanks for adding these tests Paul.
This series is: Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Tue, Oct 29, 2013 at 8:01 AM, Paul Berry wrote:
> On 25 October 2013 16:49, Anuj Phogat wrote:
>
>> V2: Get rid of redundant projection matrix.
>> Signed-off-by: Anuj Phogat
>> ---
>> tests/all.tests| 5 +
>&g
On Sat, Oct 26, 2013 at 11:37 AM, Chris Forbes wrote:
> On Sat, Oct 26, 2013 at 12:49 PM, Anuj Phogat
> wrote:
> > V2: Get rid of redundant projection matrix.
> > Signed-off-by: Anuj Phogat
> > ---
> > tests/all.tests| 6
V2: Get rid of redundant projection matrix.
V3: Draw to a multisample texture and use it later to verify
the expected color of each sample.
Use piglit_draw_rect() and get rid of redundant code.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5
V2: Get rid of redundant projection matrix.
V3: Draw to a multisample texture and use it later to verify
the expected color of each sample.
Use piglit_draw_rect() and get rid of redundant code.
Signed-off-by: Anuj Phogat
---
tests/all.tests| 5
vec2(-0.5, 0.5);
> +
> +void main()
> +{
> + vec4 res = vec4(0);
> +
> + res += vec4(interpolateAtOffset(v1, offset), 1, 1, 1);
> + res += vec4(interpolateAtOffset(v2, offset), 1, 1);
> + res += vec4(interpolateAtOffset(v3, offset), 1);
> + res += interpolateAtOffset(v4, offset);
> +
> + gl_FragColor = res;
> +}
> diff --git
> a/tests/spec/arb_gpu_shader5/compiler/interpolation/fs-interpolateAtSample.frag
>
> b/tests/spec/arb_gpu_shader5/compiler/interpolation/fs-interpolateAtSample.frag
> new file mode 100644
> index 000..825b961
> --- /dev/null
> +++
> b/tests/spec/arb_gpu_shader5/compiler/interpolation/fs-interpolateAtSample.frag
> @@ -0,0 +1,25 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.50
> +// require_extensions: GL_ARB_gpu_shader5
> +// [end config]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +in float v1;
> +in vec2 v2;
> +in vec3 v3;
> +in vec4 v4;
> +
> +void main()
> +{
> + vec4 res = vec4(0);
> +
> + res += vec4(interpolateAtSample(v1, 0), 1, 1, 1);
> + res += vec4(interpolateAtSample(v2, 1), 1, 1);
> + res += vec4(interpolateAtSample(v3, 2), 1);
> + res += interpolateAtSample(v4, 3);
> +
> + gl_FragColor = res;
> +}
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
> -
> 'glsl-1.50-geometry-tri-strip-ordering-with-prim-restart {0} {1}'.format(
> -prim_type, restart_index))
> +cmdline = 'tri-strip-ordering-with-prim-restart {0} {1}'.format(
> +prim_type, restart_index)
> +spec['glsl-1.50']['execution']['geometry'][cmdline] = \
> +concurrent_test('glsl-1.50-geometry-' + cmdline)
>
> for input_layout in ['points', 'lines', 'lines_adjacency', 'triangles',
> 'triangles_adjacency', 'line_strip',
> 'triangle_strip']:
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
GL_UNSIGNED_INT, NULL);
> +
> + for (y = 0; y < ptSize; y++) {
> + for (x = 0; x < ptSize; x++) {
> + float test[] = {(2 * x + 1) / (float)(ptSize * 2),
> + 1 - ((2 * y + 1) / (float)(ptS
On Tue, Nov 12, 2013 at 12:36 PM, Anuj Phogat wrote:
> On Mon, Nov 11, 2013 at 11:44 AM, Nicholas Mack wrote:
>> ---
>> tests/all.tests| 2 +-
>> tests/spec/gl-3.2/CMakeLists.gl.txt| 3 +-
>> ...oord-replac
0 /* level */);
> + fbstatus = glCheckFramebufferStatus(GL_FRAMEBUFFER);
> + if (fbstatus != GL_FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS) {
> + printf("Expected GL_FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS, got
> "
> + "%s\n", piglit_get_gl_enum_name(fbstatus));
> + piglit_report_result(PIGLIT_FAIL);
> + }
> + piglit_report_result(PIGLIT_PASS);
> +}
> +
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> + /* Should never be reached */
> + return PIGLIT_FAIL;
> +}
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
> +enable GL_CLIP_PLANE0
> +enable GL_CLIP_PLANE1
> +enable GL_CLIP_PLANE2
> +enable GL_CLIP_PLANE3
> +enable GL_CLIP_PLANE4
> +enable GL_CLIP_PLANE5
> +enable GL_CLIP_PLANE6
> +enable GL_CLIP_PLANE7
> +draw arrays GL_TRIANGLE_FAN 0 4
> +probe all rgba 0.0 1.0 0.0 1.0
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Test crashes with Mesa master due to an assertion failure.
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
r *gsSource = {
> - "#version 410\n"
> + "#version 150\n"
> + "#extension GL_ARB_viewport_array : enable\n"
> "layout(triangles) in;\n"
> "layout(triangle_strip, max_vertices = 3) out;\n"
> "uniform int idx;\n"
> @@ -73,7 +74,7 @@ const char *gsSource = {
> };
>
> const char *fsSource = {
> - "#version 410\n"
> + "#version 150\n"
> "uniform vec3 color;\n"
> "void main() {\n"
> " gl_FragColor = vec4(color.xyz, 1.0);\n"
> --
> 1.8.4.3
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Also add piglit_require_GLSL_version(150) in piglit_init().
With above change this patch is:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Nov 25, 2013 at 2:06 PM, Nicholas Mack wrote:
> v2: Move test into arb_texture_rectangle folder and change context
> ---
> tests/all.tests| 1 +
> tests/spec/arb_texture_rectangle/CMakeLists.gl.txt | 1 +
> .../texture-base-level-error.c
; +
> +void
> +piglit_init(int argc, char **argv)
> +{
> + bool pass = true;
> +
> + glVertexAttribDivisor(GL_MAX_VERTEX_ATTRIBS, 0);
> + pass = piglit_check_gl_error(GL_INVALID_VALUE) && pass;
> +
> + piglit_report_result(pass ? PIGLI
On Tue, Nov 26, 2013 at 2:56 PM, Jordan Justen wrote:
> On Tue, Nov 26, 2013 at 10:49 AM, Anuj Phogat wrote:
>> On Tue, Nov 26, 2013 at 8:57 AM, Jordan Justen
>> wrote:
>>> These tests are expected to run with OpenGL 3.2, so
>>> we should only use #version 15
The error INVALID_VALUE is generated if
> +* TEXTURE_BASE_LEVEL is set to any value other than zero
> +*/
> + glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_BASE_LEVEL, 37);
> + pass = piglit_check_gl_error(GL_INVALID_VALUE) && pass;
> +
> + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> + /* UNREACHED */
> + return PIGLIT_FAIL;
> +}
> --
> 1.8.3.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Dec 9, 2013 at 10:02 AM, Paul Berry wrote:
> On 6 November 2013 17:24, Anuj Phogat wrote:
>
>> V2: Get rid of redundant projection matrix.
>> V3: Draw to a multisample texture and use it later to verify
>> the expected color of each sample.
>> Use
On Fri, Dec 6, 2013 at 3:04 PM, Paul Berry wrote:
>
> On 6 November 2013 17:20, Anuj Phogat wrote:
>>
>> V2: Get rid of redundant projection matrix.
>> V3: Draw to a multisample texture and use it later to verify
>> the expected color of each sample.
>>
On Mon, Dec 9, 2013 at 6:47 PM, Paul Berry wrote:
> On 9 December 2013 18:42, Anuj Phogat wrote:
>>
>>
>>
>>
>> On Mon, Dec 9, 2013 at 10:02 AM, Paul Berry
>> wrote:
>>>
>>> On 6 November 2013 17:24, Anuj Phogat
Signed-off-by: Anuj Phogat
---
tests/gl33conform.tests | 81 +
1 file changed, 81 insertions(+)
create mode 100644 tests/gl33conform.tests
diff --git a/tests/gl33conform.tests b/tests/gl33conform.tests
new file mode 100644
index 000..9a8bd92
Also, use piglit_link_simple_program(). It ensures that
piglit_vertex gets assigned to the proper attribute slot.
This patch fixes these tests currently failing on mesa.
Signed-off-by: Anuj Phogat
---
.../arb_sample_shading/execution/builtin-gl-num-samples.cpp | 12 +---
.../execution
Also, case of non-multisample color buffer is not handled correctly
in the test. Move it inside the shader program.
Signed-off-by: Anuj Phogat
---
.../execution/builtin-gl-sample-id.cpp | 69 +++---
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a
Signed-off-by: Anuj Phogat
---
tests/util/piglit-fbo.cpp | 3 ++-
tests/util/piglit-fbo.h | 8
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/util/piglit-fbo.cpp b/tests/util/piglit-fbo.cpp
index 138b5d3..a85d19d 100644
--- a/tests/util/piglit-fbo.cpp
+++ b/tests
Existing test only covers the drawing to texture attachment with a
sample mask. This patch extends the test to include drawing to
renderbuffer attachment. This might help capture the bugs where
drawing to a texture differ from drawing to a renderbuffer.
Signed-off-by: Anuj Phogat
Existing test only covers the drawing to texture attachment with a
sample mask. This patch extends the test to include drawing to
renderbuffer attachment. This might help capture the bugs where
drawing to a texture differ from drawing to a renderbuffer.
Signed-off-by: Anuj Phogat
UFFER, GL_COLOR_ATTACHMENT0,
> + GL_RENDERBUFFER, ss_tex);
> }
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Irrespective of what you decide about suggested changes, both the
patches are: Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
break;
> }
>
> - glDisable(target);
> + /* If a GLSL program is in use, then the preceeding code should not
> +* have called glEnable(target). In that case, this code should not
> +* disable it. For some targets, like GL_TEXTURE_1D_ARRAY,
> +* glDisable(target) will generate an error.
> +*/
> + if (prog == 0)
> + glDisable(target);
> + else
> + glUseProgram(0);
>
> return pass;
> }
> --
> 1.8.1.4
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
gt; index 000..5711394
> --- /dev/null
> +++ b/tests/spec/arb_gpu_shader5/linker/sample-qualifier-vs-fs.shader_test
> @@ -0,0 +1,31 @@
> +# Tests that variables in the vertex shader can be qualified with 'sample
> out'
> +# and link against variables in the fragment shader qualified with 'sample
> in'
> +
> +[require]
> +GLSL >= 1.50
> +GL_ARB_gpu_shader5
> +
> +[vertex shader]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +sample out vec4 per_sample_color;
> +
> +void main() {
> + per_sample_color = vec4(1);
> +}
> +
> +[fragment shader]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +sample in vec4 per_sample_color;
> +
> +void main() {
> + gl_FragColor = per_sample_color;
> +}
> +
> +[test]
link success ?
> +
> --
> 1.8.4.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
With above changes made, this patch is:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
965: Use sample
barycentric coordinates with per sample shading'.
Signed-off-by: Anuj Phogat
Cc: Chris Forbes
---
Thanks Chris for pointing to a reference test which I used to create
this test.
tests/all.tests| 5 +
.../arb_sample_shading/execution/CMa
On Thu, Jan 9, 2014 at 3:43 PM, Anuj Phogat wrote:
> ARB_sample_shading extension says:
> "When the sample shading fraction is 1.0, a separate set of colors
> and other associated data are evaluated for each sample, each set
> of values are evaluated at the sample location.
27;s location.
Signed-off-by: Anuj Phogat
Cc: Chris Forbes
---
tests/all.py | 5 +
.../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +
.../execution/ignore-centroid-qualifier.cpp| 199 +
3 files changed, 205 insertions(
+void main()
> +{
> + gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);
> +}
> +
> +[test]
> +clear color 0.0 0.0 0.0 0.0
> +clear
> +draw arrays GL_POINTS 0 1
> +probe all rgba 0.0 1.0 0.0 1.0
> --
> 1.8.5.3
>
> _
On Thu, Jan 9, 2014 at 10:59 AM, Paul Berry wrote:
> ---
> .../compiler/default_local_size.comp | 39
> ++
> .../compiler/mismatched_local_size.comp| 21
> .../compiler/negative_local_size.comp | 26 +++
> .../co
Y_COMPUTE_SHADER = 0x90ED
> DISPATCH_INDIRECT_BUFFER = 0x90EE
> --
> 1.8.5.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
This series is: Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
27;in' variable with the 'centroid' qualifier.
Another test already covers the interpolation of 'in' variable
without any 'qualifier'. This change also captures the mesa bug
reported on i965 driver:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73915
S
On Thu, Jan 23, 2014 at 11:55 PM, Jordan Justen
wrote:
> Signed-off-by: Jordan Justen
> ---
> .../incorrect-in-layout-qualifier-column_major.geom | 20
>
> .../incorrect-in-layout-qualifier-max_vertices.geom | 20
>
> .../incorrect-in-layout-qualifie
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
This series is Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Jan 27, 2014 at 10:34 AM, Paul Berry wrote:
> On 23 January 2014 15:56, Anuj Phogat wrote:
>>
>> Here is what it tests:
>> Enable sample shading for the whole fragment shader using OpenGL API
>> glEnable(GL_SAMPLE_SHADING);
>> glMinSampleShading(1.0);
&
+
> +[test]
> +uniform float x 3.0
> +uniform float y 3.0
> +uniform vec2 v 0.25 0.25
> +draw rect -1 -1 2 2
> +probe all rgba 0.25 0 0 1
> --
> 1.8.3.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Signed-off-by: Anuj Phogat
---
tests/glslparsertest/glslparsertest.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/tests/glslparsertest/glslparsertest.c
b/tests/glslparsertest/glslparsertest.c
index 5957144..18bd062 100644
--- a/tests/glslparsertest
> +[fragment shader]
> +#version 150
> +
> +void main()
> +{
> + gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);
> +}
> +
> +[test]
> +clear color 0.0 0.0 0.0 0.0
> +clear
> +draw arrays GL_POINTS 0 1
> +probe all rgba 0.0 1.0 0.0 1.0
> --
> 1.8.5.3
>
> _
Signed-off-by: Anuj Phogat
---
...ayout-qualifiers-conflicting-case-1.shader_test | 47 +
...ayout-qualifiers-conflicting-case-2.shader_test | 59 +
...ayout-qualifiers-conflicting-case-3.shader_test | 58 +
...ayout-qualifiers-conflicting
Signed-off-by: Anuj Phogat
---
.../layout-qualifiers-conflicting-case-1.frag | 37 ++
.../layout-qualifiers-conflicting-case-2.frag | 37 ++
.../layout-qualifiers-matching.frag| 37 ++
3 files changed, 111
On Mon, Feb 10, 2014 at 6:42 PM, Ian Romanick wrote:
> I think you mean "compiler" in the subject. :)
>
yeah. "copiler" is still too futuristic :)
>
> On 02/10/2014 06:15 PM, Anuj Phogat wrote:
> > Signed-off-by: Anuj Phogat
> > ---
> > .../l
Signed-off-by: Anuj Phogat
---
...rect-multiple-layout-qualifier-invocations.geom | 23 ++
...rect-multiple-layout-qualifier-invocations.geom | 23 ++
2 files changed, 46 insertions(+)
create mode 100644
tests/spec/arb_gpu_shader5/compiler/correct
Signed-off-by: Anuj Phogat
---
.../execution/invocations-conflicting.shader_test | 47 ++
.../execution/invocations-matching.shader_test | 46 +
2 files changed, 93 insertions(+)
create mode 100644
tests/spec/arb_gpu_shader5/execution/invocations
On Tue, Feb 11, 2014 at 11:07 AM, Anuj Phogat wrote:
>
>
>
> On Mon, Feb 10, 2014 at 6:42 PM, Ian Romanick wrote:
>>
>> I think you mean "compiler" in the subject. :)
>
> yeah. "copiler" is still too futuristic :)
>>
>>
>>
On Thu, Feb 13, 2014 at 5:52 PM, Anuj Phogat wrote:
>
> On Tue, Feb 11, 2014 at 11:07 AM, Anuj Phogat wrote:
> >
> >
> >
> > On Mon, Feb 10, 2014 at 6:42 PM, Ian Romanick wrote:
> >>
> >> I think you mean "compiler" in the s
On Tue, Feb 18, 2014 at 3:31 PM, Ian Romanick wrote:
> On 02/18/2014 03:17 PM, Anuj Phogat wrote:
>> On Thu, Feb 13, 2014 at 5:52 PM, Anuj Phogat wrote:
>>>
>>> On Tue, Feb 11, 2014 at 11:07 AM, Anuj Phogat wrote:
>>>>
>>>>
>>>
Signed-off-by: Anuj Phogat
---
...ayout-qualifiers-conflicting-case-5.shader_test | 63 ++
...ayout-qualifiers-conflicting-case-6.shader_test | 62 +
...ayout-qualifiers-conflicting-case-7.shader_test | 50 +
3 files changed, 175 insertions
Signed-off-by: Anuj Phogat
---
.../layout-qualifiers-conflicting-case-3.frag | 38 +
.../layout-qualifiers-conflicting-case-4.frag | 39 ++
.../layout-qualifiers-conflicting-case-5.frag | 39 ++
.../layout-qualifiers
;
>
> pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>
> --
> 1.9.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Both the patches are:
Reviewed-b
V2: Add few more shader tests and do minor changes in tests added in V1.
Signed-off-by: Anuj Phogat
---
...ayout-qualifiers-conflicting-case-5.shader_test | 62 ++
...ayout-qualifiers-conflicting-case-6.shader_test | 61 +
...ayout-qualifiers-conflicting
Signed-off-by: Anuj Phogat
---
.../compiler/overlapping-attrib-locations-1.vert | 28 ++
.../compiler/overlapping-attrib-locations-2.vert | 28 ++
2 files changed, 56 insertions(+)
create mode 100644
tests/spec/arb_explicit_attrib_location/1.10
It is possible for an application to bind more than one
attribute name to the same location. This is referred to as
aliasing. It is allowed in: OpenGL 2.0 (and above) and
OpenGL ES 2.0. This test varifies that aliasing can be used
successfully in a vertex shader.
Signed-off-by: Anuj Phogat
Brian,
Today I came across this unread email from you. I missed it somehow. I'm
not sure if this information is still relevant but here is what I have
found:
Testing GL_INVALID_OPERATION for integer and depth/stencil texture formats
is based on a mesa commit:
http://lists.freedesktop.org/archive
Signed-off-by: Anuj Phogat
---
tests/texturing/teximage-errors.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/texturing/teximage-errors.c
b/tests/texturing/teximage-errors.c
index 221007f..39b7e9b 100644
--- a/tests/texturing/teximage-errors.c
+++ b/tests
This patch is to verify a bug fix in mesa commit 079bff5. This commit
allowed GL_DEPTH_COMPONENT and GL_DEPTH_STENCIL combinations in
glTexImage{123}D functions.
Signed-off-by: Anuj Phogat
---
tests/texturing/teximage-errors.c | 73 ++-
1 file changed, 72
On Wed, Mar 12, 2014 at 4:20 AM, Ken Phillis Jr wrote:
> The patch looks like it has a major problem.
>
Do you have any objections to the changes made in this patch?
> Mesa does not support OpenGL 3.x compatibility profile. This test is
> currently only using a compatibility profile. I would sugg
On Wed, Mar 12, 2014 at 6:24 AM, Brian Paul wrote:
> On 03/11/2014 06:51 PM, Anuj Phogat wrote:
>
>> This patch is to verify a bug fix in mesa commit 079bff5. This commit
>> allowed GL_DEPTH_COMPONENT and GL_DEPTH_STENCIL combinations in
>> glTexImage{123}D functions.
&
Signed-off-by: Anuj Phogat
---
tests/texturing/teximage-errors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/texturing/teximage-errors.c
b/tests/texturing/teximage-errors.c
index 30b7875..1198514 100644
--- a/tests/texturing/teximage-errors.c
+++ b/tests/texturing
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_explicit_uniform_location/loc-minmax.c | 107
> +
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_explicit_uniform_location/array-elements.c | 107
> +
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> Tests that array fits in to the boundaries of defined by the spec.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_ex
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_explicit_uniform_location/array-overlap.c | 98
> ++
>
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> This test tests overlapping uniform locations across shader stages.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_exp
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> This test tests overlapping uniform locations across shader stages.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt | 1 +
> .../arb_exp
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> This test sets different explicit location for same uniform from
> different shader stage.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt
On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli wrote:
> This test sets explicit location in vertex shader but does not set it
> for same uniform in the fragment shader.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt
;}";
>> +
>> +void
>> +piglit_init(int argc, char **argv)
>> +{
>> + int maxloc;
>> + GLuint prog;
>> +
>> + piglit_require_extension("GL_ARB_explicit_uniform_location");
>> +
>> + glGetIntegerv(GL_MAX_UNIFORM_LOCATIONS, &maxloc);
>> +
>> + if (!piglit_check_gl_error(GL_NO_ERROR))
>> + piglit_report_result(PIGLIT_FAIL);
>> +
>> + char *f_sha;
>> +
>> + /* test GL_MAX_UNIFORM_LOCATIONS, 0, and a loc in between (1) */
>> + if (asprintf(&f_sha, fshader_main, maxloc, 0, 1) == -1)
>> + piglit_report_result(PIGLIT_FAIL);
>> +
>> + prog = piglit_build_simple_program(v_sha, f_sha);
>> +
>> + free(f_sha);
>> +
>> + if (glGetUniformLocation(prog, "r") != maxloc)
>> + piglit_report_result(PIGLIT_FAIL);
>> + if (glGetUniformLocation(prog, "g") != 0)
>> + piglit_report_result(PIGLIT_FAIL);
>> + if (glGetUniformLocation(prog, "b") != 1)
>> + piglit_report_result(PIGLIT_FAIL);
>> +
>> + glDeleteProgram(prog);
>> + piglit_report_result(PIGLIT_PASS);
>> +}
>>
>
With comments from Ian and Topi fixed:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
tion = 1) uniform float r;\n"
>> + "layout(location = 2) uniform float g;\n"
>> + "layout(location = 3) uniform float a[ARRAY_SIZE];\n"
>> + "layout(location = 19) uniform float b;\n"
>> + "void main() {\n"
>> + "gl_FragCo
On Thu, Mar 13, 2014 at 9:07 AM, Ilia Mirkin wrote:
> There's no reason to attach the teximages to the framebuffer. Instead
> use renderbuffers so that we don't need to depend on ARB_depth_texture.
>
OpenGL driver may choose different blitting paths internally based on if the
attachment is a rende
On Thu, Mar 13, 2014 at 9:07 AM, Ilia Mirkin wrote:
> This removes an implicit dependency on ARB_depth_texture (and is more
> efficient).
Same comments as in Patch 1/4. With a quick search I couldn't find
different glReadPixels() internal paths in mesa. But other drivers
might have. I would wait
On Mon, Mar 17, 2014 at 6:04 AM, Tapani Pälli wrote:
> v2: fix style issues (Anuj)
> v3: change to be a shader-runner test (Ian)
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 3 ++
> .../overlap-location-within-array.shader_test | 32
> ++
On Mon, Mar 17, 2014 at 6:04 AM, Tapani Pälli wrote:
> This test sets explicit location in vertex shader but does not set it
> for same uniform in the fragment shader.
>
> v2: fix style issues (Anuj)
> v3: change to be a shader-runner test (Ian)
>
It might be worth testing that same uniform locati
_
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Made few suggestions for new tests. This series is:
Reviewed-by : Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
vertex;
> +}
> +
> +[fragment shader]
> +#extension GL_ARB_explicit_uniform_location: require
> +layout(location = 127) uniform vec4 color;
> +void main()
> +{
> + gl_FragColor = color;
> +}
> +
> +[test]
> +link error
> --
>
leteTextures(1, &tex);
> +
> + return pass;
> +}
> +
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> + piglit_require_extension("GL_ARB_framebuffer_object");
> + piglit_require_gl_version(20);
> +
> +
- 1, 0, 1) == -1)
> piglit_report_result(PIGLIT_FAIL);
>
> prog = piglit_build_simple_program(vs_text, f_sha);
>
> free(f_sha);
>
> - if (glGetUniformLocation(prog, "r") != maxloc)
> + if (glGetUniformLocation(prog, "r&
{\n"
> + "gl_FragColor = vec4(1.0, 0.0, 1.0, 1.0);\n"
> + "}";
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> + GLuint prog;
> +
> + piglit_require_extension("GL_ARB_explicit_uniform_location");
> +
> + prog = piglit_build_simple_program(vs_text, fs_text);
> +
> + glUseProgram(prog);
> +
> + /* verify that glUniform1f does not generate error */
> + glUniform1f(7, 0.1);
> +
> + if (!piglit_check_gl_error(GL_NO_ERROR))
> + piglit_report_result(PIGLIT_FAIL);
> +
> + glDeleteProgram(prog);
> + piglit_report_result(PIGLIT_PASS);
> +}
> --
> 1.8.3.1
>
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ternal_format,
> basetype);
> --
> 1.7.10.4
>
> _______
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
t_check_gl_error(GL_INVALID_OPERATION) && pass;
> +
> + /* Re-validate the program.
> +*/
> + if (program_check_status(prog)) {
> + fprintf(stderr,
> + "Program was validated with conflicting "
> + "sampler config
Builtin variables tested are gl_Layer and gl_ViewportIndex. The test
case verifies a bug fix in Intel's i965 drivers. It can be later
extended to add testing for more builtin variables.
Signed-off-by: Anuj Phogat
---
Patch is also available on my 'review' branch at:
https://git
On Sat, Apr 12, 2014 at 10:09 PM, Chris Forbes wrote:
> Signed-off-by: Chris Forbes
> ---
> .../compiler/redeclaration-around-use.frag | 31
> ++
> 1 file changed, 31 insertions(+)
> create mode 100644
> tests/spec/arb_fragment_coord_conventions/compiler/redeclarat
Test currently fails on Intel's open source linux drivers but passes on
NVIDIA's proprietary linux drivers.
Signed-off-by: Anuj Phogat
---
Patch is also available on my 'review' branch at:
https://github.com/aphogat/piglit.git
tests/all.py
On Thu, Apr 17, 2014 at 6:05 PM, Chris Forbes wrote:
> You've got some broken indentation:
>
> chrisf@moose [piglit] (master=) $ pwclient git-am 24390
> Applying patch #24390 using 'git am'
> Description: Add test to verify the values of gl_VertexID captured by
> transform feedback
> Applying: Add
1 - 100 of 468 matches
Mail list logo
