D12330: Consistently use KQuickControls.ColorButton in the config UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:135f0f9dd179: Consistently use KQuickControls.ColorButton in the config UI (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12330: Consistently use KQuickControls.ColorButton in the config UI

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH usekquickcolorbutton REVISION

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. In D12311#249270 , @sharvey wrote: > F5812033: Screenshot_20180418_161500.png > The good news is that it still behaves properly with a scaled display. > > The bad news is

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812033: Screenshot_20180418_161500.png The good news is that it still behaves properly with a scaled display. The bad news is that, due to the `minimumSize` we configured for System Settings, I can't get back to the

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. I think it would be worth it! It's definitely not a crown jewel of polished UI design, that's for sure. To test scaling, try setting a systemwide scale factor in System Settings > Display and Monitor > Displays > Scale Display, then logging out and back in,

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812014: Screenshot_20180418_155156.png The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a separate process?). I don't have a HiDPI display to test on. I tried different fonts up to 15pt and all

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

ngraham added a comment. From localization perspective, this seems important given that some languages generally yield longer strings than others (we get a lot of Bugzilla tickets on this). Also, romance languages tend to put the differentiating part of the string on the end rather than

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. It's looking a trillion times better than the early screenshots. Some feedback from a quick test: - close icon in the "add" popup doesn't have a mouseover effect so it looks a bit weird - I have no languages installed and that makes the popup look

D12102: Port Language KCM to Qt Quick

hein added a comment. + pushed a revert commit. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12102: Port Language KCM to Qt Quick

hein reopened this revision. hein added a comment. Reopen for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12102: Port Language KCM to Qt Quick

hein added a comment. Arf, no, sorry. I forgot over a week's worth of vacation that I had this on the same branch as something else. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts,

D12313: Consistently use text "Configure..." for applet configure buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R114:47feb15029da: Consistently use text Configure... for applet configure buttons (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

aacid added a comment. In D12171#248840 , @hein wrote: > Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first.

D12318: Consistently use KQuickControls.ColorButton in the config UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:f3ad84f91946: Consistently use KQuickControls.ColorButton in the config UI (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. > This revision was not accepted when it landed; it landed in state Changes Planned.Wed, Apr 18, 8:54 PM Was this intentionally merged? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc:

D12311: Align lock icon with bold message text; reduce overall size of dialog

broulik added a comment. I think there's something severly wrong with the dialog's size hints if we need to add arbitrary numbers all over the place. Can you make sure this doesn't break with - different font - larger font - screen scaling - different widget style - ...

D12313: Consistently use text "Configure..." for applet configure buttons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Can we fix `configurationNeeded` in the desktop/panel containment, please? :P REPOSITORY R114 Plasma Addons BRANCH consistentConfigurebuttontext REVISION DETAIL

D12314: expose the wallpaper config to the lockscreen

broulik added a comment. Hmm I think it would make for a nicer API to expose `wallpaperPluginName` and `wallpaperConfiguration` directly? I find doing `wallpaper.something` and `wallpaperIntegration.pluginName` a bit awkward, but fine with me. REPOSITORY R133 KScreenLocker REVISION

D12324: Sort top-level entries as well when sorting is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7d2674da2103: Sort top-level entries as well when sorting is enabled (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12324?vs=32503=32510

D12102: Port Language KCM to Qt Quick

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R119:5e6353d2824f: Port Language KCM to Qt Quick (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE

D12318: Consistently use KQuickControls.ColorButton in the config UI

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. So much red! REPOSITORY R114 Plasma Addons BRANCH useconsistentcolorbutton REVISION DETAIL https://phabricator.kde.org/D12318 To: kossebau, #plasma, #vdg,

D12318: Use consistent color button components for color config UI elements

kossebau updated this revision to Diff 32505. kossebau added a comment. also update potd wallpaper with KQuickControls.ColorButton REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12318?vs=32502=32505 BRANCH useconsistentcolorbutton REVISION DETAIL

D12318: Use consistent color button components for color config UI elements

kossebau added a comment. In D12318#249050 , @davidedmundson wrote: > There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols > > Can't we use that? Ah, I had only grepped

D12324: Sort top-level entries as well when sorting is enabled

hein created this revision. hein added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D12324 AFFECTED FILES

D12318: Use consistent color button components for color config UI elements

kossebau updated this revision to Diff 32502. kossebau added a comment. use KQuickControls.ColorButton REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12318?vs=32491=32502 BRANCH useconsistentcolorbutton REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a reviewer: Frameworks. ngraham accepted this revision. ngraham added a comment. Much better! I'd still prefer less whitespace, but this is already an improvement. But now that I'm staring at this dialog over and over again, I'm wondering if we even need the non-bold caption

D12323: Read theme.conf of themes

fvogt added inline comments. INLINE COMMENTS > davidedmundson wrote in themeconfig.cpp:169 > nice solution > > "NoGlobals" - Cascade to system settings, but omit user's globals. > > should work better. It will include the added sources, but no more

D12323: Read theme.conf of themes

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. 1 minor change. INLINE COMMENTS > themeconfig.cpp:169 > if (configFile.exists()) { > -KSharedConfigPtr themeConfig = >

D11928: fade to blur when the login box appears

zzag added a comment. In D11928#240658 , @ngraham wrote: > F5791756: Spectacle.wS4100.png It looks like there are "blur artifacts/contours"... How about adding Gaussian noise? It can help to break

D12318: Use consistent color button components for color config UI elements

davidedmundson added a comment. There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols Can't we use that? INLINE COMMENTS > kossebau wrote in ColorPicker.qml:34 > Open question to developers: > how expensive is it to have an

D12323: Read theme.conf of themes

fvogt added a comment. (Actually targeting the Plasma/5.12 branch) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D12323 To: fvogt, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D12323: Read theme.conf of themes

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Otherwise kcm_sddm ignores values in there. Previously, a theme with a default background image reverts to a color background

D12311: Align lock icon with bold message text

sharvey updated this revision to Diff 32498. sharvey added a comment. - Correct initial Y placement for `errorMessageWidget` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12311?vs=32496=32498 BRANCH align-lock-icon (branched from

D12311: Align lock icon with bold message text

sharvey added a comment. Here's the latest from the Pixel Conservation Society. I can't manage wholesale space-savings without breaking up the existing `gridLayout` and basically starting from scratch. It does resize a bit and does no harm. F5811876: Screenshot_20180418_130139.png

D12311: Align lock icon with bold message text

sharvey updated this revision to Diff 32496. sharvey added a comment. - Reduce height of dialog by shrinking UI elements when not needed Password error alert and user-choice combo box are reduced to 1px high when not needed, then restored to their original geometry when activated.

D12311: Align lock icon with bold message text

sharvey added a comment. Here's what I can come up with. I can't accomplish major resizing without breaking up the existing UI layout grid(s) and starting from scratch. But I managed to save a few pixels where I could. F5811860: Screenshot_20180418_123909.png

D12318: Use consistent color button components for color config UI elements

ngraham added a comment. +1! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12318 To: kossebau, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

kossebau added inline comments. INLINE COMMENTS > ColorPicker.qml:34 > + > +QtDialogs.ColorDialog { > +id: colorDialog Open question to developers: how expensive is it to have an instance of ColorDialog per button, instead of sharing one over all buttons? That's where the code for

D12318: Use consistent color button components for color config UI elements

kossebau added a comment. Before: F5811833: Screenshot_20180418_191455.png F5811834: Screenshot_20180418_191409.png After: F5811837: Screenshot_20180418_191620.png

D12318: Use consistent color button components for color config UI elements

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY For a consistent UX use the same component code for config

D12311: Align lock icon with bold message text

ngraham added a comment. In D12311#248878 , @sharvey wrote: > It's got a Big Scary Red Box that appears for an error. It's already in the UI design, just not visible. So when it's set to visible, its space is already allocated. > >

D11928: fade to blur when the login box appears

davidedmundson added inline comments. INLINE COMMENTS > WallpaperFader.qml:4 > + > +Copyright (C) 2014 Aleix Pol Gonzalez > + C? > LockScreenUi.qml:76 > +property bool uiVisible: false > +property bool blockUI: mainStack.depth > 1 || >

D12314: expose the wallpaper config to the lockscreen

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY the lockscreen can change behavior based on the wallpaer (D11928

D11928: fade to blue when the login box appears

mart updated this revision to Diff 32483. mart added a comment. - use the state machine for the effect - shorter animations - just blur and darken the background - whitespaces fixes - add precisions to make it work on GLES - bigger clock - move the wallpaperfader in a different

D12313: Consistently use text "Configure..." for applet configure buttons

kossebau added a comment. Another applet which has such a button is the weather applet (master-only), which already uses this string. There is some inconsistency though still: one button shows an icon, while the other two do not. This is due to QQC2 button not supporting an icon next to

D12313: Consistently use text "Configure..." for applet configure buttons

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Applets which need initial configuration display some centered

D12311: Align lock icon with bold message text

sharvey added a comment. In D12311#248852 , @ngraham wrote: > Better already! Do we even need to reserve that space? Many other such dialogs dynamically allocate it when necessary by increasing the height of the box. Is that not possible here?

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:b43a463230d0: [mediaframe applet] Enable wrapping of fill mode description in config UI (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12307?vs=32466=32480#toc

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. Should be good if it doesn't crash. REPOSITORY R114 Plasma Addons BRANCH wrapfillmodedescription REVISION DETAIL https://phabricator.kde.org/D12307 To: kossebau, #plasma,

D12311: Align lock icon with bold message text

ngraham added a comment. Better already! Do we even need to reserve that space? Many other such dialogs dynamically allocate it when necessary by increasing the height of the box. Is that not possible here? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched

D12311: Align lock icon with bold message text

sharvey added a comment. F5811737: Screenshot_20180418_100622.png How's this? It's a little tighter. Some of the white space is reserved for otherwise-invisible error messages (like an invalid password). If it gets more +1's, I'll update.

D12311: Align lock icon with bold message text

ngraham added a comment. +1 for much much less whitespace. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

davidedmundson added a comment. > Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first. Worth noting that they only expand *if* they go above the current size

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

hein added a comment. Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12171

D12311: Align lock icon with bold message text

sharvey added a comment. I just realized I inadvertently shrank the spacing between the bold headline and the non-bold explanation text. There's a lot of white space in this dialog. Let me know if you want something adjusted... REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL

D12311: Align lock icon with bold message text

sharvey added a comment. F5811717: Screenshot_20180416_124725.png Before -- F5811719: Screenshot_20180418_092904.png After REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL

D12102: Port Language KCM to Qt Quick

mart added a comment. on kirigami master the swipelistitem should look more desktopy REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12311: Align lock icon with bold message text

sharvey added a comment. In D12311#248824 , @davidedmundson wrote: > Probably fine, but can you attach a screenshot You're too quick on the draw. Was still editing the summary! REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION

D12091: HIG entry for On-demand pattern and swipe list item

mart added a comment. this may be an example screenshot for kirigami F5811714: image.png REPOSITORY R985 KDE Human Interface Guidelines REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel,

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#244758 , @abetts wrote: > Would it be hard to include a checkbox to the left of each list item that shows a selection when tapped? Sorry, can you explain which of the two lists and what "shows a selection

D12311: Align lock icon with bold message text

davidedmundson added a comment. Probably fine, but can you attach a screenshot REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12311: Align lock icon with bold message text

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Adjusted spacers in UI file to properly align icon with message text TEST PLAN - Compile

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. I would like to consider discarding this patch and the related introduction of the "acceptOnReturnPressed" property to Plasma config page concept only needed for this so far. I am currently drafting to rework the UI of the weather station page in the dialog,

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

kossebau added a comment. Target: Plasma/5.12 branch I wonder if that mode description text should be there at all, given it is inconsistent with other places in Plasma config UI, which do not have such a separate info text item for the selection of the fill mode/positioning (e.g.

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Especially with some translations the text will not fit on a

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

Yes, we were having the same issue for android. Just landed a fix. Aleix On Wed, Apr 18, 2018 at 1:16 PM, Ben Cooksley wrote: > Can someone please look into this and detail why we now have a new > dependency here? > > A speedy resolution to this is required as Frameworks

D12305: Fix build on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d9a956de53ed: Fix build on Android (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12305?vs=32460=32461 REVISION DETAIL

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

Can someone please look into this and detail why we now have a new dependency here? A speedy resolution to this is required as Frameworks build failures can lead to rapid maintainability issues for the CI system. Cheers, Ben On Tue, Apr 17, 2018 at 11:55 PM, CI System wrote:

D12305: Fix build on Android

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Kirigami was half-depending on dbus and it wouldn't build TEST