D10890: Don't skip certain recent documents in kicker and taskmanager

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R119 Plasma Desktop BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc:

D11142: Add ConnectionCheck for Dash Cards

yurchor added inline comments. INLINE COMMENTS > main.qml:132 > + if(!connectCtx){ > + var conError = i18n("I am not connected to the  internet, > Please check your network connection") > + convoLmodel.append({"itemType": "NonVisual", "InputQuery": >

D11148: Move applet packages' /code subdirs below /ui subdirs

apol added a comment. In D11148#221135 , @broulik wrote: > Well, the package definition says JS files must (should) be in "code", I don't see the advantage of moving this. There's no advantage to that rule though. Also AFAIR there's

D10747: Implement zwp_linux_dmabuf_v1

fredrik updated this revision to Diff 28986. fredrik added a comment. Import the context. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=27735=28986 REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg added a comment. Well we need to stop exporting the QT_QPA_PLATFORM value in startup script in any case, right? Or when we depend on Qt 5.11 and then set it to "wayland;x11" does it not break apps depending on Qt 5.y, y<11? So the question is just if we want to wait till we depend

D11148: Move applet packages' /code subdirs below /ui subdirs

kossebau added a comment. In D11148#221135 , @broulik wrote: > Well, the package definition says JS files must (should) be in "code", I don't see the advantage of moving this. That would the be another place to fix. Motivation for

D11148: Move applet packages' /code subdirs below /ui subdirs

broulik added a comment. Well, the package definition says JS files must (should) be in "code", I don't see the advantage of moving this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11148 To: kossebau, #plasma, mart, broulik, hein Cc: plasma-devel,

D11148: Move applet packages' /code subdirs below /ui subdirs

kossebau created this revision. kossebau added reviewers: Plasma, mart, broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As there are quite a bit QML files in the

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

davidedmundson added a comment. > interest to other apps as well, which can't yet rely on Qt 5.11 The 5.11 changes are about runtime Qt, not any new API. Apps will have to do nothing. The app itself can still rely on Qt5.0. - We discussed in the meeting, I still think

D11145: Merge applet packages' /code subdirs into /ui subdirs

kossebau created this revision. kossebau added reviewers: Plasma, mart, broulik. Restricted Application added a project: Plasma. kossebau requested review of this revision. REVISION SUMMARY As there are only a few QML files in the respective /ui subdir, having the JS file in the same dir

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#221084 , @romangg wrote: > Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push. Let's be realistic. Many applications we ship don't

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push. REPOSITORY R120 Plasma Workspace BRANCH platform-detection

Re: plasma-desktop-5.12.3 bug report

Hi David, Bug reports are submitted using Bugzilla, not email. See: - https://bugs.kde.org/ - https://community.kde.org/Get_Involved/Bug_Reporting Nate On 03/07/2018 02:02 AM, David Binderman wrote: Hello there, plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error)

D11144: Merge applet packages' /code subdirs into /ui subdirs

kossebau created this revision. kossebau added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As there are only a few QML files in the respective /ui

Re: Plasma 5.12.3

Updating now :) On Tue, Mar 6, 2018 at 3:39 PM, Jonathan Riddell wrote: > Plasma 5.12.3 bug fix release is available now for packagers > > https://www.kde.org/announcements/plasma-5.12.3.php >

plasma-desktop-5.12.3 bug report

Hello there, plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error) Memory leak: oldCorr Source code is if ( ::ioctl(fd, JSIOCGCORR, oldCorr) == -1 ) { ::close(fd); delete [] oldCorr; return JoyDevice::ERR_GET_CORR; } if (bt < 0) { return

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#220991 , @romangg wrote: > Shouldn't this function go directly in KWayland as some utily function `xdgSessionToQpaPlatform`? I believe it's generic enough for that and even though Qt 5.11 will have detection

D11142: Add ConnectionCheck for Dash Cards

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Check if there is an internet connection available before displaying

D11142: Add ConnectionCheck for Dash Cards

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:7a9795631062: Add ConnectionCheck for Dash Cards (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration

D1230: GBM remote access support for KWin

Kanedias marked 2 inline comments as done. Kanedias added a comment. @romangg , I had to recreate it after rebase, cause I don't have force-push. REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg,

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 28973. Kanedias added a comment. Review comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=25979=28973 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Please import the context. This makes reviews more easy. Either via -U9 flag to git diff or (for future diffs) by using arc directly on a feature branch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin,

D1230: GBM remote access support for KWin

romangg added a comment. Pls remove the whitespace and rebase your branch on current master (it merges without conflict). INLINE COMMENTS > drm_backend.cpp:793 > } > + rm whitespace REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To:

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg added a comment. Shouldn't this function go directly in KWayland as some utily function `xdgSessionToQpaPlatform`? I believe it's generic enough for that and even though Qt 5.11 will have detection for QT_QPA_PLATFORM the function could be of interest to other apps as well, which

D11009: Make passiveNotifications last longer, so users can actually read them

ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11009 To: ngraham, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. Not so sure why phabricator didn't set you as the commit author... sorry about that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot,

D11061: Migration request from IBusConfig to GSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e2a29f8ea072: Migration request from IBusConfig to GSettings (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28920=28964

D11009: Make passiveNotifications last longer, so users can actually read them

ngraham updated this revision to Diff 28965. ngraham added a comment. Rebase on master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11009?vs=28534=28965 BRANCH longer-lasting-passiveNotifications (branched from master) REVISION DETAIL

D11134: ToolbarApplicationHeader layout

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2e7ec021ad0e: ToolbarApplicationHeader layout (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11134?vs=28960=28963#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11134: ToolbarApplicationHeader layout

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Units.qml:101 > > -readonly property QtObject __styleItem: QtQuickControlsPrivate.StyleItem > {elementType: "frame" } > +//readonly property QtObject

D11134: ToolbarApplicationHeader layout

ngraham added a comment. +1, this is a huge visual improvement in my eyes. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11134 To: mart, #kirigami Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8827: experimental support for auto mnemonics

apol added a comment. Big +1, missed it earlier. Won't upstream QQC2 come up with something in this regard? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8827 To: mart, #plasma Cc: apol, hein, broulik, plasma-devel, ZrenBot,

D11134: ToolbarApplicationHeader layout

mart updated this revision to Diff 28960. mart edited the summary of this revision. mart added a comment. - paddings fixes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11134?vs=28956=28960 BRANCH phab/toolbartweak REVISION DETAIL

D11134: some layouting tweaks

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REPOSITORY R169 Kirigami BRANCH phab/toolbartweak REVISION DETAIL https://phabricator.kde.org/D11134 AFFECTED

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 28954. mart added a comment. - kirigami 2.3 needed REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=28926=28954 BRANCH arcpatch-D8827 REVISION DETAIL

D11133: Fix minimise all applet on wayland with an active window

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There's an async round trip after requesting

D11059: Add convenience method to get a persistent model index from TasksModel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:290ee95dacdf: Add convenience method to get a persistent model index from TasksModel (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11059?vs=28720=28947#toc

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

This revision was automatically updated to reflect the committed changes. Closed by commit R114:be06f0b74073: Allow users to change the format to BCD (decimal) in Binary Clock widget (authored by piotrkakol, committed by davidedmundson). CHANGED PRIOR TO COMMIT

D11131: [plasmashell] Set Qt::AA_UseHighDpiPixmaps

This revision was automatically updated to reflect the committed changes. Closed by commit R120:70f8f197c79a: [plasmashell] Set Qt::AA_UseHighDpiPixmaps (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11131?vs=28940=28944

D11131: [plasmashell] Set Qt::AA_UseHighDpiPixmaps

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We currently do not support Qt scaling in

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol added a comment. I was instructed to give my contact details that will be included in the commit message. Piotr Kąkol piotrka...@pm.me REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol, davidedmundson Cc: davidedmundson,

D1230: GBM remote access support for KWin

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich,

D11126: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists

kossebau added a comment. I am slightly confused though as for me kded still seems to load the kded module anyway, as the current code in kded only checks the platform on preloading, but not later. Is that really on purpose? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11126: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY kded currently fails to handle list values set for

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 28926. mart added a comment. - Merge branch 'master' into arcpatch-D8827 - better shortcut management for MenuItem REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=22409=28926 BRANCH

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In D10297#220548 , @rkflx wrote: > In D10297#220547 , @gregormi wrote: > > > Some people from Plasma reviewed the original review request on reviewboard. Should we add

D11061: Migration request from IBusConfig to GSettings

fujiwara updated this revision to Diff 28920. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28881=28920 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara,

D7087: Add "Copy Info" button to the About System KCM

rkflx added a comment. In D7087#220623 , @gregormi wrote: > By the way, on Netrunner's Plasma the About System dialog looks like this:

D7087: Add "Copy Info" button to the About System KCM

gregormi added a comment. In D7087#207306 , @rkflx wrote: > In D7087#207286 , @dhaumann wrote: > > > In fact, I wonder whether there already is a script or similar helper tools that give you this kind

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. In D10297#220547 , @gregormi wrote: > Some people from Plasma reviewed the original review request on reviewboard. Should we add some more reviewers before it can go in? Only looked at it briefly, but I did not

Re: Fwd: Re: kwin display issue on librem5

On martedì 6 marzo 2018 17:47:39 CET Martin Flöser wrote: > > also note that kwayland is part of KDE frameworks, so hopefully at > > least > > kwayland patch will be included in Next month's KDE Frameworks 5.45 > > release. > > Given that this seems to fix a severe bug, we could consider to

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In D10297#207127 , @rkflx wrote: > Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For KSysGuard

D11056: [mediacontroller applet] Use media playback status icons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:04dc4c9d2217: [mediacontroller applet] Use media playback status icons (authored by romangg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11056: [mediacontroller applet] Use media playback status icons

romangg updated this revision to Diff 28906. romangg added a comment. - Also change tooltip icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11056?vs=28902=28906 BRANCH mediaAppletStatusIcon REVISION DETAIL

D11056: [mediacontroller applet] Use media playback status icons

broulik added a comment. Can you please also update the tooltip REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma, andreask, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11056: [mediacontroller applet] Use media playback status icons

romangg updated this revision to Diff 28902. romangg added a comment. Rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11056?vs=28713=28902 BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056

D11061: Migration request from IBusConfig to GSettings

xuetianweng added inline comments. INLINE COMMENTS > panel.cpp:922 > +impanel_update_engines(impanel, var_engines); > +if (var_engines) > +g_variant_unref(var_engines); https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces Always use braces > panel.cpp:933 > +

D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28892. romangg added a comment. - Minor changes proposed by Kai REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28889=28892 BRANCH mediaAppletStructure REVISION DETAIL

Phabricator Notification Mails

Hi all, It has been brought to my attention that some find that they are receiving too much mail or other notifications from Phabricator. For those who are unaware there are numerous options available within Phabricator to allow you to control how much it notifies you of changes. To customise

D11063: [mediacontroller applet] Reorder elements

broulik accepted this revision. broulik added a comment. Go go go :) INLINE COMMENTS > ExpandedRepresentation.qml:174 > > -ColumnLayout { > -Layout.fillWidth: true > -spacing: units.smallSpacing / 2 > - > -PlasmaExtras.Heading { >

D11063: [mediacontroller applet] Reorder elements

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d511a766779b: [mediacontroller applet] Reorder elements (authored by romangg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28892=28895

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28893. zzag added a comment. take scaling factor into account REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28874=28893 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11109: [Notifications] Remove NoAccessNetworkAccessManagerFactory

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With shared QML engine this would affect all applets and since we

D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28889. romangg added a comment. Rebased on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28816=28889 BRANCH mediaAppletStructure REVISION DETAIL https://phabricator.kde.org/D11063

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel updated this revision to Diff 28886. Pitel added a comment. Moving appmenu instead of window title. REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11065?vs=28738=28886 BRANCH realign REVISION DETAIL