D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

ngraham added a comment. Maybe we need to stay back and get specific about what we're trying to support with the ability to drag-and-drop apps from the Task manager. Then we can figure whether or not that's actually valuable for our users, and if so, what's the best way to provide it while

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html So until and unless we can change Libinput itself, this has to stay as a radio button. REPOSITORY R119 Plasma Desktop

D13123: Make .deb and .rpm mime type handling optional at build time

This revision was automatically updated to reflect the committed changes. Closed by commit R134:0e851f2b6899: Make .deb and .rpm mime type handling optional at build time (authored by arojas). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D13123: Make .deb and .rpm mime type handling optional at build time

arojas added a comment. In D13123#269385 , @mak wrote: > Checking for the dpkg and rpm binaries isn't really foolproof, because you can install rpm on Debian and dpkg on Fedora & Co. easily. > The only issue proof thing that I can imagine

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

davidedmundson added a comment. Question/alternative proposal as I don't like any regressions. The main problem is we have a data under the mimetype text/url which is why apps keep processing it. We use this data for drag and drop to pins/desktop but couldn't data that be under a

D13123: Make .deb and .rpm mime type handling optional at build time

mak added a comment. Checking for the dpkg and rpm binaries isn't really foolproof, because you can install rpm on Debian and dpkg on Fedora & Co. easily. The only issue proof thing that I can imagine would be checking for the distribution name in /etc/os-release, or maybe checking for the

D13123: Make .deb and .rpm mime type handling optional at build time

apol added a comment. 5.13 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13123 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

arojas added a comment. 5.13 or master? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13123 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

davidedmundson added a comment. Please don't link to reddit. We do not do development on social media. Is it necessary to drop the distance threshold? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: davidedmundson, plasma-devel,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269312 , @esedgh wrote: > Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. > > But now that you're at it, I may give you a bit of feedback

D13141: Touchpad KCM Redesign Using Kirigami

esedgh added a comment. Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. But now that you're at it, I may give you a bit of feedback in here. Touchpad settings has "Two Finger Scrolling" and "Edge Scrolling" as a radio

D12937: Drop privileges when reading the salt file

dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:750 > It's a different process, that's why we're using pipes, i don't really want > to go into shared process memory for something as simple as this. I'm talking about the salt variable, which is returned from this

D12937: Drop privileges when reading the salt file

aacid added inline comments. INLINE COMMENTS > dakon wrote in pam_kwallet.c:750 > There can't happen anything too bad here I guess, the read() will just fail > or crash. > > I wonder if we should not get rid of this alltogether and just pass in a > stack buffer from the caller, this would

D12937: Drop privileges when reading the salt file

dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:750 > it's not a bug > > the code works and will work 100% of times, pretending malloc fails is nice > from a teoretical point of view, but it's not going to happen, if you're > going to block me on this i will make

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This prevents the user from accidentally dragging a `.desktop` file into their browser. BUG: 390034

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. In D13148#269205 , @davidedmundson wrote: > This doesn't achieve anything useful. It does for projects that have their own build system. > You're not changing any dependencies as you still link

D7087: Add "Copy Info" button to the About System KCM

rkflx added inline comments. INLINE COMMENTS > dhaumann wrote in Module.cpp:253 > The reason for this is that in a right-to-left language, you would translated > "%1 %2" by using the reverse, e.g. "%2 %1". The problem here is that a > translator will not know what to do with this. So what

D13148: Allow Kirigami build without KWin tablet mode dependency

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This doesn't achieve anything useful. You're not changing any dependencies as you still link against DBus as CMake is unchanged in this patch. Code

D11848: [Kickoff] Reduce hover delay before switching tabs

rkflx added a comment. @ngraham Are you sure the Kicker menu has a triangle filter at all? I don't think it has, making your video a bad example (or am I wrong?). Try comparing with a QWidget based menu, which for me is much easier to operate than Kicker or Kickoff with your patch. And

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. Looks pretty good to me already. Is there anything that needs to be addressed? What do you think about i18nc? INLINE COMMENTS > rkflx wrote in Module.cpp:253 > @dhaumann I wonder why you suggested to use `i18n` here too, as `text()` > should already give you the

D12937: Drop privileges when reading the salt file

aacid added inline comments. INLINE COMMENTS > dakon wrote in pam_kwallet.c:750 > I don't see a benefit in introducing new bugs just to keep a style. And if > the code does it right at some places this one should also just start right. it's not a bug the code works and will work 100% of

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Message received and understood. Sorry for jumping the gun. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. Henrik, if you move your cursor that slowly, even a triangle menu filter won't help you. Try such a slow speed with any other sub-menu paradigm. If I move my cursor as slowly as you depict in your video in Kicker or a sub-menu in one of our apps, I get the same

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes created this revision. murillobernardes added a reviewer: mart. murillobernardes added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. murillobernardes requested review of this revision. REVISION SUMMARY Even on linux it might be the case to not

D13141: Touchpad KCM Redesign Using Kirigami

knambiar added a comment. > - "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click" > - "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click" May be clearer to use: “Two tap right, three middle” → “Tap two

D12937: Drop privileges when reading the salt file

dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:730 > I can check the return code but does it matter? we'll write into the pipe > anyway, be it 0 or whatever we read, if it's not the correct stuff the other > process will fail anyway so i don't really see the need

D13122: Add second line of text for KickerDash item descriptions

hein added a comment. I'm fine with this, but yes, in the future it's a good idea to wait for maintainer review, or e.g. one VDG and one "code monkey" review - we do a bad job communicating who "needs" to approve though so it's not really on you, and I'm OK with erring on the side of work

D13100: do not use buffered file IO

aacid added a comment. have you tried this? because i have just tried it and it failed. Aren't you missing a O_CREAT ? REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13100 To: dakon, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D11848: [Kickoff] Reduce hover delay before switching tabs

rkflx added a comment. > This patch reduces it to 50ms, which is low enough to make switching feel instantaneous, but still high enough to prevent accidental tab switching when moving the mouse diagonally and clipping another button. I'm not sure if the patch is working right for me?

D12937: Drop privileges when reading the salt file

aacid added inline comments. INLINE COMMENTS > dakon wrote in pam_kwallet.c:749 > please use WIFEXITED and WEXITSTATUS here. The compiler is free to optimize > that into a simple compare if that's what it is, but you are now relying on > an implementation detail of that status code. we're

D12937: Drop privileges when reading the salt file

aacid updated this revision to Diff 34956. aacid marked 7 inline comments as done. aacid added a comment. review comments REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12937?vs=34334=34956 BRANCH arcpatch-D12937 REVISION DETAIL

D12937: Drop privileges when reading the salt file

aacid added inline comments. INLINE COMMENTS > dakon wrote in pam_kwallet.c:730 > Check return code. I would prefer to use open()/read()/close() directly, but > that can be seen as a matter of personal preferences. I can check the return code but does it matter? we'll write into the pipe

Re: Closing old Plasma 4 bugs

On Fri, May 11, 2018 at 11:06 PM Christoph Feck wrote: > On 11.02.2018 20:52, Nate Graham wrote: > > All right, so let's give it a shot. How about we make it so that normal > > users have full privilages except the following: > > > > - Can't bulk change > > - Can't change

D13141: Touchpad KCM Redesign Using Kirigami

abetts added a comment. In D13141#268862 , @ngraham wrote: > As for wanting to making this non-scrollable: in general, we should aspire for the main views of our KCMs to never require scrolling (subviews like tables are okay, of course). It's