I went with option C. The change is committed and ready for review:
http://poe.svn.sourceforge.net/viewvc/poe?view=rev&revision=2613
The commit message reads:
!!! This change breaks backward compatibility on a relatively unused
!!! feature. You are affected if you use ARG0 or ARG1 in a
!!! POE
Euh, well, I was meaning option A.
But either A or C is good for me.
Option B is too awkward as a bad API would stay forever and would bite any
new Server::TCP user.
Le 21 juillet 2009 12:37, Olivier Mengué a écrit
:
>
>
> 2009/7/16 Chris 'BinGOs' Williams
>
>> Anyways, I see three options:
>
2009/7/16 Chris 'BinGOs' Williams
> Anyways, I see three options:
>
> a). Make the functionality match the documentation;
>
> b). Make the documentation match the functionality;
>
> c). Do what dngor suggests and flatten ClientArgs, forget the socket
>and document as such.
>
> Cheers,
>
As a
On Jul 16, 2009, at 07:06, Chris 'BinGOs' Williams wrote:
First off, thanks for all the patches, I've applied them all apart
from this one.
Yes, thank you for the patches, Mark. You're improving POE. And
thanks, Chris, for reviewing and applying them. You're accelerating
the improvement
Most people want access to the raw socket to condition it before it's
passed to POE::Wheel::ReadWrite. ClientConnected is a bit late for
this. As Chris Williams mentioned, by the time ClientConnected is
called, the socket has been conditioned and $_[HEAP]{client} is ready
for action.
Th
Chris 'BinGOs' Williams wrote:
On Thu, Jul 16, 2009 at 12:59:09PM +0100, Ed W wrote:
Nick Williams wrote:
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in t
On Thu, Jul 16, 2009 at 12:59:09PM +0100, Ed W wrote:
> Nick Williams wrote:
> >Regarding the passing of the socket into clientconnected - I've wished for
> >this in the past, in order to be able to modify TCP options on the socket,
> >which didn't seem possible in the past... It would be nice if t
Nick Williams wrote:
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in the past... It would be nice if that was
possible to get at this (either via some available API
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in the past... It would be nice if that was
possible to get at this (either via some available API which I just haven't
no
On Wed, Jul 15, 2009 at 06:59:12PM -0800, Michael Fowler wrote:
> On Wed, Jul 15, 2009 at 04:08:48AM -0400, Rocco Caputo wrote:
> > For starters, $_[ARG0] isn't guaranteed to contain anything in particular.
>
> Well, it's guaranteed to contain whatever was passed as the 'args'
> argument to the PO
On Wed, Jul 15, 2009 at 11:18:03PM -0400, sungo wrote:
> Perhaps I'm misreading... What I'm hearing is "you should change this
> for me, regardless of whether it breaks other people's code". Is that an
> accurate summary?
No. That was in response to expanding ClientArgs into ARG0..$#_. I'm
sugge
On (07/15 18:59), Michael Fowler wrote:
> The code I have that actually needs it would benefit from the clarity of
> having the socket passed as ARG0. Whether or not this breaks some
> possible future change in something...
Perhaps I'm misreading... What I'm hearing is "you should change this
fo
On Wed, Jul 15, 2009 at 04:08:48AM -0400, Rocco Caputo wrote:
> For starters, $_[ARG0] isn't guaranteed to contain anything in particular.
Well, it's guaranteed to contain whatever was passed as the 'args'
argument to the POE::Session constructor, right? When the session is
constructed, 'args' is
On Jul 14, 2009, at 02:16, Michael Fowler wrote:
http://rt.cpan.org/Ticket/Display.html?id=47855
47855 requires a bit of discussion.
The problem is that the ClientConnected callback does not actually
receive a socket in ARG0. ARG0 has been spliced off in the
POE::Wheel::ReadWrite construct
Greetings,
During the course of writing a tutorial I've been noticing discrepancies
between POE::Component::Server::TCP's documentation and code. I have
filed some initial tickets:
http://rt.cpan.org/Ticket/Display.html?id=47855
http://rt.cpan.org/Ticket/Display.html?id=47854
http://
15 matches
Mail list logo