[Pywikipedia-bugs] [Maniphest] [Commented On] T354474: API requests when processing pages with XMLDumpPageGenerator

2024-01-06 Thread Mpaa
Mpaa added a comment. It seems OK to me how it is checked today, it is checked via template checking and I did not see reference to current text. I do not understand why it is checked there, as it is also checked in page.save(). It seems redundant to me, but maybe there is some edge

[Pywikipedia-bugs] [Maniphest] [Created] T354474: API requests when processing pages with XMLDumpPageGenerator

2024-01-06 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **Steps to replicate the issue**: - iterate pages with XMLDumpPageGenerator() **What happens?**: For each page an API request is done

[Pywikipedia-bugs] [Maniphest] [Edited] T354095: xmlreader might fail

2023-12-29 Thread Mpaa
Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T354095 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, mevo, Isabelladantes1983, Themindcoder, Adamm71, Jersione

[Pywikipedia-bugs] [Maniphest] [Created] T354095: xmlreader might fail

2023-12-29 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION See https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.iterparse > Note > > iterparse() only g

[Pywikipedia-bugs] [Maniphest] [Commented On] T228335: multiple matches order of _code_fam_from_url depends on Python version

2023-12-16 Thread Mpaa
Mpaa added a comment. @xqt, since now pywikibot supports only >= 3.7 this can be closed., right? TASK DETAIL https://phabricator.wikimedia.org/T228335 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Dvorapa, Aklapper, Dalba,

[Pywikipedia-bugs] [Maniphest] [Closed] T258036: Pywikibot CategorizedPageGenerator yields more files than present in category

2023-12-16 Thread Mpaa
Mpaa closed this task as "Resolved". Mpaa claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T258036 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Aklapper, pywikibot-bugs-list, Eatcha, mevo, PotsdamLamb

[Pywikipedia-bugs] [Maniphest] [Commented On] T258036: Pywikibot CategorizedPageGenerator yields more files than present in category

2023-12-16 Thread Mpaa
Mpaa added a comment. After adding lazy load of metadata in T253591 <https://phabricator.wikimedia.org/T253591> I get the same number in petscan, category in commons and script. I'll close it for now, to be reopened in case. TASK DETAIL https://phabricator.wikimedia.org/T258036

[Pywikipedia-bugs] [Maniphest] [Commented On] T353387: Suggest installing requests_oauthlib instead of throwing NoUsernameError

2023-12-15 Thread Mpaa
Mpaa added a comment. There is an error, but it almost invisible due to the long traceback: ERROR: OAuth authentication not supported: No module named 'requests_oauthlib' I think an exception should be raised here: https://github.com/wikimedia/pywikibot/blob/master/pywikibot/comms

[Pywikipedia-bugs] [Maniphest] [Commented On] T281633: [dev] pre-commit for linting and code formatting

2023-12-03 Thread Mpaa
Mpaa added a comment. @JJMC89 do you have updates about this? e.g. a new .pre-commit-config.yaml? TASK DETAIL https://phabricator.wikimedia.org/T281633 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Rubin16, valhallasw, Xqt

[Pywikipedia-bugs] [Maniphest] [Commented On] T352606: Cannot run tests vs sites where oauth is configured in user-config.py

2023-12-02 Thread Mpaa
Mpaa added a comment. I think that here we could use apipath, as the goal should to check only that the site is online. if 'hostname' not in data and 'site' in data: # Ignore if the family has defined this as # obsolete without a mapping to a hostname

[Pywikipedia-bugs] [Maniphest] [Created] T352606: Cannot run tests vs sites where oauth is configured in user-config.py

2023-12-02 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **Steps to replicate the issue** (include links if applicable): - configure to use oauth for the site used for tests (e.g. en.wikisource

[Pywikipedia-bugs] [Maniphest] [Updated] T352482: APIError: Petscan: No result for source categories

2023-12-02 Thread Mpaa
Mpaa added a comment. I think this now fails because on my request to delete "Category:Pywikibot Protect Test" in T352560 <https://phabricator.wikimedia.org/T352560>, the category has now been removed also from: User:Sn1per/ProtectTest1 User:Sn1per/ProtectT

[Pywikipedia-bugs] [Maniphest] [Triaged] T352560: doctests failing for Category.articles and Category.members

2023-12-01 Thread Mpaa
Mpaa triaged this task as "Unbreak Now!" priority. TASK DETAIL https://phabricator.wikimedia.org/T352560 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Aklapper, pywikibot-bugs-list, JJMC89, mevo, PotsdamLamb, Jyoo1011, Jo

[Pywikipedia-bugs] [Maniphest] [Commented On] T352560: doctests failing for Category.articles and Category.members

2023-12-01 Thread Mpaa
Mpaa added a comment. @JJMC89 This is my fault. There was an issue with a PetScan test and I thought it was due to this category not being present: Category:Pywikibot Protect Test so I created it. It shall be deleted at https://test.wikipedia.org/wiki

[Pywikipedia-bugs] [Maniphest] [Created] T348910: Replace deprecated inprop=preload with preloadcontent

2023-10-14 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **Steps to replicate the issue** (include links if applicable): import pywikibot import pywikibot.proofreadpage as pp site

[Pywikipedia-bugs] [Maniphest] [Commented On] T335720: Site() can request info unnecessarily

2023-05-04 Thread Mpaa
Mpaa added a comment. In T335720#8825687 <https://phabricator.wikimedia.org/T335720#8825687>, @Xqt wrote: > The problem is that the pop default is evaluated even if it is not needed: > > x = {'foo': 'bar'} > def baz(): print('quez') > > x.pop(

[Pywikipedia-bugs] [Maniphest] [Commented On] T323851: Timestamp.fromtimestampformat() class method is failing

2022-11-27 Thread Mpaa
Mpaa added a comment. Weird. Could you give an example where MW outputs a timestamp on 12 digits? See https://www.mediawiki.org/wiki/Manual:WfTimestamp TASK DETAIL https://phabricator.wikimedia.org/T323851 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Commented On] T319132: Match.group and Match.__getitem__(g) do not raise the same Exception

2022-10-01 Thread Mpaa
Mpaa added a comment. A lot of files have been changed by https://gerrit.wikimedia.org/r/c/pywikibot/core/+/836138. This might occur somewhere else. TASK DETAIL https://phabricator.wikimedia.org/T319132 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Created] T319132: Match.group and Match.__getitem__(g) do not raise the same Exception

2022-10-01 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **Steps to replicate the issue** (include links if applicable): import re text = 'abcd' pat = re.compile('z') m = pat.search(text

[Pywikipedia-bugs] [Maniphest] [Closed] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T316976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Soda, Inductiveload, Aklapper, pywikibot-bugs-list, Mpaa, PotsdamLamb, Bebiezaza

[Pywikipedia-bugs] [Maniphest] [Commented On] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa added a comment. In T316976#8209768 <https://phabricator.wikimedia.org/T316976#8209768>, @Soda wrote: > @Mpaa `prppiilimit` was recently removed as a result of T314022 <https://phabricator.wikimedia.org/T314022>, I'm guessing pywikibot hasn't been update

[Pywikipedia-bugs] [Maniphest] [Commented On] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa added a comment. I cleared pywikibot chache and now they are aligned. In [3]: site._paraminfo['query+proofreadpagesinindex']['parameters'] Out[3]: [{'index': 1, 'name': 'prop', 'type': ['ids', 'title'], 'default': 'ids|title', 'multi

[Pywikipedia-bugs] [Maniphest] [Commented On] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa added a comment. API query: URI: '/w/api.php' Body: 'prppiititle=Index%3AConfederate+Military+History+-+1899+-+Volume+4.djvu=proofreadpagesinindex=query===500=userinfo=blockinfo%7Chasmsg=5=json' TASK DETAIL https://phabricator.wikimedia.org/T316976 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa added a subscriber: Inductiveload. Mpaa added a comment. Pinging @Inductiveload, which might help on API side. TASK DETAIL https://phabricator.wikimedia.org/T316976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Inductiveload

[Pywikipedia-bugs] [Maniphest] [Created] T316976: Wrong paraminfo for query+proofreadpagesinindex

2022-09-03 Thread Mpaa
Mpaa created this task. Mpaa added projects: Pywikibot, ProofreadPage. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **Steps to replicate the issue**: import pywikibot import pywikibot.proofreadpage as pp site = pywikibot.Site('en

[Pywikipedia-bugs] [Maniphest] [Commented On] T205155: unconnected_pages generator doesn't seem to return all pages

2022-08-18 Thread Mpaa
Mpaa added a comment. In T205155#4845859 <https://phabricator.wikimedia.org/T205155#4845859>, @Mpaa wrote: > I do not know what sets the limit of 1 in the API. See https://github.com/wikimedia/mediawiki/blob/0ffef1bb1b3e7de3463552b91549de63a558d4f6/includes/sp

[Pywikipedia-bugs] [Maniphest] [Closed] T302496: archivebot.py didn't archive thread whose sign warp in a element

2022-08-10 Thread Mpaa
Mpaa closed this task as "Resolved". Mpaa claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T302496 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Ericliu1912, Xqt, Aklapper, Stang, pywikibot-bugs-list, Su

[Pywikipedia-bugs] [Maniphest] [Commented On] T302496: archivebot.py didn't archive thread whose sign warp in a element

2022-08-09 Thread Mpaa
Mpaa added a comment. | style="vertical-align:middle; padding-left:20px;" | '''新年快樂!'''感謝您過去一年來對中文維基百科的貢獻!祝閣下[[新年]]快樂,萬事如意!—— '''[[使用者:Ericliu1912|Eric Liu]]''' 創造は生命('''[[使用者討論:Ericliu1912|留言]].[[使用者:Ericliu1912#訪客芳名錄|留名]].[[維基百科:維基學生會|學生會]]''') 2022年1月31日 (一) 18:48 (UTC){{colo

[Pywikipedia-bugs] [Maniphest] [Closed] T313736: Content parameter in page.template() has no effect if page templates are cached

2022-08-09 Thread Mpaa
Mpaa closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T313736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstr

[Pywikipedia-bugs] [Maniphest] [Updated] T241689: Preloading the categories of a set of pages

2022-07-28 Thread Mpaa
Mpaa added a comment. See T67163 <https://phabricator.wikimedia.org/T67163> TASK DETAIL https://phabricator.wikimedia.org/T241689 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Xqt, Dvorapa, Aklapper, Erutuon, valh

[Pywikipedia-bugs] [Maniphest] [Retitled] T313736: Content parameter in page.template() has no effect if page templates are cached

2022-07-25 Thread Mpaa
Mpaa renamed this task from "Content parameter has no effect if page templates are cached" to "Content parameter in page.template() has no effect if page templates are cached". TASK DETAIL https://phabricator.wikimedia.org/T313736 EMAIL PREFERENCES https://phabr

[Pywikipedia-bugs] [Maniphest] [Edited] T313736: Content parameter has no effect if page templates are cached

2022-07-25 Thread Mpaa
Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck

[Pywikipedia-bugs] [Maniphest] [Created] T313736: Content parameter has no effect if page templates are cached

2022-07-25 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION When page templates are already cached, content parameter has no effect. page._templates might be created also when page is preloaded

[Pywikipedia-bugs] [Maniphest] [Commented On] T308016: Ql filter attempts to process 'non-standard' titles for pages with Proofread-page content model...

2022-05-14 Thread Mpaa
Mpaa added a comment. In T308016#7919265 <https://phabricator.wikimedia.org/T308016#7919265>, @ShakespeareFan00 wrote: > However, it does make me wonder if there is a need for the filter to be more robust about how it processes titles that aren't in the standa

[Pywikipedia-bugs] [Maniphest] [Retitled] T308266: Use random.choices() instead of random.shuffle() in site_tests.py

2022-05-13 Thread Mpaa
Mpaa renamed this task from "Use random.choises() instead of random.shuffle() in site_tests.py" to "Use random.choices() instead of random.shuffle() in site_tests.py". Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T308266 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T308266: Use random.choises() instead of random.shuffle() in site_tests.py

2022-05-12 Thread Mpaa
Mpaa added a comment. random.choices() creates a list with replacements, so you might have duplicates. random.sample() maybe? TASK DETAIL https://phabricator.wikimedia.org/T308266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa

[Pywikipedia-bugs] [Maniphest] [Commented On] T308016: Incompatible -ql and -grep filter options for listpages.py...

2022-05-10 Thread Mpaa
Mpaa added a comment. This is not a standard way of working with Proofread pages, and to handle it it would create several inconveniences (e.g. how many pages will have the related index? etc.) Before acting on pywikibot, there should be an agreement in the wikisource world

[Pywikipedia-bugs] [Maniphest] [Commented On] T307830: tools.ThreadList.stop_all() leads to AttributeError

2022-05-07 Thread Mpaa
Mpaa added a comment. In T307830#7911218 <https://phabricator.wikimedia.org/T307830#7911218>, @Xqt wrote: > @Mpaa: I am unsure how to proceed. We could > > - keep the current implementation and add a warning to our documentation that the Thread object hast

[Pywikipedia-bugs] [Maniphest] [Commented On] T307280: API:Links sometimes miss pages in Page namespace (104)

2022-04-30 Thread Mpaa
Mpaa added a comment. In T307280#7893596 <https://phabricator.wikimedia.org/T307280#7893596>, @gerritbot wrote: > Change 787876 had a related patch set uploaded (by Mpaa; author: Mpaa): > > [pywikibot/core@master] [IMPR]: make IndexPage more robust when getting l

[Pywikipedia-bugs] [Maniphest] [Updated] T307280: API:Links sometimes miss pages in Page namespace (104)

2022-04-30 Thread Mpaa
Mpaa added a project: MediaWiki-Action-API. TASK DETAIL https://phabricator.wikimedia.org/T307280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69

[Pywikipedia-bugs] [Maniphest] [Retitled] T307280: API:Links sometimes miss pages in Page namespace (104)

2022-04-30 Thread Mpaa
Mpaa renamed this task from "Improve robustnesss when getting pages linked to IndexPage" to "API:Links sometimes miss pages in Page namespace (104)". Mpaa added a project: ProofreadPage. Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T30728

[Pywikipedia-bugs] [Maniphest] [Created] T307280: Improve robustnesss when getting pages linked to IndexPage

2022-04-30 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION For unknown reasons(*) , sometimes getting pages in Page ns connected to the respective Index page via https://en.wikisource.org/w/api.php?action

[Pywikipedia-bugs] [Maniphest] [Commented On] T301800: FilePage.get_file_history() returns a dict with timestamp as key but all scripts expect a sequence

2022-04-24 Thread Mpaa
Mpaa added a comment. The return type is specified clearly. Scripts that use this function know what to expect and should act accordingly. latest_file_info(self) and oldest_file_info(self) are available for that purpose. I find problematic that someone pop() an item, as the cached

[Pywikipedia-bugs] [Maniphest] [Commented On] T306134: XMLDumpPageGenerator is still not working

2022-04-14 Thread Mpaa
Mpaa added a comment. @Xqt, I think this might be the cause. https://gerrit.wikimedia.org/r/c/pywikibot/core/+/769728 TASK DETAIL https://phabricator.wikimedia.org/T306134 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Mpaa Cc: Mpaa

[Pywikipedia-bugs] [Maniphest] [Commented On] T281633: [dev] pre-commit for linting and code formatting

2022-04-10 Thread Mpaa
Mpaa added a comment. A well documented task. I tried it and it looks nice to me. BTW, I never found a case where the code is changed yet. Will continue using it and see if I encounter one of those cases. TASK DETAIL https://phabricator.wikimedia.org/T281633 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T299806: IndexPage cannot be save if page has categories

2022-01-21 Thread Mpaa
Mpaa added a comment. page.text is: '{{:MediaWiki:Proofreadpage_index_template\n|Type=book\n|Title=\n|Language=en\n|Volume=\n|Author=\n|Translator=\n|Editor=\n|Illustrator=\n|School=\n|Publisher=\n|Address=\n|Year=\n|Key=\n|ISBN=\n|OCLC=\n|LCCN=\n|BNF_ARK=\n|ARC=\n|DOI=\n|Source

[Pywikipedia-bugs] [Maniphest] [Created] T299806: IndexPage cannot be save if page has categories

2022-01-21 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION **List of steps to reproduce** (step by step, including full links if applicable): import pywikibot from pywikibot import proofreadpage

[Pywikipedia-bugs] [Maniphest] [Updated] T299264: replace.py: exceptions in user-fixex.py are not compiled according to 'regex' key in fix

2022-01-14 Thread Mpaa
Mpaa added projects: Pywikibot, Pywikibot-replace.py. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T299264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Updated] T292539: djvutext.py failure => got multiple values for keyword argument 'site'

2021-10-05 Thread Mpaa
Mpaa added a comment. See T292367 <https://phabricator.wikimedia.org/T292367> TASK DETAIL https://phabricator.wikimedia.org/T292539 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Aklapper, pywikibot-bugs-list, Billin

[Pywikipedia-bugs] [Maniphest] [Commented On] T292367: djvutxt.py raising TypeError

2021-10-03 Thread Mpaa
Mpaa added a comment. Probably a regression from I1e89af25a6e606cb6fab6d7d37fb41d6c146261d TASK DETAIL https://phabricator.wikimedia.org/T292367 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa

[Pywikipedia-bugs] [Maniphest] [Created] T292367: djvutxt.py raising TypeError

2021-10-03 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION user@pc:~/python/core {master}$ python scripts/djvutext.py -index:Works_Translated_by_William_Whiston.djvu

[Pywikipedia-bugs] [Maniphest] [Closed] T290400: pagefromfile.py: skip page if content has not changed

2021-09-07 Thread Mpaa
Mpaa closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T290400 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck

[Pywikipedia-bugs] [Maniphest] [Triaged] T290400: pagefromfile.py: skip page if content has not changed

2021-09-06 Thread Mpaa
Mpaa triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T290400 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck

[Pywikipedia-bugs] [Maniphest] [Edited] T290400: pagefromfile.py: skip page if content has not changed

2021-09-05 Thread Mpaa
Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T290400 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor

[Pywikipedia-bugs] [Maniphest] [Created] T290400: pagefromfile.py: skip page if content has not changed

2021-09-05 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION If pages loaded from file have not changed compared to file read from wiki, there is no point in trying to write them. self.put_current

[Pywikipedia-bugs] [Maniphest] [Claimed] T57072: pagegenerators should accept pageids

2020-12-26 Thread Mpaa
Mpaa claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T57072 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Cyberpower678, gerritbot, Legoktm, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs-list, Ladsgroup

[Pywikipedia-bugs] [Maniphest] [Edited] T270051: Unify Http Exceptions across pywikibot?

2020-12-13 Thread Mpaa
Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T270051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi

[Pywikipedia-bugs] [Maniphest] [Triaged] T270051: Unify Http Exceptions across pywikibot?

2020-12-13 Thread Mpaa
Mpaa triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T270051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhali

[Pywikipedia-bugs] [Maniphest] [Created] T270051: Unify Http Exceptions across pywikibot?

2020-12-13 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Sometimes, requests.Exceptions are checked directly and then converted outside http.py (e.g. here <https://github.com/wikimedia/pywikibot/b

[Pywikipedia-bugs] [Maniphest] [Updated] T269503: login.py doesn't work (critical error "due to uncaught exception")

2020-12-12 Thread Mpaa
Mpaa added a comment. In T269503#6671662 <https://phabricator.wikimedia.org/T269503#6671662>, @Xqt wrote: > Really strange: The current wikipedia:it release is '1.36.0-wmf.18' and the response should have `'messagecode'` key. Found this: https://www.mediawiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Mpaa
Mpaa added a comment. According to this test, there are several actions that might emit 'wikibase-api-failed-save' as message. https://github.com/wikimedia/Wikibase/blob/e388e5b69ee0487566d7a8a77196ac0056f49747/repo/tests/phpunit/includes/Api/ApiUserBlockedTest.php Shouldn't

[Pywikipedia-bugs] [Maniphest] [Retitled] T268398: OptionHandler.set_options fails if available_options is overridden in initializer instead as a class attribute

2020-11-22 Thread Mpaa
Mpaa renamed this task from "OptionHandler.set_options fails id available_options is overridden in initializer instead as a class attribute" to "OptionHandler.set_options fails if available_options is overridden in initializer instead as a class attribute".

[Pywikipedia-bugs] [Maniphest] [Commented On] T267762: cannot import name 'httplib' from 'urllib3.response during "pywikibot-core-tox-fasttest-py37-docker"

2020-11-11 Thread Mpaa
Mpaa added a comment. OK, it might be this: https://github.com/urllib3/urllib3/commit/d71c784053dbf53b7cf2511f81232102a6a2ec76#diff-008f01f06c84456177464927734cc849c073b1f3d13bfab947ff812a5b4ac965L27 TASK DETAIL https://phabricator.wikimedia.org/T267762 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T267762: cannot import name 'httplib' from 'urllib3.response during "pywikibot-core-tox-fasttest-py37-docker"

2020-11-11 Thread Mpaa
Mpaa added a comment. Definitely. I tirued to install from scratch: (myenv)user@pc:~/python/work {master}$ python Python 3.8.5 (default, Sep 4 2020, 07:30:14) [GCC 7.3.0] :: Anaconda, Inc. on linux Type "help", "copyright", "credits" or

[Pywikipedia-bugs] [Maniphest] [Commented On] T267762: cannot import name 'httplib' from 'urllib3.response during "pywikibot-core-tox-fasttest-py37-docker"

2020-11-11 Thread Mpaa
Mpaa added a comment. New versions of requests and urllib3 were released today. https://github.com/psf/requests/blob/master/HISTORY.md 2.25.0 (2020-11-11) -- **Improvements** - Added support for NETRC environment variable. (#5643

[Pywikipedia-bugs] [Maniphest] [Created] T267762: cannot import name 'httplib' from 'urllib3.response during "pywikibot-core-tox-fasttest-py37-docker"

2020-11-11 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION See https://integration.wikimedia.org/ci/job/pywikibot-core-tox-fasttest-py37-docker/1535/console The same is valid for py35. 22:24:57

[Pywikipedia-bugs] [Maniphest] [Commented On] T267717: clean_sandbox.py: uncaught exception: TypeError: unsupported operand type(s) for -: 'NoneType' and 'datetime.timedelta'

2020-11-11 Thread Mpaa
Mpaa added a comment. @Xqt shouldn't self.available_options['delay_td'] be accessible also via self.opt.delay_td also after setting a new value? TASK DETAIL https://phabricator.wikimedia.org/T267717 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T261549: -redirectonly pagegenerators option wasn't ported from compat

2020-11-03 Thread Mpaa
Mpaa added a comment. @Xqt, I think this should be implemented as a filter. TASK DETAIL https://phabricator.wikimedia.org/T261549 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Homeboy_445, Strainu, Aklapper, Xqt, pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unassigned] T57072: pagegenerators should accept pageids

2020-10-27 Thread Mpaa
Mpaa removed Mpaa as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T57072 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Cyberpower678, gerritbot, Legoktm, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unassigned] T73646: replace.py: async output messages jumbled with user interaction on main thread

2020-10-27 Thread Mpaa
Mpaa removed Mpaa as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T73646 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Dvorapa, Xqt, Aklapper, gerritbot, Mpaa, JAnD, jayvdb, valhallasw, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Unassigned] T198452: Always enable namespace filtering in QueryGenerator

2020-10-27 Thread Mpaa
Mpaa removed Mpaa as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T198452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: gerritbot, Dvorapa, Mpaa, zhuyifei1999, Aklapper, Xqt, pywikibot-bugs-list, JohnsonLee01

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

2020-10-26 Thread Mpaa
Mpaa added a subscriber: Anomie. Mpaa added a comment. In T132676#6577051 <https://phabricator.wikimedia.org/T132676#6577051>, @Anomie wrote: > In T132676#6575067 <https://phabricator.wikimedia.org/T132676#6575067>, @Mpaa wrote: > >> @Anomie is base64 encode

[Pywikipedia-bugs] [Maniphest] [Updated] T266117: Frequent chunk-too-small errors

2020-10-25 Thread Mpaa
Mpaa closed this task as a duplicate of T132676: Impossible to upload a file that ends with the \r byte using Pywikibot. TASK DETAIL https://phabricator.wikimedia.org/T266117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc

[Pywikipedia-bugs] [Maniphest] [Merged] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

2020-10-25 Thread Mpaa
Mpaa merged a task: T266117: Frequent chunk-too-small errors. Mpaa added a subscriber: AntiCompositeNumber. TASK DETAIL https://phabricator.wikimedia.org/T132676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: AntiCompositeNumber, Fae, Mpaa

[Pywikipedia-bugs] [Maniphest] [Commented On] T266117: Frequent chunk-too-small errors

2020-10-25 Thread Mpaa
Mpaa added a comment. In T266117#6576230 <https://phabricator.wikimedia.org/T266117#6576230>, @Fae wrote: > As my 'personal' work-around, just for UK legislation PDFs that the API flags with chunk-too-small and fails on a second upload, the pdf is trimmed of the final by

[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

2020-10-25 Thread Mpaa
Mpaa added a comment. @Fae, strange, it worked for me, I tried this file and the byte was added. https://commons.wikimedia.org/w/index.php?title=File%3ABritish_Transport_Commission_Act_1949_%28UKLA_1949-29%29.pdf=revision=500900036=500838588 site = pywikibot.Site('commons', 'commons

[Pywikipedia-bugs] [Maniphest] [Commented On] T266117: Frequent chunk-too-small errors

2020-10-25 Thread Mpaa
Mpaa added a comment. @Fae, I proposed a fix/hack at T132676 <https://phabricator.wikimedia.org/T132676>. TASK DETAIL https://phabricator.wikimedia.org/T266117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: AntiCompositeNumber

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

2020-10-23 Thread Mpaa
Mpaa added subscribers: Anomie, Mpaa. Mpaa added a comment. @Anomie is base64 encode supported by api action=upload? TASK DETAIL https://phabricator.wikimedia.org/T132676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Anomie

[Pywikipedia-bugs] [Maniphest] [Commented On] T266117: Frequent chunk-too-small errors

2020-10-22 Thread Mpaa
Mpaa added a comment. I think it is related to T132676 <https://phabricator.wikimedia.org/T132676>, I checked the first file and it ends in '\r'. TASK DETAIL https://phabricator.wikimedia.org/T266117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Pywikipedia-bugs] [Maniphest] [Commented On] T265946: scripts fail with -v option in python3.8

2020-10-21 Thread Mpaa
Mpaa added a comment. btw, I am using Anaconda distribution. TASK DETAIL https://phabricator.wikimedia.org/T265946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Xqt, Aklapper, pywikibot-bugs-list, Mpaa, JohnsonLee01, SHEKH, Dijkstra

[Pywikipedia-bugs] [Maniphest] [Commented On] T266084: Incorrect server time from pywitibot

2020-10-21 Thread Mpaa
Mpaa added a comment. The problem is that with expiry=True a CahcedRequest is called and there True is converted to 1 day def _request(self, **kwargs): """Create a request by forwarding all parameters directly.""" if 'expiry' in kwarg

[Pywikipedia-bugs] [Maniphest] [Closed] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T266000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Xqt, Mpaa, Aklapper, pywikibot-bugs-list, Rubin16, JohnsonLee01, SHEKH, Dijkstra, A

[Pywikipedia-bugs] [Maniphest] [Reopened] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T266000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Mpaa Cc: Mpaa, Aklapper, pywikibot-bugs-list, Rubin16, JohnsonLee01, SHEKH, Dijkstra, A

[Pywikipedia-bugs] [Maniphest] [Commented On] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa added a comment. Seems working, strange. Anyhow I have added Server414Error to the managed exceptions, so the bot won't crash. TASK DETAIL https://phabricator.wikimedia.org/T266000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc

[Pywikipedia-bugs] [Maniphest] [Closed] T265257: Pywikibot ImageTransfer script has features deprecated for 5 years

2020-10-20 Thread Mpaa
Mpaa closed this task as "Resolved". Mpaa claimed this task. Mpaa added a comment. OK, I will mark this as Resolved, shall be reopened if needed. TASK DETAIL https://phabricator.wikimedia.org/T265257 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Pywikipedia-bugs] [Maniphest] [Commented On] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa added a comment. Or better, add another exception handling after line 620 except pywikibot.Server414Error as e: pywikibot.output("Server414Error --> Can't retrieve page {} : {}" .format(ref.url, e)) continue and see what is

[Pywikipedia-bugs] [Maniphest] [Commented On] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa added a comment. Print the url, if possible. Add pywikibot.output(ref.url) f = comms.http.fetch(ref.url, use_fake_user_agent=self._use_fake_user_agent) TASK DETAIL https://phabricator.wikimedia.org/T266000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Commented On] T265257: Pywikibot ImageTransfer script has features deprecated for 5 years

2020-10-20 Thread Mpaa
Mpaa added a comment. @Vicarage, is this solved after the patch? TASK DETAIL https://phabricator.wikimedia.org/T265257 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Xqt, Aklapper, pywikibot-bugs-list, Vicarage, JohnsonLee01

[Pywikipedia-bugs] [Maniphest] [Commented On] T266000: http.py - error_handling_callback

2020-10-20 Thread Mpaa
Mpaa added a comment. Not sure this is a pywikibot error. Could you find out which is the ref.url it is trying to fetch in: f = comms.http.(ref.url, use_fake_user_agent=self._use_fake_user_agent) and post it here? TASK DETAIL https://phabricator.wikimedia.org/T266000 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T265948: pywikibot can't write log file after size >1MB

2020-10-19 Thread Mpaa
Mpaa added a comment. It seems windows-specific, on Ubuntu 18.04 I get: -rw-r--r-- 1 user user 973087 Oct 19 22:39 listpages-bot.2.log -rw-r--r-- 1 user user 956838 Oct 19 22:39 listpages-bot.1.log -rw-r--r-- 1 user user 840062 Oct 19 22:39 listpages-bot.log TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Edited] T265946: scripts fail with -v option in python3.8

2020-10-19 Thread Mpaa
Mpaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T265946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi

[Pywikipedia-bugs] [Maniphest] [Commented On] T265946: scripts fail with -v option in python3.8

2020-10-19 Thread Mpaa
Mpaa added a comment. In PAWS with python3.6 there is no __file__ attribute. @PAWS:~$ python Python 3.6.9 (default, Jul 17 2020, 12:50:27) [GCC 8.4.0] on linux Type "help", "copyright", "credits" or "license" for more

[Pywikipedia-bugs] [Maniphest] [Created] T265946: scripts fail with -v option in python3.8

2020-10-19 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Scripts crash when called with -v option in python 3.8. Cannot say about other versions, except my comment below in **Expected Results

[Pywikipedia-bugs] [Maniphest] [Updated] T265842: http_tests.LiveFakeUserAgentTestCase fails

2020-10-18 Thread Mpaa
Mpaa added a comment. As reference for user agent, this task gives some background: T152075 <https://phabricator.wikimedia.org/T152075> TASK DETAIL https://phabricator.wikimedia.org/T265842 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: M

[Pywikipedia-bugs] [Maniphest] [Created] T265842: http_tests.LiveFakeUserAgentTestCase fails

2020-10-18 Thread Mpaa
Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION This test is SKIPPED in travis. tests/http_tests.py::LiveFakeUserAgentTestCase::test_fetch_with_fake_useragent SKIPPED After

[Pywikipedia-bugs] [Maniphest] [Commented On] T265800: pywikibot sitelinks have changed?

2020-10-17 Thread Mpaa
Mpaa added a comment. https://gerrit.wikimedia.org/r/c/pywikibot/core/+/442169 https://doc.wikimedia.org/pywikibot/master/api_ref/pywikibot.page.html?highlight=sitelink#pywikibot.page.SiteLink TASK DETAIL https://phabricator.wikimedia.org/T265800 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T265715: API error templatedata-invalid-parse: Syntax error in JSON

2020-10-16 Thread Mpaa
Mpaa added a comment. Seems so, could you try ti fix the page and retry? TASK DETAIL https://phabricator.wikimedia.org/T265715 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Aklapper, Kizule, pywikibot-bugs-list, JohnsonLee01

[Pywikipedia-bugs] [Maniphest] [Commented On] T265715: API error templatedata-invalid-parse: Syntax error in JSON

2020-10-16 Thread Mpaa
Mpaa added a comment. I tried to validate the json data on https://jsonlint.com/ Error: Parse error on line 446: ...pe": "string" }, }, "maps": { "cit -^ Expecting 'STRING', got '}' I thin

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T227610: Outdated document on Page.protect method

2020-10-14 Thread Mpaa
Mpaa added subscribers: Xqt, Mpaa. Mpaa added a comment. @xqt I think edit, move, create and upload (and all the process_deprecated_arg) can be removed. There is a FutureWarning since https://github.com/wikimedia/pywikibot/commit/7ddfa6576d1e0b0169f934f96ebc1b0a9b7bab4e#diff

[Pywikipedia-bugs] [Maniphest] [Unassigned] T265257: Pywikibot ImageTransfer script has features deprecated for 5 years

2020-10-12 Thread Mpaa
Mpaa removed Mpaa as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T265257 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Xqt, Aklapper, pywikibot-bugs-list, Vicarage, JohnsonLee01, SHEKH, Dijkstra, Khutuck

  1   2   3   4   5   6   >