Re: [Qemu-devel] [PATCH] target-lm32: fix LOG_DIS operand order

On 12 October 2016 at 18:15, Michael Walle wrote: > The order of most opcodes with immediates was wrong (according to the > reference manual) in the (debug) logging. Additionally, one operand for the > andhi instruction was completly wrong. Fix these. > > Signed-off-by: Michael

Re: [Qemu-devel] [PATCH 06/22] qcow2: add dirty bitmaps extension

On 11.10.2016 14:09, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:46, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Add dirty bitmap extension as specified in docs/specs/qcow2.txt. >>> For now, just mirror extension header into Qcow2 state and check >>>

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

On 11.10.2016 15:11, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 20:54, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved >>> on bdrv_close, using format driver. Format driver should

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

On Wed, Oct 12, 2016 at 03:55:18PM +0200, Claudio Imbrenda wrote: > On 12/10/16 15:15, David Hildenbrand wrote: > >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { > >>> +cpu_single_step(cpu, 0); > > > > This looks suspicious > > why? we set all cpus to single step, since

[Qemu-devel] [PATCH] script/clean-includes: added duplicate #include check

Added script to check duplicate #include entries. This check will scan and print the files in which duplicate #include entries are present. Script might output false postive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

Hi Wei, On 10/12/2016 11:49 AM, Wei Huang wrote: > On 10/11/2016 01:40 PM, Christopher Covington wrote: >> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >> even for the smallest delta of two subsequent reads. >> >> Signed-off-by: Christopher Covington >>

Re: [Qemu-devel] [Qemu-block] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

Kevin Wolf writes: > Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: >> "Daniel P. Berrange" writes: >> >> > The traditional CLI arg syntax allows two ways to specify >> > integer lists, either one value per key, or a range of >> > values per

Re: [Qemu-devel] [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address offset

Am 10.10.2016 um 17:18 schrieb Alex Williamson: On Sun, 9 Oct 2016 19:56:03 +0200 Thorsten Kohfeldt wrote: From: Thorsten Kohfeldt Date: Sat, 24 Sep 2016 20:43:20 +0200 Subject: [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

On 12.10.2016 14:30, Vladimir Sementsov-Ogievskiy wrote: > On 12.10.2016 14:38, Vladimir Sementsov-Ogievskiy wrote: >> On 07.10.2016 22:28, Max Reitz wrote: >>> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved

Re: [Qemu-devel] [PATCH 05/22] qcow2-bitmap: structs and consts

On 11.10.2016 13:50, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:34, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Create block/qcow2-bitmap.c >>> Add data structures and constraints accordingly to docs/specs/qcow2.txt >>> >>> Signed-off-by: Vladimir

[Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC

If tagged addresses are enabled, then addresses being loaded into the PC must be cleaned up by overwriting the tag bits with either all 0's or all 1's as specified in the ARM ARM spec. The decision process is dependent on whether the code will be running in EL0/1 or in EL2/3 and is controlled

[Qemu-devel] [PATCH v3 1/4] target-arm: Infrastucture changes to enable handling of tagged address loading into PC

When capturing the current CPU state for the TB, extract the TBI0 and TBI1 values from the correct TCR for the current EL and then add them to the TB flags field. Then, at the start of code generation for the block, copy the TBI fields into the DisasContext structure. Signed-off-by: Thomas

[Qemu-devel] [PATCH v3 3/4] target-arm: Comments to mark location of pending work for 56 bit addresses

Certain instructions which can not directly load a tagged address value may trigger a corner case when the address size is 56 bits. This is because incrementing or offsetting from the current PC can cause an arithetic roll-over into the tag bits. Per the ARM ARM spec, these cases should also be

[Qemu-devel] chardev's and fd's in monitors

Hi, I had a look at a couple of readline like libraries; editline and linenoise. A difficulty with using them is that they both want fd's or FILE*'s; editline takes either but from a brief look I think it's expecting to extract the fd. That makes them tricky to integrate into qemu, where the

Re: [Qemu-devel] [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls

On 10/12/2016 4:48 AM, Alex Williamson wrote: > On Tue, 11 Oct 2016 01:58:37 +0530 > Kirti Wankhede wrote: > >> Add common functions for SET_IRQS and to add capability buffer for >> GET_REGION_INFO ioctls > > Clearly should be two (or more) separate patches since

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

On 12.10.2016 10:55, Hao QingFeng wrote: > Max, > > Just a common question for this case, if sshx block driver wasn't built > into qemu-img, this case would fail as below: Good point, and thanks for bringing it up, but it's not directly linked to this series other than by its subject, of course,

[Qemu-devel] [PATCH v3 2/4] target-arm: Code changes to implement overwrite of tag field on PC load

For BR, BLR and RET instructions, if tagged addresses are enabled, the tag field in the address must be cleared out prior to loading the address into the PC. Depending on the current EL, it will be set to either all 0's or all 1's. Signed-off-by: Thomas Hanson ---

Re: [Qemu-devel] [PATCH 2/3] target-arm: Code changes to implement overwrite of tag field on PC load

On 10/11/2016 10:12 AM, Peter Maydell wrote: > On 11 October 2016 at 16:51, Thomas Hanson wrote: >> On 5 October 2016 at 16:01, Peter Maydell wrote: >>> It matches the style of the rest of the code which generally >>> prefers to convert

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

On 10/12/2016 01:10 PM, Christopher Covington wrote: > Hi Wei, > > On 10/12/2016 11:49 AM, Wei Huang wrote: >> On 10/11/2016 01:40 PM, Christopher Covington wrote: >>> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >>> even for the smallest delta of two subsequent reads. >>>

[Qemu-devel] [PATCH v3 4/4] target-arm: Comments added to identify cases in a switch

3 cases in a switch in disas_exc() require reference to the ARM ARM spec in order to determine what case they're handling. Signed-off-by: Thomas Hanson --- target-arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support

Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162 index f8eecb3..cad2bd7 100755 --- a/tests/qemu-iotests/162 +++ b/tests/qemu-iotests/162 @@ -35,6 +35,9 @@ status=1 #

[Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting

bdrv_iterate_format() did not actually sort the formats by name but by "pointer interpreted as string". That is probably not what we intended to do, so fix it (by changing qsort_strcmp() so it matches the example from qsort()'s manual page). Signed-off-by: Max Reitz ---

Re: [Qemu-devel] error reporting in functions

On 10/12/2016 10:47 AM, Vladimir Sementsov-Ogievskiy wrote: > HI all! > > My questions is: what are general recommendations in Qemu for return > code, if we have Error **errp? > What should I prefer: errp, duplicated by int return code, or void > functions with errp? Markus has already had

[Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

Some block drivers may not be loaded yet, but qemu supports them nonetheless. bdrv_iterate_format() should report them, too. Signed-off-by: Max Reitz --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index e46e4b2..88a1ea5

[Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support

As reported by Hao QingFeng, iotest 162 is currently executed even if qemu does not have any SSH support (which makes it fail, naturally). Fixing that is not so trivial, because qemu-img currently does not report modules, and SSH can be compiled as a module, so that needs to be fixed first. While

Re: [Qemu-devel] [PATCH 1/2] 9pfs: fix information leak in xattr read

On 10/12/2016 08:23 AM, Greg Kurz wrote: > > But in fact, I'm afraid we have a more serious problem here... size > comes from the guest and could cause g_malloc() to abort if QEMU has > reached some RLIMIT... we need to call g_try_malloc0() and return > ENOMEM if the allocation fails. Even if it

Re: [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage

Peter, Greetings from DigitalOcean. We're experiencing the same symptoms without this patch. We have, collectively, many gigabytes of un-planned-for RSS being used per-hypervisor that we would like to get rid of =). Without explicitly trying this patch (will do that ASAP), we immediately

Re: [Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting

On 10/12/2016 03:49 PM, Max Reitz wrote: > bdrv_iterate_format() did not actually sort the formats by name but by > "pointer interpreted as string". That is probably not what we intended > to do, so fix it (by changing qsort_strcmp() so it matches the example > from qsort()'s manual page). > >

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

On Thu, 13 Oct 2016 00:32:48 +0530 Kirti Wankhede wrote: > On 10/12/2016 9:29 PM, Alex Williamson wrote: > > On Wed, 12 Oct 2016 20:43:48 +0530 > > Kirti Wankhede wrote: > > > >> On 10/12/2016 7:22 AM, Tian, Kevin wrote: > From: Kirti

[Qemu-devel] (no subject)

Dear Sir/Ma'am I want to ‘annotate’ the translation buffers - (adding a mechanism in the translation buffers where we can store how many times they were executed, and, for each one, add some ‘amount’ could be power, could be anything). I need held to understand the translation buffer code in

Re: [Qemu-devel] MTTCG memory ordering

On Wed, Oct 12, 2016 at 10:58:43 +0200, Stefan Hajnoczi wrote: > Hi Pranith, > I was curious about the status of your MTTCG GSoC work: > > I saw your fence series which implements the noop memory barrier/fence > instructions on various architectures, but I wasn't sure if that also > covers the

[Qemu-devel] [PATCH v2] char: serial: check divider value against baud base

From: Prasad J Pandit 16550A UART device uses an oscillator to generate frequencies (baud base), which decide communication speed. This speed could be changed by dividing it by a divider. If the divider is greater than the baud base, speed is set to zero, leading to a

Re: [Qemu-devel] [PATCH] char: serial: check divider value against baud base

+-- On Tue, 11 Oct 2016, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote --+ | Your series seems to have some coding style problems. | === OUTPUT BEGIN === | Checking PATCH 1/1: char: serial: check divider value against baud base... | ERROR: braces {} are necessary for all arms of this

[Qemu-devel] [PATCH V3] colo-proxy: fix memory leak

Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen --- net/colo-compare.c| 34 +++--- net/filter-rewriter.c | 17 + trace-events | 1

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya wrote: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a >

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. The reason why patchew fails to build your series is because it doesn't

Re: [Qemu-devel] [PATCH 2/5] cpus: use atomic_read to read seqlock-protected variables

Paolo Bonzini writes: > There is a data race if the variable is written concurrently to the > read. In C11 this has undefined behavior. Use atomic_read. The > write side does not need atomic_set, because it is protected by a > mutex. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

> I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. > > Going through the config output of the test script, I see that the > supporting library for SSH which is "libssh2" seems to be

[Qemu-devel] [PULL v2 05/20] trace: remove global 'uint16 dstate[]' array

From: "Daniel P. Berrange" Instead of having a global dstate array, declare a single 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each trace event. Record a pointer to this variable in the TraceEvent struct too. By turning trace_event_get_state_dynamic_by_id into a

[Qemu-devel] [PULL v2 06/20] trace: remove duplicate control.h includes in generated-tracers.h

From: "Daniel P. Berrange" The format/h.py file adds an include for control.h to generated-tracers.h. ftrace, log and syslog, then add more duplicate includes for control.h. Reviewed-by: Stefan Hajnoczi Reviewed-by: Lluís Vilanova

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

Max, Just a common question for this case, if sshx block driver wasn't built into qemu-img, this case would fail as below: exec /home/haoqf/KVMonz/qemu/tests/qemu-iotests/../../qemu-img info --image-opts driver=ssh,host=localhost,port=0.42,path=/foo qemu-img: Could not open

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

On Tue 11 Oct 2016 06:50:27 PM CEST, Markus Armbruster wrote: > * Is the extended command still a sane interface? If writing clear > documentation for it is hard, it perhaps isn't. Pay special > attention to failure modes. Overloaded arguments are prone to > confusing errors. This is

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

On Tue 11 Oct 2016 06:32:39 PM CEST, Markus Armbruster wrote: >>> 3) QEMU could advertise that feature to the client. This is probably >>> simpler than trying to figure it out from the API. I guess that's >>> the idea of 'qmp_capabilities'? >> >> I think that was the idea, though it was never

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

Hi On Tue, Oct 11, 2016 at 8:44 PM Daniel P. Berrange wrote: > > Not sure if this is immediately helpful to your scneario or > not, but I'd like to see the qemu_chr_add_handlers method > removed long term, and everything converted to use the > qemu_chr_fe_add_watch function

Re: [Qemu-devel] [PATCH 3/5] qemu-thread: use acquire/release to clarify semantics of QemuEvent

On 12/10/2016 11:21, Alex Bennée wrote: > > Paolo Bonzini writes: > >> Do not use the somewhat mysterious atomic_mb_read/atomic_mb_set, >> instead make sure that the operations on QemuEvent are annotated >> with the desired acquire and release semantics. >> >> In

[Qemu-devel] [PATCH v2] MAINTAINERS: Add some ARM related files to the corresponding sections

The files w/cpu/a*mpcore.c are already assigned to the ARM CPU section, but the corresponding headers include/hw/cpu/a*mpcore.h are still missing. The file hw/*/imx* are already assigned to the i.MX31 machine, but the corresponding header files include/hw/*/imx* are still missing. The file

Re: [Qemu-devel] [PATCH 1/3] block: add BDS field to count in-flight requests

On 12/10/2016 11:50, Kevin Wolf wrote: > > (By the way, I need to repost this series anyway, but let's finish the > > discussion first to understand what you'd like to have in 2.8). > > I'm still not completely sold on the order in which we should do things, > but you've been insisting enough

Re: [Qemu-devel] [PATCH v8 3/6] vfio iommu: Add support for mediated devices

> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, October 11, 2016 4:29 AM > [...] > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 2ba19424e4a1..ce6d6dcbd9a8 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++

Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode

On Mon, Oct 10, 2016 at 11:41 PM, Richard Henderson wrote: > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> Signed-off-by: Artyom Tarasenko >> --- >> target-sparc/cpu.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option

* Markus Armbruster (arm...@redhat.com) wrote: > Marc-André Lureau writes: > > > This option does nothing since commit 06ac27f. Deprecate it. > > > > Signed-off-by: Marc-André Lureau > > --- > > vl.c | 11

[Qemu-devel] [PULL v2 12/20] trace: provide mechanism for registering trace events

From: "Daniel P. Berrange" Remove the notion of there being a single global array of trace events, by introducing a method for registering groups of events. The module_call_init() needs to be invoked at the start of any program that wants to make use of the trace support.

[Qemu-devel] [PULL v2 09/20] trace: remove the TraceEventID and TraceEventVCPUID enums

From: "Daniel P. Berrange" The TraceEventID and TraceEventVCPUID enums constants are no longer actually used for anything critical. The TRACE_EVENT_COUNT limit is used to determine the size of the TraceEvents array, and can be removed if we just NULL terminate the array

[Qemu-devel] [PULL v2 18/20] trace: pass trace-events to tracetool as a positional param

From: "Daniel P. Berrange" Instead of reading the contents of 'trace-events' from stdin, accept the filename as a positional parameter. This also allows for reading from multiple files, though this facility is not used at this time. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] MTTCG memory ordering

Hi Pranith, I was curious about the status of your MTTCG GSoC work: I saw your fence series which implements the noop memory barrier/fence instructions on various architectures, but I wasn't sure if that also covers the case where a strong target is emulated on a weak host. Did you make TCG

Re: [Qemu-devel] [PATCH 3/5] qemu-thread: use acquire/release to clarify semantics of QemuEvent

Paolo Bonzini writes: > Do not use the somewhat mysterious atomic_mb_read/atomic_mb_set, > instead make sure that the operations on QemuEvent are annotated > with the desired acquire and release semantics. > > In particular, qemu_event_set wakes up the waiting thread, so it

Re: [Qemu-devel] [PATCH 5/5] atomic: base mb_read/mb_set on load-acquire and store-release

On 12/10/2016 11:28, Alex Bennée wrote: > > Paolo Bonzini writes: > >> This introduces load-acquire and store-release operations in QEMU. >> For now, just use them as an implementation detail of atomic_mb_read >> and atomic_mb_set. >> >> Since docs/atomics.txt documents

[Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

NBD is using the CoMutex in a way that wasn't anticipated. For example, if there are N(N=26, MAX_NBD_REQUESTS=16) nbd write requests, so we will invoke nbd_client_co_pwritev N times. time request Actions 1

[Qemu-devel] PSA: wiki cleaned up

Hi all, I spent some time cleaning up the wiki in order to make it easier to organize information. The pages are now organized in a mostly hierarchical fashion, starting at the following entry points: * http://qemu-project.org/ChangeLog * http://qemu-project.org/Contribute (formerly

Re: [Qemu-devel] vt-x support for qemu

On 11/10/2016 20:41, Anand J wrote: > I want to run KVM on qemu. For this qemu must provide vt-x/amd-v > instruction support in the software mode. > I was planning to try to add this feature in qemu. If somebody is already > working on it please reply. QEMU provides AMD-V support. Paolo

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

On 07.10.2016 22:28, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] vt-x support for qemu

Thanks for replying. Can you please tell me where should I start looking at the code in order to understand the implementation? Thanks, Anand On Wed, Oct 12, 2016 at 4:27 PM, Paolo Bonzini wrote: > > > On 11/10/2016 20:41, Anand J wrote: > > I want to run KVM on qemu. For

[Qemu-devel] [PATCH v2 4/5] linux-user: Redirect termbits.h for Mips64 to termbits.h for Mips32

From: Aleksandar Markovic linux-user/mips64/termbits.h and linux-user/mips/termbits.h originate from the same files in Linux kernel. There is no plan to split original headers in Linux kernel into Mips32 and Mips64 versions any time soon. Therefore, it is better

[Qemu-devel] [PATCH v2 2/5] linux-user: Update mips_syscall_args[] array in main.c

From: Aleksandar Markovic Array mips_syscall_args[] determines number of arguments for each syscall on Mips32. It wasn't updated with newer syscalls. Also, preadv and pwritev have 5 arguments, not 6. Signed-off-by: Aleksandar Markovic

Re: [Qemu-devel] [PATCHv2 1/7] libqos: Isolate knowledge of spapr memory map to qpci_init_spapr()

On 12/10/2016 06:44, David Gibson wrote: > The libqos code for accessing PCI on the spapr machine type uses IOBASE() > and MMIOBASE() macros to determine the address in the CPU memory map of > the windows to PCI address space. > > This is a detail of the implementation of PCI in the machine

Re: [Qemu-devel] [PATCHv2 3/7] libqos: Limit spapr-pci to 32-bit MMIO for now

On 12/10/2016 06:44, David Gibson wrote: > Currently the functions in pci-spapr.c (like pci-pc.c on which it's based) > don't distinguish between 32-bit and 64-bit PCI MMIO. At the moment, the > qemu side implementation is a bit weird and has a single MMIO window > straddling 32-bit and 64-bit

[Qemu-devel] [PULL v2 13/20] trace: dynamically allocate trace_dstate in CPUState

From: "Daniel P. Berrange" The CPUState struct has a bitmap tracking which VCPU events are currently active. This is indexed based on the event ID values, and sized according the maximum TraceEventVCPUID enum value. When we start dynamically assigning IDs at runtime, we

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

Am 11.10.2016 um 18:50 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 10/11/2016 09:57 AM, Kevin Wolf wrote: > >> Should we introduce a new, clean blockdev-stream command that fixes this > >> and matches the common name pattern? Of course, block-stream vs. >

[Qemu-devel] [Bug 1319100] Re: qemu-arm-static bug in signal handling causes mono and java to hang

Yes it did. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1319100 Title: qemu-arm-static bug in signal handling causes mono and

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

On 10/12/2016 06:18 PM, Changlong Xie wrote: time request Actions 29 15(most case) in_flight=15, Coroutine=C15, free_sema->holder=C17, mutex->locked=false

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

On 12/10/2016 12:18, Changlong Xie wrote: > +if (s->in_flight == MAX_NBD_REQUESTS) { > +qemu_co_queue_wait(>free_sema); > assert(s->in_flight < MAX_NBD_REQUESTS); > } I was wondering if this should be a while loop instead, but the assertion protects against that. So:

Re: [Qemu-devel] [PULL v2 00/20] Tracing patches

On 12 October 2016 at 09:47, Stefan Hajnoczi wrote: > The following changes since commit 627eae7d729277c84f8e0ac07a8caab39c92c38d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2016-10-10 16:23:40 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2 11/11] iotests: add transactional failure race test

it is almost a duplication of test_transaction_failure, I think it would be better to make separate do_test_transaction_failure with parameter and two wrappers On 01.10.2016 01:00, John Snow wrote: Add a regression test for the case found by Vladimir. Reported-by: Vladimir

Re: [Qemu-devel] vt-x support for qemu

On 12/10/2016 13:34, Anand J wrote: > Thanks for replying. Can you please tell me where should I start looking > at the code in order to understand the implementation? My immediate answer is that if you cannot find it, you'll have a hard time understanding the implementation. But anyway it's

Re: [Qemu-devel] [PATCHv2 2/7] libqos: Correct error in PCI hole sizing for spapr

On 12/10/2016 06:44, David Gibson wrote: > In pci-spapr.c (as in pci-pc.c from which it was derived), the > pci_hole_start/pci_hole_size and pci_iohole_start/pci_iohole_size pairs[1] > essentially define the region of PCI (not CPU) addresses in which MMIO > or PIO BARs respectively will be

Re: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for pseries

Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1476247497-6976-1-git-send-email-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for pseries Type: series === TEST SCRIPT BEGIN ===

[Qemu-devel] [PULL v2 14/20] trace: dynamically allocate event IDs at runtime

From: "Daniel P. Berrange" Instead of having the code generator assign event IDs and event VCPU IDs, assign them when the events are registered at runtime. This will allow code to be generated from individual trace-events without having to figure out globally unique

[Qemu-devel] [PULL v2 04/20] trace: remove some now unused functions

From: "Daniel P. Berrange" The trace_event_count, trace_event_id and trace_event_pattern methods are no longer required now that everything is using the iterator APIs The trace_event_set_state and trace_event_set_vcpu_state macros were also unused. Reviewed-by: Stefan

Re: [Qemu-devel] [PATCH v4 03/20] ppc/pnv: add a core mask to PnvChip

On 10/11/2016 12:24 PM, David Gibson wrote: > On Mon, Oct 10, 2016 at 02:56:25PM +0200, Cédric Le Goater wrote: >> @@ -227,11 +227,44 @@ static void ppc_powernv_init(MachineState *machine) snprintf(chip_name, sizeof(chip_name), "chip[%d]", CHIP_HWID(i));

[Qemu-devel] [PULL v2 15/20] trace: get rid of generated-events.h/generated-events.c

From: "Daniel P. Berrange" Currently the generated-events.[ch] files contain the event dstates, constants and TraceEvent structs, while the generated-tracers.[ch] files contain the actual trace probe logic. With the removal of usage of the event enums from the API there is

Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists

"Daniel P. Berrange" writes: > When converting QemuOpts to a QObject, there is no information > about compound types available, Yes, that's a drawback of splitting the conversion into a QemuOpts -> QObject part that is oblivious of types, and a QObject -> QAPI object part

Re: [Qemu-devel] [PATCH 5/5] atomic: base mb_read/mb_set on load-acquire and store-release

Paolo Bonzini writes: > This introduces load-acquire and store-release operations in QEMU. > For now, just use them as an implementation detail of atomic_mb_read > and atomic_mb_set. > > Since docs/atomics.txt documents that atomic_mb_read only synchronizes > with an

Re: [Qemu-devel] [PULL 00/15] Migration

On 6 October 2016 at 11:59, Peter Maydell wrote: > On 5 October 2016 at 14:44, Juan Quintela wrote: >> From: Juan Quintela >> >> The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d: >> >> Merge

Re: [Qemu-devel] [PATCH] tests/boot-sector: Use mkstemp() to create a unique file name

On Tue, 11 Oct 2016 16:06:55 +0200 Thomas Huth wrote: > On 11.10.2016 15:55, Greg Kurz wrote: > > On Tue, 11 Oct 2016 15:32:02 +0200 > > Thomas Huth wrote: > > > >> The pxe-test is run for three different targets now (x86_64, i386 > >> and ppc64), and the

[Qemu-devel] [PATCH v2 0/5] linux-user: Several Mips-related patches

From: Aleksandar Markovic v1 -> v2: - Added patches 1 and 2. - Omitted patch on sysfs(); this patch will be treated separately, as it is not Mips-specific, and logicaly does not belong to this series; it will be sent at later time. This is

Re: [Qemu-devel] [PATCH v6 21/20] linux-user/bsd-user: initialize trace events subsystem

On Fri, Oct 07, 2016 at 02:51:17PM +0100, Daniel P. Berrange wrote: > The bsd-user/linux-user programs make use of the CPU emulation > code and this now requires that the trace events subsystem > is enabled, otherwise it'll crash trying to allocate an empty > trace events bitmap for the CPU

Re: [Qemu-devel] [PATCH v14 08/21] qapi: allow QObjectInputVisitor to be created with QemuOpts

"Daniel P. Berrange" writes: > Instead of requiring all callers to go through the mutli-step multi-step > process of turning QemuOpts into a suitable QObject for visiting, > add a new constructor that encapsulates this logic. This will > allow QObjectInputVisitor to be a

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > > > Of course, we must be able to build qemu correctly both with ssh enabled > > and disabled, so if you

[Qemu-devel] [PULL v2 01/20] trace: move colo trace events to net/ sub-directory

From: "Daniel P. Berrange" The colo patch series added various trace events to the top level trace-events file, despite the files using them being in a sub-dir. commit 30656b097e9dd7978d3fe9416cb9f5a421a9e63e Author: Zhang Chen Date:

[Qemu-devel] [PULL v2 20/20] trace: Add missing execution mode of guest events

From: Lluís Vilanova Add missing execution mode documentation for the 'guest_cpu_enter' and 'guest_cpu_reset' events. Signed-off-by: Lluís Vilanova Message-id: 147566900921.7708.656450813307396468.st...@fimbulvetr.bsc.es Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size

From: Prasad J Pandit Rocker network switch emulator has test registers to help debug DMA operations. While testing host DMA access, a buffer address is written to register 'TEST_DMA_ADDR' and its size is written to register 'TEST_DMA_SIZE'. When performing

[Qemu-devel] [PULL v2 17/20] trace: push reading of events up a level to tracetool main

From: "Daniel P. Berrange" Move the reading of events out of the 'tracetool.generate' method and into tracetool.main, so that the latter is not tied to generating from a single source of events. Reviewed-by: Stefan Hajnoczi Reviewed-by: Lluís Vilanova

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

On 10/11/2016 08:32 PM, Igor Mammedov wrote: Of course, @fit and @current_number should be persistent during live migration. you can drop RCU and @current_number, and @fit could be exactly recreated on target side from -device nvdim ... set of options, which must include all currently

Re: [Qemu-devel] [PATCH 29/29] target-sparc: fix up Niagara machine

On Tue, Oct 11, 2016 at 4:43 PM, Richard Henderson wrote: > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> Remove the Niagara stub implementation from sun4u.c and add a machine, >> compatible with Legion simulator from the OpenSPARC T1 project. >> >> The machine uses the

[Qemu-devel] [PATCH v2 5/5] linux-user: Fix fadvise64() syscall support for Mips32

From: Aleksandar Markovic By looking at the file arch/mips/kernel/sys.S in Linux kernel, it can be deduced that, for Mips32 platform, syscall corresponding to number _NR_fadvise64 translates to kernel function sys_fadvise64_64, and that argument layout is as

[Qemu-devel] [PATCH v2 1/5] linux-user: Update syscall numbers tables for Mips

From: Aleksandar Markovic Update from kernel header arch/mips/include/uqapi/asm/unistd.h. Signed-off-by: Aleksandar Markovic --- linux-user/mips/syscall_nr.h | 3 +++ linux-user/mips64/syscall_nr.h | 7 +++ 2 files changed,

[Qemu-devel] [PATCH v2 3/5] linux-user: Update ioctls definitions for Mips32

From: Aleksandar Markovic Update linux-user/mips/termbits.h with ioctl definitions from kernel file arch/mips/include/uapi/asm/ioctls.h. Signed-off-by: Aleksandar Markovic --- linux-user/mips/termbits.h | 12 1 file

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, October 12, 2016 3:41 PM > To: Gonglei (Arei); Michael Tokarev; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Herongguang (Stephen) > Subject: Re: [PATCH]

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

On 12/10/2016 09:54, Gonglei (Arei) wrote: > >> -Original Message- >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> Sent: Wednesday, October 12, 2016 3:41 PM >> To: Gonglei (Arei); Michael Tokarev; qemu-devel@nongnu.org >> Cc:

Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

> From: Kirti Wankhede > Sent: Tuesday, October 11, 2016 4:29 AM > [...] > + > +/* > + * mdev_unregister_device : Unregister a parent device > + * @dev: device structure representing parent device. > + * > + * Remove device from list of registered parent devices. Give a chance to > free > + *

[Qemu-devel] [PULL v2 02/20] trace: add trace event iterator APIs

From: "Daniel P. Berrange" Currently methods which want to iterate over trace events, do so using the trace_event_count() and trace_event_id() methods. This leaks the concept of a single ID enum to the callers. There is an alternative trace_event_pattern() method which can

  1   2   3   4   >