Re: [PATCH v6 32/42] nvme: allow multiple aios per command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > This refactors how the device issues asynchronous block backend > requests. The NvmeRequest now holds a queue of NvmeAIOs that are > associated with the command. This allows multiple aios to be issued for > a command.

Re: [PATCH v6 42/42] nvme: make lba data size configurable

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > --- > hw/block/nvme-ns.c | 7 ++- > hw/block/nvme-ns.h | 4 +++- > hw/block/nvme.c| 1 + > 3 files changed, 10 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH v6 33/42] nvme: use preallocated qsg/iov in nvme_dma_prp

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Since clean up of the request qsg/iov has been moved to the common > nvme_enqueue_req_completion function, there is no need to use a stack > allocated qsg/iov in nvme_dma_prp. > > Signed-off-by: Klaus Jensen > Acked

[PULL 1/2] ui/input-linux: Do not ignore ioctl() return value

2020-03-25 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Fix warnings reported by Clang static code analyzer: CC ui/input-linux.o ui/input-linux.c:343:9: warning: Value stored to 'rc' is never read rc = ioctl(il->fd, EVIOCGBIT(EV_REL, sizeof(relmap)), &relmap); ^~~

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

2020-03-25 Thread Aleksandar Markovic
12:53 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 20:17 Pon, 23.03.2020. Richard Henderson је написао/ла: > > > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > > While debugging check-acceptance failures I found an instability in > > > the mips64el test case. Briefly the test case: > > >

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Max Reitz
On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: > local_err is used again in mirror_exit_common() after > bdrv_set_backing_hd(), so we must zero it. Otherwise try to set > non-NULL local_err will crash. OK, but wouldn’t it be better hygiene to set it to NULL every time it is freed? (There

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

2020-03-25 Thread Aleksandar Markovic
12:47 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 12:44 Sre, 25.03.2020. Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > > > 16:59 Uto, 24.03.2020. Richard Henderson је написао/ла: > > > > > > On 3/24/20 5:22 AM, Jiaxun Yang wrote: > > > > Loongson multimedia

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

2020-03-25 Thread Alex Bennée
Yes I'll put it through mine. On Wed, 25 Mar 2020, 10:53 Aleksandar Markovic, < aleksandar.qemu.de...@gmail.com> wrote: > 20:17 Pon, 23.03.2020. Richard Henderson > је написао/ла: > > > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > > While debugging check-acceptance failures I found an instabilit

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Max Reitz
On 25.03.20 12:11, Max Reitz wrote: > On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: >> local_err is used again in mirror_exit_common() after >> bdrv_set_backing_hd(), so we must zero it. Otherwise try to set >> non-NULL local_err will crash. > > OK, but wouldn’t it be better hygiene to se

[PATCH] Acceptance test: Fix to EXEC migration

2020-03-25 Thread Oksana Vohchana
The exec migration test isn't run a whole test scenario. This patch fixes it Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index a8367ca023..

Re: [PATCH v4 0/2] Replaced locks with lock guard macros

2020-03-25 Thread Daniel Brodsky
> > There may be ways to rewrite that expression to avoid triggering the > warning on a 32-bit platform. Untested, but does this help: > > if (sizeof(mask) > 4 && mask <= 0xu) { > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qe

RE: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-03-25 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: 20 March 2020 16:58 > To: eric.auger@gmail.com; eric.au...@redhat.com; > qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; alex.william...@redhat.com; > jacob.

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Stefan Reiter
On 24/03/2020 17:49, Dietmar Maurer wrote: A more serious issue is that I also get a hang inside the poll loop when the VM is under load. For example, running "stress -d 5" inside the VM (Debian Buster). Then running a simply drive-backup like: { "execute": "drive-backup", "arguments": { "devic

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2020 14:11, Max Reitz wrote: On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: local_err is used again in mirror_exit_common() after bdrv_set_backing_hd(), so we must zero it. Otherwise try to set non-NULL local_err will crash. OK, but wouldn’t it be better hygiene to set it to NULL

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Wed, Mar 25, 2020 at 09:13:12AM +0100, Sergio Lopez wrote: > On Tue, Mar 24, 2020 at 02:47:43PM +0100, Max Reitz wrote: > > Hi Dietmar, > > > > I assume this is with master and has popped up only recently? > > > > Maybe it has something to do with the recent mutex patches by Stefan, so > > I’m C

Re: [PATCH v2 0/2] Rework iotests finding

2020-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200325102131.23270-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Max Reitz
On 25.03.20 12:47, Vladimir Sementsov-Ogievskiy wrote: > 25.03.2020 14:11, Max Reitz wrote: >> On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: >>> local_err is used again in mirror_exit_common() after >>> bdrv_set_backing_hd(), so we must zero it. Otherwise try to set >>> non-NULL local_err

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Max Reitz
On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: > local_err is used again in mirror_exit_common() after > bdrv_set_backing_hd(), so we must zero it. Otherwise try to set > non-NULL local_err will crash. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/mirror.c | 1 + > 1 file

Re: [PATCH-for-5.0] qga-posix: Avoid crashing process when failing to allocate memory

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/25/20 7:19 AM, Dietmar Maurer wrote: but error_setg() also calls malloc, so this does not help at all? IIUC the problem, you can send a QMP command to ask to read let's say 3GB of a file, and QEMU crashes. But this doesn't mean there the .heap is empty, there is probably few bytes still

Re: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/25/20 3:59 AM, Chen Qun wrote: Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~ hw/timer/exynos4210_mct.c:13

Re: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/25/20 1:16 PM, Philippe Mathieu-Daudé wrote: On 3/25/20 3:59 AM, Chen Qun wrote: Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^   ~

RE: [PATCH v1 12/22] intel_iommu: add PASID cache management infrastructure

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 1:32 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 12/22] intel_iommu: add PASID cache management > infrastructure > > On Sun, Mar 22, 2020 at 05:36:09AM -0700, Liu Yi L wrote: > > This patch adds a PASID cache management infrastructure based on n

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2020 14:40, Stefan Reiter wrote: On 24/03/2020 17:49, Dietmar Maurer wrote: A more serious issue is that I also get a hang inside the poll loop when the VM is under load. For example, running "stress -d 5" inside the VM (Debian Buster). Then running a simply drive-backup like: { "execute

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Dietmar Maurer
> As expected, if both BDS are running on the same IOThread (and thus, > the same AioContext), the problem is not reproducible. > > In a general sense, we could say that completion modes other than > "individual" are not supported for a transaction that may access > different AioContexts. I don't

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

2020-03-25 Thread Philippe Mathieu-Daudé
Hi Oksana, v2 was https://www.mail-archive.com/qemu-devel@nongnu.org/msg682899.html, so this is v3. Please increment the version in the patch subject. You could also send a simple "ping" to the specific patch, instead of resending it. On 3/25/20 12:31 PM, Oksana Vohchana wrote: The exec m

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Thu, 19 Mar 2020 09:01:04 +0100 Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. > > These are the advantages you are going to loose then: >

Re: [PATCH v2 0/2] Rework iotests finding

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2020 14:56, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200325102131.23270-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can pro

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Wed, Mar 25, 2020 at 01:29:48PM +0100, Dietmar Maurer wrote: > > As expected, if both BDS are running on the same IOThread (and thus, > > the same AioContext), the problem is not reproducible. > > > > In a general sense, we could say that completion modes other than > > "individual" are not supp

Re: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-03-25 Thread Auger Eric
Hi Shameer, On 3/25/20 12:35 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger [mailto:eric.au...@redhat.com] >> Sent: 20 March 2020 16:58 >> To: eric.auger@gmail.com; eric.au...@redhat.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; peter

Re: [PATCH v2 3/4] qcow2: Avoid feature name extension on small cluster size

2020-03-25 Thread Max Reitz
On 24.03.20 18:42, Eric Blake wrote: > As the feature name table can be quite large (over 9k if all 64 bits > of all three feature fields have names; a mere 8 features leaves only > 8 bytes for a backing file name in a 512-byte cluster), it is unwise > to emit this optional header in images with sm

RE: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to host

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 1:47 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to > host > > On Sun, Mar 22, 2020 at 05:36:11AM -0700, Liu Yi L wrote: > > This patch captures the guest PASID table entry modifications and > > p

RE: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to host

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 1:47 AM > To: Liu, Yi L > Sent: Wednesday, March 25, 2020 1:47 AM > Subject: Re: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to > host > > On Sun, Mar 22, 2020 at 05:36:11AM -0700, Liu Yi L wrote: > > This patch captures the gues

Re: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator

2020-03-25 Thread Eric Blake
On 3/25/20 1:50 AM, Robert Hoo wrote: By increasing avx2 length_to_accel to 128, we can simplify its logic and reduce a branch. The authorship of this patch actually belongs to Richard Henderson , Long line; it's nice to wrap commit messages around column 70 or so (because reading 'git log'

Re: [PATCH 2/6] block/mirror: fix use after free of local_err

2020-03-25 Thread Eric Blake
On 3/25/20 6:11 AM, Max Reitz wrote: On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote: local_err is used again in mirror_exit_common() after bdrv_set_backing_hd(), so we must zero it. Otherwise try to set non-NULL local_err will crash. OK, but wouldn’t it be better hygiene to set it to NU

Re: [PATCH 1/3] gdbstub: prevent uninitialized warning

2020-03-25 Thread Miroslav Rezanina
On Wed, Mar 25, 2020 at 05:21:35PM +0800, Chen Qun wrote: > According to the glib function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > qemu/gdbstub.c: In function ‘handle_query_thread_extra’: > /usr/include/glib-2.0/glib/glib-autocleanups

Re: [PATCH v2 0/2] Rework iotests finding

2020-03-25 Thread Eric Blake
On 3/25/20 5:21 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! When sending iotests to upstream or do patch porting from one branch to another we very often have to resolve conflicts in group file, as many absolutely independent features are intersecting by this file. These conflicts are simple

RE: [PATCH v1 15/22] intel_iommu: replay guest pasid bindings to host

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:00 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 15/22] intel_iommu: replay guest pasid bindings to host > > On Sun, Mar 22, 2020 at 05:36:12AM -0700, Liu Yi L wrote: > > This patch adds guest pasid bindings replay for domain > > selective pasid

[PULL 2/9] xbzrle: update xbzrle doc

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi Add new parameter description, also: 1. Remove unsociable space. 2. Nit picking: s/two/2 in report Signed-off-by: Mao Zhongyi Message-Id: <20200320143216.423374-1-maozhon...@cmss.chinamobile.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert ---

[PULL 7/9] migration/colo: fix use after free of local_err

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Vladimir Sementsov-Ogievskiy local_err is used again in secondary_vm_do_failover() after replication_stop_all(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200324153630.11882-5-vsement...@virtuozzo.com

[PULL 0/9] migration queue

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 736cf607e40674776d752acc201f565723e86045: Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +) are available in the Git repository at: git://github.com/dagrh/qemu.git tags/pull-migration-20200325b for you to fe

[PULL 5/9] tools/virtiofsd/passthrough_ll: Fix double close()

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé On success, the fdopendir() call closes fd. Later on the error path we try to close an already-closed fd. This can lead to use-after-free. Fix by only closing the fd if the fdopendir() call failed. Cc: qemu-sta...@nongnu.org Fixes: b39bce121b (add dirp_map to hide lo

[PULL 1/9] hmp-cmd: fix a missing_break warning

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Pan Nengyuan This fix coverity issues 94417686: 1260break; CID 94417686: (MISSING_BREAK) 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. 1261case MIGRATION_PARAMETER_THROTTLE

[PULL 9/9] migration: use "" instead of (null) for tls-authz

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi run: (qemu) info migrate_parameters announce-initial: 50 ms ... announce-max: 550 ms multifd-compression: none xbzrle-cache-size: 4194304 max-postcopy-bandwidth: 0 tls-authz: '(null)' Migration parameter 'tls-authz' is used to provide the QOM ID of a QAuthZ subclass instance t

[PULL 4/9] hmp/vnc: Fix info vnc list leak

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We're iterating the list, and then freeing the iteration pointer rather than the list head. Fixes: 0a9667ecdb6d ("hmp: Update info vnc") Reported-by: Coverity (CID 1421932) Signed-off-by: Dr. David Alan Gilbert Message-Id: <20200323120822.51266-1-dgilb...@redhat.c

RE: [PATCH v1 16/22] intel_iommu: replay pasid binds after context cache invalidation

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 1:47 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to > host > > On Sun, Mar 22, 2020 at 05:36:11AM -0700, Liu Yi L wrote: > > This patch captures the guest PASID table entry modifications and > > p

[PULL 3/9] tests/migration: Reduce autoconverge initial bandwidth

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg: $ make check-qtest TESTcheck-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: invalid accelerator tcg qemu-system-s390x: fa

[PULL 6/9] vl.c: fix migration failure for 3.1 and older machine types

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Igor Mammedov Migration from QEMU(v4.0) fails when using 3.1 or older machine type. For example if one attempts to migrate QEMU-2.12 started as qemu-system-ppc64 -nodefaults -M pseries-2.12 -m 4096 -mem-path /tmp/ to current master, it will fail with qemu-system-ppc64: Unknown ramblock

RE: [PATCH v1 20/22] intel_iommu: propagate PASID-based iotlb invalidation to host

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:34 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 20/22] intel_iommu: propagate PASID-based iotlb > invalidation to host > > On Sun, Mar 22, 2020 at 05:36:17AM -0700, Liu Yi L wrote: > > This patch propagates PASID-based iotlb invalidation to hos

RE: [PATCH v1 22/22] intel_iommu: modify x-scalable-mode to be string option

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:39 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 22/22] intel_iommu: modify x-scalable-mode to be string > option > > On Sun, Mar 22, 2020 at 05:36:19AM -0700, Liu Yi L wrote: > > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of >

[PULL 8/9] migration/ram: fix use after free of local_err

2020-03-25 Thread Dr. David Alan Gilbert (git)
From: Vladimir Sementsov-Ogievskiy local_err is used again in migration_bitmap_sync_precopy() after precopy_notify(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200324153630.11882-6-vsement...@virtuozzo.com>

Re: [PATCH v2 3/4] qcow2: Avoid feature name extension on small cluster size

2020-03-25 Thread Eric Blake
On 3/25/20 7:42 AM, Max Reitz wrote: On 24.03.20 18:42, Eric Blake wrote: As the feature name table can be quite large (over 9k if all 64 bits of all three feature fields have names; a mere 8 features leaves only 8 bytes for a backing file name in a 512-byte cluster), it is unwise to emit this o

Re: [PATCH v2 0/2] Rework iotests finding

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2020 16:08, Eric Blake wrote: On 3/25/20 5:21 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! When sending iotests to upstream or do patch porting from one branch to another we very often have to resolve conflicts in group file, as many absolutely independent features are intersecting by

Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq

2020-03-25 Thread Kevin Wolf
Am 24.03.2020 um 15:06 hat Minwoo Im geschrieben: > The given argument for this trace should be cqid, not sqid. > > Signed-off-by: Minwoo Im Thanks, applied to the block branch. Kevin

RE: [PATCH v1 19/22] intel_iommu: process PASID-based iotlb invalidation

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:26 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 19/22] intel_iommu: process PASID-based iotlb > invalidation > > On Sun, Mar 22, 2020 at 05:36:16AM -0700, Liu Yi L wrote: > > This patch adds the basic PASID-based iotlb (piotlb) invalidation >

[PATCH v2 2/6] block/block-copy: alloc task on each iteration

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API, so tasks will be handled in parallel. We need therefore separate allocated task on each iteration. Introduce this logic now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 18 +++--- 1 file changed, 11 insertions(+), 7 dele

[PATCH v2 0/6] block-copy: use aio-task-pool

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Hi all! This is the next step of improving block-copy: use aio task pool. Async copying loop has better performance than linear, which is shown in original series (was "[RFC 00/24] backup performance: block_status + async", so this is called v2) Vladimir Sementsov-Ogievskiy (6): block/block-co

[PATCH v2 3/6] block/block-copy: add state pointer to BlockCopyTask

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API, so we'll need state pointer in BlockCopyTask anyway. Add it now and use where possible. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/b

[PATCH v2 5/6] block/block-copy: move block_copy_task_create down

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Simple movement without any change. It's needed for the following patch, as this function will need to use some staff which is currently below it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 66 +++--- 1 file changed, 33 insertions

[PATCH v2 6/6] block/block-copy: use aio-task-pool API

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Run block_copy iterations in parallel in aio tasks. Changes: - BlockCopyTask becomes aio task structure. Add zeroes field to pass it to block_copy_do_copy - add call state - it's a state of one call of block_copy(), shared between parallel tasks. For now used only to keep information a

[PATCH v2 1/6] block/block-copy: rename in-flight requests to tasks

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API and extend in-flight request structure to be a successor of AioTask, so rename things appropriately. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 99 +++--- 1 file changed, 49 insertions(+), 50

[PATCH v2 4/6] block/block-copy: move task size initial calculation to _task_create

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Comment "Called only on full-dirty region" without corresponding assertion is a very unsafe thing. Adding assertion means call bdrv_dirty_bitmap_next_zero twice. Instead, let's move bdrv_dirty_bitmap_next_zero call to block_copy_task_create. It also allows to drop cur_bytes variable which partly du

Re: [PATCH v2 3/4] qcow2: Avoid feature name extension on small cluster size

2020-03-25 Thread Max Reitz
On 25.03.20 14:18, Eric Blake wrote: > On 3/25/20 7:42 AM, Max Reitz wrote: >> On 24.03.20 18:42, Eric Blake wrote: >>> As the feature name table can be quite large (over 9k if all 64 bits >>> of all three feature fields have names; a mere 8 features leaves only >>> 8 bytes for a backing file name

[Bug 1869006] [NEW] PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Marcin Juszkiewicz
Public bug reported: During one meeting coworker asked "did someone tried to passthrough PCIe card to other arch guest?" and I decided to check it. Plugged SATA and USB3 controllers into spare slots on mainboard and started playing. On 1GB VM instance it worked (both cold- and hot- plugged). On 4

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB

2020-03-25 Thread Marcin Juszkiewicz
Qemu command line for booting VM was generated by libvirt: /usr/bin/qemu-system-aarch64 -name guest=fedora-aarch64-pcie,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-1-fedora-aarch64-pcie/master-key.aes -blockdev {"driver":"file","filename":"/

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB

2020-03-25 Thread Marcin Juszkiewicz
attaching as file as launched wraps in ugly way ** Attachment added: "lspci -vvv" https://bugs.launchpad.net/qemu/+bug/1869006/+attachment/5341486/+files/lspci-vvv.text ** Summary changed: - PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB + PCIe cards passt

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB

2020-03-25 Thread Marcin Juszkiewicz
lspci -vvv output of used cards (host side): 28:00.0 USB controller: Renesas Technology Corp. uPD720201 USB 3.0 Host Controller (rev 03) (prog-if 30 [XHCI]) DeviceName: RTL8111EPV Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Dr. David Alan Gilbert
** Summary changed: - PCIe cards passthrough to TCG guest works only up to 3054MB of guest memory + PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg) -- You received this bug notification because you are a member of qemu- devel-ml, whic

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Marcin Juszkiewicz
Hotplug to VM with 3055MB of memory ends same way: internal error: błąd podczas wykonać polecenia QEMU „device_add”: vfio :28:00.0: failed to setup container for group 27: memory listener initialization failed: Region mach-virt.ram: vfio_dma_map(0x55c1aca5c5c0, 0x4000, 0xbef0, 0x7f3549

Re: [PATCH v2 3/4] qcow2: Avoid feature name extension on small cluster size

2020-03-25 Thread Eric Blake
On 3/25/20 8:52 AM, Max Reitz wrote: If we want to write it like that, which size limit do you propose?  Or asked differently, how much space should we reserve for other extension headers + backing file name? Well, that was the “2k/3k/...” list. :) The backing file name is limited to 1k, so I

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

2020-03-25 Thread Oksana Voshchana
Hi Philippe Thanks for the review I have some comments On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé wrote: > Hi Oksana, > > v2 was > https://www.mail-archive.com/qemu-devel@nongnu.org/msg682899.html, so > this is v3. Please increment the version in the patch subject. > > You could also

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Marcin Juszkiewicz
14:57 < aw> hrw: under /sys/kernel/iommu_groups/ there's a reserved_regions file for every group. cat the ones associated with the groups for these devices 14:59 < hrw> 14:58 (0s) hrw@puchatek:28$ cat reserved_regions 14:59 < hrw> 0xfee0 0xfeef msi 14:59 < hrw> 0x00fd

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/25/20 3:10 PM, Oksana Voshchana wrote: Hi Philippe Thanks for the review I have some comments On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: Hi Oksana, v2 was https://www.mail-archive.com/qemu-devel@nongnu.org/msg682899.html, so

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Alex Williamson
Summary: ARM64 TCG VM on x86 host has GPA overlapping host reserved IOVA regions, vfio cannot map these. The VM needs holes in the GPA to account for this. The 2nd and 3rd args of the vfio_dma_map error report are the starting IOVA address and length respectively. -- You received this bug notif

[PATCH v2 0/4] FWNMI follow up patches

2020-03-25 Thread Nicholas Piggin
Since v1, I addressed Greg's review comments, and took the mce injection patch out of this series. Thanks, Nick Nicholas Piggin (4): ppc/spapr: KVM FWNMI should not be enabled until guest requests it ppc/spapr: Improve FWNMI machine check delivery corner case comments ppc/spapr: Add FWNMI m

[PATCH v2 4/4] ppc/spapr: Don't kill the guest if a recovered FWNMI machine check delivery fails

2020-03-25 Thread Nicholas Piggin
Try to be tolerant of FWNMI delivery errors if the machine check had been recovered by the host. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_events.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c

[PATCH v2 1/4] ppc/spapr: KVM FWNMI should not be enabled until guest requests it

2020-03-25 Thread Nicholas Piggin
The KVM FWNMI capability should be enabled with the "ibm,nmi-register" rtas call. Although MCEs from KVM will be delivered as architected interrupts to the guest before "ibm,nmi-register" is called, KVM has different behaviour depending on whether the guest has enabled FWNMI (it attempts to do more

Re: [PATCH-for-5.0 3/3] virtio-gpu: Release memory returned by virtqueue_pop() with free()

2020-03-25 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 12:31 PM Philippe Mathieu-Daudé wrote: > > As virtio_gpu_handle_ctrl() fills the cmdq calling virtqueue_pop(), > we need to release it with free() in virtio_gpu_reset(). > > virtio_gpu_handle_ctrl() allocates memory calling virtqueue_pop(), > release it in virtio_gpu_pr

[PATCH v2 2/4] ppc/spapr: Improve FWNMI machine check delivery corner case comments

2020-03-25 Thread Nicholas Piggin
Some of the conditions are not as clearly documented as they could be. Also the non-FWNMI case does not need a large comment. Reviewed-by: Greg Kurz Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_events.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/

[PATCH v2 3/4] ppc/spapr: Add FWNMI machine check delivery warnings

2020-03-25 Thread Nicholas Piggin
Add some messages which explain problems and guest misbehaviour that may be difficult to diagnose in rare cases of machine checks. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_events.c | 4 hw/ppc/spapr_rtas.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/hw/ppc/spapr_events.

Re: [PATCH v4 02/15] util: vfio-helpers: Remove Error parameter from qemu_vfio_undo_mapping()

2020-03-25 Thread Murilo Opsfelder Araújo
On Thursday, March 5, 2020 11:29:32 AM -03 David Hildenbrand wrote: > Everybody discards the error. Let's error_report() instead so this error > doesn't get lost. > > This is now the same error handling as in qemu_vfio_do_mapping(). However, > we don't report any errors via the return value to the

[Bug 1863247] Re: AArch64 EXT instruction for V register does not clear MSB side bits

2020-03-25 Thread Kentaro Kawakami
Thank you for bug fix. I found trn1, trn2, zip1, zip2, uz1, uz2 instructions seem to have same bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863247 Title: AArch64 EXT instruction for V regist

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Alex Bennée
** Tags added: arm passthrough tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869006 Title: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map inv

[PATCH 0/5] ppc: sreset and machine check injection

2020-03-25 Thread Nicholas Piggin
This adds nmi injection for pnv, and similar mce injection for spapr and pnv. The mce injection has already uncovered quite a few bugs in Linux papr guest and one in pnv host code, so it has been already very useful. The mambo simulator can do similar injection but it's a bit more clunky and needs

[PATCH 3/5] nmi: add MCE class for implementing machine check injection commands

2020-03-25 Thread Nicholas Piggin
Like commit 9cb805fd26 ("cpus: Define callback for QEMU "nmi" command") this implements a machine check injection command framework and defines a monitor command for ppc. Signed-off-by: Nicholas Piggin --- hmp-commands.hx | 20 +++- hw/core/nmi.c| 61

[PATCH 1/5] ppc/spapr: tweak change system reset helper

2020-03-25 Thread Nicholas Piggin
Rather than have the helper take an optional vector address override, instead have its caller modify env->nip itself. This is more consistent when adding pnv nmi support, and also with mce injection added later. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 9 ++--- target/pp

[PATCH 5/5] ppc/pnv: Implement mce injection

2020-03-25 Thread Nicholas Piggin
This implements mce injection for pnv. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 55 target/ppc/cpu.h | 1 + target/ppc/excp_helper.c | 12 + 3 files changed, 68 insertions(+) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c

[PATCH 4/5] ppc/spapr: Implement mce injection

2020-03-25 Thread Nicholas Piggin
This implements mce injection for spapr. (qemu) mce 0 0x20 0x80 0xdeadbeef 1 Disabling lock debugging due to kernel taint MCE: CPU0: machine check (Severe) Host SLB Multihit DAR: deadbeef [Recovered] MCE: CPU0: machine check (Severe) Host SLB Multihit [Recovered] MC

[PATCH 2/5] ppc/pnv: Add support for NMI interface

2020-03-25 Thread Nicholas Piggin
This implements the NMI interface for the PNV machine, similarly to commit 3431648272d ("spapr: Add support for new NMI interface") for SPAPR. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/hw/ppc

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/25/20 3:10 PM, Oksana Voshchana wrote: Hi Philippe Thanks for the review I have some comments On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: Hi Oksana, v2 was https://www.mail-archive.com/qemu-devel@nongnu.org/msg682899.html, so

Re: [PATCH-for-5.0 v2 4/4] sheepdog: Consistently set bdrv_has_zero_init_truncate

2020-03-25 Thread Philippe Mathieu-Daudé
On 3/24/20 6:42 PM, Eric Blake wrote: block_int.h claims that .bdrv_has_zero_init must return 0 if .bdrv_has_zero_init_truncate does likewise; but this is violated if only the former callback is provided if .bdrv_co_truncate also exists. When adding the latter callback, it was mistakenly added to

Re: [PATCH v1 12/22] intel_iommu: add PASID cache management infrastructure

2020-03-25 Thread Peter Xu
On Wed, Mar 25, 2020 at 12:20:21PM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Wednesday, March 25, 2020 1:32 AM > > To: Liu, Yi L > > Subject: Re: [PATCH v1 12/22] intel_iommu: add PASID cache management > > infrastructure > > > > On Sun, Mar 22, 2020 at 05:36:09AM -0700, Liu Yi L wrot

Re: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to host

2020-03-25 Thread Peter Xu
On Wed, Mar 25, 2020 at 12:42:58PM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Wednesday, March 25, 2020 1:47 AM > > To: Liu, Yi L > > Subject: Re: [PATCH v1 14/22] intel_iommu: bind/unbind guest page table to > > host > > > > On Sun, Mar 22, 2020 at 05:36:11AM -0700, Liu Yi L wrote: >

[Bug 1863247] Re: AArch64 EXT instruction for V register does not clear MSB side bits

2020-03-25 Thread Richard Henderson
All of those, and tbl, tbx, ins, are fixed in the three subsequent commits. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863247 Title: AArch64 EXT instruction for V register does not clear MSB si

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Gerd Hoffmann
On Wed, Mar 25, 2020 at 01:32:12PM +0100, Igor Mammedov wrote: > On Thu, 19 Mar 2020 09:01:04 +0100 > Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to toggle

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-03-25 Thread Peter Maydell
My (limited) understanding of PCI was that the board and the PCI controller emulation define what the windows are where PCI BARs can live, and that PCI cards go there. (This certainly works for emulated PCI cards.) It's not clear to me why the host system imposes restrictions on the memory layout o

Re: [PATCH v1 15/22] intel_iommu: replay guest pasid bindings to host

2020-03-25 Thread Peter Xu
On Wed, Mar 25, 2020 at 01:14:26PM +, Liu, Yi L wrote: [...] > > > +/** > > > + * Caller of this function should hold iommu_lock. > > > + */ > > > +static bool vtd_sm_pasid_table_walk_one(IntelIOMMUState *s, > > > +dma_addr_t pt_base, > > > +

Re: [PATCH v1 17/22] intel_iommu: do not pass down pasid bind for PASID #0

2020-03-25 Thread Peter Xu
On Wed, Mar 25, 2020 at 10:42:25AM +, Liu, Yi L wrote: > > From: Peter Xu < pet...@redhat.com> > > Sent: Wednesday, March 25, 2020 2:13 AM > > To: Liu, Yi L > > Subject: Re: [PATCH v1 17/22] intel_iommu: do not pass down pasid bind for > > PASID > > #0 > > > > On Sun, Mar 22, 2020 at 05:36:1

[PULL 03/11] tests/vm: update FreeBSD to 12.1

2020-03-25 Thread Alex Bennée
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Alex Bennée Message-Id: <20200310083218.26355-4-kra...@redhat.com> Message-Id: <20200323161514.23952-4-alex.ben...@linaro.org> diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 58166766d91..298967fe9cf 100755 --- a/tests/vm/f

Re: [PATCH v4 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-03-25 Thread Beata Michalska
Hi, On Mon, 23 Mar 2020 at 12:44, Andrew Jones wrote: > > On Mon, Mar 23, 2020 at 11:32:26AM +, Beata Michalska wrote: > > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort > > exception with no valid ISS info to be decoded. The lack of decode info > > makes it at least

[PULL 01/11] tests/vm: write raw console log

2020-03-25 Thread Alex Bennée
From: Gerd Hoffmann Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal to watch the install console. Signed-off-by: Gerd Hoffmann Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200310083218.26355-2-kra...@redhat.com> Message-Id: <20200323161514.23952-

<    1   2   3   4   >