[quagga-dev 15832] Re: [PATCH 3/5] Add protobuf support for FPM.

2016-06-30 Thread Avneesh Sachdev
On Thu, Jun 30, 2016 at 3:25 AM, Paul Jakma wrote: > On Wed, 29 Jun 2016, Avneesh Sachdev wrote: > > As you said, this file merely defines the wire format of messages >> exchanged with the FPM. Our (Sproute's) view is that this format should be >> no more subject to the GPL than, say, the OSPF w

[quagga-dev 15833] Re: [PATCH 3/5] Add protobuf support for FPM.

2016-06-30 Thread Avneesh Sachdev
On Thu, Jun 30, 2016 at 3:32 AM, Paul Jakma wrote: > On Thu, 30 Jun 2016, Paul Jakma wrote: > > https: //lists.quagga.net/pipermail/quagga-dev/2012-October/009932.html >>> and >>> https: //lists.quagga.net/pipermail/quagga-dev/2012-November/010020.html >>> . >>> >> >> I didn't notice that >> > >

[quagga-dev 15831] Someone rebased volatile/patch-tracking/8/proposed/ff branch

2016-06-30 Thread Martin Winter
Didn’t we had this discussion back in february and agreed not to do rebasing? It really makes testing painful. If there are serious reason for a rebase, then I would rather see a 8a branch (and the old 8 branch abandoned) I would prefer to just have fixes/reverse commits added on top of it. S

[quagga-dev 15830] Re: [PATCH 21/89] bgpd: Improve peer scaling

2016-06-30 Thread Martin Winter
Paul, I think Donald is out for a week vacation… On 30 Jun 2016, at 7:36, Paul Jakma wrote: Hi, Was it this patch that Martin said caused issues for his CI/testing? (There's a few revisions/resends). I think so, but would need to go back to my old emails (but I don’t think it’s relevant f

[quagga-dev 15829] Re: [PATCH 74/89] bgpd: Add replace-as option to remove-private-as

2016-06-30 Thread Paul Jakma
On Fri, 17 Jun 2016, Daniel Walton wrote: but yeah for the patch you are looking at I think your change would be fine. So, would that be something like the edits I made to bgp_peer_remove_private_as in: http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/patch-tracking/8/proposed

[quagga-dev 15828] Re: [PATCH 56/89] ospfd: Ensure that OSPF can send out multiple packets per thread

2016-06-30 Thread Paul Jakma
Hi, resend: # Some discussion is needed on buffering/pacing. I'd like data that # the function call overhead from thread_whatever to ospf_write is a # big difference, when ospf_write itself can have a non-trivial # function call tree below it. That doesn't seem obviously true? And why '3'

[quagga-dev 15827] Re: [PATCH 84/89] lib, ospf6d, zebra: Add ABR support and make ECMP > 4.

2016-06-30 Thread Paul Jakma
Hi, (resend) This seems to be a mish-mash of two different things? regards, Paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: Dinesh Dutt Add support for ABR and allow ECMP for OSPF6 to work with zebra's ECMP size. Signed-off-by: Dinesh G Dutt Signed-off-by: Pradosh Mohapatra --- lib/

[quagga-dev 15826] Re: [PATCH 78/89] bgpd, isisd, lib, tests: Overhaul BGP debugs

2016-06-30 Thread Paul Jakma
Hi, See below. On Fri, 11 Dec 2015, Donald Sharp wrote: From: Daniel Walton Summary of changes - added an option to enable keepalive debugs for a specific peer - added an option to enable inbound and/or outbound updates debugs for a specific peer - added an option to enable update debugs fo

[quagga-dev 15825] Re: [PATCH 31/89] lib, zebra: Block configuration and installation of martians

2016-06-30 Thread Paul Jakma
On Thu, 23 Jun 2016, Paul Jakma wrote: On Wed, 22 Jun 2016, Andrew Qu wrote: Hi Paul/Donald/Vipin, May I suggest that Zebra/Quagga do not block such martian address configuration? There's actually another patch queued to allow martians: http://git.savannah.gnu.org/cgit/quagga.git/commit

[quagga-dev 15824] Re: [PATCH 05/89] bgpd: cluster-id length equality for multipath

2016-06-30 Thread Paul Jakma
Hi, I agree BGP would be much better if this was lifted up - indeed, if lifted further up past MED then it is guaranteed MED can no longer break your network (yay!). Unfortunately, mixed envs can break iBGP convergence and cause oscillations, as the commit message notes? It seems like a load

[quagga-dev 15823] Re: [PATCH] lib: update Solaris multicast API (BZ#725)

2016-06-30 Thread Paul Jakma
On Thu, 30 Jun 2016, Brian Utterback wrote: Updating the Oracle Solaris kernel may be a possibility, if I could get a spec on what the API should look like. But I thought there was a Quagga dev branch that already was updated to work with Solaris. That was my understanding and I have been eage

[quagga-dev 15822] Re: Tools Document Review - Summary of call

2016-06-30 Thread Paul Jakma
On Thu, 30 Jun 2016, Martin Winter wrote: We decided that we would like to try to use bugzilla more and see how well this works for Quagga. As part of this, the current bugzilla should be updated (it seems to be out of date by some major version) Yeah. It needs upgrading. Too out of date for

[quagga-dev 15821] Tools Document Review - Summary of call

2016-06-30 Thread Martin Winter
Document is updated on Google Docs and attached as a PDF (sorry PDF because of table) to this email Document is at https://docs.google.com/document/d/1s_EbbXwqWPmfOg6ArgKmEMm_iv0vwGvJs-7ZG4yFKb4/edit?usp=sharing The document has a list of personal choices at the end and I would encourage every

[quagga-dev 15820] Re: [PATCH 52/89] lib, vtysh: Add support for marking a file with appropriate end of context

2016-06-30 Thread Paul Jakma
Hi, Queued for consideration in r8. Question: Interesting, though can we get more information about what it's helping? And if it's changing the output of the config file - could it cause issues elsewhere? regards, Paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: Dinesh Dutt To supp

[quagga-dev 15819] Re: [PATCH 28/89] ospfd: Ensure deletion is clean

2016-06-30 Thread Paul Jakma
Hi, Queued for consideration to round 8. Though, a question (resend): # The explanation seems incomplete. How can an oi legitimately have a # NULL address? The only possibility seems to be if ospf_if_new is # given a NULL prefix argument, but that shouldn't happen, surely? # Maybe this

[quagga-dev 15818] Re: [PATCH 23/89] bgpd, lib, vtysh, zebra: Reprocess the trigger points when an attached route map changes

2016-06-30 Thread Paul Jakma
On Fri, 11 Dec 2015, Donald Sharp wrote: From: Dinesh G Dutt Currently, modifications to route maps do not affect already processed routes; they only affect new route updates. This patch addresses this limitation. That's a pretty short commit message, for a fairly involved patch. It'd be ni

[quagga-dev 15816] Re: [PATCH 17/89] bgpd, lib, zebra: 'neighbor interface' config support in BGP including RA/Zebra changes.

2016-06-30 Thread Paul Jakma
Hi, (resend). On Fri, 11 Dec 2015, Donald Sharp wrote: diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c index d0cfb78..ab9f1e1 100644 --- a/bgpd/bgp_fsm.c +++ b/bgpd/bgp_fsm.c @@ -977,6 +977,10 @@ bgp_stop (struct peer *peer) peer_delete(peer); ret = -1; } + else +{ + bg

[quagga-dev 15817] Re: [PATCH] lib: update Solaris multicast API (BZ#725)

2016-06-30 Thread Vincent JARDIN
Le 30/06/2016 16:42, David Lamparter a écrit : I would suggest to apply it, and after that if someone feels like it they can check for updated Solaris APIs or even go patch the Solaris kernel... +1 ___ Quagga-dev mailing list Quagga-dev@lists.quagga.

[quagga-dev 15815] Re: [PATCH] lib: update Solaris multicast API (BZ#725)

2016-06-30 Thread David Lamparter
Note my comment doesn't indicate a regression or new breakage, it only notes a caveat: the Solaris OS API doesn't work with unnumbered IPv4. (Maybe the API changed in the meantime - this patch is pretty old...) But considering it didn't work at all before, the patch is still an improvement. I wo

[quagga-dev 15814] Re: [PATCH 82/89] bgpd: Implement BGP as-override feature

2016-06-30 Thread Paul Jakma
Hi, Thanks. A follow-up to update bgpd.texi would also be good! --paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: Daniel Walton Allow the replacement of a specific AS with another. Signed-off-by: Daniel Walton --- bgpd/bgp_aspath.c | 52

[quagga-dev 15813] Re: [PATCH 81/89] ospfd: Add unnumbered interface support

2016-06-30 Thread Paul Jakma
Hi, This is queued for consideration for round-8. Joakim had noted this was not compatible with existing Quagga setups. Is there any way to address his concerns. He knows his stuff on this - it'd be really good to learn from his patches and/or comments and introduce unnumbered in a way that d

[quagga-dev 15808] Re: [PATCH 12/89] bgpd, lib: Show more meaningful outq value in 'show ip bgp summary' output.

2016-06-30 Thread Paul Jakma
Hi, The first paragraph is correct. Second one is a comment on a completely different patch - just ignore. Sorry. :) Paul On Thu, 30 Jun 2016, Paul Jakma wrote: Hi, This is queued up for review and consideration for integration round-8. Question (sent before): Neat, but what is 'show bg

[quagga-dev 15811] Re: [PATCH 15/89] bgpd: don't count a route with an unreachable nexthop in PfxRcd

2016-06-30 Thread Paul Jakma
Hi, As with the other email on the BGP INFO flags changing patch. Maybe we need to rationalise a bit. It's getting hard to follow what flag means what and overlaps with other flag. ? Paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: Daniel Walton Signed-off-by: Daniel Walton --- bgpd/

[quagga-dev 15812] Re: quagga / quagga-capnproto / push to upstream

2016-06-30 Thread David Lamparter
On Thu, Jun 30, 2016 at 03:53:21PM +0200, Philippe Guibert wrote: > On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter > wrote: > > Hello David, > > > I have a rebased/somewhat-cleaned version around, might be more useful > > to look at that. It's not fully cleaned up yet, but better than what's

[quagga-dev 15807] Re: tags patches

2016-06-30 Thread Paul Jakma
Sigh, I Bcc'ed the list instead of Cc'ing. Then forgot to Cc the list in my previous reply to note that and try get it to the list. ;) Apologies. See below. Paul On Thu, 30 Jun 2016, Paul Jakma wrote: Hi, Your route tags patches (forward ported by Cumulus) are queued up for review for Quag

[quagga-dev 15810] Re: [PATCH 21/89] bgpd: Improve peer scaling

2016-06-30 Thread Paul Jakma
Hi, Was it this patch that Martin said caused issues for his CI/testing? (There's a few revisions/resends). If so, should we keep the jitter? (It'll just go between 1 and 0 then I think). regards, Paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: Daniel Walton Reduce the amount of t

[quagga-dev 15809] Re: [PATCH 16/89] bgpd: Save the last message from a peer that caused us to send a NOTIFICATION

2016-06-30 Thread Paul Jakma
Hi, Thanks. Queued for consideration in r8. Quick question (resend): # Neat, but what is 'show bgp neigh' going to look like now on a box # with many peers? Should there be a separate command to view the # debug? regards, Paul On Fri, 11 Dec 2015, Donald Sharp wrote: From: "dwal...@cu

[quagga-dev 15806] Re: [PATCH 80/89] zebra: Notice passed nexthop is ONLINK

2016-06-30 Thread Paul Jakma
Hi, This is queued up for consideration for round-8. Little question (which is a resend): On Fri, 11 Dec 2015, Donald Sharp wrote: @@ -529,6 +537,25 @@ nexthop_active_ipv6 (struct rib *rib, struct nexthop *nexthop, int set, if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_FILTERED)) return

[quagga-dev 15805] re 'bgpd: Display BGP paths with unreachable nexthops as invalid'

2016-06-30 Thread Paul Jakma
Hi Daniel, Little question on this (a resend I think): Should this use BGP_INFO_HOLDDOWN instead? See also 'bgpd: Display BGP paths with unreachable nexthops as invalid', which (along with one other commit, which I can't quite find right now) raises the question of exactly what the semantics

[quagga-dev 15803] Re: [PATCH 5/5] lib: Add ability to use poll() instead of select

2016-06-30 Thread Paul Jakma
Hi, I have this in r8:ff. It seems this particular bit of this series was still tentative, and there was to be another rev or more.. or? --paul On Sat, 5 Mar 2016, Donald Sharp wrote: It's baby steps in my mind. I left the ability to use select over poll, currently, was because poll causes

[quagga-dev 15804] Re: [PATCH 12/89] bgpd, lib: Show more meaningful outq value in 'show ip bgp summary' output.

2016-06-30 Thread Paul Jakma
Hi, This is queued up for review and consideration for integration round-8. Question (sent before): Neat, but what is 'show bgp neigh' going to look like now on a box with many peers? Should there be a separate command to view the debug? regards, Paul On Fri, 11 Dec 2015, Donald Sharp wro

[quagga-dev 15802] Re: [PATCH] lib: update Solaris multicast API (BZ#725)

2016-06-30 Thread Paul Jakma
Hi, I have this hoovered up for review. Is David's comment a deal-breaker or .. Can it be addressed? regards, Paul On Mon, 14 Jan 2013, Christian Franke wrote: On OpenIndiana/Solaris the build fails with "unsupported multicast API". It's only in the IPv4 part where setsockopt IP_MULTICAST_

[quagga-dev 15801] Re: quagga / quagga-capnproto / push to upstream

2016-06-30 Thread Philippe Guibert
On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter wrote: Hello David, > I have a rebased/somewhat-cleaned version around, might be more useful > to look at that. It's not fully cleaned up yet, but better than what's > currently up there. I'll push it out some time today, will send another > ema

[quagga-dev 15800] Re: [PATCH] tools: Extend multiple-bgpd.sh to support BIRD, ExaBGP plus more configurables

2016-06-30 Thread Paul Jakma
On Wed, 29 Jun 2016, Paul Jakma wrote: * tools/multiple-bgpd.sh: Extend this script to support having multiple different implementations in the ring. Add config generator and launch functions for BIRD and ExaBGP. Allow the proportion of other instances in the ring to peer with to be config

[quagga-dev 15799] Re: [PATCH] bgpd: Add total number of routes received from neighbours to bgp summary

2016-06-30 Thread Paul Jakma
On Thu, 30 Jun 2016, Vincent JARDIN wrote: Le 30/06/2016 12:59, Paul Jakma a écrit : * bgp_vty.c: (bgp_show_summary) The sum of the routes received from each neighbour can be interesting/useful. Add a line with this to end of 'show ... bgp ... summary'. Note, this is also avail

[quagga-dev 15798] Re: [PATCH] bgpd: Add total number of routes received from neighbours to bgp summary

2016-06-30 Thread Vincent JARDIN
Le 30/06/2016 12:59, Paul Jakma a écrit : * bgp_vty.c: (bgp_show_summary) The sum of the routes received from each neighbour can be interesting/useful. Add a line with this to end of 'show ... bgp ... summary'. Note, this is also available from 'show bgp statistics', along with

[quagga-dev 15797] CI Testresult: PASSED (Re: [quagga-dev, 15796] bgpd: Add total number of routes received from neighbours to bgp summary)

2016-06-30 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2015: http://patchwork.quagga.net/patch/

[quagga-dev 15796] [PATCH] bgpd: Add total number of routes received from neighbours to bgp summary

2016-06-30 Thread Paul Jakma
* bgp_vty.c: (bgp_show_summary) The sum of the routes received from each neighbour can be interesting/useful. Add a line with this to end of 'show ... bgp ... summary'. Note, this is also available from 'show bgp statistics', along with more. --- bgpd/bgp_vty.c | 10 -- 1 fil

[quagga-dev 15795] Re: [PATCH 3/5] Add protobuf support for FPM.

2016-06-30 Thread Paul Jakma
On Thu, 30 Jun 2016, Paul Jakma wrote: https: //lists.quagga.net/pipermail/quagga-dev/2012-October/009932.html and https: //lists.quagga.net/pipermail/quagga-dev/2012-November/010020.html. I didn't notice that Ah seems I did, but didn't press it further (would have been busy elsewhere). S

[quagga-dev 15794] Re: [PATCH 3/5] Add protobuf support for FPM.

2016-06-30 Thread Paul Jakma
On Wed, 29 Jun 2016, Avneesh Sachdev wrote: As you said, this file merely defines the wire format of messages exchanged with the FPM. Our (Sproute's) view is that this format should be no more subject to the GPL than, say, the OSPF wire format. The specific scenario we're thinking about is i

[quagga-dev 15793] Re: quagga / quagga-capnproto / push to upstream

2016-06-30 Thread David Lamparter
Hi Philippe, I have a rebased/somewhat-cleaned version around, might be more useful to look at that. It's not fully cleaned up yet, but better than what's currently up there. I'll push it out some time today, will send another email. (Actually started writing docs for capnp...) However - the