Re: [Replicant] [PATCH v2] Fix "RepWifi connection not correctly reported to userspace apps" Issue #1792.

2017-08-05 Thread Joonas Kylmälä
Hi, thanks for the work Fil. I have couple comments about the patch. Fil: > --- > .../com/android/server/ConnectivityService.java| 68 > ++ > 1 file changed, 68 insertions(+) > > diff --git > a/services/core/java/com/android/server/ConnectivityService.java > b/services/c

Re: [Replicant] [PATCH v2] Fix "RepWifi connection not correctly reported to userspace apps" Issue #1792.

2017-08-06 Thread Joonas Kylmälä
Fil: > I put them there, close to "getNetworkInfoByInterfaceName()", just to > keep all my modifications together, so that it's easier to locate them > and remove them in the future. > They can be moved above getActiveNetworkInfo() if there's any strong > reason to do so. It is common practice to

Re: [Replicant] [PATCH v2] Fix "RepWifi connection not correctly reported to userspace apps" Issue #1792.

2017-08-06 Thread Joonas Kylmälä
Fil: > Joonas Kylmälä wrote: >> It is common practice to define them at top of the file. Also the AOSP >> guidelines have it: >> <https://source.android.com/source/code-style#define-fields-in-standard-places>. >> Well, now you might say that that is no reason bu

Re: [Replicant] [PATCH v2] Fix "RepWifi connection not correctly reported to userspace apps" Issue #1792.

2017-08-07 Thread Joonas Kylmälä
Fil: > Joonas Kylmälä wrote: >> I'm not talking about the method below the declarations, but instead >> about the code that is above the declarations: > > Yes, I understood. > I'd seen your point the first time. Okay, it just made me doubt as you said "And

Re: [Replicant] [PATCH v2] Fix "RepWifi connection not correctly reported to userspace apps" Issue #1792.

2017-08-07 Thread Joonas Kylmälä
Fil: > It does matter, instead. > While IPv6 addresses are usually assigned in a globally-unique way, > that's not the case with IPv4, where most infrastructures heavily rely > on NAT'ing, hence giving devices behind a router/AP a private address > (i.e. 192.168.x.x or 10.x.x.x). Think about the 1

Re: [Replicant] i9305: Add support for rt2500usb wifi devices

2017-08-13 Thread Joonas Kylmälä
Hi, Wolfgang Wiedmeyer: > As I understand, this chipset doesn't require firmware to be loaded > as it's already preinstalled. That's correct. > I searched for dongles that have RT2500USB/RT2571 and I had a hard > time finding any that I could buy in my country (Germany). Maybe > there is a way

[Replicant] Galaxy S3 not booting

2017-08-27 Thread Joonas Kylmälä
Hi, I was playing with resistors on the usb port with the i9305 (galaxy s3) device in order to get the UART serial console working. Then I gave up and took the wires out and flashed replicant to the device. The device would not boot. Then I installed twrp with lineage os to the device. Again, it w

Re: [Replicant] i9305: Add support for rt2500usb wifi devices

2017-08-27 Thread Joonas Kylmälä
Joonas Kylmälä: >> How was the performance with low battery charge? > I think there were problems with the performance when I didn't include > that patch #2 that disabled power management. After applying that patch > I think it worked as well with the low battery as with the fu

[Replicant] kernel_samsung_smdk4412: enable /proc/last_kmsg

2017-08-29 Thread Joonas Kylmälä
Hi, It would be beneficial to have /proc/last_kmsg enabled for the kernel kernel_samsung_smdk4412. Users could then easily send their kernel logs for developers to look at. I included a patch to do this. Tested on i9305. Joonas >From 859a3b0ef5cfb592bd42c735e89fdaed31898921 Mon Sep 17 00:00:00 20

[Replicant] i9305 kernel menuconfig

2017-08-29 Thread Joonas Kylmälä
Hi, as I was trying to make /proc/last_kmsg patch also for i9305 device I noticed that the .config file given by "ARCH=arm make lineageos_i9300_defconfig" will be modified by "ARCH=arm make menuconfig". This seems a bit weird to me, so should it be fixed so that it doesn't get modified? Or is ther

Re: [Replicant] i9305 kernel menuconfig

2017-08-29 Thread Joonas Kylmälä
I meant earlier i9300 instead of i9305... Joonas Kylmälä: > Hi, > > as I was trying to make /proc/last_kmsg patch also for i9305 device I > noticed that the .config file given by "ARCH=arm make > lineageos_i9300_defconfig" will be modified by "ARCH=arm make > me

Re: [Replicant] kernel_samsung_smdk4412: enable /proc/last_kmsg

2017-08-31 Thread Joonas Kylmälä
Wolfgang Wiedmeyer: > Thanks for the patch! It's nice to see you getting involved in > Replicant's development :) I'm very excited about the project! :) Kernel hacking is just so cool and then I also get to learn how the mobile phones and tablets in general work. > However, I already have such a p

Re: [Replicant] Galaxy S3 not booting

2017-09-02 Thread Joonas Kylmälä
Wolfgang Wiedmeyer: > Indeed, this sounds strange. It would have been good to have UART to > see what happens ;) I wish I would have had that. If you or someone else reading this have time it would be very helpful to get instructions on how to do it. So far I have tried with the non-modified repl

Re: [Replicant] i9305 kernel menuconfig

2017-09-04 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: >> Or is there some program I should run >> after menuconfig so that I can update the lineageos_i9300_defconfig >> changes to the git repository? > ARCH=arm make savedefconfig Thanks, I will try that! ___ Replicant mailing list Re

Re: [Replicant] Galaxy S3 not booting

2017-10-24 Thread Joonas Kylmälä
Wolfgang Wiedmeyer: > To add a little to what Denis already wrote: Make sure you have a > USB-to-UART converter that has a separate VCC pin and don't connect > it. Unfortunately, I don't really remember what resistor level I used at > the end to make it work with i9300 and I regret not documenting

[Replicant] Work on Replicant 7.1

2018-02-18 Thread Joonas Kylmälä
Hi, I have been working for the past couple days on the next Replicant version. The work I have done is based on the cm-14.1 branches from LineageOS project. Forkbomb (Simon, I guess) said there was no support in LineageOS 15 for the Samsung Galaxy S3 devices so I thought it was better to go with

[Replicant] Compiling Jack for Replicant 7.1

2018-02-23 Thread Joonas Kylmälä
Hi, I was compiling new Jack version for Replicant 7.1 and the new version requires a newer ecj.jar file than what is provided in Debian Stretch or unstable. What to do in this situation? I already sent bug report to Debian so that the version would be updated but it might take some time before th

Re: [Replicant] Compiling Jack for Replicant 7.1

2018-02-23 Thread Joonas Kylmälä
ed. > > Josh > > On 23/02/18 22:14, Joonas Kylmälä wrote: >> Hi, >> >> I was compiling new Jack version for Replicant 7.1 and the new version >> requires a newer ecj.jar file than what is provided in Debian Stretch or >> unstable. What to do in this situat

[Replicant] Help with Replicant 7.1 build error

2018-02-25 Thread Joonas Kylmälä
Hi, I'm trying to build the franken Replicant 7.1 that I have and I get the following error that I cannot figure out how to solve: ninja: Entering directory `.' [ 20% 1/5] Ensure Jack server is installed and started Jack server already installed in "/home/user/.jack-server" Server is already runn

Re: [Replicant] Help with Replicant 7.1 build error

2018-02-25 Thread Joonas Kylmälä
Hi Josh, Josh Branning: > I can't even attempt to help because I can't seem to access git.putti.space There's no HTTP server running there, only git daemon. You can get the source code I use with "repo init -u git://git.putti.space/replicant/manifest.git -b replicant-7.1-dev". However, it's not q

[Replicant] git.replicant.us server configuration

2018-03-01 Thread Joonas Kylmälä
Hi there, I was wondering if we could use some configuration management tool for the git.replicant.us server and then have the scripts publicly in a repository. The web interface doesn't load all the git repositories fast and cloning is somewhat unreliable when the server gets multiple simultaneou

Re: [Replicant] Work on Replicant 7.1

2018-03-03 Thread Joonas Kylmälä
Hi, I have now committed all my Replicant 7.1 work to git repositories. Again, to get the source code all you need to do is create an empty directory and run the following commands inside it: $ repo init -u git://git.putti.space/replicant/manifest.git -b replicant-7.1-dev $ repo sync -jN Then fo

Re: [Replicant] i9305: Add support for rt2500usb wifi devices

2018-03-20 Thread Joonas Kylmälä
Kurtis Hanna: > Hello, > > Just curious, was this patch ever merged? No, it wasn't. Joonas ___ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant

Re: [Replicant] Patch tracking, Was: i9305: Add support for rt2500usb wifi devices

2018-03-23 Thread Joonas Kylmälä
Hi! Denis 'GNUtoo' Carikli: > Would some tool like patchwork be a good idea to track the patches > status? I like the idea. I have found patchwork very useful when one needs to download patches sent to mailing list before joining the list, or if you are developing on different machine where you h

Re: [Replicant] Work on Replicant 7.1

2018-04-11 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: >> $ repo init -u git://git.putti.space/replicant/manifest.git -b >> replicant-7.1-dev >> $ repo sync -jN > As a potential contributor[1] I'm a bit lost: > - which manifest should I base my work on? Depends what you want to work on. That replicant-7.1-dev branch is for Line

Re: [Replicant] Work on Replicant 7.1

2018-06-05 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > On Wed, 11 Apr 2018 15:23:00 +0000 > Joonas Kylmälä wrote: > >> Denis 'GNUtoo' Carikli: > [...] >>> As a potential contributor[1] I'm a bit lost: >>> - which manifest should I base my work on? >>

Re: [Replicant] steps to follow BEFORE installation

2018-06-12 Thread Joonas Kylmälä
Hey! This is definitely the right place for such discussion. Do you want to come up with a draft wiki page for such instructions and send it then to this list? I think they could be useful to some people, and the backing up of ROM also to the developers! About the email: Go to https://lists.osuos

Re: [Replicant] sdcard not mounted

2018-06-19 Thread Joonas Kylmälä
See my comment on the Redmine ticket. Joonas Fil Lupin: > Hello again, > since a few months, I encounter a stranger problem: my sdcard is not mounted > by my system. Then I can just use my phone for basic functionnalities : > https://redmine.replicant.us/issues/1864 > I have no clue where to lo

[Replicant] Changes for 6.0 0004 release

2018-08-28 Thread Joonas Kylmälä
Hi, I have made bunch of little modifications to merge latest updates and security fixes from upstream sources for the next Replicant 6.0 0004 release. Please review them: For https://git.replicant.us/replicant/manifest (branch LineageOS-mirror): 0001-Adapt-to-recent-LineageOS-forks-LineageOS-mir

[Replicant] Draft patch for "F-Droid signed Repwifi" issue

2018-08-28 Thread Joonas Kylmälä
Hi, I tried to draft patches for the RepWifi ticket over here: https://redmine.replicant.us/issues/1887. Please see them as attachments. What do you think will happen when we update the RepWifi app next time in Replicant and the user has already upgraded it with F-Droid? Also will this just start

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-02 Thread Joonas Kylmälä
Hi, I can test it and push after the upstream merges. All the (non-merge) commits to this point have contained the Signed-off-by line but it seems like Replicant project has not formally established a meaning for it? I have taken it's meaning as that one certifies it is originally created by the p

Re: [Replicant] Changes for 6.0 0004 release

2018-09-02 Thread Joonas Kylmälä
builds! Joonas Joonas Kylmälä: > Hi, > > I have made bunch of little modifications to merge latest updates and > security fixes from upstream sources for the next Replicant 6.0 0004 > release. Please review them: > > For https://git.replicant.us/replicant/manifest (branch Linea

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-03 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > On Sun, 2 Sep 2018 21:17:21 +0200 > Fil wrote: > >> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 >> From: Fil Bergamo >> Date: Sun, 2 Sep 2018 16:44:44 + >> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App > Maybe mention the fac

Re: [Replicant] Draft patch for "F-Droid signed Repwifi" issue

2018-09-03 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > On Tue, 28 Aug 2018 18:53:00 +0000 > Joonas Kylmälä wrote: > >> Hi, >> >> I tried to draft patches for the RepWifi ticket over here: >> https://redmine.replicant.us/issues/1887. Please see them as >> attachments. >

Re: [Replicant] Changes for 6.0 0004 release

2018-09-14 Thread Joonas Kylmälä
Hi, just a gentle reminder: if you have time it would be great if you could take a look at the patches so we can get this moving forward. Joonas Joonas Kylmälä: > Hi, > > I can start pushing the merged repositories that didn't require any > additional commits to make it w

Re: [Replicant] Changes for 6.0 0004 release

2018-09-15 Thread Joonas Kylmälä
Hi, thanks for taking a look! :) Denis 'GNUtoo' Carikli: >> I can start pushing the merged repositories that didn't require any >> additional commits to make it work. Is that fine? > I don't understand what that means. I mean pushing those repositories where I did "git merge upstream/" and the m

Re: [Replicant] Changes for 6.0 0004 release

2018-09-15 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > On my side I should improve reviews time. I should also look into > installing a patchwork instance to keep track of the patches I forgot > about. I have an image in my mind that maintaining patchwork for 58 or so git repositories was difficult. If it doesn't turn ou

Re: [Replicant] Changes for 6.0 0004 release

2018-09-17 Thread Joonas Kylmälä
Hey, Denis 'GNUtoo' Carikli: > On Sat, 15 Sep 2018 17:00:00 +0000 > Joonas Kylmälä wrote: > >> I mean pushing those repositories where I did "git merge >> upstream/" and the merge worked without any conflicts >> and didn't require any addit

[Replicant] Messages from the past

2018-09-17 Thread Joonas Kylmälä
Hi, looks like we got bunch of messages from this mailing list from the past? Anybody else got them? I received at least 40 :) However, nice to have look into the past and what was done in the project during 2013-2015! Joonas ___ Replicant mailing list

Re: [Replicant] Changes for 6.0 0004 release

2018-09-23 Thread Joonas Kylmälä
Hi GNUtoo and others, Denis 'GNUtoo' Carikli: >> [0001-Revert-Point-ResXMLTree-to-a-copy-of-the-asset-buffe.patch > The commit reverted by the patch above is this one: >> commit 953d2a3493aaceb3209afc7eef1ff1e7f7242908 >> (replicant/replicant-6.0, m/replicant-6.0-dev) Author: Wolfgang >> Wiedmeyer

[Replicant] Creating new repository to git.replicant.us

2018-09-23 Thread Joonas Kylmälä
Hi Paul and Wolfgang, I tried to create a new LineageOS-mirror repository to git.replicant.us but step 3. at https://redmine.replicant.us/projects/replicant/wiki/LineageMirror is not much help. I think I need actual shell access in order to create the repositories we need because the command to cr

Re: [Replicant] Creating new repository to git.replicant.us

2018-09-24 Thread Joonas Kylmälä
Thanks GNUtoo! It's probably alright that way too. Denis 'GNUtoo' Carikli: > On Sun, 23 Sep 2018 19:54:00 +0000 > Joonas Kylmälä wrote: > >> Hi Paul and Wolfgang, > Hi, > >> I tried to create a new LineageOS-mirror repository to &

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-10-08 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > On Sun, 2 Sep 2018 21:17:21 +0200 > Fil wrote: > >> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 >> From: Fil Bergamo >> Date: Sun, 2 Sep 2018 16:44:44 + >> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App > Maybe mention th

Re: [Replicant] website and wiki consistency

2018-10-10 Thread Joonas Kylmälä
Hi Fil, send a patch for https://git.replicant.us/replicant/website/tree/supported-devices.php and I can apply it after a review. Joonas Fil Lupin: > Hi GNUtoo, > today, some visitor asked which one is correct between website and wiki > (https://redmine.replicant.us/boards/39/topics/13996?r=150

Re: [Replicant] [PATCH] supported-devices: add Galaxy Note 8.0 n51xx

2018-10-19 Thread Joonas Kylmälä
Hi, I noticed you closed the issue on Redmine, so got me wondering if you noticed the whitespace issue Denis mentioned? Would you be able to send updated patch for it? Joonas Fil: > On 10/18/2018 12:26 PM, Denis 'GNUtoo' Carikli wrote: >> Hi, >> >> Thanks a lot for the patch. > > 'ts a pleasure

Re: [Replicant] [PATCH] Native Wi-Fi for external dongles

2018-12-22 Thread Joonas Kylmälä
Hi, thanks for working on this! :) Is > +#define DRV_NUMBER_SEQUENTIAL_ERRORS 40 for the errors caused by the insufficient power supply for the wifi dongle? Joonas Belgin ?tirbu: > To be applied in the base source folder. > > patch -p0 < 6.0-wifi-dongle.patch > > > > _

[Replicant] Meeting at Little Delirium on Friday 19.30 ->

2019-01-31 Thread Joonas Kylmälä
Hi, there is a small meeting tomorrow, Friday at 19.30 and onwards in Brussels at the Little Delirium bar. Everybody's welcome. There is no topic for the meeting but at least few Replicant contributors will be there. Not sure how long we will stay there since some people might want to go eat dinne

Re: [Replicant] phone OS comparison and app alterntives

2019-02-09 Thread Joonas Kylmälä
Hi, Fil Lupin: > 1. Several OS for phones currently exists and it would be useful for > newcomers to understand the differences between Replicant and these OS. It > would also give answers to several questions asked on the forum. Note that the website has already a small comparison in the FAQ:

Re: [Replicant] Replicant funds usage, Handshake donation, and nlnet funding.

2019-02-20 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > Android 9.0 requires 512M of RAM reserved for userspace and kernel > for devices with such displays, so we don't have a lot of margin here. > > The GTA04 A3 and GTA04 A4 which could also be used to work on > adding support for upstream kernels to Replicant both only have

[Replicant] New landing page for Git repositories

2019-03-09 Thread Joonas Kylmälä
Hi, since it is not clear whether git.replicant.us landing page is a piece of copyrightable work and it doesn't have a free license (see https://redmine.replicant.us/issues/1914) I created a new landing page with Creative Commons Attribution-ShareAlike 3.0 Unported License. You can fetch it to you

Re: [Replicant] [PATCH] Use AOSP mirror from git.replicant.us

2019-03-31 Thread Joonas Kylmälä
Hi, I didn't have time to push yet but: Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > default.xml | 387 ++-- > 1 file changed, 193 insertions(+

Re: [Replicant] [PATCH 3/3] supported-devices: Remove Galaxy S and Nexus S

2019-04-21 Thread Joonas Kylmälä
The commit message is missing the reason why to remove these, can you add? Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > supported-devices.php | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/supported-devices.php b/supported-de

Re: [Replicant] [PATCH 1/3] Add basic gitignore

2019-04-21 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > diff --git a/.gitignore b/.gitignore > new file mode 100644 > index 000..c456b20 > --- /dev/null > +++ b/.gitignore > @@ -0,0 +1,3 @@ > +*~ > +*.swp > +#.*# If you are after the emacs autosave files it should be \#*\# instead of #.*# _

Re: [Replicant] [PATCH 2/3] Add a way to generate a static website

2019-04-21 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > diff --git a/README.txt b/README.txt > new file mode 100644 > index 000..7689c66 > --- /dev/null > +++ b/README.txt > @@ -0,0 +1,14 @@ > +== Deployment strategies == > +This website is intended to be deployed as a dynamic version > +because it contains dynamic ele

Re: [Replicant] [PATCH v2 1/3] Add basic gitignore

2019-04-23 Thread Joonas Kylmälä
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 .gitignore > > diff --git a/.gitignore b/.gitignore > new file mode 100

Re: [Replicant] [PATCH v2 2/3] Add a way to generate a static website

2019-04-23 Thread Joonas Kylmälä
If you remove the extra empty line from the end of Makefile then: Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > .gitignore | 2 ++ > Makefile | 33 + > README.txt | 1

Re: [Replicant] [PATCH v2 3/3] supported-devices: Remove Galaxy S and Nexus S

2019-04-23 Thread Joonas Kylmälä
Cool! I didn't notice the previous time but the "Unmaintained devices" row is 4 devices long instead of 3 as in the other rows. Maybe fix this too? Anyways the website scales down nicely even with 4 devices in one row but maybe the images are then not so clear so up to you if you want to fix this.

Re: [Replicant] [PATCH v3] supported-devices: Remove Galaxy S and Nexus S

2019-04-25 Thread Joonas Kylmälä
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > The Nexus S and the Galaxy S were supported by Replicant 2.3 > up to Replicant 4.2. > > As the Replicant versions 4.2 or below are not maintained anymore, > it doesn't make sense to keep the Galaxy S and Nexu

Re: [Replicant] [PATCH] Remove F-Droid until we can make a FSDG compliant version

2019-06-02 Thread Joonas Kylmälä
Hi, I'm focusing my efforts on Replicant 9, so I just checked the patch doesn't do anything horribly wrong: Acked-by: Joonas Kylmälä Feel free to push. Denis 'GNUtoo' Carikli: > It's been more than one year that Replicant is aware that > shipping F-Droid as-is

Re: [Replicant] [PATCH 1/2] tuna_defconfig: Add support for USB Ethernet adapters

2019-06-02 Thread Joonas Kylmälä
Hi, Acked-by: Joonas Kylmälä Other thing: Can you resend the 2/2 patch for this patch set since I for some reason did not receive it. Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > arch/arm/configs/tuna_defconfig | 16 &g

Re: [Replicant] libsamsung-ipc patches

2019-06-02 Thread Joonas Kylmälä
Hey, I received only patches through 1-9. That seems to be the case also in the archive: . Can you resend? Joonas Denis 'GNUtoo' Carikli: > Hi, > > The patches that are following are to be applied against libsamsung-ipc. > > De

Re: [Replicant] [PATCH 6/6] Fix undefined references to MD5_{Init, Update, Final}

2019-06-02 Thread Joonas Kylmälä
Hi, this patch does not apply for replicant-6.0 branch. Please re-send with correction. Joonas Denis 'GNUtoo' Carikli: > Before this change, libsamsung-ril was using > libsamsung-ipc as a static library. > > However, libsamsung-ipc is dynamically linked to > libcrypto. > > Statically linking l

Re: [Replicant] [PATCH 1/6] Remove unused labels

2019-06-02 Thread Joonas Kylmälä
Hi, Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > data.c| 2 -- > gen.c | 2 -- > ipc.c | 1 - > samsung-ril.c | 4 > srs.c | 3 +-- > 5 files changed, 1 ins

Re: [Replicant] [PATCH 2/6] Remove unused variables

2019-06-02 Thread Joonas Kylmälä
Hey, the variable "i" and "fail_cause" are not unused in the function ipc_gprs_call_status(). I guess you noticed these errors because of the macro RIL_VERSION >= 6? Otherwise the patch is all good! Joonas Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > call.c|

Re: [Replicant] [PATCH 3/6] Silence warnings about unused parameters

2019-06-02 Thread Joonas Kylmälä
Hi, I really don't have expertise on this so if you think it is fine I'm okay if you push it since nobody has reviewed this in such a long time. One thing caught my eye but it could be just okay: Denis 'GNUtoo' Carikli: > @@ -1449,8 +1449,9 @@ RIL_RadioFunctions ril_radio_functions = { > ri

Re: [Replicant] [PATCH 4/6] client: Fix warning about array comparison to a null pointer

2019-06-02 Thread Joonas Kylmälä
Hi, Reviewed-by: Joonas Kylmälä Joonas Denis 'GNUtoo' Carikli: > Without that fix we have: > client.c:32:6: error: comparison of array > 'ril_clients' equal to a null pointer is always > false [-Werror,-Wtautological-pointer-compare] > if (ril_c

Re: [Replicant] [PATCH 5/6] Fix implicit declaration of ipv4NetmaskToPrefixLength

2019-06-02 Thread Joonas Kylmälä
Hi, somebody who knows C better please review this! Joonas Denis 'GNUtoo' Carikli: > Rationale for using extern: > --- > The ipv4NetmaskToPrefixLength function is implemnted > in libnetutils/ifc_utils.c inside the android_system_core > repository[1]. > > In the lineage-1

Re: [Replicant] Was: [PATCH 2/2] tuna_defconfig: sync CDC Ethernet support with other devices

2019-06-03 Thread Joonas Kylmälä
Hi, okay, I don't want to spend more time reviewing these ethernet support patches so unless somebody else objects to these patches in one week and you feel confident in them please go ahead with pushing them. (I'm trying to focus my efforts again on Replicant 9.) Joonas Denis 'GNUtoo' Carikli:

Re: [Replicant] libsamsung-ril/libsamsung-ipc: delete or sync master branch? Was: [PATCH 6/6] Fix undefined references to MD5_{Init, Update, Final}

2019-06-03 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > Ah I understand what went wrong. I based my work on top of master > instead of the replicant-6.0 branch which is more recent. > > For now, I've pushed the first Acked patch to replicant-6.0-dev that > was created along the way. We generally have not used those *-dev

Re: [Replicant] [PATCH] Remove F-Droid until we can make a FSDG compliant version

2019-06-07 Thread Joonas Kylmälä
Hi, ni nhar: >> I'm focusing my efforts on Replicant 9 > > Do you say, a replicant 9 for the samsung phones is > on its way? Yes, check out the page https://redmine.replicant.us/projects/replicant/wiki/Porting_Replicant_to_Android_9 for current status. Joonas ___

Re: [Replicant] Replicant contributors meeting in Paris (France) in July

2019-06-07 Thread Joonas Kylmälä
Hi, I'm in! We can already decide probably a date for this since in the worst case we can just meet up in some public place. I suggest 27-28 of July. This way people can already get travel tickets for lower price and probably don't have so many other plans yet. Joonas Denis 'GNUtoo' Carikli: > H

Re: [Replicant] Presentations for the Replicant contributor meeting in Paris (France) the 27 and 28 July

2019-06-18 Thread Joonas Kylmälä
Hi, I was thinking a while back telling something about the porting process of a new device or basically what I did with the i9305 with the initial AOSP work. I will think about it again if I can make some sort of story or presentation about it. I would like to see presentations about the modem a

Re: [Replicant] replicant make comment on the pinephone

2019-06-23 Thread Joonas Kylmälä
Hi, ni nhar: > You say, likely there are several new phones > which have the replicant required hardware modem > isolation and therefore qualifies > for getting a replicant version? > Those phones do not get a replicant version > because of lack of money to > get replicant ported? That would be a

Re: [Replicant] Replicant contributors meeting in Paris (France) in July

2019-06-30 Thread Joonas Kylmälä
Hi, the dates are confirmed (https://redmine.replicant.us/projects/replicant/wiki/ReplicantContributorsMeetingJuly2019) and location is somewhere in Paris or nearby. The exact venue will be hopefully decided shortly. I quickly calculated and there will be at least 6 people involved more or less d

Re: [Replicant] Status of Mesa's llvmpipe for Android

2019-07-15 Thread Joonas Kylmälä
Hi dllud, thanks for the research! As we can see in https://github.com/maurossi/mesa/commit/f7c2a171a4320a5a713861440f5f3df2611d7b1e the change in Android build files to make llvmpipe work might be relatively small. Because this doesn't appear a to be huge amount of work and maintanance burden I w

Re: [Replicant] Status of Mesa's llvmpipe for Android

2019-07-15 Thread Joonas Kylmälä
ngs a bit harder. The patches are in our fork that is used with the Replicant 9 work. Joonas Kylmälä: > Hi dllud, > > thanks for the research! As we can see in > https://github.com/maurossi/mesa/commit/f7c2a171a4320a5a713861440f5f3df2611d7b1e > the change in Android build files t

Re: [Replicant] replicant make comment on the pinephone

2019-07-16 Thread Joonas Kylmälä
Hi, ni nhar: > > > Does it make the pinephone suitable for replicant? > > It looks way more suitable than the phones > already supported by > > Replicant. > > Then we should crowd fund getting you a pinephone. there are already funds for this sort of purchases so I'm sure

[Replicant] Graphics work progress for Replicant 9

2019-07-21 Thread Joonas Kylmälä
Hi, I wrote a summary on the blog about the Replicant 9 graphics work dllud, GrimKriegor and I have been doing for the last couple weeks. For anybody interested here it is: https://blog.replicant.us/2019/07/graphics-support-for-replicant-9/ Joonas ___ R

[Replicant] Replicant contributor meeting schedule

2019-07-25 Thread Joonas Kylmälä
Hi, few people have now filled in the poll for the contributor meeting in Paris: . So here is my suggestion based on the poll: Saturday 11:00 -> 17:00 (and if possible / there are interested people we can still continue hac

Re: [Replicant] Replicant contributor meeting schedule

2019-07-26 Thread Joonas Kylmälä
Hi Tiberiu, there is a dinner planned at 18.30: https://redmine.replicant.us/projects/replicant/wiki/ReplicantContributorsMeetingJuly2019#Related-events I'm not coming there myself. Joonas Tiberiu: > Hi, > > Anyone else in town today and also want to meet in this afternoon or evening, > for a

Re: [Replicant] food for replicant contributor meeting

2019-07-26 Thread Joonas Kylmälä
Thanks Fil! If you can also get something vegan would be nice. Maybe hummus with the bread (check that there are no egg, milk, etc. that is sometimes in bread). I'm not sure if I have time to go buy anything before the event on Saturday but if I do I might bring something also. Joonas Fil Lupin:

Re: [Replicant] Replicant contributor meeting schedule

2019-07-26 Thread Joonas Kylmälä
Hi, Tiberiu: > Also, two of my room mates here would like to attend the hackathon the next > days, but they're not familiar with Replicant or Android internals, they have > some Java/Dalvik knowledge. Can they come? I promised I'd ask. Of course they are welcome to join! See you tomorrow. Joon

Re: [Replicant] [PATCH] added new rss url to fix rss on the front page

2019-08-01 Thread Joonas Kylmälä
Hi, thanks! So continuing the discussion that happened on IRC: in my opinion if nobody has time to make a RSS feed like it was with the Gitlab Replicant group we could remove this widget instead. And regarding this patch, it just tells a tiny part of the work happening so I think it might misrepre

Re: [Replicant] Minutes of the 2019 Paris meeting

2019-08-06 Thread Joonas Kylmälä
Hi, yes, the summary and video recordings is here: https://redmine.replicant.us/projects/replicant/wiki/ReplicantContributorsMeetingJuly2019 Laurent F: > Hello everyone, > > Is there a summary available or some kind of report of what have been > discussed during the meeting in Paris in July? Ha

Re: [Replicant] pinephone chief wants to ship phones to a replicant manager denis please read this post

2019-08-14 Thread Joonas Kylmälä
Hi, I'm not personally interested at this time (maybe in the future) but maybe adtjm, dllud, GrimKriegor or GNUtoo are? Joonas ni nhar: >  After asking the ceo of pine64, the company which > manufactures the pinephone, some > questions in a pm on the pine64 forum, he answered me. > > He says, h

Re: [Replicant] [PATCH][website] index: Lastest images: Remove replicant 4.2 because it's not maintained anymore

2019-09-06 Thread Joonas Kylmälä
Hi, fix the "Lastest images" typo from the commit title then: Acked-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > index.php | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Replicant] [PATCH][website] index: Lastest images: Remove replicant 4.2 because it's not maintained anymore

2019-09-09 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > On Fri, 6 Sep 2019 20:03:41 +0300 > Joonas Kylmälä wrote: > >> Hi, >> >> fix the "Lastest images" typo from the commit title then: >> >> Acked-by: Joonas Kylmälä > > Thanks. I've pushed it. > &

Re: [Replicant] How shall we Redmine?

2019-10-07 Thread Joonas Kylmälä
Hi, subprojects (and using any other redmine feature) is okay as long as there is some good use for it, and I think if someone starts to use some feature in some way that causes trouble for others then I think we can make it stop quite quickly. Having a subproject for infrastucture seems good idea

Re: [Replicant] [PATCH] Native Android WiFi with external dongle

2019-10-08 Thread Joonas Kylmälä
Hi Belgin, would you be able to make a new version of this patch within this week? We are hoping to make a release candidate for Replicant 6.0004 next Monday and release the following Sunday. Joonas Denis 'GNUtoo' Carikli: > Hi, > > I'm really sorry for the delay. > > Thanks a lot for working

Re: [Replicant] [PATCH 0/7] Per process libagl/llvmpipe

2019-10-09 Thread Joonas Kylmälä
a/com.android.browser Without the last patch: Tested-by: Joonas Kylmälä Joonas Andrés Domínguez: > Selection of libagl or llvmpipe at EGL link time. It's based > on the work of Jookia and JeremyRand, but it uses files for > configuration instead of properties or symlinks. >

[Replicant] [PATCH] Disable phone number lookup settings during upgrade

2019-10-09 Thread Joonas Kylmälä
This disables during the upgrade settings that cause private information leaking through phone number lookup feature. Signed-off-by: Joonas Kylmälä --- .../cyanogenmod/cmsettings/CMDatabaseHelper.java| 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a

Re: [Replicant] [PATCH] Disable phone number lookup settings during upgrade

2019-10-09 Thread Joonas Kylmälä
Hi, this is to be applied to https://git.replicant.us/replicant/vendor_cmsdk/ Joonas Kylmälä: > This disables during the upgrade settings that cause private > information leaking through phone number lookup feature. > > Signed-off-by: Joonas Kylmälä > --- > .../cyan

[Replicant] [PATCH] Hide information leaking phone number lookup settings

2019-10-09 Thread Joonas Kylmälä
The phone number lookup service leaks private information so hide the option to enable it. Signed-off-by: Joonas Kylmälä --- src/com/android/dialer/settings/DialerSettingsActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/dialer/settings

Re: [Replicant] [PATCH] Hide information leaking phone number lookup settings

2019-10-09 Thread Joonas Kylmälä
Hi, this patch is applied to https://git.replicant.us/LineageOS-mirror/android_packages_apps_Dialer/. That is now a LineageOS mirror repo so if this patch is reviewed and accepted we need to fork the LineageOS repo. Joonas Joonas Kylmälä: > The phone number lookup service leaks priv

Re: [Replicant] release candidate for Replicant 6.0004

2019-10-09 Thread Joonas Kylmälä
Hi, Jozef Macko: > Would like to know if you prepare one day release of Replicate with base of > Android 9 or 10, please? yes, we are working on that, LineageOS 16 based Replicant 9. Joonas ___ Replicant mailing list Replicant@osuosl.org https://lists.

[Replicant] [PATCH] Use new name of FDroidPrivilegedExtension package

2019-10-09 Thread Joonas Kylmälä
The FDroidPrivilegedExtension package was updated in the manifest to 0.2.8 version. In this new version the package name is F-DroidPrivilegedExtension. Signed-off-by: Joonas Kylmälä --- config/common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common.mk b

Re: [Replicant] [PATCH] Hide information leaking phone number lookup settings

2019-10-10 Thread Joonas Kylmälä
Hi, Fil Lupin: > Should we not submit this patch also to LineageOS repo? > Do you think they will not be interested? > This could help making some users/developpers realize that android is not > exempt of privacy issues. I don't think cyanogenmod/lineageos 13 is developed anymore and this patch

Re: [Replicant] [PATCH] Use new name of FDroidPrivilegedExtension package

2019-10-10 Thread Joonas Kylmälä
Thanks, pushed! Denis 'GNUtoo' Carikli: > On Thu, 10 Oct 2019 09:23:59 +0300 > Joonas Kylmälä wrote: > >> From: Joonas Kylmälä >> To: replicant@osuosl.org >> Subject: [Replicant] [PATCH] Use new name of >> FDroidPrivilegedExtension package Date

Re: [Replicant] [PATCH] Disable phone number lookup settings during upgrade

2019-10-10 Thread Joonas Kylmälä
Thanks, pushed. Denis 'GNUtoo' Carikli: > On Thu, 10 Oct 2019 00:12:56 +0300 > Joonas Kylmälä wrote: > >> This disables during the upgrade settings that cause private >> information leaking through phone number lookup feature. >> >> Signed-off-by:

Re: [Replicant] [PATCH 0/7] Per process libagl/llvmpipe

2019-10-10 Thread Joonas Kylmälä
ed. I suggest we push these patches except the last one now even if there is no review as more than one week has passed. I'm still hoping to hear from at least some of you in the To field of this email whether you are okay pushing the patches. Joonas Joonas Kylmälä: > Hi, >

  1   2   >