Extended Ship it feature, Defaults for diff base path

Hello Reviewboard Developers! We at the TYPO3 Project are currently evaluating ReviewBoard for our patch workflow. As far as I see it, I am really impressed! There are just minor details which would be nice to have: - In our workflow, we require that there are at least 2 +1s (or ship it),

Re: Extended Ship it feature, Defaults for diff base path

Hi Sebastian. On Mon, Jan 26, 2009 at 2:37 AM, Sebastian Kurfuerst sebastian.kurfue...@gmail.com wrote: Hello Reviewboard Developers! We at the TYPO3 Project are currently evaluating ReviewBoard for our patch workflow. As far as I see it, I am really impressed! There are just minor

Re: Extended Ship it feature, Defaults for diff base path

Hey Christian, thanks for your super-fast response! Right now, we don't have anything in the code to enforce policies such as requiring two ship its before you can close out a review request. Since Review Board doesn't actually commit reviews, we can't enforce anything like that. Yep, that

Re: trunk broken?

It's due to a breakage in djblets's nightly build. It'll be fixed in tonight's nightly, or you can grab djblets svn and do: sudo python setup.py nightly install Christian On 1/26/09, DeeJay1 lukasz.jer...@gmail.com wrote: Hi! After todays svn update to rev 1712 I get: # rb-site upgrade

How do I switch back to account authentication?

Hi all, I got a Review Board install up and running on Windows, which was no small feat. It was working really well, and I'm really impressed with the tool. I got a little ambitious and tried switching to Active Directory authentication, after installing python-ldap from here:

Re: How do I switch back to account authentication?

Hi Jeremy. From the exception, it sounds like you don't have the crypt module. What version of Python are you running and how did you install it? If you can look for some missing crypt model, you may be able to fix this quickly and log in again. If not, I'll work up a small set of instructions

Re: How do I switch back to account authentication?

OK, that makes sense. Good call on the backup the DB approach. It looks like maybe Windows implementations of Python don't use crypt - it's POSIX only? When I just fire up my standard interpreter and try 'import crypt', I get ImportError: No module named crypt.

Re: How do I switch back to account authentication?

Having fun replying to myself here... http://www.python.org/doc/2.5.2/lib/module-nis.html 16.14 nis -- Interface to Sun's NIS (Yellow Pages) Availability: UNIX. The nis module gives a thin wrapper around the NIS library, useful for central administration of several hosts. Because NIS exists

Re: How do I switch back to account authentication?

Funny, I don't remember other people running into this, but I can see how one might... We probably should just have the imports for nis and crypt reside in the classes that use them, and then just catch the ImportError and do the right thing if it doesn't exist. Christian -- Christian Hammond

RE: Extended Ship it feature, Defaults for diff base path

Sebastian, OK. Currently, we have a mailing list for posting patches to, and as said, we require two +1s - at least one from a core developer. Now, many patches are still lying around as it sometimes takes a lot of time to review complicated changes. Currently, it is basically impossible to

Re: Help: how to migrate data from an old version?

I am at r1433, do I have any chance to upgrade? syndb says nothing, but the db is obviously old. Bela On Jan 17, 11:52 am, Christian Hammond chip...@chipx86.com wrote: If you do rb-site upgrade /path/to/site, that will run syncdb and evolve for you, which should fix it. Christian --

Re: Help: how to migrate data from an old version?

It should work. Make sure you do a backup first, but the upgrades should work between almost any version. Your version shouldn't be too old for it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 26, 2009 at 6:48 PM, teki teki...@gmail.com wrote: I am at

alpha1 clean installation fails

Empty mysql database, Django-1.0.2_final, Djblets-0.5alpha1, ReviewBoard-1.0alpha1, python 2.5, osx 10.5. * Installing the site... Building site directories ... OK Building site configuration files ... OK Creating database ... Creating table django_admin_log Creating table auth_permission

Re: alpha1 clean installation fails

I've been unable to duplicate this. This almost looks like an issue internal to Django, but I can't be sure what it is. Can you send me the output of: SELECT * FROM siteconfig_siteconfiguration\G from the MySQL command line. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc.

Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.

Comment #6 on issue 807 by jefflamb: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 Links to diffs might be fixed now. I haven't verified, but this may be related to issue 828. -- You received this

Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.

Comment #8 on issue 807 by chipx86: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 Really? It should solve that. You're still seeing this problem? We're using the same address in the e-mails and on the

Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

Status: New Owner: Labels: Type-Defect Priority-Medium New issue 831 by mkoebele: Can't leave comments before you publish your own newly created review request http://code.google.com/p/reviewboard/issues/detail?id=831 What steps will reproduce the problem? 1. create a new review request