New user group

2009-02-17 Thread KunalG
Hi, We are setting up review board in our company and found one feature which we need. We use LDAP authentication for login. So after a request is created by user A and A wants to add a review group to the request. But this user group needs to be created in Review Board. Is there any way we can

Diff between revisions is broken in alpha4

2009-02-17 Thread Martin
Hi, when I view the diff between revisions I get either one of the following two issues: 1) A page containing the error message : list index out of range Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-

Re: Diff between revisions is broken in alpha4

2009-02-17 Thread Martin
ah, somebody already opened a bug for this: http://code.google.com/p/reviewboard/issues/detail?id=892 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to

Re: Traceback generated when I click “View Diff”

2009-02-17 Thread eugene_k
I do have patch in the path. Patch version 2.5.4 on Linux and 2.5.9 on Windows. Is there anything else to check? Thanks, Eugene On Feb 16, 6:49 pm, Christian Hammond chip...@chipx86.com wrote: Looks like you don't have patch in your path. Christian -- Christian Hammond -

Re: Diff between revisions is broken in alpha4

2009-02-17 Thread Sebastien Douche
On Tue, Feb 17, 2009 at 16:28, Martin mkoeb...@gmail.com wrote: Am I the only one experiencing that? I have this problem too. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups

Re: Using the demo

2009-02-17 Thread Jeff Andros
diff headers for reviewboard are a bit different... the server needs to know not only the path to the file, but also the revision it was generated from... that's how it looks up the base code. as I understand it, svn diff might give you the right headers, but I'm not sure... we use p4.

Re: Using the demo

2009-02-17 Thread David Trowbridge
The demo server does point to the active SVN server. This is okay because review board never does any commits to version control. -David On Tue, Feb 17, 2009 at 11:17 AM, Anthony Foglia afog...@princeton.com wrote: Thanks. I was aware of the tool, but not using it. My questions are more

post-review degrades into O(n)

2009-02-17 Thread Gary M. Josack
Disclaimer: This post is specific to SVN. I admittedly don't know much about the other RCS's that reviewboard supports. Would anyone be against the addition of UUID as a configurable parameter when adding a repository to reviewboard or having it grab the UUID automatically when you first

Re: post-review degrades into O(n)

2009-02-17 Thread Kevin Kubasik
Even for a large reviewboard install (several dozen repos) I don't see this being a major performance benefit/detriment. Can you provide some numbers showing this as a problem? It seems like a largely theoretical slowdown. -Kevin On Tue, Feb 17, 2009 at 2:59 PM, Gary M. Josack g...@byoteki.com

Re: Diff between revisions is broken in alpha4

2009-02-17 Thread Christian Hammond
I'll try to get to this sometime this week. You'll need to grab a nightly for the fix, because we're a ways off still from beta 1. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Feb 17, 2009 at 7:44

Re: Diff between revisions is broken in alpha4

2009-02-17 Thread Christian Hammond
No, I'm going to work on a fix this week, but I haven't had the time yet. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Feb 17, 2009 at 7:10 PM, Martin mkoeb...@gmail.com wrote: is it already

Issue 892 in reviewboard: Diff-viewer crash when viewing difference between diffs with new files.

2009-02-17 Thread codesite-noreply
Comment #1 on issue 892 by mkoebele: Diff-viewer crash when viewing difference between diffs with new files. http://code.google.com/p/reviewboard/issues/detail?id=892 alternatively, I get a paginator for 2 empty pages. -- You received this message because you are listed in the owner or CC

Issue 854 in reviewboard: rb-site install failed on a database with utf-8 charset

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 854 by ytht.net: rb-site install failed on a database with utf-8 charset http://code.google.com/p/reviewboard/issues/detail?id=854 What steps will reproduce the problem? 1. use mysql backend, create database like this:

Issue 676 in reviewboard: post-review fails when uploading diff

2009-02-17 Thread codesite-noreply
Comment #2 on issue 676 by pan126: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 Same here {{{ svn info repository info: Path: https://mpu...@svn.redefine.pl/videomakine, Base path: /cruncher, Supports changesets: False svn propget

Issue 472 in reviewboard: HGTool does not support git style diff

2009-02-17 Thread codesite-noreply
Comment #8 on issue 472 by john.levon: HGTool does not support git style diff http://code.google.com/p/reviewboard/issues/detail?id=472 http://www.selenic.com/mercurial/bts/issue1268 is the relevant Mercurial bug -- You received this message because you are listed in the owner or CC fields

Issue 887 in reviewboard: Git patch (aqcuired through git show patch.diff) locks a thread and takes 100% cpu serverside

2009-02-17 Thread codesite-noreply
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Component-SCMTools Comment #1 on issue 887 by chipx86: Git patch (aqcuired through git show patch.diff) locks a thread and takes 100% cpu serverside

Issue 883 in reviewboard: GitDiffParser parses file additions badly (fix patch enclosed in description)

2009-02-17 Thread codesite-noreply
Comment #2 on issue 883 by anfedorov: GitDiffParser parses file additions badly (fix patch enclosed in description) http://code.google.com/p/reviewboard/issues/detail?id=883 Done: http://reviews.review-board.org/r/745/ -- You received this message because you are listed in the owner or CC

Issue 870 in reviewboard: display which authentication method is used

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 870 by tphams: display which authentication method is used http://code.google.com/p/reviewboard/issues/detail?id=870 *NOTE: If you have a patch, please submit it to http://reviews.review-board.org/ What's the URL of the page

Issue 896 in reviewboard: IndexError in diffviewer/views.py

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 896 by heewa.b: IndexError in diffviewer/views.py http://code.google.com/p/reviewboard/issues/detail?id=896 Traceback (most recent call last): File

Issue 897 in reviewboard: Discarded and Unpublished Reviews keep diff history

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 897 by heewa.b: Discarded and Unpublished Reviews keep diff history http://code.google.com/p/reviewboard/issues/detail?id=897 *NOTE: Do not post confidential information in this bug report.* What steps will reproduce the

Issue 898 in reviewboard: Branch-to-branch arrow appears as rarr; in the Review request changed pane

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 898 by grant.patterson: Branch-to-branch arrow appears as rarr; in the Review request changed pane http://code.google.com/p/reviewboard/issues/detail?id=898 Change the branching of a change number so that either before or

Issue 899 in reviewboard: Perforce error handling problem

2009-02-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 899 by erichuss: Perforce error handling problem http://code.google.com/p/reviewboard/issues/detail?id=899 I had an issue where I did not have a p4 ticket (I set the username and password to blank in my config), and it failed