Hi Christian,
*
*
I have the similar problem.
I want to review the files before adding them to svn repository( I want to
do a pre-commit review for that) since I am getting nothing when I issue
svn diff,how to upload diff in the reviewboard web interface for the newly
created files.
Should I
You need to use svn add before you create your diff. You don't have to do
svn commit.
On Wed, May 8, 2013 at 12:15 AM, kvr kvr@gmail.com wrote:
Hi Christian,
*
*
I have the similar problem.
I want to review the files before adding them to svn repository( I want to
do a pre-commit
Thanks that solved the issue.
On Wednesday, May 8, 2013 12:47:06 PM UTC+5:30, David Trowbridge wrote:
You need to use svn add before you create your diff. You don't have to
do svn commit.
On Wed, May 8, 2013 at 12:15 AM, kvr kvr...@gmail.com javascript:wrote:
Hi Christian,
*
*
I have
Yes, that is the exact problem. I did not perform 'add' operation as I
wasn't aware of the usage.
I am now able to post-review for all the files now.
Thanks a lot Christian!!
On Monday, 6 May 2013 13:19:56 UTC+8, Christian Hammond wrote:
It just doesn't sound like that file's being tracked
Hi,
Does anyone has any idea about this problem? Specially for the case where
post-review fails to post review for uncommitted, unversioned, new svn file.
Thanks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
I looked into the issues little more. As per the debug output and referring
to the postreview.py code -
http://reviewboard.googlecode.com/svn/trunk/wxpostreview/postreview.py (Not
sure if I am referring to the right code here, please correct me if I am
wrong)
def diff(self, files):
Apologies for multiple posts I missed on pasting diff command for newly
added, uncommitted file -
E:\Prashima\Kite_Work\server\Kite*diff -u --new-file DUMMY
src\main\java\edu\kite\controller\QuizController.java*
--- DUMMY 1970-01-01 08:00:00.0 +0800
+++
Hi,
That script is ancient and definitely not what you want. In fact, you don't
want anything in reviewboard.googlecode.com. Look at
http://github.com/reviewboard/rbtools/
When you ran the 'svn diff' command, it said that file isn't under version
control. Does that file, as listed, exist on the
Hey Christian,
The file does exist on the exact path, as listed, on my local machine. I
have set the path for svn repository to root folder. However, I had not
synced to the root. I tried that also- svn repo path set to root and I
synced local copy of the root. But this also didn't help and I
Hi,
What happens if you run that diff command without the --diff-cmd part.
Can you also tell me what versions of SVN and RBTools you're using?
Christian
On May 5, 2013, at 18:52, Prashima prashimasha...@gmail.com wrote:
Hey Christian,
The file does exist on the exact path, as listed, on
I get the same response -
C:\Workspace\Kite\Server\kite_serversvn diff
C:\Workspace\Kite\Server\kite_server\Kite\src\main\java\edu\kite\controller\QuizController.java
svn: E15:
'C:\Workspace\Kite\Server\kite_server\Kite\src\main\java\edu\kite\controller\QuizController.java'
is not under
It just doesn't sound like that file's being tracked properly by Subversion.
Is it a new file? Did you do 'svn add' on it?
Also, can you show me how you're executing post-review?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. -
Hi,
I am trying to post two pre-commit reviews using post-review. One review
contains a newly added, unversioned SVN file and other review contains an
edited, versioned file. I am able to generate diff for the edited file and
upload that to a new review request, but not able to post it using
13 matches
Mail list logo
