How to review an entire application?

2010-02-22 Thread skip
I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a

Re: ReviewBoard Error while posting review for GIT

2010-02-22 Thread Kunjal
Any update on this one? I am again stuck here... Kunjal On Feb 11, 2:01 pm, Kunjal kunjal.par...@gmail.com wrote: So, you are saying that Path variable in Admin GUI should be empty and Mirror Path: should list the git repository? Path: Empty string Mirror Path:

Re: ReviewBoard Error while posting review for GIT

2010-02-22 Thread Christian Hammond
Never saw this e-mail. Must have missed it while on vacation. With the raw URL stuff, actually you can set Path as the git repo, because we'll never use it to access files. cgit has to run on the upstream git repository, so on mobcom-git.sj.broadcom.com probably. *Something* needs local access

Update dev build instructions

2010-02-22 Thread Raja
When browsing through the dev list, I got the instructions to build reviewboard from source here: http://www.reviewboard.org/docs/codebase/dev/getting-started/ The instructions seem out-of-date with the current trunk and seem to need 2 more dependency packages. Can someone please update the dev

Re: Setting up developer environment

2010-02-22 Thread Raja
It looks like you need to get django_evolution from easy_install django_evolution or code.google.com/p/django-evolution/ I just created a post with missing packages in the dependency list, but missed this one (as I had installed reviewboard earlier using easy_install). -- Raja On Feb 18,

Re: Update dev build instructions

2010-02-22 Thread Christian Hammond
Hi Raja, Would you mind filing a bug for tracking purposes? Or if you want to quickly update them yourself, you could even modify the docs yourself (reviewboard/docs/codebase/getting-started.txt) and submit a patch to http://reviews.reviewboard.org/. Christian -- Christian Hammond -

Re: How to review an entire application?

2010-02-22 Thread Christian Hammond
Hi Skip, Your versions of post-review and Review Board sound pretty out-of-date, first of all, so I'd recommend setting aside some time to do an upgrade. Let me see if I have this right. You have a directory full of committed code that hasn't been reviewed yet. This code may span multiple

Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stephen Gallagher
On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend

Re: How to review an entire application?

2010-02-22 Thread skip
Christian Let me see if I have this right. You have a directory full of Christian committed code that hasn't been reviewed yet. This code may Christian span multiple revisions. You want to put that code up for Christian review. Is that correct? Yup. Christian There's no

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
Thanks. So I would need to write a custom backend/middleware instead? On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com wrote: On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user middleware/backend to support basic http authentication:

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Christian Hammond
Or we should figure out a scheme to allow for setting that on other backends. Could check an attribute on the backend. Maybe assume that we can set that info and have a flag for turning it off, which LDAP, NIS, etc. can do. Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Issue 1451 in reviewboard: Base field should be stripped before using

2010-02-22 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 1451 by chipx86: Base field should be stripped before using http://code.google.com/p/reviewboard/issues/detail?id=1451 Fixed on master (3ca1e5a) -- You received this message because you are listed in the owner or CC fields of this issue, or

Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode

2010-02-22 Thread reviewboard
Updates: Status: Fixed Comment #15 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail?id=1476 (No comment was entered for this change.) -- You received this message because you are listed in

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
Comment by evgeny.zislis: The responses are json, but the requests (in rb 1.5) are strangle multipart form data! Took me ages to figure out how to request stuff from the server. Example: {{{ curl --cookie cookies.txt --cookie-jar cookies.txt -X POST -F username=xxx -F password=yyy

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
Comment by evgeny.zislis: The responses are json, but the requests (in rb 1.5) are strangly sent using multipart form data! Took me ages to figure out how to request stuff from the server. Example: {{{ curl --cookie cookies.txt --cookie-jar cookies.txt -X POST -F username=xxx -F

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
Comment by evgeny.zislis: The responses are json, but the requests (in rb 1.5) are strangely sent using multipart form data! Took me ages to figure out how to request stuff from the server. Example: {{{ curl --cookie cookies.txt --cookie-jar cookies.txt -X POST -F username=xxx -F

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-22 Thread reviewboard
Comment #4 on issue 1494 by gfbett: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 RC1 fixed the application data issue, but not the external diff command --

Re: Issue 1281 in reviewboard: Adding comments in diff viewer can delete or overwrite existing comments.

2010-02-22 Thread reviewboard
Comment #3 on issue 1281 by kyle.getz: Adding comments in diff viewer can delete or overwrite existing comments. http://code.google.com/p/reviewboard/issues/detail?id=1281 I don't think the line numbers need to go into the thousands for this to be triggered. On the contrary, I perceive the

Issue 1509 in reviewboard: Throws an exception upon a click on review request

2010-02-22 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1509 by kcgade: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 'm seeing this error for reviewboard.twitter.com when I click on a review request.

Re: Issue 1509 in reviewboard: Throws an exception upon a click on review request

2010-02-22 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 1509 by trowbrds: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 Do you have the full traceback? -- You received this message because you are listed in the owner or CC fields

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-22 Thread reviewboard
Comment #2 on issue 1491 by psarmstr: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 To me at least, it feels like not wanting this is specific to certain setups (or small shops that don't have LDAP setup properly yet). Managing everything through a single

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-22 Thread reviewboard
Comment #3 on issue 1491 by chipx86: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 You may want groups for permission purposes, or for review groups, or neither. Some places map review groups to mailman lists, and not anything in LDAP. -- You received this

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-22 Thread reviewboard
Comment #2 on issue 1506 by locomocogogo: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 Thanks for your help. Let me give you the info you need first before I try anything... Yes, on our installed copy

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-22 Thread reviewboard
Comment #3 on issue 1506 by chipx86: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 That should be new enough to migrate properly. Anything prior to evolutions (which is a few years old now) would be