Greetings,
I've set up reviewboard 1.0.8 successfully (apache/mod_python/
postgresql). All on Linux (FC12). Now, post-review fails to work as
expected:
[joac...@testsrv perf]$ post-review --version
RBTools 0.2
[joac...@testsrv perf]$ post-review -d --server=testsrv/reviews
svn info
git
On 06/02/2010 08:50 PM, Christian Hammond wrote:
Hi,
Sorry, I missed this e-mail entirely.
It's most likely that the origin of the central server is different
between what Review Board has recorded and what your Git clone is
using. The remote origin on your clone must match exactly the Path
There are, but not for 1.5. We absolutely have to get this release out and
I'm only allowing a couple crucial things in. I'd like to see this done for
1.6 or 1.7.
Right now, you have the following options:
1) Tell people to standardize on one or the other
2) If there's only two options
The value passed to --server must be a full URL, not just a file path.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jun 3, 2010 at 1:34 AM, Joachim Worringen
worrin...@googlemail.comwrote:
On Jun 2, 5:40 pm, Christian Hammond chip...@chipx86.com wrote:
Can you look at that reject file and the other files in that directory and
see if anything stands out as being wrong there? If it is the file endings,
then that's something I'll be looking into shortly, but it would be nice to
This is also happening with the 'hg postreview' plugin, so I'm fairly
sure that it's something fundamental to RB that's broken.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network
Sounds like something is failing when Review Board talks to the repository.
This is a Subversion repository? What happens if you do a `svn cat` on that
file with that revision from the Review Board server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -
Hi Aaron,
I've been looking into it. Trying to make sure we can fix this without
breaking other files.
As always, additional help fixing bugs is always appreciated. My time is
limited right now as it is.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -
On Thu, Jun 3, 2010 at 2:12 PM, Christian Hammond chip...@chipx86.comwrote:
As always, additional help fixing bugs is always appreciated. My time is
limited right now as it is.
Trust me, that's going around ;-)
I'll spend some time on it if I can. Please, do let me know if you find
anything
I get:
svn: Network connection closed unexpectedly
Thank you! I kept debugging the post-review side of it, but it looks
like something's wrong from the server's perspective.
Thanks a lot!
Rob
On Jun 3, 1:50 pm, Christian Hammond chip...@chipx86.com wrote:
Sounds like something is failing
Comment #1 on issue 1670 by seagle0128: post-review does not support UTF-8
in patch files
http://code.google.com/p/reviewboard/issues/detail?id=1670
I got this error, too.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this
Comment #2 on issue 1670 by seagle0128: post-review does not support UTF-8
in patch files
http://code.google.com/p/reviewboard/issues/detail?id=1670
I got this error, too. I am using RBTools 0.2
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues
Updates:
Status: Confirmed
Labels: Component-DiffViewer Milestone-Release1.5
Comment #1 on issue 1541 by chipx86: Multibyte characters in diff fragments
are broken with syntax highlighting.
http://code.google.com/p/reviewboard/issues/detail?id=1541
Can you submit this to
Comment #5 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
One thing I'm not sure from the repro case here. Is this the source file
(pre-patch)
that has the funky newlines? Or does the patch
Updates:
Owner: chipx86
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0.x
Component-DiffViewer
Comment #6 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
(No comment
Updates:
Status: Confirmed
Comment #7 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Nevermind, I have a test case now. I just don't have a fix that's working.
The problem is that we
Comment #8 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Of course, if we then change the diff so that the ^M is preserved, it'll
break
against the source input where the ^M is not
Comment #9 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
There's, of course, no question that this is outside of what one would
typically
expect, but as for how these files are getting
Comment #11 on issue 1668 by chipx86: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Let me ask.. Is the intent of the ^M in these files to be newlines, or are
they just
ending up this way from broken editors? Are
20 matches
Mail list logo
