Re: Help on viewing diff

2010-06-24 Thread Amit Agrawal
Well, i am doing so but it gives me diff posted as part of revision4 but not actually diofff between base to revision4. Please see attached snapshot for revision selection,what i am using. -Amit On Thu, Jun 24, 2010 at 12:38 AM, David Trowbridge trowb...@gmail.comwrote: Click on the r4 in the

Re: Help on viewing diff

2010-06-24 Thread Christian Hammond
The way Review Board handles diffs today is that every revision of the diff is meant to be a single change, from the base to the tip of the branch. What I think you're wanting (please correct me if I'm wrong) is more of a patchset concept, with each diff being an iteration of a change. This

Re: Connection close when uploading diff file

2010-06-24 Thread Christian Hammond
Hi, This may be due to some issue between Review Board and your repository. What type of repository are you using? Can you turn on logging in the administration UI (Admin - Settings - Logging), reproduce the problem, and then see if there's anything in the log files? Christian -- Christian

Git Patchsets (was [Re: Help on viewing diff])

2010-06-24 Thread Stephen Gallagher
On 06/24/2010 02:43 AM, Christian Hammond wrote: The way Review Board handles diffs today is that every revision of the diff is meant to be a single change, from the base to the tip of the branch. What I think you're wanting (please correct me if I'm wrong) is more of a patchset concept, with

Page not found when using reviewboard 1.0.8 with mod_wsgi

2010-06-24 Thread Chia Hao Lo
Hi, I used apache2 + mod_wsgi + reviewboard 1.0.8 and got page not found error. The error message when accessing http://my-host/reviews/: - Request Method: GET Request URL:

Re: Unable to submit reviews via post-review after svn switch --relocate

2010-06-24 Thread Christian Hammond
Hi Edwin, There shouldn't be any caches for this. The error means literally that there is no Repository matching the path provided in either its Path or Mirror Path fields. Make sure that there isn't some off-by-one somewhere (a trailing / where there shouldn't be, or where there should be,

Re: Unable to submit reviews via post-review after svn switch --relocate

2010-06-24 Thread Edwin Vane
On that note, I notice that the post-review debug output shows the relative path as /trunk. Is this expected? That is, will post-review strip the '/' off the repository path and any characters following this repository path are considered the base path? I'll check our reviewboard server to double

Re: Every patch failing on new RB install w/Mercurial

2010-06-24 Thread Gordon Morehouse
I've now replicated this on an entirely different RB 1.5 beta 2 installation running on Debian Lenny. I will file a bug report. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/

remote Mercurial repo support?

2010-06-24 Thread Gordon Morehouse
Hello, The manual page about repositories contains no information whatsoever about Mercurial. Is it possible to configure a remote Mercurial repo either via HTTP(S) or SSH, or does Review Board require disk access to the repository? If it's possible via HTTP, what is the path to use? The path

ReviewBoard-GIT: Local Clone

2010-06-24 Thread Robert Pachos
Hi there, I'm trying out RB 1.0.8 on linux with Git and I'm having trouble configuring a local repository. When I go to New Review Request I don't get any valid repositories in the list. I have configured the git repository as follows in RB: Name: Test Repo Path:

Re: Every patch failing on new RB install w/Mercurial

2010-06-24 Thread Gordon Morehouse
On Jun 24, 1:28 pm, Gordon Morehouse gordon.moreho...@gmail.com wrote: I've now replicated this on an entirely different RB 1.5 beta 2 installation running on Debian Lenny.  I will file a bug report. ...and it turns out the bug report was filed against the documentation, because upon looking at

red borders around punctuation characters

2010-06-24 Thread Gordon Morehouse
When viewing diffs in Review Board, in some of the chunks I'm seeing punctuation characters be enclosed in red borders. This is happening on both the old and new side of the diff. What does this signify, or is it a bug? Example: return array('type' = $action_handle,

Re: red borders around punctuation characters

2010-06-24 Thread David Trowbridge
Probably pygments has the wrong idea about what type of file it is, and is highlighting what it thinks are errors. -David On Thu, Jun 24, 2010 at 4:41 PM, Gordon Morehouse gordon.moreho...@gmail.com wrote: When viewing diffs in Review Board, in some of the chunks I'm seeing punctuation

Re: red borders around punctuation characters

2010-06-24 Thread Gordon Morehouse
Ah, okay, it's a '.inc' file which contains PHP code. On Jun 24, 4:52 pm, David Trowbridge trowb...@gmail.com wrote: Probably pygments has the wrong idea about what type of file it is, and is highlighting what it thinks are errors. -David On Thu, Jun 24, 2010 at 4:41 PM, Gordon Morehouse

Re: remote Mercurial repo support?

2010-06-24 Thread Dan Buch
IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path

Issue 1699 in reviewboard: Manual contains zero information about Mercurial repo setup

2010-06-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1699 by gordon.morehouse: Manual contains zero information about Mercurial repo setup http://code.google.com/p/reviewboard/issues/detail?id=1699 What's the URL of the page containing the problem?

Issue 1700 in reviewboard: RB fails to get raw output from Mercurial HTTP repo

2010-06-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1700 by gordon.morehouse: RB fails to get raw output from Mercurial HTTP repo http://code.google.com/p/reviewboard/issues/detail?id=1700 What version are you running? 1.5 beta 2 What steps will reproduce the problem? 1.

Issue 1701 in reviewboard: Punctuation characters highlighted with red border in .inc files containing PHP

2010-06-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1701 by gordon.morehouse: Punctuation characters highlighted with red border in .inc files containing PHP http://code.google.com/p/reviewboard/issues/detail?id=1701 What version are you running? 1.5 beta 2 What steps