Re: Reviewboard alpa
Hi , I've run into major issues with post-review as well now. it is not able to post the reviews as well. It keeps retrying and retrying but fails. Thanks, Roshan Pius On Tue, Jan 20, 2009 at 12:27 PM, roshan pius roshanpiustho...@gmail.com wrote: VirtualHost *:80 ServerName xxx.xxx.com DocumentRoot /srv/www/htdocs/review-board-evros/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/srv/www/htdocs/review-board-evros/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_review-board-evros /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /srv/www/htdocs/review-board-evros/htdocs/media Alias /errordocs /srv/www/htdocs/review-board-evros/htdocs/errordocs /VirtualHost On Tue, Jan 20, 2009 at 12:20 PM, Christian Hammond chip...@chipx86.com wrote: Hmm. If sounds like the site install went fine. Can you e-mail me the resulting Apache config and the HTML from any page on the site (something generic like the login page would do). It's probably either the site root setting, or Apache is looking in the wrong place for media files. Christian On 1/19/09, roshan pius roshanpiustho...@gmail.com wrote: Hi 1.I'm not using a domain name as of now, running it directly with an IP:(xxx.xxx.xxx.xxx).Will get a domain later. But i was running before with direct IP. 2.As is said, i was running the old reviewboard off the svn checkout so i didn't have a rb-site installation so rb-site upgrade is not possible. 3.It is using the same old database( i can see all the members as well as the old review requests, just that the layout is messed). 4.The Symbolic links htdocs/media/ directory(seems to be ok): drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 . drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 .. lrwxrwxrwx 1 www-data www-data 101 Jan 19 20:05 admin - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/media/admin lrwxrwxrwx 1 www-data www-data 80 Jan 19 20:05 djblets - /usr/local/lib/python2.6/site-packages/Djblets-0.5alpha1-py2.6.egg/djblets/media lrwxrwxrwx 1 www-data www-data 98 Jan 19 20:05 rb - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/media/rb drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 uploaded 6. When i installed ReviewBoard i used python setup.py install and then did rb-site /srv/www/htdocs/review-board.com 7.For some reason the easy_install had some issues while i was trying yesterday, it was saying it was not able to. That is why i manually downloaded the tar.gz files and installed using python setup.py install On Tue, Jan 20, 2009 at 3:21 AM, Christian Hammond chip...@chipx86.com wrote: A few things I need to know first: 1) Is your Review Board install using its own subdomain, or is it in a directory off a domain? 2) If it's in a directory off a domain, did you specify that directory during the install? 3) Is this using an existing database? 4) Try running rb-site upgrade on the site again. Does that fix the problem? 5) What do the symlinks look like in your site's htdocs/media/ directory? Are they pointing to the right place? 6) When you installed Review Board, did you use setup.py install? 7) What happens when you install via easy_install? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 6:57 AM, roshanpius roshanpiustho...@gmail.com wrote: Hi , I installed the Reviewboard alpha tar.gz file today and installed an instance using rb-site tool as i have been running reviewboard out of my svn checkout till now. But when i restarted my apache server with the new conf file (generated from the rb-site install) and when i tried to login i found the page-media garbled. I mean the colors and the general page layout is messed up. I'm pretty sure it is a minor issue with some media path or permissions or something like that. What exactly do i need to configure for the media? Please Help fast ,lot of people are using it and it is temporarily down because of this issue. Thanks, Roshan Pius -- -- Christian Hammond - chip...@chipx86.com VMware, Inc. --~--~-~--~~~---~--~~ You received this
Re: Reviewboard alpa
Can you run post-review with -d and attach the debug log? Is it just asking for a password over and over? If so, try deleting ~/.post-review-cookies.txt. I'm imagining the problem is the site root or media root. Can you attach the HTML file of any page on your install? It'll help me determine if this is the cause. If so, we can fix this pretty easily. You may want to also try going to http://yoursite/admin/, logging in, clicking on Settings, and then checking what the Media URL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 12:51 AM, roshan pius roshanpiustho...@gmail.comwrote: Hi , I've run into major issues with post-review as well now. it is not able to post the reviews as well. It keeps retrying and retrying but fails. Thanks, Roshan Pius On Tue, Jan 20, 2009 at 12:27 PM, roshan pius roshanpiustho...@gmail.com wrote: VirtualHost *:80 ServerName xxx.xxx.com DocumentRoot /srv/www/htdocs/review-board-evros/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/srv/www/htdocs/review-board-evros/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_review-board-evros /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /srv/www/htdocs/review-board-evros/htdocs/media Alias /errordocs /srv/www/htdocs/review-board-evros/htdocs/errordocs /VirtualHost On Tue, Jan 20, 2009 at 12:20 PM, Christian Hammond chip...@chipx86.com wrote: Hmm. If sounds like the site install went fine. Can you e-mail me the resulting Apache config and the HTML from any page on the site (something generic like the login page would do). It's probably either the site root setting, or Apache is looking in the wrong place for media files. Christian On 1/19/09, roshan pius roshanpiustho...@gmail.com wrote: Hi 1.I'm not using a domain name as of now, running it directly with an IP:(xxx.xxx.xxx.xxx).Will get a domain later. But i was running before with direct IP. 2.As is said, i was running the old reviewboard off the svn checkout so i didn't have a rb-site installation so rb-site upgrade is not possible. 3.It is using the same old database( i can see all the members as well as the old review requests, just that the layout is messed). 4.The Symbolic links htdocs/media/ directory(seems to be ok): drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 . drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 .. lrwxrwxrwx 1 www-data www-data 101 Jan 19 20:05 admin - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/media/admin lrwxrwxrwx 1 www-data www-data 80 Jan 19 20:05 djblets - /usr/local/lib/python2.6/site-packages/Djblets-0.5alpha1-py2.6.egg/djblets/media lrwxrwxrwx 1 www-data www-data 98 Jan 19 20:05 rb - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/media/rb drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 uploaded 6. When i installed ReviewBoard i used python setup.py install and then did rb-site /srv/www/htdocs/review-board.com 7.For some reason the easy_install had some issues while i was trying yesterday, it was saying it was not able to. That is why i manually downloaded the tar.gz files and installed using python setup.py install On Tue, Jan 20, 2009 at 3:21 AM, Christian Hammond chip...@chipx86.com wrote: A few things I need to know first: 1) Is your Review Board install using its own subdomain, or is it in a directory off a domain? 2) If it's in a directory off a domain, did you specify that directory during the install? 3) Is this using an existing database? 4) Try running rb-site upgrade on the site again. Does that fix the problem? 5) What do the symlinks look like in your site's htdocs/media/ directory? Are they pointing to the right place? 6) When you installed Review Board, did you use setup.py install? 7) What happens when you install via easy_install? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On
Re: Reviewboard alpa
I added the line to vhosts.conf file Options FollowSymLinks When i tried accessing the http://135.254.219.50/media/ - I got this error on the browser Page not found (404) Request Method: GET Request URL:http://135.254.219.50/error/HTTP_FORBIDDEN.html.var Regards, Roshan Pius On Tue, Jan 20, 2009 at 3:06 PM, Christian Hammond chip...@chipx86.com wrote: That file seems to have some issues. Perhaps the browser tried to normalize the file paths, but they end up looking like: SCRIPT type=text/javascript src=./Dashboard Review Board administration_files/jquery-1.2.6.min.js/SCRIPT There's also a bunch of custom HTML in there, and existing HTML that's modified. Definitely looks like the browser is doing it. Can you look at the source for that file in your browser, find any link or script line, and paste it? Also, what happens if you go to http://yoursite/media/ ? Do you get a 404, or a directory with admin and rb and djblets ? Another thing that could potentially cause this is Apache being configured to block symlinks by default. Try to edit your Apache config and, in the Location /media section, add: Options FollowSymLinks This may fix it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:17 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , The post-review worked once i removed the old cookies file. You may want to also try going to http://yoursite/admin/, logging in, clicking on Settings, and then checking what the Media URL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. I already tried this and no luck. My media URL is already /media/. I've attached the admin html page. i accessed using the url : http://xxx.xxx.xxx.xxx/admin Thanks, Roshan Pius On Tue, Jan 20, 2009 at 2:26 PM, Christian Hammond chip...@chipx86.com wrote: Can you run post-review with -d and attach the debug log? Is it just asking for a password over and over? If so, try deleting ~/.post-review-cookies.txt. I'm imagining the problem is the site root or media root. Can you attach the HTML file of any page on your install? It'll help me determine if this is the cause. If so, we can fix this pretty easily. You may want to also try going to http://yoursite/admin/, logging in, clicking on Settings, and then checking what the Media URL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 12:51 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , I've run into major issues with post-review as well now. it is not able to post the reviews as well. It keeps retrying and retrying but fails. Thanks, Roshan Pius On Tue, Jan 20, 2009 at 12:27 PM, roshan pius roshanpiustho...@gmail.com wrote: VirtualHost *:80 ServerName xxx.xxx.com DocumentRoot /srv/www/htdocs/review-board-evros/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/srv/www/htdocs/review-board-evros/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_review-board-evros /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /srv/www/htdocs/review-board-evros/htdocs/media Alias /errordocs /srv/www/htdocs/review-board-evros/htdocs/errordocs /VirtualHost On Tue, Jan 20, 2009 at 12:20 PM, Christian Hammond chip...@chipx86.com wrote: Hmm. If sounds like the site install went fine. Can you e-mail me the resulting Apache config and the HTML from any page on the site (something generic like the login page would do). It's probably either the site root setting, or Apache is looking in the wrong place for media files. Christian On 1/19/09, roshan pius roshanpiustho...@gmail.com wrote: Hi 1.I'm not using a domain name as of now, running it directly with an IP:(xxx.xxx.xxx.xxx).Will get a domain later. But i was running before with direct IP. 2.As is said, i was running
Re: Reviewboard alpa
Okay, so you're getting a Forbidden error with this directory, but the HTML file for that is missing so it's sending a 404 instead. What you're seeing is a config error on your server where Apache's user is unable to access your media directory. The user just doesn't have the permissions required. Check to make sure your site's htdocs/media directory (and everything else in htdocs/) has permissions set so that the Apache user can access it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:46 AM, roshan pius roshanpiustho...@gmail.comwrote: I added the line to vhosts.conf file Options FollowSymLinks When i tried accessing the http://135.254.219.50/media/ - I got this error on the browser Page not found (404) Request Method: GET Request URL:http://135.254.219.50/error/HTTP_FORBIDDEN.html.var Regards, Roshan Pius On Tue, Jan 20, 2009 at 3:06 PM, Christian Hammond chip...@chipx86.com wrote: That file seems to have some issues. Perhaps the browser tried to normalize the file paths, but they end up looking like: SCRIPT type=text/javascript src=./Dashboard Review Board administration_files/jquery-1.2.6.min.js/SCRIPT There's also a bunch of custom HTML in there, and existing HTML that's modified. Definitely looks like the browser is doing it. Can you look at the source for that file in your browser, find any link or script line, and paste it? Also, what happens if you go to http://yoursite/media/ ? Do you get a 404, or a directory with admin and rb and djblets ? Another thing that could potentially cause this is Apache being configured to block symlinks by default. Try to edit your Apache config and, in the Location /media section, add: Options FollowSymLinks This may fix it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:17 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , The post-review worked once i removed the old cookies file. You may want to also try going to http://yoursite/admin/, logging in, clicking on Settings, and then checking what the Media URL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. I already tried this and no luck. My media URL is already /media/. I've attached the admin html page. i accessed using the url : http://xxx.xxx.xxx.xxx/admin Thanks, Roshan Pius On Tue, Jan 20, 2009 at 2:26 PM, Christian Hammond chip...@chipx86.com wrote: Can you run post-review with -d and attach the debug log? Is it just asking for a password over and over? If so, try deleting ~/.post-review-cookies.txt. I'm imagining the problem is the site root or media root. Can you attach the HTML file of any page on your install? It'll help me determine if this is the cause. If so, we can fix this pretty easily. You may want to also try going to http://yoursite/admin/, logging in, clicking on Settings, and then checking what the Media URL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 12:51 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , I've run into major issues with post-review as well now. it is not able to post the reviews as well. It keeps retrying and retrying but fails. Thanks, Roshan Pius On Tue, Jan 20, 2009 at 12:27 PM, roshan pius roshanpiustho...@gmail.com wrote: VirtualHost *:80 ServerName xxx.xxx.com DocumentRoot /srv/www/htdocs/review-board-evros/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/srv/www/htdocs/review-board-evros/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_review-board-evros /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /srv/www/htdocs/review-board-evros/htdocs/media Alias /errordocs
Re: Evolution failed during upgrade
I don't think I modified anything intentionally. I just copied the sqlite3 database file to the new location. The hint wasn't particularly helpful, it just stated 'field_type'. I wasn't aware that there was even anything in ReviewBoard about a bug tracker. I did build the install from the debian source package which has a few minor modifications, but it shouldn't affect this. The schema for the table is: CREATE TABLE scmtools_repository ( id integer NOT NULL PRIMARY KEY, name varchar(64) NOT NULL UNIQUE, path varchar(128) NOT NULL UNIQUE, mirror_path varchar(128) NOT NULL, username varchar(32) NOT NULL, password varchar(128) NOT NULL, tool_id integer NOT NULL REFERENCES scmtools_tool (id), bug_tracker varchar(200) NOT NULL, encoding varchar(32) NOT NULL ); CREATE INDEX scmtools_repository_tool_id ON scmtools_repository (tool_id); I tried changing it as well as dropping the table altogether and it still gives me the same error. Dan On Jan 19, 4:54 pm, Christian Hammond chip...@chipx86.com wrote: You can use: rb-site manage /path/to/site evolve -- --hint (note the -- before any parameters passed to manage) Did you at any point modify your models.py by hand? You shouldn't really be seeing this error. When you copied the database over, was this through a file copy or a database dump? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 8:40 AM, Dan Savilonis d...@n-cube.org wrote: I've run rb-site upgrade to try to upgrade an older ~svn1520 installation database. I have the a fresh easy_install installation from yesterday and copied the old database over, but I ran into the issue below. How do I get manage.py to run now that I'm on an egg installation toi debug this? I can't get it to find settings_local.py. Rebuilding directory structure Updating database There are unapplied evolutions for reviews. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Project signature has changed - an evolution is required Installing json fixture 'initial_data' from '/usr/lib/python2.5/site- packages/ReviewBoard-0.9.dev_20090118-py2.5.egg/reviewboard/scmtools/ fixtures'. Installed 6 object(s) from 1 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: In field 'bug_tracker': Property 'field_type' has changed Thanks, Dan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Evolution failed during upgrade
I think the problem may be your version of django-evolution. Try to: 1) Remove the django_evolution* files/directories in /usr/lib/python2.5/site-packages (or python2.4, depending on the version you're using) 2) easy_install --upgrade django_evolution I think you just have an out-of-date version of this. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:42 AM, Dan Savilonis d...@n-cube.org wrote: I don't think I modified anything intentionally. I just copied the sqlite3 database file to the new location. The hint wasn't particularly helpful, it just stated 'field_type'. I wasn't aware that there was even anything in ReviewBoard about a bug tracker. I did build the install from the debian source package which has a few minor modifications, but it shouldn't affect this. The schema for the table is: CREATE TABLE scmtools_repository ( id integer NOT NULL PRIMARY KEY, name varchar(64) NOT NULL UNIQUE, path varchar(128) NOT NULL UNIQUE, mirror_path varchar(128) NOT NULL, username varchar(32) NOT NULL, password varchar(128) NOT NULL, tool_id integer NOT NULL REFERENCES scmtools_tool (id), bug_tracker varchar(200) NOT NULL, encoding varchar(32) NOT NULL ); CREATE INDEX scmtools_repository_tool_id ON scmtools_repository (tool_id); I tried changing it as well as dropping the table altogether and it still gives me the same error. Dan On Jan 19, 4:54 pm, Christian Hammond chip...@chipx86.com wrote: You can use: rb-site manage /path/to/site evolve -- --hint (note the -- before any parameters passed to manage) Did you at any point modify your models.py by hand? You shouldn't really be seeing this error. When you copied the database over, was this through a file copy or a database dump? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 8:40 AM, Dan Savilonis d...@n-cube.org wrote: I've run rb-site upgrade to try to upgrade an older ~svn1520 installation database. I have the a fresh easy_install installation from yesterday and copied the old database over, but I ran into the issue below. How do I get manage.py to run now that I'm on an egg installation toi debug this? I can't get it to find settings_local.py. Rebuilding directory structure Updating database There are unapplied evolutions for reviews. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Project signature has changed - an evolution is required Installing json fixture 'initial_data' from '/usr/lib/python2.5/site- packages/ReviewBoard-0.9.dev_20090118-py2.5.egg/reviewboard/scmtools/ fixtures'. Installed 6 object(s) from 1 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: In field 'bug_tracker': Property 'field_type' has changed Thanks, Dan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Windows Installation w/ Apache 2: What if I don't have sites-available or sites-enabled directories?
Do you have uploaded and uploaded/images directories owned by the web server in your site's htdocs/media/ directory? If not, go ahead and create them and then restart Apache. If you're using rb-site, then rb-site /path/to/site upgrade will take care of the syncdb, the evolve, and fixing any symlinks or updating media files when need be. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:56 AM, SamClark pimp.roc...@gmail.com wrote: Hmm... I updated my checkout and managed to get something actually. I think my problem was using localhost, 127.0.0.1, computername instead on my LAN address for the domain name. I'm now getting the 'manual server updates required page'. The root of my instance of review board is c:\apacheweb\reviewboard. I ran 'manage.py syncdb' (and manage.py evolve --execute just for shits) at this location with the following output: C:\apacheweb\reviewboardmanage.py syncdb Upgrading Review Board from 0.9 to 1.0alpha2 Installing json fixture 'initial_data' from 'C:\svn\reviewboard \scmtools\fixture s'. Installed 6 object(s) from 1 fixture(s) C:\apacheweb\reviewboardmanage.py evolve --execute No evolution required. I restarted apache and still got the same manual server updates page. I also tried clearing my browswer cache. I am running mysql 5.0.67. On Jan 19, 4:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sam. Some distros don't provide a sites-available or sites-enabled. In these cases, I'd just recommend modifying httpd.conf and append the configuration. It sounds like you've tried this, though. Does the Apache error log say anything? Also, make sure you have a NameVirtualHost entry somewhere in the file that specifies the IP address of the server. What do you see when you visit the site? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 3:38 PM, SamClark pimp.roc...@gmail.com wrote: I'm trying to serve review board through apache 2.2.10. I just had rb- site.py complete but I don't have the sites-available or sites-enabled directories and it doesn't look like httpd.conf has any mention of either. Should I look for another apache distribution? I have tried pasting the review board config file into my virtual hosts file and uncommenting the virtual host reference httpd.conf in the past with no luck.- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
[P4.connect()] Connect to server failed; check $P4PORT.
Hey all, I'm wondering if anyone might be able to throw me a clue: when I try to add a review request through the web interface I get this error message in red: [P4.connect()] Connect to server failed; check $P4PORT. TCP connect to //lyrdepot/products/hqlib/main/ failed. //lyrdepot/products/hqlib/ main/: service unknown. I can connect through p4 from the command-line as well as P4V, so I don't see how $P4PORT could be the issue. What else could be wrong? I only get this error when don't fill in the 'change number' field. When I do fill in that field (and submit), the form just refreshes without adding review and without giving me an error. (I posted an issue at http://code.google.com/p/reviewboard/issues/detail?id=823 , but I realize that most of the problem here is most certainly something I've done wrong during installation/configuration.) Thanks for any help! The app looks great in the screenshots and I'm anxious to get it running here... --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Evolution failed during upgrade
That did it. I just started over fresh with a new site directory, copied the database over and it went flawlessly. I had a debian package installed for django-evolution that was older so easy_install didn't install it as a dependency. Thanks, Dan On Jan 20, 4:18 pm, Christian Hammond chip...@chipx86.com wrote: I think the problem may be your version of django-evolution. Try to: 1) Remove the django_evolution* files/directories in /usr/lib/python2.5/site-packages (or python2.4, depending on the version you're using) 2) easy_install --upgrade django_evolution I think you just have an out-of-date version of this. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:42 AM, Dan Savilonis d...@n-cube.org wrote: I don't think I modified anything intentionally. I just copied the sqlite3 database file to the new location. The hint wasn't particularly helpful, it just stated 'field_type'. I wasn't aware that there was even anything in ReviewBoard about a bug tracker. I did build the install from the debian source package which has a few minor modifications, but it shouldn't affect this. The schema for the table is: CREATE TABLE scmtools_repository ( id integer NOT NULL PRIMARY KEY, name varchar(64) NOT NULL UNIQUE, path varchar(128) NOT NULL UNIQUE, mirror_path varchar(128) NOT NULL, username varchar(32) NOT NULL, password varchar(128) NOT NULL, tool_id integer NOT NULL REFERENCES scmtools_tool (id), bug_tracker varchar(200) NOT NULL, encoding varchar(32) NOT NULL ); CREATE INDEX scmtools_repository_tool_id ON scmtools_repository (tool_id); I tried changing it as well as dropping the table altogether and it still gives me the same error. Dan On Jan 19, 4:54 pm, Christian Hammond chip...@chipx86.com wrote: You can use: rb-site manage /path/to/site evolve -- --hint (note the -- before any parameters passed to manage) Did you at any point modify your models.py by hand? You shouldn't really be seeing this error. When you copied the database over, was this through a file copy or a database dump? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 8:40 AM, Dan Savilonis d...@n-cube.org wrote: I've run rb-site upgrade to try to upgrade an older ~svn1520 installation database. I have the a fresh easy_install installation from yesterday and copied the old database over, but I ran into the issue below. How do I get manage.py to run now that I'm on an egg installation toi debug this? I can't get it to find settings_local.py. Rebuilding directory structure Updating database There are unapplied evolutions for reviews. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Project signature has changed - an evolution is required Installing json fixture 'initial_data' from '/usr/lib/python2.5/site- packages/ReviewBoard-0.9.dev_20090118-py2.5.egg/reviewboard/scmtools/ fixtures'. Installed 6 object(s) from 1 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: In field 'bug_tracker': Property 'field_type' has changed Thanks, Dan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Windows Installation w/ Apache 2: What if I don't have sites-available or sites-enabled directories?
I didn't need to create those directories. They were already. The apache service is running as me (my windows domain login), and I should have all the necessary permissions. Running rb-site upgrade produced: C:\apacheweb\reviewboardrb-site.py upgrade . --copy-media Rebuilding directory structure Updating database Installing json fixture 'initial_data' from 'C:\Python25\lib\site- packages\revie wboard-0.9.dev_20081124-py2.5.egg\reviewboard\scmtools\fixtures'. Installed 6 object(s) from 1 fixture(s) No evolution required. I am still getting the 'manual server updates required' page. Running without the --copy-media flag gives me the old no attribute 'symlink' error. On Jan 20, 2:20 pm, Christian Hammond chip...@chipx86.com wrote: Do you have uploaded and uploaded/images directories owned by the web server in your site's htdocs/media/ directory? If not, go ahead and create them and then restart Apache. If you're using rb-site, then rb-site /path/to/site upgrade will take care of the syncdb, the evolve, and fixing any symlinks or updating media files when need be. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:56 AM, SamClark pimp.roc...@gmail.com wrote: Hmm... I updated my checkout and managed to get something actually. I think my problem was using localhost, 127.0.0.1, computername instead on my LAN address for the domain name. I'm now getting the 'manual server updates required page'. The root of my instance of review board is c:\apacheweb\reviewboard. I ran 'manage.py syncdb' (and manage.py evolve --execute just for shits) at this location with the following output: C:\apacheweb\reviewboardmanage.py syncdb Upgrading Review Board from 0.9 to 1.0alpha2 Installing json fixture 'initial_data' from 'C:\svn\reviewboard \scmtools\fixture s'. Installed 6 object(s) from 1 fixture(s) C:\apacheweb\reviewboardmanage.py evolve --execute No evolution required. I restarted apache and still got the same manual server updates page. I also tried clearing my browswer cache. I am running mysql 5.0.67. On Jan 19, 4:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sam. Some distros don't provide a sites-available or sites-enabled. In these cases, I'd just recommend modifying httpd.conf and append the configuration. It sounds like you've tried this, though. Does the Apache error log say anything? Also, make sure you have a NameVirtualHost entry somewhere in the file that specifies the IP address of the server. What do you see when you visit the site? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 3:38 PM, SamClark pimp.roc...@gmail.com wrote: I'm trying to serve review board through apache 2.2.10. I just had rb- site.py complete but I don't have the sites-available or sites-enabled directories and it doesn't look like httpd.conf has any mention of either. Should I look for another apache distribution? I have tried pasting the review board config file into my virtual hosts file and uncommenting the virtual host reference httpd.conf in the past with no luck.- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Windows Installation w/ Apache 2: What if I don't have sites-available or sites-enabled directories?
Oh, it looks like you're running an older Review Board. Make sure to pass --upgrade to easy_install, like so: easy_install --upgrade ReviewBoard Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 2:24 PM, SamClark pimp.roc...@gmail.com wrote: I didn't need to create those directories. They were already. The apache service is running as me (my windows domain login), and I should have all the necessary permissions. Running rb-site upgrade produced: C:\apacheweb\reviewboardrb-site.py upgrade . --copy-media Rebuilding directory structure Updating database Installing json fixture 'initial_data' from 'C:\Python25\lib\site- packages\revie wboard-0.9.dev_20081124-py2.5.egg\reviewboard\scmtools\fixtures'. Installed 6 object(s) from 1 fixture(s) No evolution required. I am still getting the 'manual server updates required' page. Running without the --copy-media flag gives me the old no attribute 'symlink' error. On Jan 20, 2:20 pm, Christian Hammond chip...@chipx86.com wrote: Do you have uploaded and uploaded/images directories owned by the web server in your site's htdocs/media/ directory? If not, go ahead and create them and then restart Apache. If you're using rb-site, then rb-site /path/to/site upgrade will take care of the syncdb, the evolve, and fixing any symlinks or updating media files when need be. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:56 AM, SamClark pimp.roc...@gmail.com wrote: Hmm... I updated my checkout and managed to get something actually. I think my problem was using localhost, 127.0.0.1, computername instead on my LAN address for the domain name. I'm now getting the 'manual server updates required page'. The root of my instance of review board is c:\apacheweb\reviewboard. I ran 'manage.py syncdb' (and manage.py evolve --execute just for shits) at this location with the following output: C:\apacheweb\reviewboardmanage.py syncdb Upgrading Review Board from 0.9 to 1.0alpha2 Installing json fixture 'initial_data' from 'C:\svn\reviewboard \scmtools\fixture s'. Installed 6 object(s) from 1 fixture(s) C:\apacheweb\reviewboardmanage.py evolve --execute No evolution required. I restarted apache and still got the same manual server updates page. I also tried clearing my browswer cache. I am running mysql 5.0.67. On Jan 19, 4:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sam. Some distros don't provide a sites-available or sites-enabled. In these cases, I'd just recommend modifying httpd.conf and append the configuration. It sounds like you've tried this, though. Does the Apache error log say anything? Also, make sure you have a NameVirtualHost entry somewhere in the file that specifies the IP address of the server. What do you see when you visit the site? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 3:38 PM, SamClark pimp.roc...@gmail.com wrote: I'm trying to serve review board through apache 2.2.10. I just had rb- site.py complete but I don't have the sites-available or sites-enabled directories and it doesn't look like httpd.conf has any mention of either. Should I look for another apache distribution? I have tried pasting the review board config file into my virtual hosts file and uncommenting the virtual host reference httpd.conf in the past with no luck.- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: [P4.connect()] Connect to server failed; check $P4PORT.
It sounds like the connection information for the repository is wrong in Review Board. If you're the admin, you'll need to go into the admin UI and correct it. The server should be set to the value of $P4PORT. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:42 PM, Cainus cai...@gmail.com wrote: Hey all, I'm wondering if anyone might be able to throw me a clue: when I try to add a review request through the web interface I get this error message in red: [P4.connect()] Connect to server failed; check $P4PORT. TCP connect to //lyrdepot/products/hqlib/main/ failed. //lyrdepot/products/hqlib/ main/: service unknown. I can connect through p4 from the command-line as well as P4V, so I don't see how $P4PORT could be the issue. What else could be wrong? I only get this error when don't fill in the 'change number' field. When I do fill in that field (and submit), the form just refreshes without adding review and without giving me an error. (I posted an issue at http://code.google.com/p/reviewboard/issues/detail?id=823 , but I realize that most of the problem here is most certainly something I've done wrong during installation/configuration.) Thanks for any help! The app looks great in the screenshots and I'm anxious to get it running here... --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 805 in reviewboard: post-review script fails when using CVS.
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-High Milestone-Release1.0 Component-Scripts Comment #3 on issue 805 by chipx86: post-review script fails when using CVS. http://code.google.com/p/reviewboard/issues/detail?id=805 Thanks. Fixed in r1674. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 820 in reviewboard: It is possible for a user to create multiple draft reviews, leading to an unviewable review
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 820 by timw.at.work: It is possible for a user to create multiple
draft reviews, leading to an unviewable review
http://code.google.com/p/reviewboard/issues/detail?id=820
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
View diff page on another user's published review
What steps will reproduce the problem?
1. Comment on multiple lines in the diff
2. Edit some of your comments (by clicking on the comment markers, changing
the text, and hitting Save)
3. Hit Edit Review on the green draft-review banner
4. Fill in some review text and change one or more of the comments
5. Hit Publish Review
I have not minimized the steps, yet, but I've only just encountered this
recently (and once). It may be necessary to further click on some
just-entered comments and click cancel.
What is the expected output? What do you see instead?
Expected:
The (single) review I have been composing is published, and an email is
sent.
Actual:
An email is sent for the review I expected, but the publish action
redirects me to an exception page ('get()' returning multiple rows instead
of 1). The account who just published the review can no longer access that
review (the same exception page shows).
What operating system are you using? What browser?
Ubuntu 8.10 x86_64's Firefox 3.0.5
Please provide any additional information below.
If it matters, there were other reviews (with code references) on an older
diff. I think I did not click on any markers for these older reviews, since
I was reviewing a newer diff with no existing reviews.
Unfortunately, I didn't capture the stack trace.
It is likely easy to reproduce the stack trace: just use the Admin tool to
toggle the 'Public' field to 'false' for at least two reviews from the same
user in the same review request, then try to view the review request as
that user.
The real issue seems to be caused by several factors:
1) get() is used when retrieving a user's draft review(s) for a given
review request,
2) the JSON API and/or the underlying model does not prevent the creation
of multiple (user, review request, non-Public review) sets, and
3) some of the JS in the diff viewer page is (accidentally or
intentionally) trying to create a new review request instead of modifying
the current draft in at least one situation.
If multiple drafts are reasonable, (1) is the only problem, and some GUI
work may be in order.
It seems to me that the real problem is (3).
The existence of (2) allows (3) to violate the model's invariants so that
it becomes impossible for the user to fix it.
Workaround:
If you encounter this (an exception when trying to view a review), either
(1) view it anonymously, or (2) log in as Administrator and find the
offending reviews (either delete them or mark them as Public).
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Comment on GettingStarted in reviewboard
Comment by andreas.kloeckner: Wow, installing RB is really unnecessarily hard. 1) The rb-site tool somehow forgot to create the fcgi server script that I was supposed to run, and I have no idea what to put in there. (find -name '*fcgi*' also draws a blank) 2) Don't hide installations behind opaque (if shiny) configuration tools. Ultimately, you're not doing your users a favor. I can set up Django apps just fine, but I have *no* idea how to set up RB. I've given up. Unrelatedly, you may want to think about supporting mod_wsgi. For me, it's much less crashy than mod_python. Django likes it, too. For more information: http://code.google.com/p/reviewboard/wiki/GettingStarted --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 824 in reviewboard: Enter key does nothing in the Attach Screenshot dialog
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 824 by jamesdlin: Enter key does nothing in the Attach Screenshot dialog http://code.google.com/p/reviewboard/issues/detail?id=824 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Try attaching a screenshot to a review request. 2. Fill out the caption and path. 3. Press the enter key. What is the expected output? What do you see instead? Something seems to happen (I see my browser's throbber moving momentarily), but the screenshot doesn't actually seem to be added to the review request. I would expect it to submit, as if I had clicked on the Attach button. What operating system are you using? What browser? Windows XPx64sp2 with Firefox 3.0.5. Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 821 in reviewboard: Updating a diff with a diff + parent diff does not work.
Updates: Status: NeedInfo Comment #1 on issue 821 by chipx86: Updating a diff with a diff + parent diff does not work. http://code.google.com/p/reviewboard/issues/detail?id=821 What version/nightly are you using? Both Review Board and Djblets. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 721 in reviewboard: Diff Viewer SCMError - callback_get_login required
Updates: Status: NeedInfo Comment #4 on issue 721 by chipx86: Diff Viewer SCMError - callback_get_login required http://code.google.com/p/reviewboard/issues/detail?id=721 The error is definitely opaque, and not sent by us. Do you know what version of PySVN you have? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on GettingStarted in reviewboard
Comment by chipx86: andreas: We're working on supporting fastcgi better, as well as mod_wsgi. A fastcgi init script is coming in alpha 2. I'm sorry the configuration tools caused you problems, but ultimately it's saved many of our users a lot of frustration. The number of support requests since reducing rb-site has dropped dramatically. Most people don't know how to set up Apache correctly, and providing sample files or documentation was not good enough. These concerns are best taken to the mailing list, as the comments here are largely ignored and will soon go away. For more information: http://code.google.com/p/reviewboard/wiki/GettingStarted --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 820 in reviewboard: It is possible for a user to create multiple draft reviews, leading to an unviewable review
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Comment #2 on issue 820 by chipx86: It is possible for a user to create multiple draft reviews, leading to an unviewable review http://code.google.com/p/reviewboard/issues/detail?id=820 I've recently noticed this as well. We need to make this a priority for alpha 2. Thanks for all the research on it. I'm going to go through later and see if I can get a solid repro case and get this fixed. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 822 in reviewboard: post-review: Locale for svn should be set to C
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 822 by lukasz.jernas: post-review: Locale for svn should be set to C http://code.google.com/p/reviewboard/issues/detail?id=822 What steps will reproduce the problem? 1. run post-review in an environment different than C or en 2. watch it fail on detecting the repository format deej...@sulaco:~/PRACA/osm/merkaartor$ ./post-review The current directory does not contain a checkout from a supported source code repository. deej...@sulaco:~/PRACA/osm/merkaartor$ locale LANG=pl_PL.UTF-8 LC_CTYPE=pl_PL.UTF-8 LC_NUMERIC=pl_PL.UTF-8 LC_TIME=pl_PL.UTF-8 LC_COLLATE=pl_PL.UTF-8 LC_MONETARY=pl_PL.UTF-8 LC_MESSAGES=pl_PL.UTF-8 LC_PAPER=pl_PL.UTF-8 LC_NAME=pl_PL.UTF-8 LC_ADDRESS=pl_PL.UTF-8 LC_TELEPHONE=pl_PL.UTF-8 LC_MEASUREMENT=pl_PL.UTF-8 LC_IDENTIFICATION=pl_PL.UTF-8 LC_ALL= What is the expected output? What do you see instead? post-review should set it's own locale to C and then execute any checks and commands on the repository it's run in. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 826 in reviewboard: Publishing screenshot comment reviews fails and duplicates comments
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 826 by timw.at.work: Publishing screenshot comment reviews fails and duplicates comments http://code.google.com/p/reviewboard/issues/detail?id=826 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? http://server/r/123/s/456/ What steps will reproduce the problem? 1. Comment on a portion of a screenshot 2. Comment on a portion of another another in the same review request 3. Edit the review (add some review text separate from the comments) 4. Publish the review 5. Re-visit the review request page What is the expected output? What do you see instead? Expected: After 5, the review is published, and it shows up as you just left it in step 4. Actual: After 4, multiple error boxes appear in the page body. The still-draft review now has four comments, where each entered comment has been duplicated and attached to a seemingly-unrelated screenshot (from a different review request). What operating system are you using? What browser? Ubuntu 8.10 x86_64's Firefox 3.0.5 Please provide any additional information below. I traced the HTTP traffic, and the POSTs seem to be reasonable. As in Issue 820, I see comments double-posting (once on entry, and once milliseconds before the publish POST occurs). Once the described error has occurred, I notice in the Admin tool that the review indeed links to 4 comments, and the most recent two are linked to unrelated screenshots. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
