New user group
Hi, We are setting up review board in our company and found one feature which we need. We use LDAP authentication for login. So after a request is created by user A and A wants to add a review group to the request. But this user group needs to be created in Review Board. Is there any way we can add directly our mailer group IDs directly under the groups just like adding reviewb...@googlegroups.com in the request. If I try to enter directly the group email ID it is not added. Is there any way this could be achieved TIA, Kunal --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Diff between revisions is broken in alpha4
Hi, when I view the diff between revisions I get either one of the following two issues: 1) A page containing the error message : list index out of range Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4- py2.4.egg/reviewboard/diffviewer/views.py, line 145, in view_diff interdiffset, highlighting, True)[0] IndexError: list index out of range 2) The page showing the code review header but the panel which is supposed to show the diff now shows a paginator for 2 pages but both pages are empty. Logging is enabled but no errors in httpd's error log. Am I the only one experiencing that? Thanks, Martin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff between revisions is broken in alpha4
ah, somebody already opened a bug for this: http://code.google.com/p/reviewboard/issues/detail?id=892 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Traceback generated when I click “View Diff”
I do have patch in the path. Patch version 2.5.4 on Linux and 2.5.9 on Windows. Is there anything else to check? Thanks, Eugene On Feb 16, 6:49 pm, Christian Hammond chip...@chipx86.com wrote: Looks like you don't have patch in your path. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, Feb 16, 2009 at 12:46 PM, eugene_k kozlov.eug...@gmail.com wrote: When I click View Diff traceback was generated: [Errno 2] No such file or directory Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/views.py, line 145, in view_diff interdiffset, highlighting, True)[0] File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 619, in get_diff_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.5alpha3-py2.5.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 618, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 341, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 248, in get_original_file large_data=True)[0] File /usr/lib/python2.5/site-packages/Djblets-0.5alpha3-py2.5.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 247, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 227, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4- py2.5.egg/reviewboard/scmtools/perforce.py, line 92, in get_file p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, stderr=subprocess.PIPE) File /usr/lib64/python2.5/subprocess.py, line 594, in __init__ errread, errwrite) File /usr/lib64/python2.5/subprocess.py, line 1091, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory I've Review Board alpha 4 running under Fedora 10 and windows Perforce repository. Review generated on Windows box using post-review. Another issue I have is an E-mail and Diff settings. I've typed in mail server IP address and checked Send e-mails for …. Clicked on Save button and all went back to default: Send e-mails for … unchecked, Mail Server set to localhost. Same story under Diff Viewer Settings. Any help is welcome. Thank you all, Eugene --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff between revisions is broken in alpha4
On Tue, Feb 17, 2009 at 16:28, Martin mkoeb...@gmail.com wrote: Am I the only one experiencing that? I have this problem too. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using the demo
diff headers for reviewboard are a bit different... the server needs to know not only the path to the file, but also the revision it was generated from... that's how it looks up the base code. as I understand it, svn diff might give you the right headers, but I'm not sure... we use p4. 2009/2/17 Anthony Foglia afog...@princeton.com: This might be a stupid question. I'd like to play around with the demo, and follow a patch through the review process, but I'm having trouble uploading a patch. My plan was just to add a file, maybe add additional patches to it, etc. My first question: Which repository do I use for demo purposes? Navi or Review Board SVN? Second: What should my patch contain? I tried making a patch with a new file, setting the base diff path to /, but I get an Unable to parse diff revision header when uploading the diff. I think this is because my diff was made outside any version control, and the revision header is a timestamp. Do I need to check out the demo's repository first? If so, where is it? -- Anthony Foglia Princeton Consultants -- Jeff O|||O --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using the demo
The demo server does point to the active SVN server. This is okay because review board never does any commits to version control. -David On Tue, Feb 17, 2009 at 11:17 AM, Anthony Foglia afog...@princeton.com wrote: Thanks. I was aware of the tool, but not using it. My questions are more about how to use the demo, than review board. What repository should be used for demo users: Navi or Review Board SVN? From where do I check out the repository so I can make changes to post for demo purposes? I am assuming the demo does not use the Google Code SVN server where the review board code is, because that would risk demo users making changes to the published code. Am I wrong? Is there simply a directory that's a sandbox for demo users? If so, which. Jeff Andros wrote: sorry, just hit me just how unhelpful that really was. There's a command line tool called post-review you can download to actually produce your uploads. doc on the tool is here: http://code.google.com/docreader/#p=reviewboards=reviewboardt=Using_PostReview the tool can be downloaded out of svn here: http://reviewboard.googlecode.com/svn/trunk/reviewboard/contrib/tools/ 2009/2/17 Jeff Andros j...@bigredtj.com: diff headers for reviewboard are a bit different... the server needs to know not only the path to the file, but also the revision it was generated from... that's how it looks up the base code. as I understand it, svn diff might give you the right headers, but I'm not sure... we use p4. 2009/2/17 Anthony Foglia afog...@princeton.com: This might be a stupid question. I'd like to play around with the demo, and follow a patch through the review process, but I'm having trouble uploading a patch. My plan was just to add a file, maybe add additional patches to it, etc. My first question: Which repository do I use for demo purposes? Navi or Review Board SVN? Second: What should my patch contain? I tried making a patch with a new file, setting the base diff path to /, but I get an Unable to parse diff revision header when uploading the diff. I think this is because my diff was made outside any version control, and the revision header is a timestamp. Do I need to check out the demo's repository first? If so, where is it? -- Anthony Foglia Princeton Consultants (609) 987-8787 x233 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
post-review degrades into O(n)
Disclaimer: This post is specific to SVN. I admittedly don't know much about the other RCS's that reviewboard supports. Would anyone be against the addition of UUID as a configurable parameter when adding a repository to reviewboard or having it grab the UUID automatically when you first configure it and store it? I ask because currently post-review will get a list of the repositories then iterate over each one until it finds a match. This seems wasteful and can take a while when you have a large number of repositories to work through. The UUID should not change in a repository and querying possibly every repo in your list for this data to find a match seems wasteful when the list of the repos can provide this data making post-review perform O(1) for number of repos. Any comments/questions? Thanks, Gary M. Josack --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review degrades into O(n)
Even for a large reviewboard install (several dozen repos) I don't see this being a major performance benefit/detriment. Can you provide some numbers showing this as a problem? It seems like a largely theoretical slowdown. -Kevin On Tue, Feb 17, 2009 at 2:59 PM, Gary M. Josack g...@byoteki.com wrote: Disclaimer: This post is specific to SVN. I admittedly don't know much about the other RCS's that reviewboard supports. Would anyone be against the addition of UUID as a configurable parameter when adding a repository to reviewboard or having it grab the UUID automatically when you first configure it and store it? I ask because currently post-review will get a list of the repositories then iterate over each one until it finds a match. This seems wasteful and can take a while when you have a large number of repositories to work through. The UUID should not change in a repository and querying possibly every repo in your list for this data to find a match seems wasteful when the list of the repos can provide this data making post-review perform O(1) for number of repos. Any comments/questions? Thanks, Gary M. Josack -- Kevin Kubasik http://kubasik.net/blog --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff between revisions is broken in alpha4
I'll try to get to this sometime this week. You'll need to grab a nightly for the fix, because we're a ways off still from beta 1. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Feb 17, 2009 at 7:44 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, Feb 17, 2009 at 16:28, Martin mkoeb...@gmail.com wrote: Am I the only one experiencing that? I have this problem too. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff between revisions is broken in alpha4
No, I'm going to work on a fix this week, but I haven't had the time yet. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Feb 17, 2009 at 7:10 PM, Martin mkoeb...@gmail.com wrote: is it already fixed in the svn version? bug issue 892 is still marked as 'new'. Thanks, Martin On Feb 17, 5:42 pm, Christian Hammond chip...@chipx86.com wrote: I'll try to get to this sometime this week. You'll need to grab a nightly for the fix, because we're a ways off still from beta 1. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Feb 17, 2009 at 7:44 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, Feb 17, 2009 at 16:28, Martin mkoeb...@gmail.com wrote: Am I the only one experiencing that? I have this problem too. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 892 in reviewboard: Diff-viewer crash when viewing difference between diffs with new files.
Comment #1 on issue 892 by mkoebele: Diff-viewer crash when viewing difference between diffs with new files. http://code.google.com/p/reviewboard/issues/detail?id=892 alternatively, I get a paginator for 2 empty pages. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 854 in reviewboard: rb-site install failed on a database with utf-8 charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 854 by ytht.net: rb-site install failed on a database with utf-8 charset http://code.google.com/p/reviewboard/issues/detail?id=854 What steps will reproduce the problem? 1. use mysql backend, create database like this: create database reviewboard CHARACTER SET utf8 COLLATE utf8_bin; 2. run rb-site install, rb-site install will failed with the follwing log( see attachment) What is the expected output? What do you see instead? I want to see rb-site install sucess. But it failed. What operating system are you using? What browser? Debian etch. Please provide any additional information below. Attachments: fail.log 6.3 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Comment #2 on issue 676 by pan126: post-review fails when uploading diff
http://code.google.com/p/reviewboard/issues/detail?id=676
Same here
{{{
svn info
repository info: Path: https://mpu...@svn.redefine.pl/videomakine, Base
path: /cruncher, Supports
changesets: False
svn propget reviewboard:url /Users/marek/Desktop/Projects/cruncher
svn diff --diff-cmd=diff
svn info sql/patches/030.core_movie_is_interlaced.sql
svn info sql/rollbacks/030.core_movie_is_interlaced.sql
svn info sql/patches/030.core_movie_is_interlaced.sql
svn info sql/patches/030.core_movie_is_interlaced.sql
svn info sql/patches/030.core_movie_is_interlaced.sql
svn info sql/rollbacks/030.core_movie_is_interlaced.sql
svn info sql/rollbacks/030.core_movie_is_interlaced.sql
svn info sql/rollbacks/030.core_movie_is_interlaced.sql
svn info test.txt.delete.me
Looking for 'tvod5 /' cookie in /Users/marek/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board at http://tvod5:8080/
Logging in with username mpulczynski
Sending None
HTTP POSTing to http://tvod5:8080/api/json/accounts/login/:
{'username': 'mpulczynski', 'password':
'**'}
Logged in.
Attempting to create review request for None
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
repository info: Path: https://svn.redefine.pl/videomakine, Base path:
/cruncher, Supports changesets:
False
Sending None
HTTP POSTing to http://tvod5:8080/api/json/reviewrequests/new/:
{'repository_path':
u'https://svn.redefine.pl/videomakine'}
Review request created
Attempting to set field 'summary' to 'dupa' for review request '37'
Sending None
HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/set/: {'summary': 'dupa'}
Attempting to set field 'description' to 'dupa' for review request '37'
Sending None
HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/set/:
{'description': 'dupa'}
Sending None
HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/save/: {}
Review request draft saved
Uploading diff, size: 986
Property changes on: .
___
Name: reviewboard:url
+ http://tvod5:8080
Index: /cruncher/sql/patches/030.core_movie_is_interlaced.sql
===
--- /cruncher/sql/patches/030.core_movie_is_interlaced.sql
(revision
0)
+++ /cruncher/sql/patches/030.core_movie_is_interlaced.sql
(revision
0)
@@ -0,0 +1,4 @@
+BEGIN;
+ALTER TABLE core_movie ADD video_is_interlaced boolean NULL;
+COMMIT;
+
Index: /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
===
--- /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
(revision 0)
+++ /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
(revision 0)
@@ -0,0 +1,3 @@
+BEGIN;
+ALTER TABLE core_movie DROP video_is_interlaced;
+COMMIT;
Index: /cruncher/test.txt.delete.me
===
DUPA {'path': {'content': '\nProperty changes on:
.\n___\nName:
reviewboard:url\n
+
http://tvod5:8080\n\nIndex:
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\n===
\n---
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,4 @@\n+BEGIN;\n+
ALTER TABLE core_movie ADD video_is_interlaced boolean
NULL;\n+COMMIT;\n+\nIndex:
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\n==
=\n---
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,3 @@\n+BEGIN;\n+
ALTER TABLE core_movie DROP video_is_interlaced;\n+COMMIT;\nIndex:
/cruncher/test.txt.delete.me\n
===\n', 'filename': 'diff'}}
Sending {'path': {'content': '\nProperty changes on:
.\n___\nName:
reviewboard:url\n
+
http://tvod5:8080\n\nIndex:
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\n===
\n---
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,4 @@\n+BEGIN;\n+
ALTER TABLE core_movie ADD video_is_interlaced boolean
NULL;\n+COMMIT;\n+\nIndex:
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\n==
Issue 472 in reviewboard: HGTool does not support git style diff
Comment #8 on issue 472 by john.levon: HGTool does not support git style diff http://code.google.com/p/reviewboard/issues/detail?id=472 http://www.selenic.com/mercurial/bts/issue1268 is the relevant Mercurial bug -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 887 in reviewboard: Git patch (aqcuired through git show patch.diff) locks a thread and takes 100% cpu serverside
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Component-SCMTools Comment #1 on issue 887 by chipx86: Git patch (aqcuired through git show patch.diff) locks a thread and takes 100% cpu serverside http://code.google.com/p/reviewboard/issues/detail?id=887 Looks like I missed a patch that would have fixed this. Sorry about that. If you'll grab tonight's nightly (generated in about 20 minutes), this should be fixed. It will be available at http://downloads.review-board.org/nightlies/ReviewBoard-1.0beta1.dev_20090216-py2.5.egg Fixed in r1790. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 883 in reviewboard: GitDiffParser parses file additions badly (fix patch enclosed in description)
Comment #2 on issue 883 by anfedorov: GitDiffParser parses file additions badly (fix patch enclosed in description) http://code.google.com/p/reviewboard/issues/detail?id=883 Done: http://reviews.review-board.org/r/745/ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 870 in reviewboard: display which authentication method is used
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 870 by tphams: display which authentication method is used
http://code.google.com/p/reviewboard/issues/detail?id=870
*NOTE: If you have a patch, please submit it to
http://reviews.review-board.org/
What's the URL of the page this enhancement relates to, if any?
/account/login/
Describe the enhancement and the motivation for it.
We have LDAP, NIS, and AD. User is confused which authentication method to
use. I modified ./templates/accounts/login.html to display
{{siteconfig.settings.auth_backend}}. And it's showing nis instead of NIS
(like in admin/forms.py).
What operating system are you using? What browser?
n/a
Please provide any additional information below.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 896 in reviewboard: IndexError in diffviewer/views.py
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 896 by heewa.b: IndexError in diffviewer/views.py http://code.google.com/p/reviewboard/issues/detail?id=896 Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4-py2.5.egg/reviewboard/diffviewer/views.py, line 141, in view_diff first_file = page.object_list[0] IndexError: list index out of range -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 897 in reviewboard: Discarded and Unpublished Reviews keep diff history
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 897 by heewa.b: Discarded and Unpublished Reviews keep diff history http://code.google.com/p/reviewboard/issues/detail?id=897 *NOTE: Do not post confidential information in this bug report.* What steps will reproduce the problem? 1. Create a new review request. 2. Upload a diff. (diffA) 3. Upload a new diff. (diffB) 4. Discard review request. 5. Create a new review request with same changeset. 6. Upload a diff. (diffC) What is the expected output? What do you see instead? I expect just one diff (diffC). But somehow, it keeps the history of all the diffs. This changeset number is now lost forever. I have to create a new changeset and do the whole process over again. What operating system are you using? What browser? Ubuntu/Firefox Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 898 in reviewboard: Branch-to-branch arrow appears as rarr; in the Review request changed pane
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 898 by grant.patterson: Branch-to-branch arrow appears as rarr; in the Review request changed pane http://code.google.com/p/reviewboard/issues/detail?id=898 Change the branching of a change number so that either before or after there was an automerge. The arrow character appears in the Review request changed box as rarr; -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 899 in reviewboard: Perforce error handling problem
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 899 by erichuss: Perforce error handling problem
http://code.google.com/p/reviewboard/issues/detail?id=899
I had an issue where I did not have a p4 ticket (I set the username and
password to blank in my config), and it failed in an unclear way.
The problem is that the P4Error exception API has changed. It now takes
two arguments. Line 102 in perforce.py needs to change. Additionally, as
it is written now, it ignores the first line, but I do not think that is
correct. In my case, the p4 command only printed 1 line:
'Perforce password (P4PASSWD) invalid or unset.'
I think changing that line to something like this would be helpful:
raise P4Error('P4 command failed:', error)
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
