RE: Help! Error 500 on deploy :(
Thanks for the good wishes! Well the best part is that Review Board has been working so well for us that the control group I did an initial rollout with has, on their own, expanded to include our entire development team ☺ Great product: thanks very much for your hard work! Dana Lacoste PS: I did manage to fix the problem I had (which was with Artifactory, not Review Board) but only by re-installing everything from scratch. sigh From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Wednesday, September 09, 2009 1:17 PM To: reviewboard@googlegroups.com Subject: Re: Help! Error 500 on deploy :( I was wracking my brain trying to figure out how a disk space issue could break Review Board so heavily ;) Good luck on fixing the issue. Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Visual SourceSafe
Is it possible to add support for Visual SourceSafe? I'd be willing to help if someone could point me in the right direction to get started. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Visual SourceSafe
As long as Visual SourceSafe allows for grabbing a file of a specific revision remotely in some form, then it can be made to work with Review Board. I believe some other people on the mailing list were going to work on this at some point, but I haven't heard anything in a while. It might be worth reading the mailing list archive to find out what the status was of that and seeing who was involved. If you'd like to work on Visual SourceSafe integration, we'd be happy to help with any guidance. Generally the requirements are: 1) The ability to download a file from a repository remotely, given a file path and revision. This can be provided either by a Python module (must be plain Python, not IronPython), a command-line tool (better if it's cross-platform) or an HTTP request if it can be retrieved that way. 2) Support in post-review for posting/updating a review request. 3) A standard diff format that contains revision information as part of the filename headers. If the tools for Visual SourceSafe don't provide this, you will need to construct it yourself in post-review, either by building a custom diff or post-processing it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Sep 10, 2009 at 12:01 PM, Travis dahlke.tra...@gmail.com wrote: Is it possible to add support for Visual SourceSafe? I'd be willing to help if someone could point me in the right direction to get started. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Feature Request: Include changed files with review
So, before we used Review Board we used an internal (python based, similar to how p4review works) tool to do the following: 1 - Make a copy of the files in a changelist to a share 2 - Make a copy of the baseline version files to the same share 3 - Make a wrapper file specifying what the files were 4 - Send an email pointing at the files saying I've proposed this change, can you review it? to users specified by the code changer. 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a python wrapper which would launch the tool for you) With Review Board, 1-4 are working FAR better than we had before, and we also get : 6 - A website which records feedback on changes BUT We can't do #5. With complicated changes and large number of files the Review Board page can be hard to navigate (not that I think there's anything Review Board can do about this: some changes are too complicated) and the diff might not show adequate info (now THIS is something I think we _can_ do something about.) So I'd like to propose a feature Request: I'd like to be able to attach a .zip to a review request containing the entirety of the changed files. This way I could click on Download Diff and get a .tar/.zip of the modified versions of the files which I could view in their entirety (instead of just the .diff files) I realize this isn't trivial, but I thought I'd ask in case someone else thought it would be useful too :) Thanks, Dana Lacoste --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board has moved to Git - Changes required
On 2009-09-10 17:45, Dan Savilonis wrote: That's not NNTP :-). (IMO HTTP interfaces are even worse than mail. /me laments underappreciated NNTP which is still by far the best interface for discussion lists.) Sounds like you'd be happiest in an IRC client. Um... you are joking, right? IRC is not nearly so easy to follow history (total lack of threads = chaos) and doesn't lend itself to quote-reply format. As for different services, Google Groups doesn't appear to have a native NNTP interface (there is even a Google Answer explicitly stating that there isn't one), whereas gmane is very nearly the canonical NNTP gateway for FLOSS projects, carrying hundreds (maybe even thousands) of lists. Including vim-dev, which is also a Google Group :-). On the bright side, now that reviewboard is in git, you should have no trouble rebasing your patch until it gets accepted! True :-). (Actually, the patch still applied cleanly, sans needing to type manually the name of the file to patch, since post-review is now named postreview.py. Alas, Review Board didn't seem to like the resulting updated diff, so I made a new request, 1031.) -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board has moved to Git - Changes required
Yeah, updating an existing review request just won't work, since the repository has changed. I have no objections to setting things up with gmane, though I don't know enough about gmane to know exactly how this will work. I assume when you reply it still is sent to the mailing list, meaning you need to subscribe anyway. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Sep 10, 2009 at 4:24 PM, Matthew Woehlke mw_tr...@users.sourceforge.net wrote: On 2009-09-10 17:45, Dan Savilonis wrote: That's not NNTP :-). (IMO HTTP interfaces are even worse than mail. /me laments underappreciated NNTP which is still by far the best interface for discussion lists.) Sounds like you'd be happiest in an IRC client. Um... you are joking, right? IRC is not nearly so easy to follow history (total lack of threads = chaos) and doesn't lend itself to quote-reply format. As for different services, Google Groups doesn't appear to have a native NNTP interface (there is even a Google Answer explicitly stating that there isn't one), whereas gmane is very nearly the canonical NNTP gateway for FLOSS projects, carrying hundreds (maybe even thousands) of lists. Including vim-dev, which is also a Google Group :-). On the bright side, now that reviewboard is in git, you should have no trouble rebasing your patch until it gets accepted! True :-). (Actually, the patch still applied cleanly, sans needing to type manually the name of the file to patch, since post-review is now named postreview.py. Alas, Review Board didn't seem to like the resulting updated diff, so I made a new request, 1031.) -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Feature Request: Include changed files with review
Hi Dana, I see two ways of doing this. 1) Make an actual view that returns a zip file (or something) that contains all the files, basically using existing code that we have to download each one, and assemble a zip file of those files. There's a little bit of processing time, but it shouldn't be too bad, really. 2) Implement more general file attachment support. There's a long-standing feature request for attaching arbitrary files. See http://code.google.com/p/reviewboard/issues/detail?id=239 Uploading file attachments is something we want to have in, but just haven't made a priority. If someone wants to work on this, though, we'd be glad to discuss it and get a change in! It would work similarly to the screenshots. Attachments would have a filename and a mimetype, and they'd be accessible through, say, /r/ID/attachments/filename. Maybe we really want both, long-term. What are your thoughts? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Sep 10, 2009 at 4:17 PM, Lacoste, Dana (TSG Software San Diego) dana.laco...@hp.com wrote: So, before we used Review Board we used an internal (python based, similar to how p4review works) tool to do the following: 1 - Make a copy of the files in a changelist to a share 2 - Make a copy of the baseline version files to the same share 3 - Make a wrapper file specifying what the files were 4 - Send an email pointing at the files saying I've proposed this change, can you review it? to users specified by the code changer. 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a python wrapper which would launch the tool for you) With Review Board, 1-4 are working FAR better than we had before, and we also get : 6 - A website which records feedback on changes BUT We can't do #5. With complicated changes and large number of files the Review Board page can be hard to navigate (not that I think there's anything Review Board can do about this: some changes are too complicated) and the diff might not show adequate info (now THIS is something I think we _*can*_ do something about.) So I'd like to propose a feature Request: I'd like to be able to attach a .zip to a review request containing the entirety of the changed files. This way I could click on Download Diff and get a .tar/.zip of the modified versions of the files which I could view in their entirety (instead of just the .diff files) I realize this isn't trivial, but I thought I'd ask in case someone else thought it would be useful too J Thanks, Dana Lacoste --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1304 in reviewboard: test
Updates: Status: Spam Comment #1 on issue 1304 by trowbrds: test http://code.google.com/p/reviewboard/issues/detail?id=1304 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1302 in reviewboard: post-review on Solaris?
Comment #6 on issue 1302 by birbilis: post-review on Solaris? http://code.google.com/p/reviewboard/issues/detail?id=1302 Cool, thanks :) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1306 in reviewboard: Chrome: description and testing done boxes expand with every letter typed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1306 by jhuffaker: Chrome: description and testing done boxes expand with every letter typed http://code.google.com/p/reviewboard/issues/detail?id=1306 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0 Chrome: 4.0.201.1 What's the URL of the page containing the problem? Part of setting up a new review request What steps will reproduce the problem? 1. Install Chrome 2. Open a new review request 3. Start writing a description. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
