Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Christian Hammond
Django-tagging would still require a lot of work to implement properly. Once you're at the point of modifying Review Board to this degree, you may as well just add this to Review Board directly. This sort of feature request is fairly common, and we've been discussing to what degree we want to impl

Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Stodge
Could you use the django-tagging application? I'm not sure if that would help but I thought I'd suggest it. On Feb 7, 6:53 pm, B S Srinidhi wrote: > Hi, > > I'm fairly new to ReviewBoard (and Django :) and need some help in > customizing RB for an internal deployment. > > I would like to introduc

Re: UnicodeDecodeError when posting review.

2010-02-26 Thread Christian Hammond
If people can provide sample diffs that break against the Review Board repository, we'll have an easier time testing this and verify it doesn't break again. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Th

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-26 Thread Christian Hammond
Mine too. We really need some example diffs that break things so we can put them into the unit test suite and verify when we fix it that other diffs don't break. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com

Re: Create a repository via API? Alternatives?

2010-02-26 Thread Christian Hammond
The settings module should just be 'reviewboard.settings'. The 'settings_local' is imported from that. That could be the problem you were hitting. I would advise going this route. Down the road, I'd like to have better support for users to write Django management commands that live in the site di

Re: What is the status of ClearCase integration on Windows?

2010-02-26 Thread Christian Hammond
Having a version that doesn't require an SCM is unlikely to happen in the foreseeable future. We require an SCM to grab the full files so we can even build the diffs. There's way too much that would have to be changed and worked around if we were to remove this requirement. I would much rather som

Re: Unable to upload screenshots

2010-02-26 Thread Christian Hammond
What version of Djblets is on there? I believe this may now be fixed as of 0.5.6. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jan 26, 2010 at 12:55 PM, David Resnick wrote: > No, I'm still stuck w

Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Christian Hammond
Hi Srinidhi, Sorry for not getting back to you on this. The data for comments are stored in reviewboard/reviews/models.py. You'd need to update the API (webapi/) and the UI (htdocs/media/rb/js/*) and the review request page (reviews/views.py) and probably more things. You're going to hit a probl

Re: Help Installing in a directory, not a subdomain

2010-02-26 Thread Christian Hammond
Glad to hear it :) There seem to be issues with the newer pysvn and Subversion. I suspect pysvn isn't properly checking for its own compatibility with the Subversion in the path. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http:/

Re: Settings Not Staying Set

2010-02-26 Thread Christian Hammond
You can go into the Database section of the Admin UI and look in the Site Configuration section. Make sure not to save anything in there or you may end up messing up the settings. It's meant to be a read-only page (and will be in the future). Generally what i'd suggest is to make the changes and

Re: Need some help on CVS diff file format

2010-02-26 Thread Christian Hammond
Hi, That *should* work. As long as the files are in the same repository, and the files are unique, Review Board should be able to handlle it. You could then pass the result to post-review --diff-filename. To my knowledge, there aren't other sites for Review Board information. It's just the Google

Re: Settings Not Staying Set

2010-02-26 Thread Jeff Leyser
Thanks for the very quick replies! How can I verify the settings? Are they stored in a table, or a file on disk? thanks, Jeff On Feb 26, 10:36 am, Christian Hammond wrote: > There's some issue with our settings code and various server threads knowing > when to update their local caches of the s

Re: Settings Not Staying Set

2010-02-26 Thread Christian Hammond
There's some issue with our settings code and various server threads knowing when to update their local caches of the settings. Thought we had it fixed before but it's been cropping up, so I'm looking into a fix hopefully for beta 2. Christian -- Christian Hammond - chip...@chipx86.com Review Bo

Re: Settings Not Staying Set

2010-02-26 Thread Stephen Gallagher
I've also seen that behavior. I think ReviewBoard doesn't set the right no-cache header for that page. On 02/26/2010 01:25 PM, Jeff Leyser wrote: > Hi, > > I've just setup ReviewBoard 1.0.5.1, and am having some problems. The > basics are working (connected to our SVN repo, able to create, view &

Settings Not Staying Set

2010-02-26 Thread Jeff Leyser
Hi, I've just setup ReviewBoard 1.0.5.1, and am having some problems. The basics are working (connected to our SVN repo, able to create, view & edit reviews, etc) My primary problem is that email is not being sent. As far as I can tell from the mail server logs on the machine, ReviewBoard is ne

Re: ReviewBoard Error while posting review for GIT

2010-02-26 Thread Christian Hammond
Ah okay. I've been giving you instructions for the 1.5 case. You could proceed with 1.0, which will require that you instead maintain a local clone of the repository on the Review Board server (or make the main one accessible from the Review Board server in some way) and have it always in sync. Th