post-review fails to login / uses wrong URL
Greetings,
I've set up reviewboard 1.0.8 successfully (apache/mod_python/
postgresql). All on Linux (FC12). Now, post-review fails to work as
expected:
[joac...@testsrv perf]$ post-review --version
RBTools 0.2
[joac...@testsrv perf]$ post-review -d --server=testsrv/reviews
svn info
git rev-parse --git-dir
hg root
hg svn info
repository info: Path: ssh://h...@192.168.10.168/perf, Base path: ,
Supports changesets: False
hg diff
Looking for ' testsrv/reviews/' cookie in
/home/joachim/.post-review-cookies.txt
Couldn't load cookie file: [Errno 2] No such file or directory:
'/home/joachim/.post-review-cookies.txt'
== Review Board Login Required
Enter username and password for Review Board at testsrv/reviews/
Username: joachim
Password:
Logging in with username joachim
HTTP POSTing to
http://testsrv/reviews/testsrv/reviews/api/json/accounts/login/:
{'username': 'joachim', 'password': '**'}
Got HTTP error: 404: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
Transitional//EN
Obviously, the URL is incorrect: the server string testsrv/reviews
is repeated.
I tried to configure the server via ~.reviewboardrc, but this fails
as well:
[joac...@testsrv perf]$ cat ~/.reviewboardrc
REVIEWBOARD_URL=http://testsrv/reviews
[joac...@testsrv perf]$ post-review -d
Syntax error in config file: /home/joachim/.reviewboardrc
Line 1 offset 21
Any ideas on how to fix this?
thanks, Joachim
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.5 Beta 2 Released
On 06/02/2010 08:50 PM, Christian Hammond wrote: Hi, Sorry, I missed this e-mail entirely. It's most likely that the origin of the central server is different between what Review Board has recorded and what your Git clone is using. The remote origin on your clone must match exactly the Path or Mirror Path of your Repository entry in Review Board. Christian Are there any plans to support aliases for this? For example, my project can be cloned from https://git.fedorahosted.org/sssd.git or https://git.fedorahosted.org/git/sssd.git and both alternatives are in use among my team. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.5 Beta 2 Released
There are, but not for 1.5. We absolutely have to get this release out and I'm only allowing a couple crucial things in. I'd like to see this done for 1.6 or 1.7. Right now, you have the following options: 1) Tell people to standardize on one or the other 2) If there's only two options available, put one in Path and the other in Mirror Path. 3) Create a second Repository entry for the other variation. This option kinda sucks, though, but is doable if you have to. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jun 2, 2010 at 5:54 PM, Stephen Gallagher step...@gallagherhome.com wrote: On 06/02/2010 08:50 PM, Christian Hammond wrote: Hi, Sorry, I missed this e-mail entirely. It's most likely that the origin of the central server is different between what Review Board has recorded and what your Git clone is using. The remote origin on your clone must match exactly the Path or Mirror Path of your Repository entry in Review Board. Christian Are there any plans to support aliases for this? For example, my project can be cloned from https://git.fedorahosted.org/sssd.git or https://git.fedorahosted.org/git/sssd.git and both alternatives are in use among my team. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review fails to login / uses wrong URL
The value passed to --server must be a full URL, not just a file path.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jun 3, 2010 at 1:34 AM, Joachim Worringen
worrin...@googlemail.comwrote:
Greetings,
I've set up reviewboard 1.0.8 successfully (apache/mod_python/
postgresql). All on Linux (FC12). Now, post-review fails to work as
expected:
[joac...@testsrv perf]$ post-review --version
RBTools 0.2
[joac...@testsrv perf]$ post-review -d --server=testsrv/reviews
svn info
git rev-parse --git-dir
hg root
hg svn info
repository info: Path: ssh://h...@192.168.10.168/perf, Base path: ,
Supports changesets: False
hg diff
Looking for ' testsrv/reviews/' cookie in
/home/joachim/.post-review-cookies.txt
Couldn't load cookie file: [Errno 2] No such file or directory:
'/home/joachim/.post-review-cookies.txt'
== Review Board Login Required
Enter username and password for Review Board at testsrv/reviews/
Username: joachim
Password:
Logging in with username joachim
HTTP POSTing to
http://testsrv/reviews/testsrv/reviews/api/json/accounts/login/:
{'username': 'joachim', 'password': '**'}
Got HTTP error: 404: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
Transitional//EN
Obviously, the URL is incorrect: the server string testsrv/reviews
is repeated.
I tried to configure the server via ~.reviewboardrc, but this fails
as well:
[joac...@testsrv perf]$ cat ~/.reviewboardrc
REVIEWBOARD_URL=http://testsrv/reviews
[joac...@testsrv perf]$ post-review -d
Syntax error in config file: /home/joachim/.reviewboardrc
Line 1 offset 21
Any ideas on how to fix this?
thanks, Joachim
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Every patch failing on new RB install w/Mercurial
On Jun 2, 5:40 pm, Christian Hammond chip...@chipx86.com wrote: Can you look at that reject file and the other files in that directory and see if anything stands out as being wrong there? If it is the file endings, then that's something I'll be looking into shortly, but it would be nice to know for sure. Certainly. Here's the directory listing, permissions removed for brevity: www-data www-data 1710 2010-06-02 16:31 o_document.inc.diff www-data www-data 21039 2010-06-02 16:31 tmpmYOAiW www-data www-data 21039 2010-06-02 16:31 tmpmYOAiW-new www-data www-data 1504 2010-06-02 16:31 tmpmYOAiW-new.rej Inspecting the .rej file with vim, :fenc claims the file is utf-8 encoded and :ff claims it has unix line endings. Looking at the .rej and .diff files in a hex editor, I only see 0x0a line endings. The diff looks like a normal simple diff without any funny stuff, though I confess I don't know exactly what I might be looking for. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Every patch failing on new RB install w/Mercurial
This is also happening with the 'hg postreview' plugin, so I'm fairly sure that it's something fundamental to RB that's broken. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
some post-review requests succeed, some fail -- same repository user
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /, Supports
changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for None
Submitting the review request as robin
HTTP POSTing to http://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin' for
review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing to http://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields
had errors', u'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
And here's a success:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33715 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33714:33715 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /, Supports
changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33714
Re: some post-review requests succeed, some fail -- same repository user
Sounds like something is failing when Review Board talks to the repository.
This is a Subversion repository? What happens if you do a `svn cat` on that
file with that revision from the Review Board server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jun 3, 2010 at 9:18 AM, Robert Cabacungan
robert.cabacun...@gmail.com wrote:
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /,
Supports changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for
None
Submitting the review request as robin
HTTP POSTing to http://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin'
for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing to http://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
And here's a success:
/usr/local/bin/post-review
Re: (issue 1668) line endings in 1.0.7
Hi Aaron, I've been looking into it. Trying to make sure we can fix this without breaking other files. As always, additional help fixing bugs is always appreciated. My time is limited right now as it is. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jun 3, 2010 at 9:28 AM, Aaron Sherman a...@ajs.com wrote: I haven't seen any chatter about this, and I do have a helpful reproducer, now. Before I go diving into this to see if I can find anything on my own, I was wondering if this was something that had already been identified or if it's likely to be trivial for someone who knows / last touched the code? -- Aaron Sherman Email or GTalk: a...@ajs.com http://www.ajs.com/~ajs http://www.ajs.com/%7Eajs -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: (issue 1668) line endings in 1.0.7
On Thu, Jun 3, 2010 at 2:12 PM, Christian Hammond chip...@chipx86.comwrote: As always, additional help fixing bugs is always appreciated. My time is limited right now as it is. Trust me, that's going around ;-) I'll spend some time on it if I can. Please, do let me know if you find anything (via the ticket is fine) and I'll do the same. -- Aaron Sherman Email or GTalk: a...@ajs.com http://www.ajs.com/~ajs -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: some post-review requests succeed, some fail -- same repository user
I get:
svn: Network connection closed unexpectedly
Thank you! I kept debugging the post-review side of it, but it looks
like something's wrong from the server's perspective.
Thanks a lot!
Rob
On Jun 3, 1:50 pm, Christian Hammond chip...@chipx86.com wrote:
Sounds like something is failing when Review Board talks to the repository.
This is a Subversion repository? What happens if you do a `svn cat` on that
file with that revision from the Review Board server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jun 3, 2010 at 9:18 AM, Robert Cabacungan
robert.cabacun...@gmail.com wrote:
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/--summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /,
Supports changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for
None
Submitting the review request as robin
HTTP POSTing tohttp://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin'
for review request '47'
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files
Comment #1 on issue 1670 by seagle0128: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 I got this error, too. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files
Comment #2 on issue 1670 by seagle0128: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 I got this error, too. I am using RBTools 0.2 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1541 in reviewboard: Multibyte characters in diff fragments are broken with syntax highlighting.
Updates: Status: Confirmed Labels: Component-DiffViewer Milestone-Release1.5 Comment #1 on issue 1541 by chipx86: Multibyte characters in diff fragments are broken with syntax highlighting. http://code.google.com/p/reviewboard/issues/detail?id=1541 Can you submit this to http://reviews.reviewboard.org/? All patches must go through our standard code review process. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Comment #5 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 One thing I'm not sure from the repro case here. Is this the source file (pre-patch) that has the funky newlines? Or does the patch add them? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Updates: Owner: chipx86 Labels: -Priority-Medium Priority-Critical Milestone-Release1.0.x Component-DiffViewer Comment #6 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Updates: Status: Confirmed Comment #7 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 Nevermind, I have a test case now. I just don't have a fix that's working. The problem is that we do newline normalization so that files with lines ending in \r, \n, \r\n, or \r\r\n are processed correctly, but this completely breaks with the patch files. If you have: foo bar^M foo^Mbaz foo And then you add a couple lines, diff will give you: foo +hello bar^M foo^Mbaz foo +world See how diff considers the ^M to be part of the string, not a newline. However, our parser will see that ^M and try to make it a newline, in order to work around other file formats and oddities. This then breaks us, since we'll get a normalized diff that looks like: foo +hello bar foo baz foo +world We may have to process diffs separately, but it's going to be hard to do so without causing new problems. I'd be really interested in finding out how these files are getting so messed up. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Comment #8 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 Of course, if we then change the diff so that the ^M is preserved, it'll break against the source input where the ^M is not preserved, and there's no great way to preserve that there. If we do change the ^M to \n in order to get a new line in the diff, the lines referenced in the diff will no longer be correct and it may fail to apply. Rock and a hard place. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Comment #9 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 There's, of course, no question that this is outside of what one would typically expect, but as for how these files are getting so messed up, imagine that you're reviewing a change to ReviewBoard itself which addresses this problem. It might well include a test case with such a file and subsequent changes to the test case... well, you see where this is going. It is, in fact, purely in a QA context that we're seeing these issues (though that might be partially a result of the versioning differences we have between some parts of our QA environment and other environments using ReviewBoard. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings
Comment #11 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 Let me ask.. Is the intent of the ^M in these files to be newlines, or are they just ending up this way from broken editors? Are they intended to be there for the sake of I want a ^M ? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
