Re: I have some problems about Languages.
Well, I found a little clue about encoding.
/usr/lib/python2.6/json/__init__.py
in this codes, they said python only decode 'ASCII' and 'Unicode'.
So, python couldn't decode when encounter like a 'Korean word'
I find some solution about decoding.
For example,
a= '테스트'
unicodeA =a.decode('euc-kr')
utf8A = unicodeA.encode('utf-8')
or
u = unicode(a, 'euc-kr').encode('utf-8')
Now, I must find the where reviewboard receive response message
which their request to perforce using 'p4 describe' command.
Anyone who knows about that, please tell me.
Thank you.
On 4월8일, 오후12시47분, jh5774@samsung.com jh5774@samsung.com
wrote:
I already set them and test... but still problem is occurred.
I logging some arguments, in
/usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/djblets/
webapi/core.py, line 85,
def encode(self, o, *args, **kwargs):
self.encode_args = args
self.encode_kwargs = kwargs
in this code, argument o have values
{'stat': 'ok', 'review_request': ReviewRequest: [Bad Unicode data]}
Now, I must find that: ReviewRequest: [Bad Unicode data]
But it's so complicate to me.
Anyway, thank you for your help.
On 4월7일, 오후11시07분, Chris M. Clark chris.cl...@ingres.com wrote:
You need the RB admin to fill in the empty encoding box for the repository,
try euc-kr. A regular user is NOT permitted to change this setting.
-Original Message-
From: reviewboard@googlegroups.com on behalf of jh5774@samsung.com
Sent: Wed 4/6/2011 10:40 PM
To: reviewboard
Subject: Re: I have some problems about Languages.
Our Perforce server is window 2003 server
server manager said, he didn't set charset anything.
So, maybe perforce server's encoding is euc-kr..
And, my Reviewboard, in repository setting, Advanced -
Encoding box is empty.
How my ReviewBoard settings change to euc-kr??
Please anyone response to me...
Thank you.
On 4?7?, ??10?48?, jh5774@samsung.com jh5774@samsung.com
wrote:
Our repository is perforce, their P4CHARATERSET=none.
Our Reviewboard's database support Unicode(utf-8).
And our reviewboard repository setting, Advanced - Encoding box is
empty.
Please check that...
Thank you.
On 4?7?, ??2?24?, Min-Woo Lee mw44@gmail.com wrote:
maybe you seems to using euc-kr in your perforce
2011. 4. 6. ?? 9:36? Chris Clark chris.cl...@ingres.com?? ??:
This looks VERY similar in behavior (but different manifestation) to
the
UnicodeDecode error that another Windows user saw recently with UTF8
encoded
files (check the archive for UnicodeDecode). I.e. this isn't a language
issue but an character set encoding issue
There are a few options here but I suspect the easiest is for you to
modify the repository info in Reviewboard and declare the encoding. I'm
guessing you are using a multibyte encoding rather than utf8? Can you
tell
us the encoding?
Chris
jh5774@samsung.com wrote:
Well,
My language, Korean, isn't parsing in Reviewboard.
For example,
I submit Change List(CL) in perforce, and CL's description field is
filled with 'Korean', not English.
And, I go to my Reviewboard server.
In Main menu,
Select New Review Request and select repository (perforce port)
input CL number(with that CL), and click the button 'Create Review
Request'
Then, there's some error in my Review Request.
my description field is empty, and file diff isn't in the RQ.
Below is my reviewboard error messages.
p4 -p 10.244.106.31:1666 info
repository info: Path: 10.244.106.31:1666, Base path: None,
Supports
changesets: True
Generating diff for changenum 901357
p4 describe -s 901357
Processing edit of //this is a branch path. so I delete them
example.h
Writing //this is a branch path. so I delete them example.h#1 to
c:\users\admini~1\appdata\local\temp\tmpcezv0o p4 print -o
c:\users\admini~1\appdata\local\temp\tmpcezv0o -q //this
is a branch path. so I delete them example.h#1 diff -urNp
c:\users\admini~1\appdata\local\temp\tmpcezv0o
d:\projects\S3350_REL_AE\3p_mm_ct_lib\aac_encoder\lib\export\include\aacplu
senc.h Looking for '10.244.106.190 /reviewboard_demo/' cookie in
C:\Users\Administrator\AppData\Roaming\.post-review-cookies.jh5774.bae.txt
Loaded valid cookie -- no login required
HTTP GETting api/
HTTP GETtinghttp://10.244.106.190/reviewboard_demo/api/info/
Using the new web API
Attempting to create review request on 10.244.106.31:1666 for
901357
HTTP POSTing to
http://10.244.106.190/reviewboard_demo/api/review-requests/:{'changenum':
'901357', 'repository': '10.244.106.31:1666'}
Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
Transitional//EN
Re: Realized web-based post-commit reviews
I think it is easy to support additional centralized SCMs. I already did it for Perforce and Microsoft TFS in a previous version. As far as I know there is no similar project for Git. However, it should be possible to extend post-reviewboard to handle Git as well. So far I have not looked into Review Board's Git support and therefore I can't tell if there are any conceptual issues. Philipp On Apr 7, 8:58 pm, Vincent Yee v...@sendmail.com wrote: Good work! How about CVS? From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Martin Sent: Thursday, April 07, 2011 11:53 AM To: reviewboard@googlegroups.com Subject: Re: Realized web-based post-commit reviews Congratulations, I saw you customization and is great. Do you know if there is something like that for git? Thanks in advance. Martin. -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Realized web-based post-commit reviews
That sounds great. Indeed it would be nice to merge this feature into the official code line and I'm willing to assist. Looking forward to your feedback. Philipp -- Philipp Henkel Citrix Online - www.citrixonline.com The views expressed here are mine alone and have not been authorized by, and do not necessarily reflect the views of, Citrix. On Apr 7, 11:20 pm, Christian Hammond chip...@chipx86.com wrote: Awesome! This is something we've wanted for a while, and even had a couple student projects to try to figure it out. I'd love to work on getting this into Review Board. Will look through the code after I'm back from my little vacation :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Apr 7, 2011 at 5:32 AM, Philipp Henkel weltraumpi...@googlemail.com wrote: Hi, In order to simplify the creation of post-commit review requests I created a customized version of Review Board 1.5. I integrated a new request creation form into the web user interface and extended the Subversion SCM tool. The creation of a new request is now as simple as follows: - Select a repository which features post-commit - at the moment Subversion only - Hit Show my pending revisions to get list of your latest code changes - Select one or more of your revisions from the list - Hit Create button to automatically build up the request My changes are fully compatible with Review Board 1.5. I did not add new database tables nor colums. Therefore you can easily install post- reviewboard over your 1.5 installation. The source, more information and a screenshot is available at http://philipphenkel.github.com/post-reviewboard Of course, any feedback is appreciated! Best regards, Philipp -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Realized web-based post-commit reviews
Hi Philipp, This looks like a great feature - our dev teams work by checking in code at the end of each day, so being able to do a post-commit review over multiple revisions would be a killer feature for us. I'm currently evaluating the 1.6beta1 version - would there be much involved in porting your changes up to the 1.6 code base ? We use scmbug to integrate SVN with bugzilla, so our checkin comments have a consistent format - what would be involved in getting your code to use a RE pattern to parse bug numbers out of the revision comments and automatically add them to the review ? Looking forward to seeing this functionality integrated into the main codebase. Rob On Thu, 7 Apr 2011 05:32:44 -0700 (PDT), Philipp Henkel wrote: Hi, In order to simplify the creation of post-commit review requests I created a customized version of Review Board 1.5. I integrated a new request creation form into the web user interface and extended the Subversion SCM tool. The creation of a new request is now as simple as follows: - Select a repository which features post-commit - at the moment Subversion only - Hit Show my pending revisions to get list of your latest code changes - Select one or more of your revisions from the list - Hit Create button to automatically build up the request My changes are fully compatible with Review Board 1.5. I did not add new database tables nor colums. Therefore you can easily install post- reviewboard over your 1.5 installation. The source, more information and a screenshot is available at http://philipphenkel.github.com/post-reviewboard [1] Of course, any feedback is appreciated! Best regards, Philipp Links: -- [1] http://philipphenkel.github.com/post-reviewboard -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Realized web-based post-commit reviews
Hi Rob, Most probably moving to 1.6 code line is not much effort. At least I tried to keep my changes to the main code base small. At the moment I'm fully focused on adding more feature and therefore I have not yet evaluated 1.6. Regarding scmbug: Parsing the svn log is not a big deal and not much overhead as all data is already cached. If a regex is used to extract bug numbers this is good candidate for an official feature in my opinion. Have a nice weekend, Philipp -- Philipp Henkel Citrix Online - www.citrixonline.com On Apr 8, 10:22 am, Rob Coward r...@jive-videos.net wrote: Hi Philipp, This looks like a great feature - our dev teams work by checking in code at the end of each day, so being able to do a post-commit review over multiple revisions would be a killer feature for us. I'm currently evaluating the 1.6beta1 version - would there be much involved in porting your changes up to the 1.6 code base ? We use scmbug to integrate SVN with bugzilla, so our checkin comments have a consistent format - what would be involved in getting your code to use a RE pattern to parse bug numbers out of the revision comments and automatically add them to the review ? Looking forward to seeing this functionality integrated into the main codebase. Rob On Thu, 7 Apr 2011 05:32:44 -0700 (PDT), Philipp Henkel wrote: Hi, In order to simplify the creation of post-commit review requests I created a customized version of Review Board 1.5. I integrated a new request creation form into the web user interface and extended the Subversion SCM tool. The creation of a new request is now as simple as follows: - Select a repository which features post-commit - at the moment Subversion only - Hit Show my pending revisions to get list of your latest code changes - Select one or more of your revisions from the list - Hit Create button to automatically build up the request My changes are fully compatible with Review Board 1.5. I did not add new database tables nor colums. Therefore you can easily install post- reviewboard over your 1.5 installation. The source, more information and a screenshot is available at http://philipphenkel.github.com/post-reviewboard[1] Of course, any feedback is appreciated! Best regards, Philipp Links: -- [1]http://philipphenkel.github.com/post-reviewboard -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Realized web-based post-commit reviews
Hi Philipp, Are You simply running post-review under the scene or somehow import Python classes from rbtools and call appropriate method? I will also a little bit improve UI leaving New Review Request but modifying it just extending window by some Java Script tab like http://jqueryui.com/demos/tabs/ e.g.: Upload diff Enter revisions Greetings from Poland, On Fri, Apr 8, 2011 at 5:10 PM, Philipp Henkel weltraumpi...@googlemail.com wrote: Hi Rob, Most probably moving to 1.6 code line is not much effort. At least I tried to keep my changes to the main code base small. At the moment I'm fully focused on adding more feature and therefore I have not yet evaluated 1.6. Regarding scmbug: Parsing the svn log is not a big deal and not much overhead as all data is already cached. If a regex is used to extract bug numbers this is good candidate for an official feature in my opinion. Have a nice weekend, Philipp -- Philipp Henkel Citrix Online - www.citrixonline.com On Apr 8, 10:22 am, Rob Coward r...@jive-videos.net wrote: Hi Philipp, This looks like a great feature - our dev teams work by checking in code at the end of each day, so being able to do a post-commit review over multiple revisions would be a killer feature for us. I'm currently evaluating the 1.6beta1 version - would there be much involved in porting your changes up to the 1.6 code base ? We use scmbug to integrate SVN with bugzilla, so our checkin comments have a consistent format - what would be involved in getting your code to use a RE pattern to parse bug numbers out of the revision comments and automatically add them to the review ? Looking forward to seeing this functionality integrated into the main codebase. Rob On Thu, 7 Apr 2011 05:32:44 -0700 (PDT), Philipp Henkel wrote: Hi, In order to simplify the creation of post-commit review requests I created a customized version of Review Board 1.5. I integrated a new request creation form into the web user interface and extended the Subversion SCM tool. The creation of a new request is now as simple as follows: - Select a repository which features post-commit - at the moment Subversion only - Hit Show my pending revisions to get list of your latest code changes - Select one or more of your revisions from the list - Hit Create button to automatically build up the request My changes are fully compatible with Review Board 1.5. I did not add new database tables nor colums. Therefore you can easily install post- reviewboard over your 1.5 installation. The source, more information and a screenshot is available at http://philipphenkel.github.com/post-reviewboard[1] Of course, any feedback is appreciated! Best regards, Philipp Links: -- [1]http://philipphenkel.github.com/post-reviewboard -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: installing Reviewboard on Centos 5.5 64-bit
Thanks! I'll report back on progress. On Apr 7, 5:07 pm, David Trowbridge trowb...@gmail.com wrote: It looks like you need to install a -devel package for mysql in order to get the headers. -David On Thu, Apr 7, 2011 at 4:02 PM, Dean deanjohns...@gmail.com wrote: I'm following the v1.5 admin installation doc, and ran into trouble on the mysql-python step. I've been installing as root, and am down to wondering if there are environment setting I have omitted because everybody know python but me... I get these errors: easy_install mysql-python Searching for mysql-python Readinghttp://pypi.python.org/simple/mysql-python/ Readinghttp://sourceforge.net/projects/mysql-python/ Readinghttp://sourceforge.net/projects/mysql-python Best match: MySQL-python 1.2.3 Downloading http://download.sourceforge.net/sourceforge/mysql-python/MySQL-python... Processing MySQL-python-1.2.3.tar.gz Running MySQL-python-1.2.3/setup.py -q bdist_egg --dist-dir /tmp/ easy_install-nX4ESs/MySQL-python-1.2.3/egg-dist-tmp-mHwDDq warning: no files found matching 'MANIFEST' warning: no files found matching 'ChangeLog' warning: no files found matching 'GPL' _mysql.c:36:23: error: my_config.h: No such file or directory _mysql.c:38:19: error: mysql.h: No such file or directory _mysql.c:39:26: error: mysqld_error.h: No such file or directory _mysql.c:40:20: error: errmsg.h: No such file or directory _mysql.c:76: error: expected specifier-qualifier-list before ‘MYSQL’ _mysql.c:90: error: expected specifier-qualifier-list before ‘MYSQL_RES’ _mysql.c: In function ‘_mysql_Exception’: _mysql.c:120: warning: implicit declaration of function ‘mysql_errno’ _mysql.c:120: error: ‘_mysql_ConnectionObject’ has no member named ‘connection’ _mysql.c:123: error: ‘CR_MAX_ERROR’ undeclared (first use in this function) _mysql.c:123: error: (Each undeclared identifier is reported only once _mysql.c:123: error: for each function it appears in.) _mysql.c:131: error: ‘CR_COMMANDS_OUT_OF_SYNC’ undeclared (first use in this function) _mysql.c:132: error: ‘ER_DB_CREATE_EXISTS’ undeclared (first use in this function) _mysql.c:133: error: ‘ER_SYNTAX_ERROR’ undeclared (first use in this function) _mysql.c:134: error: ‘ER_PARSE_ERROR’ undeclared (first use in this function) _mysql.c:135: error: ‘ER_NO_SUCH_TABLE’ undeclared (first use in this function) _mysql.c:136: error: ‘ER_WRONG_DB_NAME’ undeclared (first use in this function) _mysql.c:137: error: ‘ER_WRONG_TABLE_NAME’ undeclared (first use in this function) _mysql.c:138: error: ‘ER_FIELD_SPECIFIED_TWICE’ undeclared (first use in this function) _mysql.c:139: error: ‘ER_INVALID_GROUP_FUNC_USE’ undeclared (first use in this function) _mysql.c:140: error: ‘ER_UNSUPPORTED_EXTENSION’ undeclared (first use in this function) _mysql.c:141: error: ‘ER_TABLE_MUST_HAVE_COLUMNS’ undeclared (first use in this function) _mysql.c:170: error: ‘ER_DUP_ENTRY’ undeclared (first use in this function) _mysql.c:213: warning: implicit declaration of function ‘mysql_error’ _mysql.c:213: error: ‘_mysql_ConnectionObject’ has no member named ‘connection’ _mysql.c:213: warning: passing argument 1 of ‘PyString_FromString’ makes pointer from integer without a cast _mysql.c: In function ‘_mysql_server_init’: _mysql.c:308: warning: label ‘finish’ defined but not used _mysql.c:234: warning: unused variable ‘item’ _mysql.c:233: warning: unused variable ‘groupc’ _mysql.c:233: warning: unused variable ‘i’ _mysql.c:233: warning: unused variable ‘cmd_argc’ _mysql.c:232: warning: unused variable ‘s’ _mysql.c: In function ‘_mysql_ResultObject_Initialize’: _mysql.c:363: error: ‘MYSQL_RES’ undeclared (first use in this function) _mysql.c:363: error: ‘result’ undeclared (first use in this function) _mysql.c:368: error: ‘MYSQL_FIELD’ undeclared (first use in this function) _mysql.c:368: error: ‘fields’ undeclared (first use in this function) _mysql.c:377: error: ‘_mysql_ResultObject’ has no member named ‘use’ _mysql.c:380: warning: implicit declaration of function ‘mysql_use_result’ _mysql.c:380: error: ‘_mysql_ConnectionObject’ has no member named ‘connection’ _mysql.c:382: warning: implicit declaration of function ‘mysql_store_result’ _mysql.c:382: error: ‘_mysql_ConnectionObject’ has no member named ‘connection’ _mysql.c:383: error: ‘_mysql_ResultObject’ has no member named ‘result’ _mysql.c:386: error: ‘_mysql_ResultObject’ has no member named ‘converter’ _mysql.c:389: warning: implicit declaration of function ‘mysql_num_fields’ _mysql.c:390: error: ‘_mysql_ResultObject’ has no member named ‘nfields’ _mysql.c:391: error: ‘_mysql_ResultObject’ has no member named ‘converter’ _mysql.c:392: warning: implicit declaration of function ‘mysql_fetch_fields’ _mysql.c:438: error: ‘_mysql_ResultObject’ has no member named ‘converter’ _mysql.c: In function
Re: installing Reviewboard on Centos 5.5 64-bit
If I use this method (very attractive) do you recommend I back out the steps I've made prior to using your yum/rpm install? On Apr 8, 6:20 am, Stephen Gallagher step...@gallagherhome.com wrote: On 04/07/2011 07:02 PM, Dean wrote: I'm following the v1.5 admin installation doc, and ran into trouble on the mysql-python step. I've been installing as root, and am down to wondering if there are environment setting I have omitted because everybody know python but me... Make your life easier: use the pre-build ReviewBoard RPMs I created for EPEL 5. Add the EPEL repository (instructions here:http://fedoraproject.org/wiki/EPEL#How_can_I_use_these_extra_packages.3F) Then 'yum install ReviewBoard' and you'll get everything you need. No need to use easy_install or understand python. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: installing Reviewboard on Centos 5.5 64-bit
On 04/08/2011 11:57 AM, Dean wrote: If I use this method (very attractive) do you recommend I back out the steps I've made prior to using your yum/rpm install? It's always a good idea to start from a clean state, yes. However RPM/yum *should* be able to handle things for you here. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: I have some problems about Languages.
jh5774@samsung.com wrote:
Well, I found a little clue about encoding.
/usr/lib/python2.6/json/__init__.py
in this codes, they said python only decode 'ASCII' and 'Unicode'.
So, python couldn't decode when encounter like a 'Korean word'
I find some solution about decoding.
For example,
a= '테스트'
unicodeA =a.decode('euc-kr')
utf8A = unicodeA.encode('utf-8')
or
u = unicode(a, 'euc-kr').encode('utf-8')
Now, I must find the where reviewboard receive response message
which their request to perforce using 'p4 describe' command.
Anyone who knows about that, please tell me.
I'd be tempted to take a look at postreview and look at adding an
encoding flag. I haven't yet really looked at the transport mechanism,
there is a string implication that Unicode (specifically utf8) is sent
for the diffs, really bytes should be sent. This may be because json is
supposed to be utf8. Basically you would do the first part of your
example above in postreview. The other option (and this is a hack) is to
change your site packages to change the default system encoding for
Python from ASCII (default for windows) to euc-kr. This normally isn't
recommended BUT it would be a good diagnostic step to take to
prove/disprove the theory. See
http://blog.ianbicking.org/illusive-setdefaultencoding.html
Let us know how you get on.
The extreme solution would be to use utf8 encoding for all source code,
which is fine for new projects but more tricky for older projects.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'
No, I haven't upgrade my server yet. It's a clean 1.5.1 install. On Thu, Apr 7, 2011 at 5:02 PM, Chris Clark chris.cl...@ingres.com wrote: Leonel, I forgot to ask, are you seeing this after an upgrade? Chris Clark wrote: Leonel Togniolli wrote: Every week or so I get one of these below in the mail from my RB server. I wasn't able to determine what triggers it, unfortunately. Me too. See http://code.google.com/p/reviewboard/issues/detail?id=1526 I suggest you log a comment on the issue/bug so that there is a record on how many people are seeing this. I'm now seeing this every day, I think with different users. I know one user has seen this a couple of times (some of the VPN users makes it tricky to know for sure who hits it). I didn't see it with: Django-1.1.1, Djblets-0.5.5, Reviewboard 1.0.5.1 Your seeing it with: Django-1.2.3, Djblets-0.6.6, Reviewboard-1.5.1 I'm seeing it with: Django-1.3, Djblets-0.6.7, Reviewboard-1.5.5 Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails
Comment #6 on issue 1986 by bradford...@emc.com: CVS repository(pserver) addition fails http://code.google.com/p/reviewboard/issues/detail?id=1986 When I created the ReviewBoard repository specifying both the username and passsword in the :pserver: string, the repository got created successfully. :pserver:mccorb1:password@smarts-cvs.lss.emc.com:2906/apps/cvs/smarts However, when I created a diff file, I got an error message when I tried to create a new Review request: cvs server: cannot find module `/apps/cvs/smarts/smarts/app-version/Makedefs.pl' - ignored. I was able to create the Review request by editting the diff file and removing the path information that is part of the :pserver: string (the drb file works; drbM is the original): 05:28 /home/mccorb1/SAM82D9B/smarts/app-version 515 diff drb drbM 3c3 RCS file: smarts/app-version/Makedefs.pl,v --- RCS file: /apps/cvs/smarts/smarts/app-version/Makedefs.pl,v 18c18 RCS file: smarts/app-version/misc/Makedefs.pl,v --- RCS file: /apps/cvs/smarts/smarts/app-version/misc/Makedefs.pl,v 05:28 /home/mccorb1/SAM82D9B/smarts/app-version 516 Attachments: drbM 1.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2065 in reviewboard: patch fails when trying to view patch
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2065 by kande...@gmail.com: patch fails when trying to view patch http://code.google.com/p/reviewboard/issues/detail?id=2065 What version are you running? 1.5.4 What's the URL of the page containing the problem? /r/id/diff/ What steps will reproduce the problem? 1. Put console.py into a sub directory. (eg. /repo/review/) 2. Upload console.patch for review. 3. Try to view the patch. What is the expected output? What do you see instead? Instead of difference, a Python traceback is shown: Traceback (most recent call last): ... File /usr/lib/python2.7/site-packages/ReviewBoard-1.5.4-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 378, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) (Full traceback attached.) patch() method executes this command, imho this is wrong: patch -o /tmp/reviewboard.Tvwttz/tmpP37ele-new /tmp/reviewboard.Tvwttz/tmpP37ele /tmp/reviewboard.Tvwttz/console.py.diff patch command fails: invalid output file name: /tmp/reviewboard.Tvwttz/tmpP37ele Changing working directory and running patch works fine: cd /tmp/reviewboard.Tvwttz/ patch -o tmpP37ele-new tmpP37ele console.py.diff IMHO, an os.chdir() will fix this. Attachments: console.py 404 bytes console.patch 382 bytes traceback.log 1.4 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2065 in reviewboard: patch fails when trying to view patch
Comment #1 on issue 2065 by kande...@gmail.com: patch fails when trying to view patch http://code.google.com/p/reviewboard/issues/detail?id=2065 Sorry, wrong file was attached. Attachments: console.py 281 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1526 in reviewboard: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'
Comment #10 on issue 1526 by tognio...@gmail.com:
AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'
http://code.google.com/p/reviewboard/issues/detail?id=1526
For the record, I get this occasionally too. Haven't been able to determine
who was using the server when the error happened or what he was doing.
Traceback (most recent call last):
File C:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django\core\handlers\base.py,
line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\auth\util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)
File C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\accounts\decorators.py,
line 46, in _check_valid_prefs
return view_func(request, *args, **kwargs)
File C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\views.py,
line 330, in dashboard
return grid.render_to_response(template_name)
File C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 700, in render_to_response
self.load_state()
File C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 535, in load_state
self.precompute_objects()
File C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 611, in precompute_objects
pk__in=self.id_list).order_by())
File C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\datagrids.py,
line 438, in post_process_queryset
queryset.with_counts(self.request.user))
File C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 654, in post_process_queryset
queryset = column.augment_queryset(queryset)
File C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\datagrids.py,
line 83, in augment_queryset
pk__in=self.datagrid.id_list).values_list('pk', flat=True)
AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'
ModPythonRequest
path:/dashboard/,
GET:QueryDict: {u'view': [u'outgoing']},
POST:QueryDict: {},
COOKIES:{'rbsessionid': 'c307d37908b2901bbd2e42e4b714ce9b'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
'HTTP_ACCEPT_LANGUAGE': 'pt-br,pt;q=0.8,en-us;q=0.5,en;q=0.3',
'HTTP_CACHE_CONTROL': 'max-age=0',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=c307d37908b2901bbd2e42e4b714ce9b',
'HTTP_HOST': 'myserver2:8080',
'HTTP_KEEP_ALIVE': '115',
'HTTP_REFERER': 'http://myserver2:8080/dashboard/?view=outgoing',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR;
rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8',
'PATH_INFO': u'/dashboard/',
'PATH_TRANSLATED': None,
'QUERY_STRING': 'view=outgoing',
'REMOTE_ADDR': '172.16.44.45',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'myserver2',
'SERVER_PORT': 8080,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2057 in reviewboard: Detect and auto-link review request IDs
Comment #3 on issue 2057 by cord...@gmail.com: Detect and auto-link review request IDs http://code.google.com/p/reviewboard/issues/detail?id=2057 Sorry, but I don't understand. I used /r/7721 in a comment and that is exactly what I got, I was hoping for it to be automatically replaced with a hyperlink to the corresponding URL similar to the Bugzilla autolinking feature. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
