Issue 3854 in reviewboard: Bug links only work immediately after editing a review description

2015-04-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3854 by davefid...@gmail.com: Bug links only work immediately  
after editing a review description

https://code.google.com/p/reviewboard/issues/detail?id=3854

What version are you running?
2.0.15

What's the URL of the page containing the problem?
Any review page e.g. http://reviews/r/24090/

What steps will reproduce the problem?
1. Create a review
2. Ensure that the Description contains a reference to a bugzilla bug such  
as bug 12345

3. Press OK
4. Observe that the text bug 12345 is rendered as a link to the  
repository bugzilla URL

5. Refresh the page or view as another user


What is the expected output?

The text bug 12345 remains rendered as a link to the repository bugzilla.

What do you see instead?

The text bug 12345 is not a hyperlink any more.

What operating system are you using? What browser?

Debian Squeeze, python easy_install
Problem occurs on Firefox, Chrome and IE

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: [question] python-dateutil version

2015-04-22 Thread Stephen Gallagher
dateutil broke compatibility after 1.5, so Review Board had to lock it to a
known-good version.
On Wed, Apr 22, 2015 at 6:30 AM Michael Zhilin miz...@gmail.com wrote:

 Hi,

 I'm working on porting ReviewBoard 2.x on FreeBSD system. Today I've faced
 problem with versioning of python-dateutil. According to setup.py, RB
 requires dateutil ver.1.5 (exact), but actual version (with Py2 support) is
 2.4.2.

 My question is: is there any (hidden) reason to have exact version 1.5?

 AFAIK dateutil support Python 2.7 with versions 1.5  2.2+

 Thank you in advance,
   Michael.

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Problems upgrading to 2.0.13 and 2.0.15

2015-04-22 Thread Daniel Dominguez
That fixed it.  Many Thanks!

On Friday, April 17, 2015 at 2:05:03 PM UTC-7, Christian Hammond wrote:

 Hi Daniel,

 Sorry, I've been pretty swamped.

 First, make a backup of your database. Then, try:

 DELETE FROM django_project_version WHERE id=4;

 Then perform the upgrade again.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Fri, Apr 17, 2015 at 10:29 AM, Daniel Dominguez daniel.j@gmail.com 
 javascript: wrote:

 Any update here?


 On Friday, March 20, 2015 at 1:29:07 PM UTC-7, Daniel Dominguez wrote:

 Running --hint --evolve had not been done before.  It was just my 
 experimenting after seeing this issue (with a current backup of the db 
 first of course).

 Anyhow, I've attached the sql dump you requested.

 Thanks!

 On Friday, March 20, 2015 at 8:28:36 AM UTC-7, Daniel Dominguez wrote:

 When I performed the upgrade form 2.0.12 to 2.0.13, the site-upgrade 
 failed.  It didn't seem to break our reviewboard instance, so I just 
 ignored it at the time.  I recently upgraded to 2.0.15, and the result is 
 the same.  Again, our reviewboard server seems to be fine, but this is 
 starting to make me nervous.


 -- begin log output --
 Creating tables ...
 Project signature has changed - an evolution is required
 Installing custom SQL ...
 Installing indexes ...
 Installed 0 object(s) from 0 fixture(s)
 The stored evolutions do not completely resolve all model changes.

 Run `./manage.py evolve --hint` to see a suggestion for the changes 
 required.

 The following are the changes that could not be resolved:
 In model reviews.ReviewRequest:
 Field 'description_rich_text' has been added
 Field 'testing_done_rich_text' has been added
 In model reviews.Review:
 Field 'body_top_rich_text' has been added
 Field 'body_bottom_rich_text' has been added
 In model reviews.ReviewRequestDraft:
 Field 'description_rich_text' has been added
 Field 'testing_done_rich_text' has been added
 In model accounts.Profile:
 Field 'default_use_rich_text' has been added
 CommandError: Your models contain changes that Django Evolution cannot 
 resolve automatically.

 
 I've trying running evolve -- --hint --execute, but that fails with the 
 following

 CommandError: Error applying evolution: (1060, Duplicate column name 
 'default_use_rich_text')



 I've checked that I have the latest django_evolution installed for my 
 platform (0.7.4).  This is running on a MySql database.

 It seems like the evolution is trying to add columns that already 
 exist.  Maybe a version table didn't get incremented in the prior 
 evolution?  Any hints on how I can troubleshoot this?



  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: New comment moderation in effect

2015-04-22 Thread Gaurav Chhabra
Thanks for your reply. :)

On Wed, Apr 22, 2015 at 8:42 PM, David Trowbridge trowb...@gmail.com
wrote:

 How long depends on whether the moderators are asleep.

 -David
 On Wed, Apr 22, 2015 at 8:11 AM GC varuag.chha...@gmail.com wrote:

 Hi,


 Today i tried posting a query for the first time. This was done around
 three hours back but i'm yet to see it on the board. Subject line was 
 Command
 Line tool for Review Board administration. Can anyone please let me
 know as to how long it generally takes for a post to get approved?


 Regards,
 Gaurav


 On Friday, June 12, 2009 at 3:58:23 PM UTC+5:30, Christian Hammond wrote:

 Hi everyone.

 As I'm sure you all have seen, we've been getting some spam lately.
 There was a discussion in an earlier thread about enabling comment
 moderation, and after thinking it over, I've decided to go ahead and enable
 this for new users. Existing users who have been approved shouldn't have
 any trouble posting, but new users may see delays before their first e-mail
 is sent.

 I'm going to try recruiting a couple regulars from this mailing list to
 act as moderators. If you're up for the task, please let me know. Bonus
 points for people in non-PST timezones.

 Christian

 --

 Christian Hammond - chi...@chipx86.com


 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/mS591c3RLoI/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Command Line tool for Review Board administration

2015-04-22 Thread GC
Hi,


Does Review Board provides a CLI for administrators? We use Git as our 
version control system and we receive following requests from time-to-time:

Add repository
Add user
Add reviewers (Not very frequent)

Although these operations don’t consume much time, I would like to automate 
them, if possible.


Thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: New comment moderation in effect

2015-04-22 Thread GC
Hi,


Today i tried posting a query for the first time. This was done around 
three hours back but i'm yet to see it on the board. Subject line was Command 
Line tool for Review Board administration. Can anyone please let me know 
as to how long it generally takes for a post to get approved?


Regards,
Gaurav


On Friday, June 12, 2009 at 3:58:23 PM UTC+5:30, Christian Hammond wrote:

 Hi everyone.

 As I'm sure you all have seen, we've been getting some spam lately. There 
 was a discussion in an earlier thread about enabling comment moderation, 
 and after thinking it over, I've decided to go ahead and enable this for 
 new users. Existing users who have been approved shouldn't have any trouble 
 posting, but new users may see delays before their first e-mail is sent.

 I'm going to try recruiting a couple regulars from this mailing list to 
 act as moderators. If you're up for the task, please let me know. Bonus 
 points for people in non-PST timezones.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: New comment moderation in effect

2015-04-22 Thread David Trowbridge
How long depends on whether the moderators are asleep.

-David
On Wed, Apr 22, 2015 at 8:11 AM GC varuag.chha...@gmail.com wrote:

 Hi,


 Today i tried posting a query for the first time. This was done around
 three hours back but i'm yet to see it on the board. Subject line was Command
 Line tool for Review Board administration. Can anyone please let me know
 as to how long it generally takes for a post to get approved?


 Regards,
 Gaurav


 On Friday, June 12, 2009 at 3:58:23 PM UTC+5:30, Christian Hammond wrote:

 Hi everyone.

 As I'm sure you all have seen, we've been getting some spam lately. There
 was a discussion in an earlier thread about enabling comment moderation,
 and after thinking it over, I've decided to go ahead and enable this for
 new users. Existing users who have been approved shouldn't have any trouble
 posting, but new users may see delays before their first e-mail is sent.

 I'm going to try recruiting a couple regulars from this mailing list to
 act as moderators. If you're up for the task, please let me know. Bonus
 points for people in non-PST timezones.

 Christian

 --

 Christian Hammond - chi...@chipx86.com


 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

2015-04-22 Thread Steve
Actually, maybe I should be testing out 2.5 anyway.  I think I'll give that 
a try first.

--steve

On Wednesday, April 22, 2015 at 2:53:10 PM UTC-7, Steve wrote:

 Will do.  Thanks!


 On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote:

 Would you mind filing a bug on our issue tracker?

 Thanks,
 -David

 On Tue, Apr 21, 2015 at 2:35 PM Steve seide...@gmail.com wrote:

 Oops, sorry for forgetting that.

 Review Board 2.0.15
 RBTools 0.7.2

 --steve


 On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number 
 is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, 
 but 
 there may be good reasons to not update it.  So I guess my question is, 
 is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically 
 updated 
 in the review request with the actual submitted change list number, 
 because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)

2015-04-22 Thread James Knight
So I wasn't using RBTools but I figured I'd try it first to see a working 
solution with rbt rather than using the web interface.

After installing and invoking `rbt`, the first commit of ten (10) created 
my first review for me. As soon as I try performing an `rbt posh 
full_commit_index` on the second or greater commits they fail. The 
specific error for my case was:

$ rbt post 2c6346ea50d25a974f4819a372f252d34d35d0da

 ERROR: Error validating diff


 my_file: The file was not found in the repository.


I assume this is a valid error message since the file is created in the 
first commit and ReviewBoard cannot interpret the parent state of the newer 
commit(s). After looking at the documentation, I don't see a way to provide 
a list of local parent commits which ReviewBoard can interpret the chain of 
changes. I assume the only work around I can do is actually push up the 
changes on the remote on a branch (something I wanted to avoid) and 
reference the branch in rbt's `--parent` parameter when generating a review 
for each pending commit.

On Thursday, April 16, 2015 at 2:37:30 PM UTC-4, Stephen Gallagher wrote:

 On Thu, 2015-04-16 at 09:07 -0700, James Knight wrote:

 I have the following scenario, I have a remote Git repository (powered by 
 GitLab) configured and working as expected with ReviewBoard (2.0.15). In my 
 local repository (cloned), I have a series of ten (10) commits I'm about to 
 push to the origin. Before I do this, I generate a (full indexed; unified) 
 patch for the respective commits and I want to put them into ReviewBoard. 
 Uploading the patches, I proceed as follows:

1. Make a new review. Select the first patch and upload to 
ReviewBoard. The review is created.
2. Make a second review. Select the second patch and attempt to upload 
to ReviewBoard. ReviewBoard complains the parent hash doesn't exist. I 
 then 
upload my second patch with my first patch as a parent diff. The review is 
created.
3. Attempt to make a third review. Select the third patch to upload 
but find no way to upload since I cannot complete the parent chain of 
diffs. Full stop.

 The exact error message is as follows:

 The file file (revision hash) was not found in the repository


 Is there a way I can append multiple parent diff's for a review? My 
 attempts were to merge append patch 1 and 2 together, with no luck. Or, 
 am I attempting to use ReviewBoard in an incorrect way?

 The only work around I see is waiting until I commit the new patches into 
 the remote repository before adding the other patches, for example:

1. Add patches 1 and 2 to respective reviews.
2. Reviews approved and patches committed.
3. Add patches 3 and 4 to respective reviews.
4. Reviews approved and patches committed.
5. ~keep repeating until final patch is committed~

 Any help would be appreciated.



 Try doing this:

 rbt post commit_id

 One at a time, from the oldest to the newest. Use *exactly* the commit ID 
 as shown by 'git log'.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

2015-04-22 Thread Steve
Will do.  Thanks!


On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote:

 Would you mind filing a bug on our issue tracker?

 Thanks,
 -David

 On Tue, Apr 21, 2015 at 2:35 PM Steve seide...@gmail.com javascript: 
 wrote:

 Oops, sorry for forgetting that.

 Review Board 2.0.15
 RBTools 0.7.2

 --steve


 On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number 
 is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, 
 but 
 there may be good reasons to not update it.  So I guess my question is, 
 is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically 
 updated 
 in the review request with the actual submitted change list number, 
 because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)

2015-04-22 Thread David Trowbridge
How have you configured the repository on Review Board?

-David

On Wed, Apr 22, 2015 at 1:50 PM James Knight james.d.kni...@live.com
wrote:

 So I wasn't using RBTools but I figured I'd try it first to see a working
 solution with rbt rather than using the web interface.

 After installing and invoking `rbt`, the first commit of ten (10) created
 my first review for me. As soon as I try performing an `rbt posh
 full_commit_index` on the second or greater commits they fail. The
 specific error for my case was:

 $ rbt post 2c6346ea50d25a974f4819a372f252d34d35d0da

 ERROR: Error validating diff


 my_file: The file was not found in the repository.


 I assume this is a valid error message since the file is created in the
 first commit and ReviewBoard cannot interpret the parent state of the newer
 commit(s). After looking at the documentation, I don't see a way to provide
 a list of local parent commits which ReviewBoard can interpret the chain of
 changes. I assume the only work around I can do is actually push up the
 changes on the remote on a branch (something I wanted to avoid) and
 reference the branch in rbt's `--parent` parameter when generating a review
 for each pending commit.

 On Thursday, April 16, 2015 at 2:37:30 PM UTC-4, Stephen Gallagher wrote:

 On Thu, 2015-04-16 at 09:07 -0700, James Knight wrote:

 I have the following scenario, I have a remote Git repository (powered by
 GitLab) configured and working as expected with ReviewBoard (2.0.15). In my
 local repository (cloned), I have a series of ten (10) commits I'm about to
 push to the origin. Before I do this, I generate a (full indexed; unified)
 patch for the respective commits and I want to put them into ReviewBoard.
 Uploading the patches, I proceed as follows:

1. Make a new review. Select the first patch and upload to
ReviewBoard. The review is created.
2. Make a second review. Select the second patch and attempt to
upload to ReviewBoard. ReviewBoard complains the parent hash doesn't 
 exist.
I then upload my second patch with my first patch as a parent diff. The
review is created.
3. Attempt to make a third review. Select the third patch to upload
but find no way to upload since I cannot complete the parent chain of
diffs. Full stop.

 The exact error message is as follows:

 The file file (revision hash) was not found in the repository


 Is there a way I can append multiple parent diff's for a review? My
 attempts were to merge append patch 1 and 2 together, with no luck. Or,
 am I attempting to use ReviewBoard in an incorrect way?

 The only work around I see is waiting until I commit the new patches into
 the remote repository before adding the other patches, for example:

1. Add patches 1 and 2 to respective reviews.
2. Reviews approved and patches committed.
3. Add patches 3 and 4 to respective reviews.
4. Reviews approved and patches committed.
5. ~keep repeating until final patch is committed~

 Any help would be appreciated.



 Try doing this:

 rbt post commit_id

 One at a time, from the oldest to the newest. Use *exactly* the commit ID
 as shown by 'git log'.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Command Line tool for Review Board administration

2015-04-22 Thread Christian Hammond
Hi,

We don't provide a tool for adding those (though that'd be a handy project
for someone to work on). We do have an API, though, for adding/manipulating
repositories, default reviewers, review requests, and just about anything
else.

It does not support adding users, though. Most people use an LDAP or Active
Directory server when they need that kind of ability. That said, I'm not
opposed to adding that functionality, but it'd be low on our todo list, so
the best way to get that into the product is by writing a patch and
contributing it.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Wed, Apr 22, 2015 at 3:04 AM, GC varuag.chha...@gmail.com wrote:

 Hi,


 Does Review Board provides a CLI for administrators? We use Git as our
 version control system and we receive following requests from time-to-time:

 Add repository
 Add user
 Add reviewers (Not very frequent)

 Although these operations don’t consume much time, I would like to
 automate them, if possible.


 Thanks

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Not able to find a function

2015-04-22 Thread Barret Rennie
Hi there,

Hello;

Definitions for these functions don’t actually exist. The Resource class 
(defined in rbtools.api.resource) generates these functions at run time from 
the JSON returned by the Review Board web API.

Each returned JSON response has a “links” field, which contains a a JSON object 
mapping names to URLs and metadata. Each resource name in the links field (e.g. 
diffs) has a get_resource_name (e.g., get_diffs) method created. If you look at 
resource.py:150, you can see the logic where it iterates through the links and 
generates lambdas.

The create function is similar, but we have a special function _create 
(resource.py:31) that handles adding keyword args to the http request and sends 
it.

I hope this answers your questions.
Barret Rennie
 On Apr 21, 2015, at 10:19 PM, XYZ karthikut...@gmail.com wrote:
 
 Hi,
 
 I am trying to understand the integration of perforce repository with review 
 board.
 I am stuck at one point, i am not able to find the implementation of a 
 particular function.
 
 Can someone please explain how this function call works:
 
 In rbtools\command\post.py file, within post_request function :
 
 review_request = api_root.get_review_requests().create(**request_data)
 
 Where are these functions? 
 
 get_review_requests()
 create()
 
 Similarly, further down :
 review_request.get_diffs().upload_diff(diff_content,**diff_kwargs)
 
 where is get_diffs() method ?
 
 Tnx
 
 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[question] python-dateutil version

2015-04-22 Thread Michael Zhilin
Hi, 

I'm working on porting ReviewBoard 2.x on FreeBSD system. Today I've faced 
problem with versioning of python-dateutil. According to setup.py, RB 
requires dateutil ver.1.5 (exact), but actual version (with Py2 support) is 
2.4.2. 

My question is: is there any (hidden) reason to have exact version 1.5?

AFAIK dateutil support Python 2.7 with versions 1.5  2.2+

Thank you in advance, 
  Michael.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.