How to patch javascript changes on production envrionment?

2015-07-06 Thread Xy Sui
Hi, I would like to patch my rvb server (version 2.0.15) with the changes in the below review request: https://reviews.reviewboard.org/r/7186/ So my patch steps are: wget http://reviews.reviewboard.org/r/7186/diff/raw/ -O /tmp/r7186.patch cd

How to path javascript changes on production envrionment?

2015-07-06 Thread Xy Sui
Hi, I would like to patch our reviewboard server with the diff of below review request which includes 2 javascript changes https://reviews.reviewboard.org/r/7186/ So my patch steps are: wget http://reviews.reviewboard.org/r/7186/diff/raw/ -O /tmp/r7186.patch cd

when i svn delete the file AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png, then post-review failed, what's wrong ?

2015-07-06 Thread Joost Shao
1: post-review AdminLTE 2: Failed to execute command: ['svn', 'info', 'AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png'] [svn: E205000: Try 'svn help info' for more information\n, svn: E205000: Syntax error parsing peg revision '2x.png'\n] what's wrong with the charater @ ? some one can tell

Re: Upgrade to 2.0.15 just worked, and users liked it

2015-07-06 Thread John Schmitt
Are you suggesting that I copy both the database and also the site directory? Are you suggesting that I skip the `rb-site install` step completely? Thanks for the tips. On Sunday, July 5, 2015 at 10:39:38 PM UTC-7, Christian Hammond wrote: Hi John, If setting things up to import an

Re: Upgrade to 2.0.15 just worked, and users liked it

2015-07-06 Thread John Schmitt
Can you please explain your thinking about setuptools? I have an up-to-date centos 7 installation. On Sunday, July 5, 2015 at 10:36:45 PM UTC-7, Christian Hammond wrote: Hi, What version of Python are you using? Can you try upgrading setuptools? It might just be too old now. Christian

CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)

2015-07-06 Thread John Schmitt
Is there a work-around for this? # rb-site upgrade /var/www/reviews.domain.com Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output

Sentry / Raven + Reviewboard

2015-07-06 Thread gjacobs
Anyone using Reviewboard and Sentry / Raven Client? http://www.getsentry.com https://github.com/getsentry/sentry In our case, we wire Sentry into most internal systems so we can monitor and capture failures. I'm looking at using Reviewboard 2.5 Beta internally and wanted to capture both

Re: Upgrade to 2.0.15 just worked, and users liked it

2015-07-06 Thread Christian Hammond
The 0.6c* series of setuptools are considered heavily legacy at this point. A lot of has happened in the world of Python packaging over the past year or so, including new standards around package versioning, lookup, naming, etc. So it's possible something is messed up there. That said, I would

Re: Upgrade to 2.0.15 just worked, and users liked it

2015-07-06 Thread Christian Hammond
Yeah, you'll want the same site directory, because of the configuration and data files. Otherwise, you'll generate a new site with keys that don't match some of the state in the database. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag,

Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)

2015-07-06 Thread John Schmitt
My script drops the entire database then does a clean install. Then I import my old mysql database and run `rb-site upgrade`. I'd really like to be able to finish this upgrade. My struggle with it has been a couple of weeks now - I keep hoping that I'm doing something wrong and that posting my

Re: CRITICAL:root:Error running database evolver function change_column_attr_unique:

2015-07-06 Thread John Schmitt
Thanks for looking at this, Christian. When dumping my old database, I have the option of adding 'DROP TABLE' commands. I've been doing that since I get different error messages without it. Should I find a better way to dump and import? I'm working on reproducing so that I can answer your

Re: when i svn delete the file AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png, then post-review failed, what's wrong ?

2015-07-06 Thread Christian Hammond
Review Board's speed when showing diffs is usually the result of the response times of the repository. What version of Review Board are you using there? Also, post-review is now ancient and was replaced a long time ago. It's failing because @ is special in SVN paths. This has since been fixed, I

Re: Deleting a diff from a published review?

2015-07-06 Thread Christian Hammond
Hey Terry, Not without removing it in the database, I'm afraid. That would then effect some other behavior, though, and break the change record. Best to just leave it in, maybe have the developer post a review stating that the diffs are the same and to ignore that version. Christian On Monday,

Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)

2015-07-06 Thread Christian Hammond
This looks like another symptom of a very confused database. Are you starting from scratch every time you do an import + upgrade? It's not enough to drop individual tables. The entire database must be recreated. Christian On Monday, July 6, 2015, John Schmitt marmalo...@gmail.com wrote: Is

Update to RBTools 0.7.4, scripts to interface with reviewboard now error.

2015-07-06 Thread Jens Stobernack
Hello, I have been using Review Board version 1.7.16 with great success. I had been using Centos 7 with RBTools 0.7.2 (package RBTools-0.7.2-1.el7.noarch). I recently updated the Centos 7 install and RBTool was updated to version 0.7.4 (package RBTools-0.7.4-1.el7.noarch). I use a canned

Re: Update to RBTools 0.7.4, scripts to interface with reviewboard now error.

2015-07-06 Thread Jens Stobernack
I am wondering if the updates to Bug 3858 https://code.google.com/p/reviewboard/issues/detail?id=3858 might have created this change in behaviour. Regards. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check

Re: Hook capabilities: Extending Reviewboard

2015-07-06 Thread Christian Hammond
Hey Chris, This sounds like something that would be a good addition, but doesn't exist yet. Just to make sure I fully understand, you want this outside of the review request box, below it, but above the diff viewer boxes. I'm all for adding a few more TemplateHooks like this. Perhaps

Re: Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial

2015-07-06 Thread reviewboard
Comment #1 on issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 Similar to closed Issue 3894 -- You received this message because this project is

Re: Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial

2015-07-06 Thread reviewboard
Comment #2 on issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 Workaround is to just be in the root of the repository when running rbt post -- You

Migrate database(mysql) to another server

2015-07-06 Thread Shan Shan
Hi, I need to move rb database to a separate server. Is it just as simple as dump the database to the new server and change setting_local.py? Do I need to shut/restart anything? Thanks, Shan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to

Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial

2015-07-06 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 *** READ THIS BEFORE POSTING! *** ***

Re: Migrate database(mysql) to another server

2015-07-06 Thread David Trowbridge
It's pretty much that simple. You'll need to restart your web server after changing the settings file. -David On Mon, Jul 6, 2015 at 5:26 PM Shan Shan shan33s...@gmail.com wrote: Hi, I need to move rb database to a separate server. Is it just as simple as dump the database to the new server

Re: Migrate database(mysql) to another server

2015-07-06 Thread Christian Hammond
Hi Shan, If there's nothing more complex (like a version/database upgrade), then you should be set with that. Make sure the new database grants the necessary permissions for Review Board's assigned user in settings_local.py. You probably need to reload Apache to get all the threads seeing the

Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)

2015-07-06 Thread John Schmitt
On Monday, July 6, 2015 at 2:41:34 PM UTC-7, Christian Hammond wrote: Hi John, Yeah, I know this must be frustrating. I don't know why it's being so difficult, as we routinely have people upgrade from 1.0.x and 1.5.x to 2.0.x without problems. If you're able to get me that list of SQL

Re: Update to RBTools 0.7.4, scripts to interface with reviewboard now error.

2015-07-06 Thread Christian Hammond
Hi Jens, It's possible that something regressed here. Would you mind filing a new bug that we can use to track this? I'll see what we can do to get a fix in for the upcoming 0.7.5 release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag,

Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)

2015-07-06 Thread Christian Hammond
Hi John, Yeah, I know this must be frustrating. I don't know why it's being so difficult, as we routinely have people upgrade from 1.0.x and 1.5.x to 2.0.x without problems. If you're able to get me that list of SQL statements (from the `rb-site manage /path/to/site evolve -- --sql`) on a clean

Hook capabilities: Extending Reviewboard

2015-07-06 Thread Chris Lang
Hey there, I have been developing an extension for ReviewBoard and have a prototype for the extension running on my local version of ReviewBoard. It is an extension for reviewing diffs on a review request. I have successfully gotten it to appear at the bottom of the page when you click on a

Issue 3911 in reviewboard: It suddenly comes to Data directory changes

2015-07-06 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3911 by china.li...@gmail.com: It suddenly comes to Data directory changes https://code.google.com/p/reviewboard/issues/detail?id=3911 What version are you running? ReviewBoard-1.7.27-py2.6.egg-info What's the URL of the

It suddenly comes to Data directory changes

2015-07-06 Thread china . lichen
I have used ReviewBoard for 2 months. It ran well till last friday(2015.07.03). It suddenly shows Data directory changes and ask me to check the the data folder in htdocs and the configuration file as below: If using fastcgi or wsgi, you want to check the reviewboard.fcgi or reviewboard.wsgi

Re: How to path javascript changes on production envrionment?

2015-07-06 Thread Xy Sui
Nice. It works after I rebuild the reviewboard egg package. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know!

Re: Github Enterprise with Okta login - Cannot login with token

2015-07-06 Thread Christian Hammond
Hi Albert, We discussed this separately, but for anybody else who comes across this, GitHub Enterprise's API does not support services like Okta for authenticating with the API for retrieving an API token. It requires a username and password, according to their documentation and that error

Re: Issues setting up subversion repo (svn+ssh) on Review Board

2015-07-06 Thread Christian Hammond
Hi Carel, Sorry for the delay in responding to this. It got buried in my inbox. You'll probably need to update oyur PYTHONPATH as well: PYTHONPATH=/path/to/sitedir/conf Where conf/ contains settings_local.py. Something to note, though. We are not using OpenSSH, and our backend isn't set

Deleting a diff from a published review?

2015-07-06 Thread Dunnigan, Terrence J
Hi all, One of my developers created a peer review last week, and then uploaded a diff and published an update to that review today. So the review has two diffs - 1 and 2. The developer realized that he forgot to push his changes before generating the diff, and as a result there is no