How to patch javascript changes on production envrionment?
Hi, I would like to patch my rvb server (version 2.0.15) with the changes in the below review request: https://reviews.reviewboard.org/r/7186/ So my patch steps are: wget http://reviews.reviewboard.org/r/7186/diff/raw/ -O /tmp/r7186.patch cd /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.15-py2.7.egg/ sudo patch -p1 /tmp/r7186.patch After restarting apache, I found the target javscript files didn't change under SITE_ROOT directory. To list the files under SITE_ROOT/htdocs/static/rb/js, I always got the old modification time, e.g.: -rw-rw-r-- 1 root staff 173950 *May 18 10:53 *reviews.min.f40f098c0f34.js Any idea how to force uglifyjs or django pipeline to regenerate the compressed js files? Thanks a lot! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
How to path javascript changes on production envrionment?
Hi, I would like to patch our reviewboard server with the diff of below review request which includes 2 javascript changes https://reviews.reviewboard.org/r/7186/ So my patch steps are: wget http://reviews.reviewboard.org/r/7186/diff/raw/ -O /tmp/r7186.patch cd /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.15-py2.7.egg/ sudo patch -p1 /tmp/r7186.patch After restart apache, I don't see the target javascript files under SITE_ROOT changed, To list the files under SITE_ROOT/htdocs/static/rb/js, I always got the old modification date: -rw-rw-r-- 1 root staff 173950 *May 18 10:53* reviews.min.f40f098c0f34.js Any idea to trigger uglifyjs or django pipeline to regenerate the compressed static files? Thanks already. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
when i svn delete the file AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png, then post-review failed, what's wrong ?
1: post-review AdminLTE 2: Failed to execute command: ['svn', 'info', 'AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png'] [svn: E205000: Try 'svn help info' for more information\n, svn: E205000: Syntax error parsing peg revision '2x.png'\n] what's wrong with the charater @ ? some one can tell me? the png file is https://github.com/fronteed/icheck/blob/1.x/skins/square/aero%402x.png and the reviewboard is so slow to diff many files. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Upgrade to 2.0.15 just worked, and users liked it
Are you suggesting that I copy both the database and also the site directory? Are you suggesting that I skip the `rb-site install` step completely? Thanks for the tips. On Sunday, July 5, 2015 at 10:39:38 PM UTC-7, Christian Hammond wrote: Hi John, If setting things up to import an existing database, you'd want to copy over the site directory and do `rb-site upgrade` rather than an install. The reason being that `rb-site install` will generate new keys for authentication and for the install key for the version of Review Board (needed for some extensions), and it's important to use the ones associated with the database. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Sat, Jul 4, 2015 at 8:57 PM, John Schmitt marma...@gmail.com javascript: wrote: Do I understand correctly that you do the database import *before *you run `rb-site install`? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Upgrade to 2.0.15 just worked, and users liked it
Can you please explain your thinking about setuptools? I have an
up-to-date centos 7 installation.
On Sunday, July 5, 2015 at 10:36:45 PM UTC-7, Christian Hammond wrote:
Hi,
What version of Python are you using?
Can you try upgrading setuptools? It might just be too old now.
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Wed, Jun 24, 2015 at 2:17 AM, Noopur Sankhere noopur.s...@gmail.com
javascript: wrote:
Hi Eric,
I am trying to installI ReviewBoard1.7.13(same is on my production
server) on test server first. I have installed python, apache +mod_wsgi,
patch, memchached, python setuptools up til now. And stuck at easy_install
ReviewBoard==1.7.13 command. This command is not working.
It s giving me following logs:
Searching for ReviewBoard==1.7.13
Reading http://pypi.python.org/simple/ReviewBoard/
Download error: unknown url type: https -- Some packages may not be found!
Couldn't find index page for 'ReviewBoard' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading http://pypi.python.org/simple/
Download error: unknown url type: https -- Some packages may not be found!
No local packages or download links found for ReviewBoard==1.7.13
Best match: None
Traceback (most recent call last):
File /usr/bin/easy_install, line 8, in module
load_entry_point('setuptools==0.6c11', 'console_scripts',
'easy_install')()
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1712, in main
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1700, in with_ei_usage
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1716, in lambda
File /usr/lib64/python2.7/distutils/core.py, line 152, in setup
dist.run_commands()
File /usr/lib64/python2.7/distutils/dist.py, line 953, in run_commands
self.run_command(cmd)
File /usr/lib64/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 211, in run
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 434, in easy_install
File build/bdist.linux-i686/egg/setuptools/package_index.py, line
475, in fetch_distribution
AttributeError: 'NoneType' object has no attribute 'clone'
my http/https proxy are set properly still I am facing this issue.
Please help.
On Tuesday, 23 June 2015 23:21:28 UTC+5:30, er...@tibco.com wrote:
I'm not at liberty to share the Ansible scripts that I run, sorry about
that.
The actual installation of ReviewBoard was pretty easy:
# Install ReviewBoard itself
- name: Install ReviewBoard
easy_install: name=ReviewBoard==2.0.15
sudo: yes
register: reviewboard_install
That's the simple part! (Note the use of the reviewboard_install
registered variable - later in my Ansible task list, I make a complete
backup of the database if this is true, so that in the case of a real
upgrade, the data is automatically backed up.)
In general, I've found success with Ansible by going one step at a time.
In my case, I created a clone of my production server by way of building
out an Ansible script executing against a VM. Then I could restore my VM
state and re-run my Ansible playbook as many times as I wanted, tweaking it
as needed.
What this script looks like will vary based on your target OS, how you
configure Apache, and many other details. In my case, I tried to use as
many of the packages from the system package manager, and only use the ones
installed by easy_install when the OS-provided package was insufficient.
To make it easy to test against production data, I put this in my
Ansible script:
- name: Copy database backup file to machine
copy: src={{ rb_database_backup }} dest=/root/toimport.sql
sudo: yes
when: rb_database_backup is defined
- name: Import existing machine data
shell: mysql -u root -p{{ mysql_root_password }} /root/toimport.sql
when: rb_database_backup is defined
sudo: yes
So if I invoke the Ansible script with
--extra-vars=rb_database_backup=/path/to/export/of/production/data, then
I end up with a complete working copy of the production system, with all of
its data (from when I did the backup).
The other trick, which works nicely with ReviewBoard is the installation
upgrade part. Ansible is built running idempotent operations, and the
structure of ReviewBoard management tasks is such that they (mostly) just
work in that context. Which means you can get away with something like this
(I've edited this to remove information specific to my company, so this
script won't work as-is).
- name: Create databases
mysql_db: name=rbdatabase
sudo: yes
- name: Grant privileges
mysql_user: name=rbuser append_privs=yes priv=rbdatabase.*:ALL
sudo: yes
- name:
CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)
Is there a work-around for this? # rb-site upgrade /var/www/reviews.domain.com Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Upgrading Review Board from 1.5.5 to 2.0.17 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for hostingsvcs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for site. Adding baseline version for new models Evolutions in attachments baseline: file_attachment_orig_filename, file_attachment_file_max_length_512, file_attachment_repo_info, file_attachment_repo_path_no_index, file_attachment_repo_revision_max_length_64 Evolutions in site baseline: localsite_public Evolutions in hostingsvcs baseline: account_hosting_url, account_hosting_url_max_length_255, account_unique_together_baseline Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic. PlasticTool) in database CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists) -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Sentry / Raven + Reviewboard
Anyone using Reviewboard and Sentry / Raven Client? http://www.getsentry.com https://github.com/getsentry/sentry In our case, we wire Sentry into most internal systems so we can monitor and capture failures. I'm looking at using Reviewboard 2.5 Beta internally and wanted to capture both exceptions and Critical/Error/Warn events with our internal server. I've followed the Django client setup guide as per: http://raven.readthedocs.org/en/latest/integrations/django.html Not sure if this will work out of box, or if I should make these changes deeper within Reviewboard. So anyone done this before? If I know where to hook this in code base wise, happy to add optional logic to let users pass in a DSN and have reviewboard sentry integration 'turn on'. I am also wondering about the reviewboard command line end user tools also longer term. Anyone interested? Anyone done this before? Sentry is amazing. If you've never heard of it before, take a close look. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Upgrade to 2.0.15 just worked, and users liked it
The 0.6c* series of setuptools are considered heavily legacy at this point.
A lot of has happened in the world of Python packaging over the past year
or so, including new standards around package versioning, lookup, naming,
etc. So it's possible something is messed up there.
That said, I would still expect that version to find the packages, having
looked into it further. I'm wondering if perhaps a proxy server is getting
in the way. Worth trying to install with:
export http_proxy=proxy server
export https_proxy=proxy server
easy_install args
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Mon, Jul 6, 2015 at 2:06 PM, John Schmitt marmalo...@gmail.com wrote:
Can you please explain your thinking about setuptools? I have an
up-to-date centos 7 installation.
On Sunday, July 5, 2015 at 10:36:45 PM UTC-7, Christian Hammond wrote:
Hi,
What version of Python are you using?
Can you try upgrading setuptools? It might just be too old now.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Wed, Jun 24, 2015 at 2:17 AM, Noopur Sankhere noopur.s...@gmail.com
wrote:
Hi Eric,
I am trying to installI ReviewBoard1.7.13(same is on my production
server) on test server first. I have installed python, apache +mod_wsgi,
patch, memchached, python setuptools up til now. And stuck at easy_install
ReviewBoard==1.7.13 command. This command is not working.
It s giving me following logs:
Searching for ReviewBoard==1.7.13
Reading http://pypi.python.org/simple/ReviewBoard/
Download error: unknown url type: https -- Some packages may not be
found!
Couldn't find index page for 'ReviewBoard' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading http://pypi.python.org/simple/
Download error: unknown url type: https -- Some packages may not be
found!
No local packages or download links found for ReviewBoard==1.7.13
Best match: None
Traceback (most recent call last):
File /usr/bin/easy_install, line 8, in module
load_entry_point('setuptools==0.6c11', 'console_scripts',
'easy_install')()
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1712, in main
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1700, in with_ei_usage
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 1716, in lambda
File /usr/lib64/python2.7/distutils/core.py, line 152, in setup
dist.run_commands()
File /usr/lib64/python2.7/distutils/dist.py, line 953, in
run_commands
self.run_command(cmd)
File /usr/lib64/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 211, in run
File build/bdist.linux-i686/egg/setuptools/command/easy_install.py,
line 434, in easy_install
File build/bdist.linux-i686/egg/setuptools/package_index.py, line
475, in fetch_distribution
AttributeError: 'NoneType' object has no attribute 'clone'
my http/https proxy are set properly still I am facing this issue.
Please help.
On Tuesday, 23 June 2015 23:21:28 UTC+5:30, er...@tibco.com wrote:
I'm not at liberty to share the Ansible scripts that I run, sorry about
that.
The actual installation of ReviewBoard was pretty easy:
# Install ReviewBoard itself
- name: Install ReviewBoard
easy_install: name=ReviewBoard==2.0.15
sudo: yes
register: reviewboard_install
That's the simple part! (Note the use of the reviewboard_install
registered variable - later in my Ansible task list, I make a complete
backup of the database if this is true, so that in the case of a real
upgrade, the data is automatically backed up.)
In general, I've found success with Ansible by going one step at a
time. In my case, I created a clone of my production server by way of
building out an Ansible script executing against a VM. Then I could restore
my VM state and re-run my Ansible playbook as many times as I wanted,
tweaking it as needed.
What this script looks like will vary based on your target OS, how you
configure Apache, and many other details. In my case, I tried to use as
many of the packages from the system package manager, and only use the ones
installed by easy_install when the OS-provided package was insufficient.
To make it easy to test against production data, I put this in my
Ansible script:
- name: Copy database backup file to machine
copy: src={{ rb_database_backup }} dest=/root/toimport.sql
sudo: yes
when: rb_database_backup is defined
- name: Import existing machine data
shell: mysql -u root -p{{ mysql_root_password }} /root/toimport.sql
when: rb_database_backup is defined
sudo: yes
So if I invoke the Ansible script with
Re: Upgrade to 2.0.15 just worked, and users liked it
Yeah, you'll want the same site directory, because of the configuration and data files. Otherwise, you'll generate a new site with keys that don't match some of the state in the database. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Mon, Jul 6, 2015 at 2:08 PM, John Schmitt marmalo...@gmail.com wrote: Are you suggesting that I copy both the database and also the site directory? Are you suggesting that I skip the `rb-site install` step completely? Thanks for the tips. On Sunday, July 5, 2015 at 10:39:38 PM UTC-7, Christian Hammond wrote: Hi John, If setting things up to import an existing database, you'd want to copy over the site directory and do `rb-site upgrade` rather than an install. The reason being that `rb-site install` will generate new keys for authentication and for the install key for the version of Review Board (needed for some extensions), and it's important to use the ones associated with the database. Christian -- Christian Hammond - chi...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Sat, Jul 4, 2015 at 8:57 PM, John Schmitt marma...@gmail.com wrote: Do I understand correctly that you do the database import *before *you run `rb-site install`? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)
My script drops the entire database then does a clean install. Then I import my old mysql database and run `rb-site upgrade`. I'd really like to be able to finish this upgrade. My struggle with it has been a couple of weeks now - I keep hoping that I'm doing something wrong and that posting my script would alert someone brighter than me that I could do something better and finish this. Thanks for taking an interest. On Mon, Jul 6, 2015 at 11:08 AM, Christian Hammond christ...@beanbaginc.com wrote: This looks like another symptom of a very confused database. Are you starting from scratch every time you do an import + upgrade? It's not enough to drop individual tables. The entire database must be recreated. Christian On Monday, July 6, 2015, John Schmitt marmalo...@gmail.com wrote: Is there a work-around for this? # rb-site upgrade /var/www/reviews.domain.com Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Upgrading Review Board from 1.5.5 to 2.0.17 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for hostingsvcs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for site. Adding baseline version for new models Evolutions in attachments baseline: file_attachment_orig_filename, file_attachment_file_max_length_512, file_attachment_repo_info, file_attachment_repo_path_no_index, file_attachment_repo_revision_max_length_64 Evolutions in site baseline: localsite_public Evolutions in hostingsvcs baseline: account_hosting_url, account_hosting_url_max_length_255, account_unique_together_baseline Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic. PlasticTool) in database CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists) -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/21RErXZnLpo/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CRITICAL:root:Error running database evolver function change_column_attr_unique:
Thanks for looking at this, Christian.
When dumping my old database, I have the option of adding 'DROP TABLE'
commands. I've been doing that since I get different error messages
without it. Should I find a better way to dump and import?
I'm working on reproducing so that I can answer your question.
On Sunday, July 5, 2015 at 10:51:12 PM UTC-7, Christian Hammond wrote:
Hi John,
It looks like what's happening is that the database upgrade process is
expecting your old database to have a unique index/constraint for a field
(marking a particular column as being unique across entries in the table),
which it doesn't have for some reason.
What I'd suggest is:
1) Restoring the database backup and getting a list of all indexes on the
database.
2) Running:
rb-site manage /path/to/site evolve -- --sql
... and dumping that to a file.
3) Find what indexes/constraints are being removed/changed that aren't
present in the original database. If this isn't clear, go ahead and post
both sets of data here.
4) Add any indexes that are missing.
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Sat, Jul 4, 2015 at 8:53 PM, John Schmitt marma...@gmail.com
javascript: wrote:
# rpm -q ReviewBoard python-djblets python-django-evolution
ReviewBoard-2.0.17-1.el7.noarch
python-djblets-0.8.20-1.el7.noarch
python-django-evolution-0.7.5-1.el7.noarch
On Sat, Jul 4, 2015 at 12:53 PM, Christian Hammond chri...@beanbaginc.com
javascript: wrote:
Hi John,
What versions of Review Board and Django Evolution are you using?
Christian
On Saturday, July 4, 2015, John Schmitt marma...@gmail.com javascript:
wrote:
Something seems to go wrong during my upgrade. What do I need to do to
make this work?
This is my script that ought to upgrade my installation from 1.55 to 2.0
#!/bin/bash
export PS4='+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}():
}'
set -x
set -e
set -u
systemctl stop httpd
# perform a fresh installation of ReviewBoard
rm -rf /var/www/reviews.domain.com
mysql --password=password -e 'drop database if exists reviewboard;'
mysql --password=password -e 'create database reviewboard;'
rb-site install /var/www/reviews.domain.com --noinput
\
--opt-out-support-data
\
--domain-name='
reviews.domain.com' \
--site-root='/'
\
--static-url='static/'
\
--media-url='media/'
\
--db-type='mysql'
\
--db-name='reviewboard'
\
--db-user='root'
\
--db-pass='password'
\
--db-host='localhost'
\
--cache-type='memcached'
\
--cache-info='localhost:11211'
\
--web-server-type='apache'
\
--web-server-port='80'
\
--python-loader='wsgi'
\
--admin-user='admin'
\
--admin-password='password'
\
--admin-email='
jschm...@domain.com'
chown -R apache.apache /var/www/reviews.domain.com/data
chown -R apache.apache /var/www/reviews.domain.com/htdocs/media/ext
chown -R apache.apache /var/www/reviews.domain.com/htdocs/media/uploaded
chown -R apache.apache /var/www/reviews.domain.com/htdocs/static/ext
mkdir /var/www/reviews.domain.com/search-index
chown -R apache.apache /var/www/reviews.domain.com/search-index
# import the reviewboard data from the old reviewobard installation
# general.log grows too big so I delete it but I have to restart mariadb
so it'll create a fresh one
rm -rf /var/log/mariadb/general.log
mysql --password=password /root/reviewboard.dump
rm -rf /var/log/mariadb/general.log
systemctl restart mariadb
# the old installation was stored at /data/...
# the new installation is stored at /var/www/reviews.domain.com/...
# the new installation directory has to be manually set in the
siteconfig_siteconfiguration table
# the siteconfig_siteconfiguration is a giant json string
#mysql --password=password --batch --skip-column-names -e 'use
reviewboard; select settings from
Re: when i svn delete the file AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png, then post-review failed, what's wrong ?
Review Board's speed when showing diffs is usually the result of the response times of the repository. What version of Review Board are you using there? Also, post-review is now ancient and was replaced a long time ago. It's failing because @ is special in SVN paths. This has since been fixed, I believe, in newer versions of RBTools containing 'rbt post'. Christian On Monday, July 6, 2015, Joost Shao joostshao1...@gmail.com wrote: 1: post-review AdminLTE 2: Failed to execute command: ['svn', 'info', 'AdminLTE/2.1.1/plugins/iCheck/flat/a...@2x.png'] [svn: E205000: Try 'svn help info' for more information\n, svn: E205000: Syntax error parsing peg revision '2x.png'\n] what's wrong with the charater @ ? some one can tell me? the png file is https://github.com/fronteed/icheck/blob/1.x/skins/square/aero%402x.png and the reviewboard is so slow to diff many files. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com'); . For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Deleting a diff from a published review?
Hey Terry, Not without removing it in the database, I'm afraid. That would then effect some other behavior, though, and break the change record. Best to just leave it in, maybe have the developer post a review stating that the diffs are the same and to ignore that version. Christian On Monday, July 6, 2015, Dunnigan, Terrence J terrence.j.dunni...@boeing.com wrote: Hi all, One of my developers created a peer review last week, and then uploaded a diff and published an update to that review today. So the review has two diffs – 1 and 2. The developer realized that he forgot to push his changes before generating the diff, and as a result there is no difference between diff 1 and 2. Is it possible to “delete” diff #2? To completely remove it, as if it didn’t exist? Thanks, Terry -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com'); . For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)
This looks like another symptom of a very confused database. Are you starting from scratch every time you do an import + upgrade? It's not enough to drop individual tables. The entire database must be recreated. Christian On Monday, July 6, 2015, John Schmitt marmalo...@gmail.com wrote: Is there a work-around for this? # rb-site upgrade /var/www/reviews.domain.com Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Upgrading Review Board from 1.5.5 to 2.0.17 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for hostingsvcs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for site. Adding baseline version for new models Evolutions in attachments baseline: file_attachment_orig_filename, file_attachment_file_max_length_512, file_attachment_repo_info, file_attachment_repo_path_no_index, file_attachment_repo_revision_max_length_64 Evolutions in site baseline: localsite_public Evolutions in hostingsvcs baseline: account_hosting_url, account_hosting_url_max_length_255, account_unique_together_baseline Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic. PlasticTool) in database CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists) -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com'); . For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Update to RBTools 0.7.4, scripts to interface with reviewboard now error.
Hello,
I have been using Review Board version 1.7.16 with great success. I had
been using Centos 7 with RBTools 0.7.2 (package RBTools-0.7.2-1.el7.noarch).
I recently updated the Centos 7 install and RBTool was updated to version
0.7.4 (package RBTools-0.7.4-1.el7.noarch).
I use a canned script which posts reviews to a remote server running
reviewboard 1.7.16.
The error that I am getting is:
ERROR: Unexpected API Error: You are not logged in (HTTP 401, API Error 103)
The problem with this message is that I know that I am logged in.
This is the script that I run on 0.7.2 which has worked flawlessly.
Unfortunately I can't share it all but this is the snippet that runs the
rbt stuff.
#
# Use RBTools if available
if (system(qq(rbt --version 2/dev/null)) == 0)
{
# Posting Options:
my $rbt_options = qq( --publish) unless ( $draft );
# Review Board Server Options:
$rbt_options .= qq( --server https://{URL Removed, sorry});
$rbt_options .= qq( --username $username);
$rbt_options .= qq( --password $password);
# Repository Options:
$rbt_options .= qq( --repository $repository);
# Review Request Field Options:
$rbt_options .= qq( --summary $title);
$rbt_options .= qq( --description $description) unless (-f
$description);
$rbt_options .= qq( --description-file $description) if (-f
$description);
$rbt_options .= qq( --testing-done $testing) unless (-f $testing);
$rbt_options .= qq( --testing-done-file $testing) if (-f
$testing);
$rbt_options .= qq( --branch $branch);
$rbt_options .= qq( --target-groups $reviewer_groups);
$rbt_options .= qq( --target-people $reviewers);
# Diff Generation Options:
$rbt_options .= qq( --diff-filename $diffFile);
# Create a new review request
my $output = qx(rbt post $rbt_options);
my $result = ($? 8);
if ($result == 0)
{
(my $url) = $output =~ /(.*\/diff\/)/;
print \nYou can watch your review at .$url.\n\n;
system(rm -f $diffFile $stdErr);
}
exit $result;
}
If I run the rbt command manually with debug on I see the same issue so I
know that the script isn't the problem.
~/ws/myproject/code /usr/bin/rbt post --debug --server
https://review.my.server.com; --username jstobern --password removed
--repository removed --summary Test cmdline --branch HEAD
--diff-filename review.diff
RBTools 0.7.4
Python 2.7.5 (default, Jun 24 2015, 00:41:19)
[GCC 4.8.3 20140911 (Red Hat 4.8.3-9)]
Running on
Linux-3.10.0-229.7.2.el7.x86_64-x86_64-with-centos-7.1.1503-Core
Home = /home/jstobern
Current directory = /home/jstobern/ws/myproject/code
Running: git version
Checking for a Subversion repository...
Running: svn --non-interactive info
Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: '/home/jstobern/ws/myproject/code' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
---
Checking for a Mercurial repository...
Unable to execute hg --help: skipping Mercurial
Checking for a CVS repository...
repository info: Path: cvspc.my.server.com:/swdev/cvsrep, Base path:
None, Supports changesets: False
Making HTTP GET request to https://review.my.server.com/api/
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
File /usr/lib/python2.7/site-packages/rbtools/commands/main.py, line
133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /usr/lib/python2.7/site-packages/rbtools/commands/__init__.py,
line 612, in run_from_argv
exit_code = self.main(*args) or 0
File /usr/lib/python2.7/site-packages/rbtools/commands/post.py, line
643, in main
api_client, api_root = self.get_api(server_url)
File /usr/lib/python2.7/site-packages/rbtools/commands/__init__.py,
line 768, in get_api
raise CommandError('Unexpected API Error: %s' % e)
rbtools.commands.CommandError: Unexpected API Error: You are not logged in
(HTTP 401, API Error 103)
~/ws/myproject/code
I noticed that if I REMOVE the --username option. The rbt command (and
hence the script) works correctly. I'm assuming that is because it falls
back to using the data in the .rbtools-cookies. This is not how I intended
this script to work because the username and password are derived by my
script that then passed to rbt via --username and --password.
Is it possible to get the functionality to the way it worked in 0.7.2?
Passwords change often in our environment so the
Re: Update to RBTools 0.7.4, scripts to interface with reviewboard now error.
I am wondering if the updates to Bug 3858 https://code.google.com/p/reviewboard/issues/detail?id=3858 might have created this change in behaviour. Regards. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Hook capabilities: Extending Reviewboard
Hey Chris, This sounds like something that would be a good addition, but doesn't exist yet. Just to make sure I fully understand, you want this outside of the review request box, below it, but above the diff viewer boxes. I'm all for adding a few more TemplateHooks like this. Perhaps after-review-request-box and before-diff-viewer? (The former would be on any page with a review request box, the latter being before the collection of diff viewer boxes specifically?) Are you in a position to put together a patch for this for Review Board? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Chris Lang crlan...@gmail.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: July 6, 2015 at 3:08:28 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Subject: Hook capabilities: Extending Reviewboard Hey there, I have been developing an extension for ReviewBoard and have a prototype for the extension running on my local version of ReviewBoard. It is an extension for reviewing diffs on a review request. I have successfully gotten it to appear at the bottom of the page when you click on a review request, and then click on View Diff. I was able to do so using the TemplateHook and setting it to base-after-content. This is great so far however, I would like this to appear after the summary/description/testing done box but before any of the side-by-side diff comparisons. The base-before-content option also does not achieve the desired results as my extension comes before the summary box. From reading about the different hooks I have not be able to find a way to achieve this. If there is currently a way to set this up, that would be great. If there is not, I would just like to express interest in having such an option available for everyone. Thank you for your time. Sincerely, Chris Lang -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial
Comment #1 on issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 Similar to closed Issue 3894 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial
Comment #2 on issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 Workaround is to just be in the root of the repository when running rbt post -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Migrate database(mysql) to another server
Hi, I need to move rb database to a separate server. Is it just as simple as dump the database to the new server and change setting_local.py? Do I need to shut/restart anything? Thanks, Shan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3910 in reviewboard: rbt post fails when parent has empty files and currently in subdirectory using mercurial
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent has empty files and currently in subdirectory using mercurial https://code.google.com/p/reviewboard/issues/detail?id=3910 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? RBTools 0.7.3 What's the URL of the page containing the problem? http://reviews.internal What steps will reproduce the problem? 1. Create a mercurial repository with three committed files, fileA, fileB, and fileC. fileA and fileB must have some content, fileC must be empty. 2. Remove fileA. Edit contents of fileB. 3. Create a sub directory and go into it 4. rbt post What is the expected output? What do you see instead? I expected the posted review to only contain fileA and fileB. The posted review contains fileC as well. What operating system are you using? What browser? Mac OS X, Mercurial 3.4.1 Please provide any additional information below. The problem is RBT tries to locate newly added empty files by running two commands: base_files = hg locate -r base tip_empty_files = hg locate -r tip set:size(0) newly_added_empty_files = tip_empty_files - base_files hg locate -r base returns the following: folder1/subfolder1/fileA.txt folder2/subfolder2/fileB.txt folder1/subfolder3/fileC.txt where as hg locate -r tip set:size(0) returns: ../folder1/subfolder3/fileC.txt Note that the first command uses a path relative to the root of the repository, the second uses a path relative to the current directory. When calculating the set difference fileC.txt doesn't match and rbt posts it as a newly added file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Migrate database(mysql) to another server
It's pretty much that simple. You'll need to restart your web server after changing the settings file. -David On Mon, Jul 6, 2015 at 5:26 PM Shan Shan shan33s...@gmail.com wrote: Hi, I need to move rb database to a separate server. Is it just as simple as dump the database to the new server and change setting_local.py? Do I need to shut/restart anything? Thanks, Shan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Migrate database(mysql) to another server
Hi Shan, If there's nothing more complex (like a version/database upgrade), then you should be set with that. Make sure the new database grants the necessary permissions for Review Board's assigned user in settings_local.py. You probably need to reload Apache to get all the threads seeing the new database location. I would schedule downtime, so that people don't end up writing to the old database while migrating, and lose content in the process. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Mon, Jul 6, 2015 at 5:16 PM, Shan Shan shan33s...@gmail.com wrote: Hi, I need to move rb database to a separate server. Is it just as simple as dump the database to the new server and change setting_local.py? Do I need to shut/restart anything? Thanks, Shan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)
On Monday, July 6, 2015 at 2:41:34 PM UTC-7, Christian Hammond wrote: Hi John, Yeah, I know this must be frustrating. I don't know why it's being so difficult, as we routinely have people upgrade from 1.0.x and 1.5.x to 2.0.x without problems. If you're able to get me that list of SQL statements (from the `rb-site manage /path/to/site evolve -- --sql`) on a clean database import, it might help shed some light on this. What do you mean by a clean database import? I have a clone of our running 1.5.5 installation. Do you want the results of that command before I dump it? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Update to RBTools 0.7.4, scripts to interface with reviewboard now error.
Hi Jens, It's possible that something regressed here. Would you mind filing a new bug that we can use to track this? I'll see what we can do to get a fix in for the upcoming 0.7.5 release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Mon, Jul 6, 2015 at 11:26 AM, Jens Stobernack jstob...@gmail.com wrote: I am wondering if the updates to Bug 3858 https://code.google.com/p/reviewboard/issues/detail?id=3858 might have created this change in behaviour. Regards. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists)
Hi John, Yeah, I know this must be frustrating. I don't know why it's being so difficult, as we routinely have people upgrade from 1.0.x and 1.5.x to 2.0.x without problems. If you're able to get me that list of SQL statements (from the `rb-site manage /path/to/site evolve -- --sql`) on a clean database import, it might help shed some light on this. Can you also provide the result of: `rb-site manage /path/to/site list-evolutions` Basically, what seems to be happening is that this intermediary table (managed by Django for some data we work with) is being created, and then an evolution is trying to create it again, which shouldn't be happening (and I'm not sure why it would). Having the data above would help in figuring out why this may be happening. Just to provide this option, we offer support contracts for Review Board that, amongst other things, includes database repair/massaging. We take the dumps of the database and give you a dump back that works with the target release. We've done this for other companies at this point quite successfully. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Mon, Jul 6, 2015 at 11:13 AM, John Schmitt marmalo...@gmail.com wrote: My script drops the entire database then does a clean install. Then I import my old mysql database and run `rb-site upgrade`. I'd really like to be able to finish this upgrade. My struggle with it has been a couple of weeks now - I keep hoping that I'm doing something wrong and that posting my script would alert someone brighter than me that I could do something better and finish this. Thanks for taking an interest. On Mon, Jul 6, 2015 at 11:08 AM, Christian Hammond christ...@beanbaginc.com wrote: This looks like another symptom of a very confused database. Are you starting from scratch every time you do an import + upgrade? It's not enough to drop individual tables. The entire database must be recreated. Christian On Monday, July 6, 2015, John Schmitt marmalo...@gmail.com wrote: Is there a work-around for this? # rb-site upgrade /var/www/reviews.domain.com Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Upgrading Review Board from 1.5.5 to 2.0.17 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for hostingsvcs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for site. Adding baseline version for new models Evolutions in attachments baseline: file_attachment_orig_filename, file_attachment_file_max_length_512, file_attachment_repo_info, file_attachment_repo_path_no_index, file_attachment_repo_revision_max_length_64 Evolutions in site baseline: localsite_public Evolutions in hostingsvcs baseline: account_hosting_url, account_hosting_url_max_length_255, account_unique_together_baseline Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic. PlasticTool) in database CommandError: Error applying evolution: (1050, Table 'reviews_review_file_attachment_comments' already exists) -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/21RErXZnLpo/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options,
Hook capabilities: Extending Reviewboard
Hey there, I have been developing an extension for ReviewBoard and have a prototype for the extension running on my local version of ReviewBoard. It is an extension for reviewing diffs on a review request. I have successfully gotten it to appear at the bottom of the page when you click on a review request, and then click on View Diff. I was able to do so using the TemplateHook and setting it to base-after-content. This is great so far however, I would like this to appear after the summary/description/testing done box but before any of the side-by-side diff comparisons. The base-before-content option also does not achieve the desired results as my extension comes before the summary box. From reading about the different hooks I have not be able to find a way to achieve this. If there is currently a way to set this up, that would be great. If there is not, I would just like to express interest in having such an option available for everyone. Thank you for your time. Sincerely, Chris Lang -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3911 in reviewboard: It suddenly comes to Data directory changes
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3911 by china.li...@gmail.com: It suddenly comes to Data directory changes https://code.google.com/p/reviewboard/issues/detail?id=3911 What version are you running? ReviewBoard-1.7.27-py2.6.egg-info What's the URL of the page containing the problem? http://rb.91laiqian.cn What steps will reproduce the problem? 1.visit http://rb.91laiqian.cn 2.it comes to Data directory changes 3.before that, we have used reviewboard for 2 months and made no changes to environment or rb's code What is the expected output? What do you see instead? it should come to the main page. What operating system are you using? What browser? Server: centos 6.5 client: chrome 40.0.2214.115 Please provide any additional information below. Attachments: review board failed.jpg 129 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
It suddenly comes to Data directory changes
I have used ReviewBoard for 2 months. It ran well till last friday(2015.07.03). It suddenly shows Data directory changes and ask me to check the the data folder in htdocs and the configuration file as below: If using fastcgi or wsgi, you want to check the reviewboard.fcgi or reviewboard.wsgi file in your site's htdocs directory and add the following if missing: os.environ['HOME'] = '/var/www/rb.91laiqian.cn/data' I didn't change any code in reviewboard. The only difference is I install ReviewBoard based on nginx+fastcgi following the link: How to install ReviewBoard under Nginx? http://stackoverflow.com/questions/22411723/how-to-install-reviewboard-under-nginx Please help me~~ https://lh3.googleusercontent.com/-HfEVN-k25Uo/VZs4cZNErsI/Kto/BdCEsbRg5Pk/s1600/review%2Bboard%2Bfailed.jpg below is more information if you need. What version are you running? ReviewBoard-1.7.27-py2.6.egg-info What's the URL of the page containing the problem? http://rb.91laiqian.cn What steps will reproduce the problem? 1.visit http://rb.91laiqian.cn 2.it comes to Data directory changes 3.before that, we have used reviewboard for 2 months and made no changes to environment or rb's code What is the expected output? What do you see instead? it should come to the main page. What operating system are you using? What browser? Server: centos 6.5 client: chrome 40.0.2214.115 -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to path javascript changes on production envrionment?
Nice. It works after I rebuild the reviewboard egg package. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Github Enterprise with Okta login - Cannot login with token
Hi Albert, We discussed this separately, but for anybody else who comes across this, GitHub Enterprise's API does not support services like Okta for authenticating with the API for retrieving an API token. It requires a username and password, according to their documentation and that error message (which is coming from GitHub Enterprise). Given that, you will need a standard user on GitHub Enterprise that you can use for authentication. That user's credentials will *not* be stored. Only the resulting token will be. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Wed, Jul 1, 2015 at 8:58 AM, Albert Franzi albert.fra...@schibsted.com wrote: Hi all, We are trying to use reviewboard with power pack to link our github enterprise account. The problem resides in that we use okta as 'middleware' authentication so reviewboard cannot link. I try to generate a valid token from my github account but reviewboard does not accept. Reviewboard return follow error : Unable to link the account: This API can only be accessed with username and password Basic Auth Any idea? Thanks, -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issues setting up subversion repo (svn+ssh) on Review Board
Hi Carel,
Sorry for the delay in responding to this. It got buried in my inbox.
You'll probably need to update oyur PYTHONPATH as well:
PYTHONPATH=/path/to/sitedir/conf
Where conf/ contains settings_local.py.
Something to note, though. We are not using OpenSSH, and our backend isn't
set to deal with .ssh/config files. I don't believe setting a username in
that file is going to do anything in our case. You'll need to specify the
username as part of the repository setup.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Mon, Jun 29, 2015 at 8:06 AM, Carel Combrink carel.combr...@gmail.com
wrote:
This is a follow up on my previous issue (How to create an initial code
review (post-commit)
https://groups.google.com/forum/#!topic/reviewboard/aaXILxtH6dw), but I
think the subject needed updating:
My Review Board server set up::
Review Board: 2.0.18 (upgraded from 2.0.17)
OS: Ubuntu 14.04
Authorisation method: LDAP
My Subversion server is using svn+ssh
My Client computer:
OS: Ubuntu 14.04
I have added the Repository on the dashboard but can't get the keyless
authentication to work correctly.
My Review Board server should connect to the subversion server using my
username for now (during evaluation I do not want to create the user on the
server)
- I have created a config file under /var/www/reviewboard/data/.ssh
that contains my username to use for the server.
- I have generated keys on the RB server and added the id_rsa.pub (in
data/.ssh/) key to authorized_keys on the svn server.
- I have added the Repository on the RB admin page
- My path is set to: svn+ssh://server ip/MyRepoName
- If I do not supply a username for the repository I get an unable to
authenticate error if I save.
- If I add my username then save it does not give any errors and the
repository is added.
To test the SSH setup, I do the following steps on the RB server:
$ sudo -s
$ sudo -u www-data -s
$ cd /tmp
$ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh
svn.server.ip
I get the following error:
www-data@ubuntu14:~$ DEBUG_RBSSH=1
DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh svn.server.ip
Traceback (most recent call last):
File /usr/local/bin/rbssh, line 9, in module
load_entry_point('ReviewBoard==2.0.18', 'console_scripts', 'rbssh')()
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line 558,
in load_entry_point
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
2682, in load_entry_point
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
2355, in load
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
2361, in resolve
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/cmdline/rbssh.py,
line 46, in module
import paramiko
File build/bdist.linux-x86_64/egg/paramiko/__init__.py, line 30, in
module
File build/bdist.linux-x86_64/egg/paramiko/transport.py, line 49, in
module
File build/bdist.linux-x86_64/egg/paramiko/dsskey.py, line 26, in
module
File build/bdist.linux-x86_64/egg/Crypto/PublicKey/DSA.py, line 89, in
module
File build/bdist.linux-x86_64/egg/Crypto/Random/__init__.py, line 29,
in module
File build/bdist.linux-x86_64/egg/Crypto/Random/_UserFriendlyRNG.py,
line 38, in module
File
build/bdist.linux-x86_64/egg/Crypto/Random/Fortuna/FortunaAccumulator.py,
line 39, in module
File
build/bdist.linux-x86_64/egg/Crypto/Random/Fortuna/FortunaGenerator.py,
line 35, in module
File build/bdist.linux-x86_64/egg/Crypto/Util/Counter.py, line 59, in
module
File build/bdist.linux-x86_64/egg/Crypto/Util/_counter.py, line 7, in
module
File build/bdist.linux-x86_64/egg/Crypto/Util/_counter.py, line 4, in
__bootstrap__
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
1161, in resource_filename
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
1861, in get_resource_filename
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
1921, in _extract_resource
File build/bdist.linux-x86_64/egg/pkg_resources/__init__.py, line
1207, in extraction_error
pkg_resources.ExtractionError: Can't extract file(s) to egg cache
The following error occurred while trying to extract file(s) to the Python
egg
cache:
[Errno 13] Permission denied:
'/home/my-username/.python-eggs/pycrypto-2.6.1-py2.7-linux-x86_64.egg-tmp/Crypto/Util/tmp2R_tL2.$extract'
The Python egg cache directory is currently set to:
/home/my-username/.python-eggs
Perhaps your account does not have write access to this directory? You can
change the cache directory by setting the PYTHON_EGG_CACHE environment
variable to point to an accessible directory.
Trying to set the PYTHON_EGG_CACHE I get:
/tmp$ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings
Deleting a diff from a published review?
Hi all, One of my developers created a peer review last week, and then uploaded a diff and published an update to that review today. So the review has two diffs - 1 and 2. The developer realized that he forgot to push his changes before generating the diff, and as a result there is no difference between diff 1 and 2. Is it possible to delete diff #2? To completely remove it, as if it didn't exist? Thanks, Terry -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
