Re: Diff currently unavailable

With custom-generated git diffs, the biggest problem people run into is the revision range not quite being correct. For instance, in this case: o [master] | | | o [my-branch] [HEAD] |/ ... If you're on HEAD and you generate a diff from master..HEAD, you can end up with a diff that

Issue 3942 in reviewboard: Rendering Markup fails depending on machine local

Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3942 by msu...@aurea.com: Rendering Markup fails depending on machine local https://code.google.com/p/reviewboard/issues/detail?id=3942 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or

Issue 3943 in reviewboard: Email failing to send

Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3943 by msu...@aurea.com: Email failing to send https://code.google.com/p/reviewboard/issues/detail?id=3943 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be ***

RE: RHEL6 - httpd using 1.3GB+ for Review Board?

We started seeing the memory issues via diffs failing to load in the last couple of days. We last saw this several months ago and we upped the resources on the VM at that time. No new repositories or configuration changes lately. There’s a few larger PDFs (1-2 megabytes.. not huge by any

RE: Diff currently unavailable

Yes we are on my-branch when we generate our own diff. It sounds like that’s what ‘rbt post’ would do as well. There’s a number of these reviewboard.xyz folders in the temp directory, suggesting the problem is somewhat common. From my-branch, our diff command is simply: git diff --full-index

RE: Diff currently unavailable

Yes, this is with git. We have a script that generates the diff file using git and then uses rbtools to post the diff. It runs on Windows with git 1.8.3. The .rej file is 21 lines. Every line (but the last) ends with a LF character. It’s mostly showing deleted lines (starting with a -), with

RHEL6 - httpd using 1.3GB+ for Review Board?

My Review Board server (RHEL6, Review Board 1.7.27) is running out of memory. Is it normal for a httpd process on RHEL6 to use 1739m of virtual /1.3g in resident memory? What might cause a runaway httpd process? Thanks, Terry -- Supercharge your Review Board with Power Pack:

Re: Recommended Approach To Add Review Diff Comments Through API

The API is expecting you to pass in the row number which is you is the number indicating which row of a side by side diff the comment is on. This row number might not match the file line number if your diff contains adds / deletes on either side. The Review Bot project has some MIT licensed code

Re: Absolute links in reply mails

Hey Chris, We are actually having this issue again in reviewboard 2.0.18, except with file uploads. The src attribute of the image contains a relative link, the same as it is when you visit the actual review request (but the other attributes are different), eg: img class=modified-image

Recommended Approach To Add Review Diff Comments Through API

Hi All, I have some automated machinery that creates diff comments based on the line numbers in the new diff. This creates an issue on the correct line number the majority of the time. However, there are cases when the line number passed through the API does not strictly map to the correct

Re: Absolute links in reply mails

Hi Zach, Can you file a bug report with a repro case to help us track this? It otherwise will just get lost in the mailing list. Thanks :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Wed, Aug

Diff currently unavailable

Every now and then we encounter an error where the diff is not available. For example, today one of my coworkers created a review request with 22 changed files. 21 of them display properly in ReviewBoard 1.7.27 but one does not. The error is: Exception: The patch to 'file.cpp' didn't apply

Re: RHEL6 - httpd using 1.3GB+ for Review Board?

Hi Terry, That sounds like a lot. Is this just one out of many httpd processes doing this? Are you using prefork or worker in Apache? Often times, this kind of thing happens when Review Board is set to use local memory caches and not memcached, but that should result in all the processes

Re: Diff currently unavailable

Hi Terry, Is this with Git, or something else? How is the diff being generated? What's in the .rej file? Any chance there's some whitespace inconsistencies, form feed characters, etc.? Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag,

Re: RHEL6 - httpd using 1.3GB+ for Review Board?

Hey Terry, Prefork is required for Review Board 1.7.x, but prefork works well in the later 2.0.x releases. We're using prefork ourselves. I wouldn't expect this to be a Power Pack issue. It very well could be some obscure bug in Review Board 1.7.x. How long has this been going on? Any