Re: Missing an LDAP Bind DN?

2014-02-23 Thread Tamer Afify
Wow, who named those labels MUST be different from who coded the authentication, or he is super dum. I have been days trying to figure out what is wrong with my ldap login. I'm sure you did too in this 8days. I should have re-engineered the code to figure how to use a reviewboard feature. That

Re: Missing an LDAP Bind DN?

2014-02-24 Thread Tamer Afify
Thanks Christian Stephen for fixing this. It really made me hit my head for a while. My corporate un-organized ldap directory shows that my reviewboard users are scattered under different OUs. How can I configure authentication to allow all my users to login? i.e. one user is

Use Mail Server Groups in Review Request Groups

2014-02-24 Thread Tamer Afify
Hi, If I configure my review email server to be my corporate exchange (SMTP) server, would I be able to add exchange DL (distribution lists) in my review request groups? Or I have to recreate the mail groups in Reviewboard as review groups? Thanks for your attention, -- Get the Review

Re: Missing an LDAP Bind DN?

2014-02-26 Thread Tamer Afify
Not sure why network administrators do such a variation of ou users, but it seems to be quite common. I'll appreciate if that feature would be available. Thanks, On Tuesday, February 25, 2014 6:51:24 AM UTC-6, Stephen Gallagher wrote: On 02/24/2014 08:51 PM, Tamer Afify wrote: Thanks

What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
Hi All, [root@reviewboard ~]# rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig auth_ad_domain_name CommandError: Command doesn't accept any arguments [root@reviewboard ~]# rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig CommandError: --key must be

Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
I figured it out: rb-site manage /var/www/html/reviewboard.searshc.com/ set-siteconfig -- --key=auth_ad_find_dc_from_dns --value=0 rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig -- --key=auth_ad_domain_name but rb-site manage /var/www/html/reviewboard.searshc.com/

Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
oh and of course in 2.0 Beta 3 if set that flag, I wasn't able to log in even with admin account. On Wednesday, March 5, 2014 2:58:47 AM UTC-6, Tamer Afify wrote: I figured it out: rb-site manage /var/www/html/reviewboard.searshc.com/ set-siteconfig -- --key=auth_ad_find_dc_from_dns

Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
I was getting error error: cannot convert argument to integer emailed to me. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at

Can reviewboard integrate with multiple domains or LDAP URLs?

2014-03-11 Thread Tamer Afify
How can I allow login and review process for users from different domains? I would appreciate any workaround or Dev walk through to get this if it isn't yet in feature list. Note I have 1.7.9 I have 2.4 as well. Thanks for your support, -- Get the Review Board Power Pack at

Re: Can reviewboard integrate with multiple domains or LDAP URLs?

2014-03-17 Thread Tamer Afify
Thanks David for your response, I'm not sure what doe sub-domain mean? I use LDAP browser to view the domain users and I see majority of users are in the OU=Users but few are in another OU=Bla Users, DC=some, DC=domain, DC=com. Both have the same DC name but different OUs. So how would such

'Client' object has no attribute 'config_dir'

2014-03-20 Thread Tamer Afify
After upgrading to RC1 and do a rbt post I get this error; DEBUG:root:Error data: {u'fields': {u'path': [u'Client' object has no attribute 'config_dir']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Traceback (most recent call last): File

Re: 'Client' object has no attribute 'config_dir'

2014-03-21 Thread Tamer Afify
I have two RB servers, both setup identical except one is 1.7.22 and the other is RC1. RB Server setup: Repository Type: Subversion Path: https://some.svn.server.com/svn/repo Username: AD username with access to repo Password: AD user password Bug Tracker URL:

Usability bug in 1.7.22: Review comments recipients

2014-03-21 Thread Tamer Afify
When a reviewer publish his review, the review is set To the reviewers and CC the review requester. It should be the opposite as the comments are intended for the person doing code change not the reviewers. Not sure if that feature is incorporated in RC1 2.0 or not, as I'm currently blocked

Re: Usability bug in 1.7.22: Review comments recipients

2014-03-21 Thread Tamer Afify
Great thanks for the quick reply. I added extra enhancement to the tracked bug. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/

Re: 'Client' object has no attribute 'config_dir'

2014-03-24 Thread Tamer Afify
Is this a problem because of my setup? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you

Re: 'Client' object has no attribute 'config_dir'

2014-03-24 Thread Tamer Afify
I have two RB servers, both setup identical except one is 1.7.22 and the other is RC1. RB Server setup: Repository Type: Subversion Path: https://some.svn.server.com/svn/repo Username: AD username with access to repo Password: AD user password Bug Tracker URL:

Exception thrown for user AnonymousUser at https://my.reviewboard.url.com/api/info/

2014-03-24 Thread Tamer Afify
I keep getting emails with this exception randomly while users are logging in. yet I don't hear any complain from them. Did I miss something in setup? Users use ActiveDirectory credentials to login. Here is the debug log lines for it; 13383 2014-03-24 21:42:01,572 - DEBUG - - User

Request a review for post-committed one file revision

2014-04-15 Thread Tamer Afify
Hi All, Can rbt tool send a code review for one file only post-committed change revision? I was imagining something like rbt post https:\\svn.server\path\to\a\file#0001 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at

Why the SVN diff have to be for a working copy source to post a review?

2014-04-21 Thread Tamer Afify
As my team starting to do CR process, managers need to review code previously checked-in. Yet they don't want to have a local copy of all the source code to post reviews. Is there a way to post a review using an SVN URL and a revision? What would be the parameters for rbt.exe? I'm using

Integrated ReviewBoard in TortoiseSVN 1.8.X

2014-05-08 Thread Tamer Afify
Hi All, I have made few changes in TortoiseSVN 1.8.X release to allow for; 1. Send a pre-commit review request from File Explorer menu 2. Send a post-commit review request from Tortoise Show Logs dialog 3. Review Commit source in one step, that would add the review URL in the commit log message

How can I post a review for selected files only?

2014-08-06 Thread Tamer Afify
Per the documentation this should do it for Server 1.7.22, rbt 0.6 and SVN repository rbt post -I file path yet that generates a code review request (with a diff file) for all checked out files under current path (where rbt is called). Am I doing something wrong? -- Get the Review Board Power

Re: How can I post a review for selected files only?

2014-08-12 Thread Tamer Afify
:21 PM, Tamer Afify tamer...@gmail.com javascript: wrote: Per the documentation this should do it for Server 1.7.22, rbt 0.6 and SVN repository rbt post -I file path yet that generates a code review request (with a diff file) for all checked out files under current path (where rbt

Re: How to link github account on RB 2.0.11

2015-01-12 Thread Tamer Afify
Hi Christian, Do I understand from this response that there is no way for RB to support code review for GitHub Enterprise (github.companyname.com) without buying the power pack? or RB can't support a Git repo with HTTPS protocol? If it is supported can you provide help on how to add a GitHub

Re: Error Sending email

2015-02-09 Thread Tamer Afify
I'm following the code of 'get_email_address_for_user()' any help will be appreciated... -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know!

Re: Error Sending email

2015-02-09 Thread Tamer Afify
Please Ignore. I resolved the issue I created to waste my time. I realized that some user accounts (including mine) was created (logged on the RB site) before I setup the email attribute correctly for the LDAP authentication. Which caused those accounts to be stored without an email address.

Error Sending email

2015-02-09 Thread Tamer Afify
I setup RB2.0.12 to use corp SMTP server. It sends test emails successfully, but fails to send any review request notification emails. It probably has to do with resolving user email address from ldap (attribute is configured as default 'mail'). What I get in log; 59 2015-02-09 23:04:01,083 -