Re: Is Review Board mostly useful in offline code review?

2011-09-29 Thread Jeff Andros
This is how we started using reviewboard: we would use it more as meeting
notes during a conference room code review.

We progressed through that by everyone reviewing the code and leaving notes,
then meeting in the conference room to go over them, but dropped the face to
face part shortly afterwards.  Reviewboard just makes it unneccessary.

but to answer your question, it works pretty well for face to face reviews.

--Jeff

On Thu, Sep 29, 2011 at 10:49 AM, Nelson Jones huawen@gmail.com wrote:

 Is it overkill if used for  meeting type code review (face to face
 code review)? Any comments?
 Thanks

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Installing ReviewBoard in Ubuntu 10.04

2010-09-07 Thread Jeff Andros
You've tried following the steps here?
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/I
don't know that there's anything different enough in Ubuntu 10.4 that would
make these instructions not work.

--Jeff

On Tue, Sep 7, 2010 at 11:25 AM, Rajat Khandelwal rajatgupt...@gmail.comwrote:

 Hi all

 I wanted to install review board in my ubuntu 10.04 and as there are no
 good tutorials about that, I am unable to do that. Please help me in this.
 Thanks.

 --
 Rajat Khandelwal
 SD 39 Satpura Hostel
 B.Tech. Comp. Sc.  Engg. 2nd year
 IIT Delhi

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Multiple diffs in the same review request

2010-05-07 Thread Jeff Andros
How is this different from the update diff option that's currently there?

On Fri, May 7, 2010 at 5:00 PM, Andrew aschwa...@gmail.com wrote:

 Hi guys.  I've been playing with the multiple revisions support in
 ReviewBoard.

 I was wondering what people think about these two suggestions:

 1. It would be nice to be able to compose changesets.  For instance,
 if I have one changeset under review, it then gets reviewed, then I
 post a second changeset that is based on the first changeset, it would
 be neat to be able to see the diff from pre-first diff to post-second
 diff.  I understand that currently, it is possible to see the diff
 from post-first diff to post-second diff.

 2. Given that #1 is not currently a feature, I am instructing all of
 my users to update review requests with changesets that are based on
 the same initial revision.  This way, the reviewer can see what's new
 in the second revision, as well as the full second revision.  I'm
 wondering whether it would be worth optionally enforcing this as a
 feature, or warning the user if the different revisions have different
 parents.

 My question #2 may be related to my other question at

 http://groups.google.com/group/reviewboard/browse_thread/thread/aefd7a770dca771a

 Thanks.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: What does ship it and starred review request mean?

2010-01-21 Thread Jeff Andros
We use Ship it is a marker from the reviewers that they believe the code
is ready to be committed (shipping the changed code, as in to customers)
Some times the reviewer will want the original author to make the changes,
and re-post the code (if the changes are sufficiently minor, we normally
skip this step, and list changes but mark the review ship it)

The stars I don't use too much, but I believe they're like the stars in
Gmail, In this case they mark a review you may want to check back on for
some reason.

--Jeff

2010/1/21 qhlonline qhlonl...@163.com

 Hi, all.
   I am not quite catch what does the reviews label ship it and star
 mean. What does these used to do and how to use them in practice? can any
 one give me some suggestion?
   And In my understanding, I think ship it can lable a review as
 critical or urgent to other reviewers. Is that true? if not, how to label
 ureng review request or reviews ?


 Best Regards!


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Love Dont Cost a Thing clip

2010-01-18 Thread Jeff Andros
I thought these were moderated now?

On Mon, Jan 18, 2010 at 6:12 AM, Press Centre sybleheb...@gmail.com wrote:

 Love Don't Cost a Thing clip special edition with Naked Jennifer
 Lopez! Just look!
 http://duuit.com/-jenifer

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Error 500 Logging on New Review Request

2009-08-03 Thread Jeff Andros
I don't remember exactly how to set I up, but there's an additional logging 
switch in reviewboard, I don't know if it'll help, but I know christian has 
mentioned it a few times. You can check the list archive for how to set this, 
or christian normally responds about 1pm PDT.

Hth,
--Original Message--
From: David Kent
Sender: reviewboard@googlegroups.com
To: reviewboard
ReplyTo: reviewboard@googlegroups.com
Subject: Error 500 Logging on New Review Request
Sent: Aug 3, 2009 11:03 AM


I've just installed ReviewBoard and after i set up a repository
(subversion) and attempt to create a New Review Request it gives me
the Error 500 page.  I can't find *any* logging of what happened.
Does anyone have ideas for how I can at least get logging
information?  I'm totally blind as to what the problem is without some
sort of log.

-David




--Jeff
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Error 500 Logging on New Review Request

2009-08-03 Thread Jeff Andros
Hmmm, sounds like it's probably something in your web server install... We 
might be getting beyond me, but can you describe you environment? Send a copy 
of your (sanitized) config file?
--Jeff

-Original Message-
From: David Kent dgk...@gmail.com

Date: Mon, 3 Aug 2009 13:28:26 
To: reviewboard@googlegroups.com
Subject: Re: Error 500 Logging on New Review Request


Thanks Jeff, but I believe I've already done that.  To provide a bit more
context, here is where I've looked and what I've tried:
1 - Looked in error.log and access.log of Apache.  I've seen nothing in
error.log and only the following in access.log:

10.52.53.39 - - [03/Aug/2009:12:56:13 -0500] GET /r/new/ HTTP/1.1 500 526

2 - Enabled application logging in ReviewBoard using the option in the admin
section under Settings - Logging  and pointed it to log in
C:\ReviewBoard\logs.  After doing this I only see the following in the
logfile:

2009-08-03 12:01:32,937 - INFO - Logging
to C:\ReviewBoard\logs\reviewboard.log with a minimum level of DEBUG
2009-08-03 12:01:32,937 - INFO - Log file for Review Board v1.0

3.  I've tried logging with and without code profiling.  Neither seems to do
anything.

-David

On Mon, Aug 3, 2009 at 1:13 PM, Jeff Andros j...@bigredtj.com wrote:

 I don't remember exactly how to set I up, but there's an additional logging
 switch in reviewboard, I don't know if it'll help, but I know christian has
 mentioned it a few times. You can check the list archive for how to set
 this, or christian normally responds about 1pm PDT.

 Hth,
 --Original Message--
 From: David Kent
 Sender: reviewboard@googlegroups.com
 To: reviewboard
 ReplyTo: reviewboard@googlegroups.com
 Subject: Error 500 Logging on New Review Request
 Sent: Aug 3, 2009 11:03 AM


 I've just installed ReviewBoard and after i set up a repository
 (subversion) and attempt to create a New Review Request it gives me
 the Error 500 page.  I can't find *any* logging of what happened.
 Does anyone have ideas for how I can at least get logging
 information?  I'm totally blind as to what the problem is without some
 sort of log.

 -David




 --Jeff
 





--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: backup and restore SQLite DB

2009-07-16 Thread Jeff Andros
not to be a pain, but does the web user also have write access to the
directory that the SQLite file resides in? it needs to create a couple of
temp files in that directory for indices and such.

--Jeff

2009/7/16 Pravin Nadarajoo ramp...@gmail.com


 Hi there,

 I've just installed the new stable release of ReviewBoard (ver 1.0) on
 a new machine and i'm trying to move my Sqlite DB (.db) from an old
 one with ReviewBoard (rc2) to the new machine. From your site, I
 learnt that all I need to do is point ReviewBoard to the location of
 the old DB file and it should work. But i'm getting thrown with an
 Internal Server Error, even after changing the ownership of it to
 the web user.

 Is there a proper way in which i can backup my SQLite DB from the old
 ReviewBoard (old machine) and then properly restore it to my new
 machine's ReviewBoard? Please point me in the right direction.

 Thanks

 Truly
 Pravin

 



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: backup and restore SQLite DB

2009-07-16 Thread Jeff Andros
It's not just the file, the folder it resides in as well. That should be a 7 
for the user that the web server runs under
--Jeff

-Original Message-
From: Pravin Nadarajoo ramp...@gmail.com

Date: Thu, 16 Jul 2009 19:04:30 
To: reviewboardreviewboard@googlegroups.com
Subject: Re: backup and restore SQLite DB



Thanks for your reply Jeff. I left the permissions of the DB file as
644. Will just try 777 for now and see what happens. Will write here
again.

Thanks
Pravin

On Jul 17, 2:21 am, Jeff Andros j...@bigredtj.com wrote:
 not to be a pain, but does the web user also have write access to the
 directory that the SQLite file resides in? it needs to create a couple of
 temp files in that directory for indices and such.

 --Jeff

 2009/7/16 Pravin Nadarajoo ramp...@gmail.com





  Hi there,

  I've just installed the new stable release of ReviewBoard (ver 1.0) on
  a new machine and i'm trying to move my Sqlite DB (.db) from an old
  one with ReviewBoard (rc2) to the new machine. From your site, I
  learnt that all I need to do is point ReviewBoard to the location of
  the old DB file and it should work. But i'm getting thrown with an
  Internal Server Error, even after changing the ownership of it to
  the web user.

  Is there a proper way in which i can backup my SQLite DB from the old
  ReviewBoard (old machine) and then properly restore it to my new
  machine's ReviewBoard? Please point me in the right direction.

  Thanks

  Truly
  Pravin

 --
 Jeff
 O|||O



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: stuck with install/config

2009-07-01 Thread Jeff Andros
You sound pretty new to debian style apache management, so here goes.

Yeah, you'll either need to shut off the default site, or configure reviewboard 
as a vhost.  Shutting off default is probably the easiest.  You shouldn't have 
to remove it, there's a management script that will do that for you, a2dissite 
or something like that (sorry, not set up to check the actual name from my 
blackberry). There's that command's twin, a2ensite, that will turn on 
reviewboard if you drop the config file in the /etc/apache2/sites-available 
directory (again, double check that path as I'm working from memory).  

This is debian's apache management system, it's pretty sweet if you dig into 
it.  There should be documentation all over the web if you get really 
interested in learning more.
--Jeff

-Original Message-
From: grimbeaver tbrez...@gmail.com

Date: Wed, 1 Jul 2009 06:07:59 
To: reviewboardreviewboard@googlegroups.com
Subject: Re: stuck with install/config



Not sure about the apache setup on Ubuntu 8.10.  But on Ubuntu 9.10 I
had to remove the default site file /etc/apache2/sites-enabled/000-
default before the site would load.  Not sure if that will help you
but thought I would throw it out there.

On Jul 1, 7:40 am, Jim Priest thecr...@gmail.com wrote:
 I'm going back through everything this AM - the only thing I can't
 find is this reference in my reviewboard.conf

 Location /
 ...
 SetEvn DJANGO_SETTINGS_MODULE reviewboard.settings
 ...
 /Location

 I've seen that settings file mentioned on other posts - where does
 that file live??

 I guess at this point I'm going to just start over and try again from
 scratch and see what happens.

 Jim


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: What functionality does the Subversion repo connection provide in RB?

2009-07-01 Thread Jeff Andros
Reviewboard displays the files in a two column view.  It pulls the base file
from the repo, displays that on the left column, applies the diff, then
displays the results on the right column.  This way you've got the entire
file to look over as you're reviewing it, not just the parts that have
changed.

2009/7/1 Eric P eric.maill...@gmail.com


 Ok, this probably sounds like a stupid question, but I'm curious what
 functionality the connection to the repository brings to RB
 (Subversion in my example).

 When I create a diff for a review (on the command line via 'svn
 diff'), and then upload the diff, RB appears to make a check against
 the repo for some kind of validation.  But beyond that I don't see
 what the repo connection provides in terms of actual functionality;
 the diff already provides all the info necessary for the review (minus
 the base path which we manually enter anyway).

 I bet if I was a more seasoned user I wouldn't be asking this.

 Thanks for reading,
 Eric P.

 



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: rb-site install - Review Board is taking a nap

2009-06-25 Thread Jeff Andros
I've yet to do an install like that, and someone else may correct me, but
normally that message means that the apache user does not have write access
to bothr the sqlite file and the folder that contains it.

Try tracking that down and changing the permissions/owner.

--Jeff

2009/6/25 Eric P eric.maill...@gmail.com


 Hi (me again),

 I have all my dependency issues sorted, and I've installed my first
 Review Board site per the documentation.

 When I go to visit the site, I see the 'Review Board is taking a nap'
 dialog box.

 In my Apache error_log, I see some errors:

 [error] [client 127.0.0.1] mod_python (pid=3617,
 interpreter='reviewboard_reviews_mysite_com', phase='PythonHandler',
 handler='django.core.handlers.modpython'): Application error
 ...
 [error] [client 127.0.0.1] Traceback (most recent call last):
 [Thu Jun 25 09:51:56 2009] [error] [client 127.0.0.1]   File
 /usr/lib/python2.6/site-packages/mod_python/importer.py, line 1537,
 in HandlerDispatch\ndefault=default_handler, arg=req,
 silent=hlist.silent)
 ...
 [error] [client 127.0.0.1] OperationalError: attempt to write a
 readonly database


 FYI. Here are the params I used to set up the site.

 rb-site install reviews.mysite.com \
 --domain-name=reviews.mysite.com \
 --site-root=/ \
 --media-url=/media \
 --db-type=sqlite3 \
 --cache-type=memcached \
 --cache-info=memcached://localhost:11211/ \
 --web-server-type=apache \
 --python-loader=modpython


 I'm not sure what to make of those errors.   It looks like there are a
 couple issues.

 Anyway, thanks for reading.
 Eric P

 



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: ReviewBoard General Inquiries

2009-05-25 Thread Jeff Andros
I'm not really sure why this is an issue, but all uploads to reviewboard are
via diff.  If you use the post-review tool, you never have to
see/touch/smell the diff at all, you just deal with the review, and your
VCS's revision specs.

Even though you're uploading a diff, reviewboard goes out to your VCS, pulls
out the whole file, and hilights the areas which have changed.

I think that answers your question as I understand it; if you're asking
whether you can review existing files(like reviewing your whole codebase),
check the archives of this list... Christian has covered that a few times,
and it's very possible to do with post-review.


-- 
Jeff
O|||O

2009/5/25 Carlo Camerino cmcamer...@gmail.com


 Hi,

 i am evaluating several code review software for our company.
 We have this question regarding review board,

 one of the barriers of entry for our programmers to use reviewboard is that
 we are not using diffs for code reviews but rather we are using files.

 We don't want to be able to upload diffs but rather upload files for
 consumption purposes.

 Does review-board support this kind of model?

 if not,
 will it support it in the future.

 Hopefully ReviewBoard will be able to support it in the future as it
 is such a nice tool.

 Also do you support writing a review by email , or adding comments via
 email?

 Thanks

 Carlo

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Using the demo

2009-02-17 Thread Jeff Andros

diff headers for reviewboard are a bit different... the server needs
to know not only the path to the file, but also the revision it was
generated from... that's how it looks up the base code.  as I
understand it, svn diff might give you the right headers, but I'm not
sure... we use p4.

2009/2/17 Anthony Foglia afog...@princeton.com:

 This might be a stupid question.  I'd like to play around with the
 demo, and follow a patch through the review process, but I'm having
 trouble uploading a patch.  My plan was just to add a file, maybe add
 additional patches to it, etc.

 My first question: Which repository do I use for demo purposes?  Navi
 or Review Board SVN?

 Second: What should my patch contain?  I tried making a patch with a
 new file, setting the base diff path to /, but I get an Unable to
 parse diff revision header when uploading the diff.  I think this is
 because my diff was made outside any version control, and the revision
 header is a timestamp.

 Do I need to check out the demo's repository first?  If so, where is
 it?

 --
 Anthony Foglia
 Princeton Consultants
 




-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Newbie question: setup problems

2009-01-08 Thread Jeff Andros
I had this problem too... make sure your web user has permissions not only
on the sqlite file, but on the directory it resides in as well.
Jeff
O|||O


2009/1/8 Chris Clark chris.cl...@ingres.com


 Phil wrote:
  .Sqlite3 is complaining that it cannot open the database file.
  (sqlite3.OperationalError: unable to open database file)
 
  Has anyone else had this problem? My understanding is that Python 2.5
  includes sqlite  thus I wouldn't have to install it again -- is this
  incorrect? Have I missed installing something?
 

 If you are getting the sqlite error, this proves (py) sqlite is
 installed :-)

 You _probably_ have a file/path permission problem as sqlite databases
 are files. I suspect when you ran manage you did it as a different user
 than the one who runs the web server.

 Chris


 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread Jeff Andros
It just hit me too, that you can just click the expand changes link in the
diff viewer header, there's nothing stopping you from reviewing parts that
didn't change, we do it all the time... just make sure to hit that link,
otherwise the comments that are in old sections won't be displayed

--Christian or Dave--
as an enhancement, how hard would it be to set auto expand as either a
user or global setting?

Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros [EMAIL PROTECTED] wrote:

 There are two ways to do this:

 1. if you manually diff your current file against a file that doesn't exist
 (there may be a flag you need to set on your diff program), it will generate
 a diff against a new file, then you just need to adjust the diff header to
 make it right... we've got a simple script that does this for our perforce
 repo

 2. I haven't tried it, but there's a revision range argument on
 post-review.  Last I knew, this doesn't work for all SCM's, but it should
 eventually.  just supply a revision number like 0.  (this has been suggested
 before I think)

 HTH
 Jeff
 O|||O

 Help me and the Leukemia and Lymphoma society fight blood cancers:
 http://pages.teamintraining.org/dm/tucson08/jandros



 On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED]wrote:


 In the diff viewer, for new files, only one version of the file is
 show (because only 1 exists). I would like our code reviews to be more
 about reviewing a file in a given state, not simply a diff. Is there
 anyway to create your diff so that the diff viewer will only show a
 single version of the file, as specified by the diff file? This would
 avoid the side by side of the same file, which I am sure is extremely
 useful, but for how we work, is something we'd like to be able to
 bypass if we could.

 By the way, this is ideal for reviewers who are looking at the code
 for the first time, who need to review the entire file, not just the
 diff from version X to Y.
 



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread Jeff Andros
There are two ways to do this:

1. if you manually diff your current file against a file that doesn't exist
(there may be a flag you need to set on your diff program), it will generate
a diff against a new file, then you just need to adjust the diff header to
make it right... we've got a simple script that does this for our perforce
repo

2. I haven't tried it, but there's a revision range argument on
post-review.  Last I knew, this doesn't work for all SCM's, but it should
eventually.  just supply a revision number like 0.  (this has been suggested
before I think)

HTH
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED] wrote:


 In the diff viewer, for new files, only one version of the file is
 show (because only 1 exists). I would like our code reviews to be more
 about reviewing a file in a given state, not simply a diff. Is there
 anyway to create your diff so that the diff viewer will only show a
 single version of the file, as specified by the diff file? This would
 avoid the side by side of the same file, which I am sure is extremely
 useful, but for how we work, is something we'd like to be able to
 bypass if we could.

 By the way, this is ideal for reviewers who are looking at the code
 for the first time, who need to review the entire file, not just the
 diff from version X to Y.
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---