Re: Error when SVN server is unreachable.

2011-07-26 Thread Leonel Togniolli
I have py25-pysvn-svn161-1.7.0-1177

On Tue, Jul 26, 2011 at 5:05 AM, Christian Hammond chip...@chipx86.com wrote:
 Hi Leonel,

 What version of pysvn do you have installed?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Mon, Jul 25, 2011 at 11:24 AM, Leonel Togniolli tognio...@gmail.com
 wrote:

 Issue 2191 for this one.

 On Thu, Jul 21, 2011 at 12:39 PM, Leonel Togniolli tognio...@gmail.com
 wrote:
  Hi,
 
  When trying to access a diff of an existing review request, while the
  SVN server is for some reason unavailable (and the diff is not
  cached), I get the error below. It seems to me there's a bug in the
  error handling. 1.6.1 RC1
 
  global name 'ClientError' is not defined
 
  Traceback (most recent call last):
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\views.py,
  line 151, in view_diff
     interdiffset, highlighting, True)
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 1071, in get_diff_files
     large_data=True)
   File
  c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
  line 166, in cache_memoize
     data = lookup_callable()
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 1070, in lambda
     enable_syntax_highlighting)),
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 551, in get_chunks
     old = get_original_file(filediff)
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 364, in get_original_file
     large_data=True)[0]
   File
  c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
  line 166, in cache_memoize
     data = lookup_callable()
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 363, in lambda
     data = cache_memoize(key, lambda: [fetch_file(file, revision)],
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
  line 342, in fetch_file
     data = tool.get_file(file, revision)
   File
  c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\scmtools\svn.py,
  line 135, in get_file
     except ClientError, e:
  NameError: global name 'ClientError' is not defined
 

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Added Files not being added to reviews

2011-07-25 Thread Leonel Togniolli
Hi,

After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files
are not included in review requests by post-review. If I call
post-review specifying the added-file filename, I get There don't
seem to be any diffs!. Is this intentional?

While I'm at it, a feature request: the ability to configure an ignore
list for post-review. Right now I have some files that get changed
locally automatically but are not commited. Right now I have to
manually revert them before calling post-review, or post-review a
specific file/folder without them.

-- 
Leonel

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Added Files not being added to reviews

2011-07-25 Thread Leonel Togniolli
Issue 2188 logged for the feature request.

Sorry, meant to include the info but forgot. It's on SVN. The file
shows as added the TortoiseSVN's check for modifications dialog.

post-review -d didn't seem to show anything interesting.

On Mon, Jul 25, 2011 at 2:21 PM, Christian Hammond chip...@chipx86.com wrote:
 Hi Leonel,

 What sort of repository are you using this with? We generally call out to
 svn diff, git diff, etc., so it's dependent on how the particular SCM works.

 Can you file the feature request on the bug tracker?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli tognio...@gmail.com
 wrote:

 Hi,

 After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files
 are not included in review requests by post-review. If I call
 post-review specifying the added-file filename, I get There don't
 seem to be any diffs!. Is this intentional?

 While I'm at it, a feature request: the ability to configure an ignore
 list for post-review. Right now I have some files that get changed
 locally automatically but are not commited. Right now I have to
 manually revert them before calling post-review, or post-review a
 specific file/folder without them.

 --
 Leonel

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Internal Server Error: /admin/feed/news/

2011-07-25 Thread Leonel Togniolli
I ended up logging Issue 2189 for the unhandled error and Issue 2190
for the feature request.

On Thu, Jul 21, 2011 at 12:41 PM, Leonel Togniolli tognio...@gmail.com wrote:
 Sure. Should I log a request for proxy support or a bug for the error I get?

 I don't care that much for getting the news loaded, but I'd prefer if
 it would handle a problem fetching them more gracefully.

 On Wed, Jul 20, 2011 at 8:25 PM, Christian Hammond chip...@chipx86.com 
 wrote:
 Hi Leonel,

 This is a known issue. While it won't make 1.6.0, I'd like to get
 proxy support in for 1.6.x. I'm not sure we have a bug filed for it,
 though. Would you mind filing one?

 Christian


 On Wednesday, July 20, 2011, Leonel Togniolli tognio...@gmail.com wrote:
 Hi !

 I'm in the process of upgrading my 1.5.1 install to 1.6 RC1. First
 thing I noticed is that when visiting the admin interface the news in
 do not load and I get the error below in the mail. There's a proxy
 server with authentication so ReviewBoard won't be able to get online
 to retrieve news anyway.

 Traceback (most recent call last):

  File 
 c:\python25\lib\site-packages\django-1.3-py2.5.egg\django\core\handlers\base.py,
 line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File 
 c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\feedview\views.py,
 line 38, in view_feed
    force_overwrite=request.GET.has_key(reload)))

  File 
 c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
 line 173, in cache_memoize
    data = lookup_callable()

  File 
 c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\feedview\views.py,
 line 23, in fetch_feed
    data = urllib2.urlopen(url).read()

  File C:\Python25\lib\urllib2.py, line 124, in urlopen
    return _opener.open(url, data)

  File C:\Python25\lib\urllib2.py, line 381, in open
    response = self._open(req, data)

  File C:\Python25\lib\urllib2.py, line 399, in _open
    '_open', req)

  File C:\Python25\lib\urllib2.py, line 360, in _call_chain
    result = func(*args)

  File C:\Python25\lib\urllib2.py, line 1107, in http_open
    return self.do_open(httplib.HTTPConnection, req)

  File C:\Python25\lib\urllib2.py, line 1080, in do_open
    r = h.getresponse()

  File C:\Python25\lib\httplib.py, line 928, in getresponse
    response.begin()

  File C:\Python25\lib\httplib.py, line 385, in begin
    version, status, reason = self._read_status()

  File C:\Python25\lib\httplib.py, line 349, in _read_status
    raise BadStatusLine(line)

 BadStatusLine


 ModPythonRequest
 path:/admin/feed/news/,
 GET:QueryDict: {},
 POST:QueryDict: {},
 COOKIES:{'JSESSIONID': 'c89210830acfce364e3bd8bb55c921c2',
  'rbsessionid': '808f6ddd7ecd1710a507fcfe05c29688',
  'screenResolution': '1366x768'},
 META:{'AUTH_TYPE': None,
  'CONTENT_LENGTH': 0,
  'CONTENT_TYPE': None,
  'GATEWAY_INTERFACE': 'CGI/1.1',
  'HTTP_ACCEPT': 'text/html, */*',
  'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
  'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
  'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8,pt-BR;q=0.6,pt;q=0.4',
  'HTTP_CONNECTION': 'keep-alive',
  'HTTP_COOKIE': 'JSESSIONID=c89210830acfce364e3bd8bb55c921c2;
 screenResolution=1366x768;
 rbsessionid=808f6ddd7ecd1710a507fcfe05c29688',
  'HTTP_HOST': 'xxxbuild',
  'HTTP_REFERER': 'http://xxxbuild/admin/',
  'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; WOW64)
 AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.122
 Safari/534.30',
  'HTTP_X_FCCKV2': 'g2HP6vytWCGacqhIqnHAyiobwZw4nPryglP/jQ==',
  'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
  'PATH_INFO': u'/admin/feed/news/',
  'PATH_TRANSLATED': None,
  'QUERY_STRING': None,
  'REMOTE_ADDR': '172.16.44.61',
  'REMOTE_HOST': None,
  'REMOTE_IDENT': None,
  'REMOTE_USER': None,
  'REQUEST_METHOD': 'GET',
  'SCRIPT_NAME': '',
  'SERVER_NAME': 'xxx2-xxx',
  'SERVER_PORT': 80,
  'SERVER_PROTOCOL': 'HTTP/1.1',
  'SERVER_SOFTWARE': 'mod_python'}

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

 --
 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know

Re: Error when SVN server is unreachable.

2011-07-25 Thread Leonel Togniolli
Issue 2191 for this one.

On Thu, Jul 21, 2011 at 12:39 PM, Leonel Togniolli tognio...@gmail.com wrote:
 Hi,

 When trying to access a diff of an existing review request, while the
 SVN server is for some reason unavailable (and the diff is not
 cached), I get the error below. It seems to me there's a bug in the
 error handling. 1.6.1 RC1

 global name 'ClientError' is not defined

 Traceback (most recent call last):
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\views.py,
 line 151, in view_diff
    interdiffset, highlighting, True)
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 1071, in get_diff_files
    large_data=True)
  File 
 c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
 line 166, in cache_memoize
    data = lookup_callable()
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 1070, in lambda
    enable_syntax_highlighting)),
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 551, in get_chunks
    old = get_original_file(filediff)
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 364, in get_original_file
    large_data=True)[0]
  File 
 c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
 line 166, in cache_memoize
    data = lookup_callable()
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 363, in lambda
    data = cache_memoize(key, lambda: [fetch_file(file, revision)],
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py,
 line 342, in fetch_file
    data = tool.get_file(file, revision)
  File 
 c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\scmtools\svn.py,
 line 135, in get_file
    except ClientError, e:
 NameError: global name 'ClientError' is not defined


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: post-reviews: The requested URL could not be retrieved

2011-06-24 Thread Leonel Togniolli
Hmm, let me try to start over.

There's a file called .reviewboardrc that can be created, on windows I
put it on %APPDATA% folder. It's meant for post-review settings.
There's some info about it here:

http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#reviewboardrc

It is a python file, so I created it and put the two lines below on it
to set an environment variable that will cause post-review to bypass
my proxy server, which requires authentication that i doesn't handle
well:

import os
os.environ[no_proxy] = *

It was the best way I found to automatically bypass proxy on each
user's machine.

On Wed, Jun 22, 2011 at 10:58 PM, ptrchen ptrc...@gmail.com wrote:
 How do I get parsed as a Python file? Got a link or instructions?

 Thanks!

 On Jun 22, 2:55 pm, Leonel Togniolli tognio...@gmail.com wrote:
 It's not. It's an optional file that you can create and add settings.
 It's parsed as a python file so that's why my workaround works.

 On Tue, Jun 21, 2011 at 8:36 PM, ptrchen ptrc...@gmail.com wrote:
  Looking at my %appdata% folder...

  Does .reviewboardrc get automatically installed? I don't see it in my
  %appdata% folder.

  Thanks!

  Peter

  On Jun 21, 12:42 pm, Leonel Togniolli tognio...@gmail.com wrote:
 http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r...

  On windows, I have it on each user's %appdata% folder.

  On Tue, Jun 21, 2011 at 4:20 PM, ptrchen ptrc...@gmail.com wrote:
   Hi Leonel,

   Thanks for the reply, but where may I find .reviewboardrc?

   Thanks!

   Peter

   On Jun 20, 4:42 am, Leonel Togniolli tognio...@gmail.com wrote:
   Hi ptrchen,

   I worked around this issue by adding two lines to .reviewboardrc

   import os
   os.environ[no_proxy] = *

   On Fri, Jun 17, 2011 at 7:48 PM, ptrchen ptrc...@gmail.com wrote:
Hi Christian,

I think this page suggestions that should address my issues, correct?
   http://groups.google.com/group/reviewboard/browse_thread/thread/69e33...

On Jun 10, 4:54 pm, ptrchen ptrc...@gmail.com wrote:
Sorry Chrisitan, never mind, I misread your post. I'll do some more
digging for overriding the proxy configuration

On Jun 10, 4:51 pm,ptrchenptrc...@gmail.com wrote:

 Ah, so would setting the environment variable in the command 
 prompt
 window do the trick?

 On Jun 10, 4:32 pm, Christian Hammond chip...@chipx86.com wrote:

  We've seen people run into this sort of error with proxy 
  servers. Regardless
  of your client-side proxy server configuration (say, in your 
  Internet
  settings, on Windows), it may still use the proxy server on 
  post-review.

  The error output looks very much like it came from a proxy 
  server, meaning
  that the request is going out to the proxy, and the proxy can't 
  find the
  domain. You'll need to blacklist it. I don't recall if it will 
  at all
  respect this black list with Python running on Windows. If it's 
  Linux, then
  you want to be sure your http_proxy environment variable isn't 
  set.

  This has come up a couple of times, and it's clear we need a 
  setting in
  post-review itself to just override the proxy configuration.

  If you search on this mailing list, you'll probably find a 
  couple other
  solutions.

  Christian

  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com

  On Fri, Jun 10, 2011 at 3:55 PM,ptrchenptrc...@gmail.com 
  wrote:
   Sorry for not listing all the output, but company policy 
   prohibits me
   from doing that.

   Yes, the error lists the hostname and FQDN

   Also, we do give it the FQDN following the --server option

   On Jun 10, 2:56 pm, Tucker j...@gmail.com wrote:
Does the error actually only list the hostname and not the 
fully
qualified name?  If so, that may be part of your problem 
(throwing out
guesses).  Have you tried using the fully qualified name?

On Fri, Jun 10, 2011 at 11:22 AM,ptrchenptrc...@gmail.com 
wrote:
 Hi Tucker,

 Thanks for the reply.

 I ran nslookup server_name from both server_name 
 (XP server) and
 from a sparc-solaris2.10 machine.

 Both return

 Name:   server_name.domain
 Address: ip_address

 On Jun 10, 11:15 am, Tucker j...@gmail.com wrote:
 You appear to have a DNS problem:

 Unable to determine IP address from host name for 
 server_name.

 What does nslookup server_name say?

 On Thu, Jun 9, 2011 at 7:12 
 PM,ptrchenptrc...@gmail.com wrote:
  Hi,

  We've been trying to run post-review but have been 
  running into a
  requested URL could not be retrieved error

  We're running:

  ReviewBoard 1.5.5 on Windows XP

Re: post-reviews: The requested URL could not be retrieved

2011-06-22 Thread Leonel Togniolli
It's not. It's an optional file that you can create and add settings.
It's parsed as a python file so that's why my workaround works.

On Tue, Jun 21, 2011 at 8:36 PM, ptrchen ptrc...@gmail.com wrote:
 Looking at my %appdata% folder...

 Does .reviewboardrc get automatically installed? I don't see it in my
 %appdata% folder.

 Thanks!

 Peter

 On Jun 21, 12:42 pm, Leonel Togniolli tognio...@gmail.com wrote:
 http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r...

 On windows, I have it on each user's %appdata% folder.

 On Tue, Jun 21, 2011 at 4:20 PM, ptrchen ptrc...@gmail.com wrote:
  Hi Leonel,

  Thanks for the reply, but where may I find .reviewboardrc?

  Thanks!

  Peter

  On Jun 20, 4:42 am, Leonel Togniolli tognio...@gmail.com wrote:
  Hi ptrchen,

  I worked around this issue by adding two lines to .reviewboardrc

  import os
  os.environ[no_proxy] = *

  On Fri, Jun 17, 2011 at 7:48 PM, ptrchen ptrc...@gmail.com wrote:
   Hi Christian,

   I think this page suggestions that should address my issues, correct?
  http://groups.google.com/group/reviewboard/browse_thread/thread/69e33...

   On Jun 10, 4:54 pm, ptrchen ptrc...@gmail.com wrote:
   Sorry Chrisitan, never mind, I misread your post. I'll do some more
   digging for overriding the proxy configuration

   On Jun 10, 4:51 pm,ptrchenptrc...@gmail.com wrote:

Ah, so would setting the environment variable in the command prompt
window do the trick?

On Jun 10, 4:32 pm, Christian Hammond chip...@chipx86.com wrote:

 We've seen people run into this sort of error with proxy servers. 
 Regardless
 of your client-side proxy server configuration (say, in your 
 Internet
 settings, on Windows), it may still use the proxy server on 
 post-review.

 The error output looks very much like it came from a proxy server, 
 meaning
 that the request is going out to the proxy, and the proxy can't 
 find the
 domain. You'll need to blacklist it. I don't recall if it will at 
 all
 respect this black list with Python running on Windows. If it's 
 Linux, then
 you want to be sure your http_proxy environment variable isn't set.

 This has come up a couple of times, and it's clear we need a 
 setting in
 post-review itself to just override the proxy configuration.

 If you search on this mailing list, you'll probably find a couple 
 other
 solutions.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Jun 10, 2011 at 3:55 PM,ptrchenptrc...@gmail.com wrote:
  Sorry for not listing all the output, but company policy 
  prohibits me
  from doing that.

  Yes, the error lists the hostname and FQDN

  Also, we do give it the FQDN following the --server option

  On Jun 10, 2:56 pm, Tucker j...@gmail.com wrote:
   Does the error actually only list the hostname and not the 
   fully
   qualified name?  If so, that may be part of your problem 
   (throwing out
   guesses).  Have you tried using the fully qualified name?

   On Fri, Jun 10, 2011 at 11:22 AM,ptrchenptrc...@gmail.com 
   wrote:
Hi Tucker,

Thanks for the reply.

I ran nslookup server_name from both server_name (XP 
server) and
from a sparc-solaris2.10 machine.

Both return

Name:   server_name.domain
Address: ip_address

On Jun 10, 11:15 am, Tucker j...@gmail.com wrote:
You appear to have a DNS problem:

Unable to determine IP address from host name for 
server_name.

What does nslookup server_name say?

On Thu, Jun 9, 2011 at 7:12 PM,ptrchenptrc...@gmail.com 
wrote:
 Hi,

 We've been trying to run post-review but have been 
 running into a
 requested URL could not be retrieved error

 We're running:

 ReviewBoard 1.5.5 on Windows XP
 Python 2.5.x
 Apache 2.2.x

 Subversion 1.6.16, running on a sparc-solaris2.10

 Here is the output after adding the --debug option:

  --
 post-review --server=server_name/rb_site 
 --username= --
 password= --revision-range=8325 --debug
 RBTools 0.3.2
 Home = C:\Documents and Settings\\Application Data
 svn info
 diff --version
 repository info: Path: 
 svn-server/ParentPath/RepoName, Base
  pa
 th: /trunk, Supports changesets: False
 HTTP GETting api/
 Got HTTP error: 503: !DOCTYPE HTML PUBLIC 
 -//W3C//DTD HTML 4.01
  Transition
 al//EN http://www.w3.org/TR/html4/loose.dtd;
 HTMLHEADMETA HTTP-EQUIV=Content-Type

Re: post-reviews: The requested URL could not be retrieved

2011-06-21 Thread Leonel Togniolli
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#reviewboardrc

On windows, I have it on each user's %appdata% folder.

On Tue, Jun 21, 2011 at 4:20 PM, ptrchen ptrc...@gmail.com wrote:
 Hi Leonel,

 Thanks for the reply, but where may I find .reviewboardrc?

 Thanks!

 Peter

 On Jun 20, 4:42 am, Leonel Togniolli tognio...@gmail.com wrote:
 Hi ptrchen,

 I worked around this issue by adding two lines to .reviewboardrc

 import os
 os.environ[no_proxy] = *

 On Fri, Jun 17, 2011 at 7:48 PM, ptrchen ptrc...@gmail.com wrote:
  Hi Christian,

  I think this page suggestions that should address my issues, correct?
 http://groups.google.com/group/reviewboard/browse_thread/thread/69e33...

  On Jun 10, 4:54 pm, ptrchen ptrc...@gmail.com wrote:
  Sorry Chrisitan, never mind, I misread your post. I'll do some more
  digging for overriding the proxy configuration

  On Jun 10, 4:51 pm,ptrchenptrc...@gmail.com wrote:

   Ah, so would setting the environment variable in the command prompt
   window do the trick?

   On Jun 10, 4:32 pm, Christian Hammond chip...@chipx86.com wrote:

We've seen people run into this sort of error with proxy servers. 
Regardless
of your client-side proxy server configuration (say, in your Internet
settings, on Windows), it may still use the proxy server on 
post-review.

The error output looks very much like it came from a proxy server, 
meaning
that the request is going out to the proxy, and the proxy can't find 
the
domain. You'll need to blacklist it. I don't recall if it will at all
respect this black list with Python running on Windows. If it's 
Linux, then
you want to be sure your http_proxy environment variable isn't set.

This has come up a couple of times, and it's clear we need a setting 
in
post-review itself to just override the proxy configuration.

If you search on this mailing list, you'll probably find a couple 
other
solutions.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com

On Fri, Jun 10, 2011 at 3:55 PM,ptrchenptrc...@gmail.com wrote:
 Sorry for not listing all the output, but company policy prohibits 
 me
 from doing that.

 Yes, the error lists the hostname and FQDN

 Also, we do give it the FQDN following the --server option

 On Jun 10, 2:56 pm, Tucker j...@gmail.com wrote:
  Does the error actually only list the hostname and not the fully
  qualified name?  If so, that may be part of your problem 
  (throwing out
  guesses).  Have you tried using the fully qualified name?

  On Fri, Jun 10, 2011 at 11:22 AM,ptrchenptrc...@gmail.com wrote:
   Hi Tucker,

   Thanks for the reply.

   I ran nslookup server_name from both server_name (XP 
   server) and
   from a sparc-solaris2.10 machine.

   Both return

   Name:   server_name.domain
   Address: ip_address

   On Jun 10, 11:15 am, Tucker j...@gmail.com wrote:
   You appear to have a DNS problem:

   Unable to determine IP address from host name for 
   server_name.

   What does nslookup server_name say?

   On Thu, Jun 9, 2011 at 7:12 PM,ptrchenptrc...@gmail.com 
   wrote:
Hi,

We've been trying to run post-review but have been running 
into a
requested URL could not be retrieved error

We're running:

ReviewBoard 1.5.5 on Windows XP
Python 2.5.x
Apache 2.2.x

Subversion 1.6.16, running on a sparc-solaris2.10

Here is the output after adding the --debug option:

 --
post-review --server=server_name/rb_site --username= 
--
password= --revision-range=8325 --debug
RBTools 0.3.2
Home = C:\Documents and Settings\\Application Data
svn info
diff --version
repository info: Path: 
svn-server/ParentPath/RepoName, Base
 pa
th: /trunk, Supports changesets: False
HTTP GETting api/
Got HTTP error: 503: !DOCTYPE HTML PUBLIC -//W3C//DTD 
HTML 4.01
 Transition
al//EN http://www.w3.org/TR/html4/loose.dtd;
HTMLHEADMETA HTTP-EQUIV=Content-Type 
CONTENT=text/html;
charset=iso-8859
-1
TITLEERROR: The requested URL could not be 
retrieved/TITLE
STYLE 
type=text/css!--BODY{background-color:#ff;font-
family:verdana,san
s-serif}PRE{font-family:sans-serif}--/STYLE
/HEADBODY
H2The requested URL could not be retrieved/H2
HR noshade size=1px
P
While trying to retrieve the URL:
A
 HREF=server_name/rb_site/api/server_name/rb_site/api//
A
P

Re: post-reviews: The requested URL could not be retrieved

2011-06-20 Thread Leonel Togniolli
Hi ptrchen,

I worked around this issue by adding two lines to .reviewboardrc

import os
os.environ[no_proxy] = *

On Fri, Jun 17, 2011 at 7:48 PM, ptrchen ptrc...@gmail.com wrote:
 Hi Christian,

 I think this page suggestions that should address my issues, correct?
 http://groups.google.com/group/reviewboard/browse_thread/thread/69e334db357f183e/955e8ebd634d0a94?lnk=gstq=proxy+post-review#955e8ebd634d0a94



 On Jun 10, 4:54 pm, ptrchen ptrc...@gmail.com wrote:
 Sorry Chrisitan, never mind, I misread your post. I'll do some more
 digging for overriding the proxy configuration

 On Jun 10, 4:51 pm,ptrchenptrc...@gmail.com wrote:

  Ah, so would setting the environment variable in the command prompt
  window do the trick?

  On Jun 10, 4:32 pm, Christian Hammond chip...@chipx86.com wrote:

   We've seen people run into this sort of error with proxy servers. 
   Regardless
   of your client-side proxy server configuration (say, in your Internet
   settings, on Windows), it may still use the proxy server on post-review.

   The error output looks very much like it came from a proxy server, 
   meaning
   that the request is going out to the proxy, and the proxy can't find the
   domain. You'll need to blacklist it. I don't recall if it will at all
   respect this black list with Python running on Windows. If it's Linux, 
   then
   you want to be sure your http_proxy environment variable isn't set.

   This has come up a couple of times, and it's clear we need a setting in
   post-review itself to just override the proxy configuration.

   If you search on this mailing list, you'll probably find a couple other
   solutions.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.reviewboard.org
   VMware, Inc. -http://www.vmware.com

   On Fri, Jun 10, 2011 at 3:55 PM,ptrchenptrc...@gmail.com wrote:
Sorry for not listing all the output, but company policy prohibits me
from doing that.

Yes, the error lists the hostname and FQDN

Also, we do give it the FQDN following the --server option

On Jun 10, 2:56 pm, Tucker j...@gmail.com wrote:
 Does the error actually only list the hostname and not the fully
 qualified name?  If so, that may be part of your problem (throwing 
 out
 guesses).  Have you tried using the fully qualified name?

 On Fri, Jun 10, 2011 at 11:22 AM,ptrchenptrc...@gmail.com wrote:
  Hi Tucker,

  Thanks for the reply.

  I ran nslookup server_name from both server_name (XP server) 
  and
  from a sparc-solaris2.10 machine.

  Both return

  Name:   server_name.domain
  Address: ip_address

  On Jun 10, 11:15 am, Tucker j...@gmail.com wrote:
  You appear to have a DNS problem:

  Unable to determine IP address from host name for server_name.

  What does nslookup server_name say?

  On Thu, Jun 9, 2011 at 7:12 PM,ptrchenptrc...@gmail.com wrote:
   Hi,

   We've been trying to run post-review but have been running into 
   a
   requested URL could not be retrieved error

   We're running:

   ReviewBoard 1.5.5 on Windows XP
   Python 2.5.x
   Apache 2.2.x

   Subversion 1.6.16, running on a sparc-solaris2.10

   Here is the output after adding the --debug option:

--
   post-review --server=server_name/rb_site --username= --
   password= --revision-range=8325 --debug
   RBTools 0.3.2
   Home = C:\Documents and Settings\\Application Data
   svn info
   diff --version
   repository info: Path: svn-server/ParentPath/RepoName, 
   Base
pa
   th: /trunk, Supports changesets: False
   HTTP GETting api/
   Got HTTP error: 503: !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 
   4.01
Transition
   al//EN http://www.w3.org/TR/html4/loose.dtd;
   HTMLHEADMETA HTTP-EQUIV=Content-Type CONTENT=text/html;
   charset=iso-8859
   -1
   TITLEERROR: The requested URL could not be retrieved/TITLE
   STYLE type=text/css!--BODY{background-color:#ff;font-
   family:verdana,san
   s-serif}PRE{font-family:sans-serif}--/STYLE
   /HEADBODY
   H2The requested URL could not be retrieved/H2
   HR noshade size=1px
   P
   While trying to retrieve the URL:
   A
HREF=server_name/rb_site/api/server_name/rb_site/api//
   A
   P
   The following error was encountered:
   BLOCKQUOTE
   Unable to determine IP address from host name for
   Iserver_name/I
   /BLOCKQUOTE

   P
   The dnsserver returned:
   BLOCKQUOTE
   Name Error: The domain name does not exist.
   /BLOCKQUOTE

   P
   This means that:
   PRE
   The cache was not able to resolve the hostname presented in the 
   URL.
   Check if the address is correct.


Re: Feature Request for Reviewboard

2011-05-06 Thread Leonel Togniolli
In the mean time, you can just log in the mysql db and query for the
info. The schema is fairly straightforward.That's what I did when I
needed similar info recently.

On Fri, May 6, 2011 at 9:03 AM, Ashith asithraj.she...@gmail.com wrote:
 We are planning to track the review requests and the reviewers
 statistics in reviewboard. Right now the statistics is only for the
 reviews and review requests. It would be helpful if the statistics
 provided the following data,

 1. No of review requests logged by each user till date (can be broken
 down as lst 7 days, last month, all days)
 2. No of review requests each user is linked to.
 3. No of reviews done by each user.

 It would also be helpful to add a cool graphing tool to show the
 statistics in a neat little graph.

 I know I am asking for the moon, but I am so excited with the concept
 of introducing reviewboard in our organization I guess I can be
 pardoned for asking for the moon.

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

2011-04-08 Thread Leonel Togniolli
No, I haven't upgrade my server yet. It's a clean 1.5.1 install.

On Thu, Apr 7, 2011 at 5:02 PM, Chris Clark chris.cl...@ingres.com wrote:
 Leonel, I forgot to ask, are you seeing this after an upgrade?

 Chris Clark wrote:

 Leonel Togniolli wrote:

 Every week or so I get one of these below in the mail from my RB
 server. I wasn't able to determine what triggers it, unfortunately.


 Me too. See http://code.google.com/p/reviewboard/issues/detail?id=1526

 I suggest you log a comment on the issue/bug so that there is a record on
 how many people are seeing this.

 I'm now seeing this every day, I think with different users. I know one
 user has seen this a couple of times (some of the VPN users makes it tricky
 to know for sure who hits it).

 I didn't see it with: Django-1.1.1, Djblets-0.5.5, Reviewboard 1.0.5.1

 Your seeing it with: Django-1.2.3, Djblets-0.6.6, Reviewboard-1.5.1

 I'm seeing it with: Django-1.3, Djblets-0.6.7, Reviewboard-1.5.5

 Chris


 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

2011-04-07 Thread Leonel Togniolli
Every week or so I get one of these below in the mail from my RB
server. I wasn't able to determine what triggers it, unfortunately.

Traceback (most recent call last):

 File 
C:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django\core\handlers\base.py,
line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File 
C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\auth\util.py,
line 46, in _checklogin
   return view_func(request, *args, **kwargs)

 File 
C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\accounts\decorators.py,
line 46, in _check_valid_prefs
   return view_func(request, *args, **kwargs)

 File 
C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\views.py,
line 330, in dashboard
   return grid.render_to_response(template_name)

 File 
C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 700, in render_to_response
   self.load_state()

 File 
C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 535, in load_state
   self.precompute_objects()

 File 
C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 611, in precompute_objects
   pk__in=self.id_list).order_by())

 File 
C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\datagrids.py,
line 438, in post_process_queryset
   queryset.with_counts(self.request.user))

 File 
C:\Python25\lib\site-packages\djblets-0.6.6-py2.5.egg\djblets\datagrid\grids.py,
line 654, in post_process_queryset
   queryset = column.augment_queryset(queryset)

 File 
C:\Python25\lib\site-packages\reviewboard-1.5.1-py2.5.egg\reviewboard\reviews\datagrids.py,
line 83, in augment_queryset
   pk__in=self.datagrid.id_list).values_list('pk', flat=True)

AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'


ModPythonRequest
path:/dashboard/,
GET:QueryDict: {u'view': [u'outgoing']},
POST:QueryDict: {},
COOKIES:{'rbsessionid': 'c307d37908b2901bbd2e42e4b714ce9b'},
META:{'AUTH_TYPE': None,
 'CONTENT_LENGTH': 0,
 'CONTENT_TYPE': None,
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT':
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
 'HTTP_ACCEPT_LANGUAGE': 'pt-br,pt;q=0.8,en-us;q=0.5,en;q=0.3',
 'HTTP_CACHE_CONTROL': 'max-age=0',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'rbsessionid=c307d37908b2901bbd2e42e4b714ce9b',
 'HTTP_HOST': 'myserver2:8080',
 'HTTP_KEEP_ALIVE': '115',
 'HTTP_REFERER': 'http://myserver2:8080/dashboard/?view=outgoing',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR;
rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8',
 'PATH_INFO': u'/dashboard/',
 'PATH_TRANSLATED': None,
 'QUERY_STRING': 'view=outgoing',
 'REMOTE_ADDR': '172.16.44.45',
 'REMOTE_HOST': None,
 'REMOTE_IDENT': None,
 'REMOTE_USER': None,
 'REQUEST_METHOD': 'GET',
 'SCRIPT_NAME': '',
 'SERVER_NAME': 'myserver2',
 'SERVER_PORT': 8080,
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SOFTWARE': 'mod_python'}.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: TortoiseHg Review Board Dialog

2011-03-03 Thread Leonel Togniolli
Hi. Looks really nice.

I'm not familiar with the history of TortoiseHG. Is it a fork of
TortoiseSVN or does it only have the turtle in common? I'm wondering
how much effort would be to adapt this for SVN.

On Wed, Mar 2, 2011 at 8:41 PM, Michael De Wildt
michael.dewi...@gmail.com wrote:
 Gday All,
 I thought id let you know that TortoiseHg 2.0 is now bundled with a dialog
 that I wrote that allows users to post reviews to reviewboard directly from
 the TortoiseHg workbench.
 It is a GUI for the mercurial-reviewboard extension and, hopefully, it will
 be a valuable tool for people who use Mercurial and Reviewboard.
 You can read all about it in my blog
 - http://www.mikeyd.com.au/projects/tortoisehg-reviewboard/
 Any comments or suggestions will be appreciated.
 Cheers,
 Mikey

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


post-review and proxies

2010-12-30 Thread Leonel Togniolli
This week authentication was changed to be required for our proxy server and 
post-review stopped working. This seems to be caused by two factors:

1. It doesn't handle proxy authentication.
2. Proxy exceptions aren't honored so the proxy isn't skipped as it should.

I did find an older message about this topic where the poster worked around 
the issue with a script that wrapped post-review and disabled/enabled the IE 
proxy, but I didn't quite like that solution.

After reading some post-review and urllib source I found a new workaround. 
Add the lines below to .reviewboardrc (which I found to be executable to my 
surprise):

import os
os.environ[no_proxy] = *

Hope that helps someone.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Permissions and Offline Mode

2010-12-22 Thread Leonel Togniolli
Hi Christian,

 Yes. Admin UI - Settings - Authentication - Allow anonymous access
 (or something like that).

Thanks, this works. Missed it the first time around.

 This is a requirement. Review Board grabs the files from the SCM and
 patches them in order to get the complete original and new files, and
 then performs a side-by-side diff.

I see. So when you display diffs you're not showing the data the
client sent you, but applying a patch e recomparing files.

I could live without access to the extra context, but I understand the
design and will work with it.

Thanks. I'll have more questions as we work with it on the next few weeks.

-- 
Leonel

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Permissions and Offline Mode

2010-12-21 Thread Leonel Togniolli
Hi,

I recently started looking into Review Board and I'm about to give it a try 
with my team. A couple questions before I start:

It appears to be possible as an unauthenticated user to see all review 
quests and the diffs. I need to prevent that and only let logged in users to 
do so. A setting I missed somewhere?

Second, it appears client and server need a live connection to the SCM 
server. I'm using SVN in case that makes a difference. This is inadequate to 
me because we are in a different physical network than our server and reach 
it through on-demand VPN. 

It seems to me that I have all the need, in the client, to create the review 
request. SVN stores the original files, which are used to generate the diffs 
of uncommitted changes, which are uploaded to the server and displayed. This 
is for pre-commit reviews, of course. Otherwise either the client or the 
server would need to reach it and fetch the requested revisions (I'd prefer 
the client but can't be picky about that). Am I missing something?

Otherwise, ReviewBoard looks great. Installation was a little bumpy (on 
windows with apache, mysql) but I figured things out without too much 
trouble. Looking forward to use it for real.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en