Re: RB always assumes requestor closes request?

2014-11-13 Thread Stephen Bash
, Stephen Bash scb...@gmail.com wrote: Hi all- I'm curious if this is a bug or a feature: since RB 2.0 I've noticed that RB always assumes the user who created the review request closes it. I liked the pre-2.0 model where RB recorded (and sent notifications from) the actual user who selected

RB always assumes requestor closes request?

2014-11-06 Thread Stephen Bash
Hi all- I'm curious if this is a bug or a feature: since RB 2.0 I've noticed that RB always assumes the user who created the review request closes it. I liked the pre-2.0 model where RB recorded (and sent notifications from) the actual user who selected Submitted or Discarded. A little

Search review descriptions?

2014-10-22 Thread Stephen Bash
Hi all- We have a Git hook script that posts commits to Review Board when they are pushed to a special repository. The hook script always adds the commit ID (SHA) to the review's description, but with RB 2.0.7 typing the first few characters of a SHA in the search box doesn't turn up any

Re: Search review descriptions?

2014-10-22 Thread Stephen Bash
-Original Message- From: Stephen Bash scb...@gmail.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: October 22, 2014 at 8:50:37 AM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Subject: Search review descriptions? Hi all- We have a Git

Re: Review Board, Git and patch-series

2012-12-16 Thread Stephen Bash
On Monday, October 31, 2011 10:45:15 AM UTC-4, Stephen Gallagher wrote: I've been trying to work out for some time now how to accomplish patch-series in Git with Review Board. This is a very important part of my project's workflow, and the lack of this support has been preventing us from

Publish reply banner appears offscreen

2012-10-22 Thread Stephen Bash
A coworker pointed this behavior out to me and I'm curious if it's common to RB 1.6.12 installs or just ours. In a long review, if the user comments on something near the bottom of the review, the This reply is a draft banner doesn't show up at the top of the screen (playing around it looks

Git pure renames don't post correctly in RB 1.6.12

2012-10-17 Thread Stephen Bash
Hi all- After upgrading to 1.6.12 last week, I finally got around to updating my Git hook script to detect renames and send them to RB. Unfortunately it looks like pure renames don't post correctly. For example, I generated a trivial commit with a single rename:

Re: Git pure renames don't post correctly in RB 1.6.12

2012-10-17 Thread Stephen Bash
in the 1.7 betas. 1.6 won't get it, as it required some rewrites I don't feel comfortable backporting at this time. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Oct 17, 2012 at 8:20 AM, Stephen Bash