Re: How to connect comments and changes?

2009-08-12 Thread Christian Hammond
Hi Philipp, We certainly should document this better. I'd also like to expand the UI so that it will you show when you're making a comment what lines were selected, and allow you to change this while the dialog is up in such a way where it's obvious that you can do this. I'll definitely take a do

Re: How to connect comments and changes?

2009-08-12 Thread Philipp Henkel
Hi Scott, That's exactly the functionality I was looking for. Great! Now even my review request pages provide a good overview. :-) It would be helpful to underline this feature in the documentation / user guide / Commenting on Lines: Commenting on Lines To co

Re: How to connect comments and changes?

2009-08-11 Thread Scott Quesnelle
Hey Philipp, When you post a comment, instead of clicking on a single line, you can click and drag over a group of lines, and then that whole set of lines shows up for extra context. We have found its useful to have that functionality since it allows the user to tailor the amount of context neces

Re: How to connect comments and changes?

2009-08-11 Thread Philipp Henkel
Hi Christian, Thanks for pointing out that the diff viewer is not the right place for tracking changes and discussions. I understand that tracking comments across revisions is difficult. However, I was asking because some of the commercial review tools provide such functionality. If it is recomme

Re: How to connect comments and changes?

2009-08-07 Thread Christian Hammond
Hi Philipp, All the discussion on a series of changes takes place on the review request's page. You shouldn't really use the diff viewer for this. Migrating comments across revisions of a diff is incredibly hard and impossible to do successfully, consistently. You can't guarantee the lines will ma

How to connect comments and changes?

2009-08-07 Thread Philipp Henkel
Hello, I'm new to Review Board and I would like to use it in combination with Perforce and post-review. There seems to be no strong connection of comments and code changes. In Diff View comments seem to be bound to single diffs. When you add a new diff it is difficult to match old comments and n