Re: Review Comments Everywhere

2008-11-12 Thread Terry Zhong
That sounds logical, but in fact the reason Review Board cannot handle comments in inter-diffs is that in every diff view, there is only one comment column, all at left. We always see diffs in two columns: original and new, If we connect comments to one rev, we just need to display them in the pro

Re: Review Comments Everywhere

2008-11-11 Thread Christian Hammond
We'd need a really clear UI for this. People do often review interdiffs themselves, so you'd need a way to distinguish between comments in each revision and comments on the interdiffs without it being confusing. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Nov 10, 20

Re: Review Comments Everywhere

2008-11-10 Thread eyal
On Nov 11, 1:20 am, "Christian Hammond" <[EMAIL PROTECTED]> wrote: > > People wrote comments, and I updated my diff. I can understand in ver2 > > I can't see comments of ver1, but why not diff between 1-2? I want to > > read comments of ver1 on 1-2 diff so to check whether all comments are > > han

Re: Review Comments Everywhere

2008-11-10 Thread Christian Hammond
Hi Terry. Comments inline. On Mon, Nov 10, 2008 at 4:56 AM, Terry Zhong <[EMAIL PROTECTED]> wrote: > > Scene 1 > A and B wrote comments on my review, and I want to reply for each > comments, when I replied all comments on request view as draft, I > click "publish", and find only A's replys are

Review Comments Everywhere

2008-11-10 Thread Terry Zhong
Scene 1 A and B wrote comments on my review, and I want to reply for each comments, when I replied all comments on request view as draft, I click "publish", and find only A's replys are published, B's are still draft. If I reply on diff view, OK this time all comments get published, but now my com