Re: Issue 1488 in reviewboard: Storing review request number in .git/config

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: component-RBTools Comment #1 on issue 1488 by chipx86: Storing review request number in .git/config http://code.google.com/p/reviewboard/issues/detail?id=1488 I could see this as being useful. The trick will be to not leave IDs around

Re: Issue 1485 in reviewboard: Newby issues: RB 1.1 alpha 2

2010-02-21 Thread reviewboard
Updates: Status: NotABug Owner: chipx86 Labels: -Type-Defect Type-Support Comment #1 on issue 1485 by chipx86: Newby issues: RB 1.1 alpha 2 http://code.google.com/p/reviewboard/issues/detail?id=1485 This is best sent to the mailing list, but to answer your questions: 1

Re: Issue 1486 in reviewboard: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change

2010-02-21 Thread reviewboard
Updates: Labels: -Priority-Medium Priority-High Milestone-Release1.5 Component-DiffViewer Interdiffs Comment #1 on issue 1486 by chipx86: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change http://code.google.com/p/reviewboard/issues/detail

Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode

2010-02-21 Thread reviewboard
Updates: Status: Started Owner: chipx86 Labels: -Priority-Medium Priority-High Component-EMail Component-Settings Comment #12 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail

Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode

2010-02-21 Thread reviewboard
Updates: Labels: Milestone-Release1.5 Comment #13 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail?id=1476 (No comment was entered for this change.) -- You received this message because you

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-21 Thread reviewboard
Updates: Labels: Component-Accounts Component-Reviews Comment #1 on issue 1491 by chipx86: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 This is pretty specific to certain setups and is certainly not something we'd want to make default. If we do

Re: Issue 768 in reviewboard: When you upload multiple diffs before publishing a review request, discard all diffs except the last one

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 768 by chipx86: When you upload multiple diffs before publishing a review request, discard all diffs except the last one http://code.google.com/p/reviewboard/issues/detail?id=768 This hasn't been a problem for a while. It's fixed these days

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-21 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #1 on issue 1506 by chipx86: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 Your install is too old. You'll need to create

Re: Issue 1502 in reviewboard: post-review.py generated review request notification emails have wrong sender and signature

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Component-EMail Comment #1 on issue 1502 by chipx86: post-review.py generated review request notification emails have wrong sender and signature http://code.google.com/p/reviewboard/issues/detail?id=1502 Makes sense

Re: Issue 1501 in reviewboard: Download diff for changesets containing changes to only one file are missing diff headers

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Component-DiffParser Milestone-Release1.5 Comment #3 on issue 1501 by chipx86: Download diff for changesets containing changes to only one file are missing diff headers http://code.google.com/p/reviewboard/issues/detail?id=1501

Re: Issue 1501 in reviewboard: Download diff for changesets containing changes to only one file are missing diff headers

2010-02-21 Thread reviewboard
Updates: Status: WontFix Comment #4 on issue 1501 by chipx86: Download diff for changesets containing changes to only one file are missing diff headers http://code.google.com/p/reviewboard/issues/detail?id=1501 Scratch that. We only put the headers there if it's an empty file

Re: Issue 1499 in reviewboard: post-review tool can't use some forms of CVS/Root entries

2010-02-21 Thread reviewboard
Updates: Status: NeedInfo Labels: Component-RBTools Comment #2 on issue 1499 by chipx86: post-review tool can't use some forms of CVS/Root entries http://code.google.com/p/reviewboard/issues/detail?id=1499 Can you submit a patch to http://reviews.reviewboard.org/ ? -- You

Re: Issue 1497 in reviewboard: post-review tool doesn't support certain CVS formats

2010-02-21 Thread reviewboard
Updates: Status: Invalid Comment #1 on issue 1497 by chipx86: post-review tool doesn't support certain CVS formats http://code.google.com/p/reviewboard/issues/detail?id=1497 There's no info in here about what's wrong or why. Assuming this is replaced by bug 1499. Otherwise, please

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #1 on issue 1494 by chipx86: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 Upgrade

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1279 Comment #2 on issue 1494 by chipx86: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 (No comment

Re: Issue 1279 in reviewboard: post-review on windows assumes pre-vista hard coded path

2010-02-21 Thread reviewboard
Comment #6 on issue 1279 by chipx86: post-review on windows assumes pre-vista hard coded path http://code.google.com/p/reviewboard/issues/detail?id=1279 Issue 1494 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue

Re: Issue 1473 in reviewboard: Upload diff including binary file failed with postreview.py

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #1 on issue 1473 by chipx86: Upload diff including binary file failed with postreview.py http://code.google.com/p/reviewboard/issues/detail?id=1473 It sounds like your version of RBTools/post-review is quite old. Please

Re: Issue 1468 in reviewboard: rb-site install giving error make sure you are running as administrator

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Comment #2 on issue 1468 by chipx86: rb-site install giving error make sure you are running as administrator http://code.google.com/p/reviewboard/issues/detail?id=1468 The error should be changed. Basically it wants

Re: Issue 1471 in reviewboard: Groups page has a error

2010-02-21 Thread reviewboard
Comment #2 on issue 1471 by chipx86: Groups page has a error http://code.google.com/p/reviewboard/issues/detail?id=1471 Issue 1464 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue

Re: Issue 1464 in reviewboard: All Groups button crashes app if no starred entry

2010-02-21 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1471 Comment #2 on issue 1464 by chipx86: All Groups button crashes app if no starred entry http://code.google.com/p/reviewboard/issues/detail?id=1464 (No comment was entered for this change.) -- You received this message because you

Re: Issue 1460 in reviewboard: post-review fails when current branch is called tracking remote branch

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #2 on issue 1460 by chipx86: post-review fails when current branch is called tracking remote branch http://code.google.com/p/reviewboard/issues/detail?id=1460 This should be fixed in RC1. -- You received this message

Re: Issue 1458 in reviewboard: User View on site button has broken path

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Milestone-Release1.5 Component-Admin Comment #1 on issue 1458 by chipx86: User View on site button has broken path http://code.google.com/p/reviewboard/issues/detail?id=1458 (No comment was entered

Re: Issue 1450 in reviewboard: Attempt to mark closed review submitted again yields Internal error: 200 OK

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Component-Reviews Comment #1 on issue 1450 by chipx86: Attempt to mark closed review submitted again yields Internal error: 200 OK http://code.google.com/p/reviewboard/issues/detail?id=1450 (No comment was entered

Re: Issue 1455 in reviewboard: rb-site install giving error make sure you are running as administrator

2010-02-21 Thread reviewboard
Updates: Status: UserError Comment #3 on issue 1455 by chipx86: rb-site install giving error make sure you are running as administrator http://code.google.com/p/reviewboard/issues/detail?id=1455 (No comment was entered for this change.) -- You received this message because you

Re: Issue 1451 in reviewboard: Base field should be stripped before using

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 EasyFix Component-Reviews Comment #1 on issue 1451 by chipx86: Base field should be stripped before using http://code.google.com/p/reviewboard/issues/detail?id=1451 Should be an easy fix. -- You received this message

Re: Issue 1459 in reviewboard: post-review produces error /reviewboard/api/json/accounts/login/ not found

2010-02-21 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #1 on issue 1459 by chipx86: post-review produces error /reviewboard/api/json/accounts/login/ not found http://code.google.com/p/reviewboard/issues/detail?id=1459 Sounds like that's not the right path

Re: Issue 1423 in reviewboard: post-review expects an array internally and a string is returned

2010-02-21 Thread reviewboard
Updates: Status: Fixed Owner: chipx86 Comment #4 on issue 1423 by chipx86: post-review expects an array internally and a string is returned http://code.google.com/p/reviewboard/issues/detail?id=1423 Committed to master as 24b1e9d. In the future, please post patches to our

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Comment #3 on issue 1494 by gfbett: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 Thanks, I will upgrade -- You received this message because you are listed

Re: Issue 1358 in reviewboard: New review request fails

2010-02-21 Thread reviewboard
Comment #3 on issue 1358 by justin.d.teems: New review request fails http://code.google.com/p/reviewboard/issues/detail?id=1358 thanks. will do. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your

Re: Issue 1500 in reviewboard: xx lines hidden [Expand] link stopped working

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 1500 by trowbrds: xx lines hidden [Expand] link stopped working http://code.google.com/p/reviewboard/issues/detail?id=1500 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC

Re: Issue 583 in reviewboard: ReviewBoard does not verify patch when uploading

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #9 on issue 583 by chipx86: ReviewBoard does not verify patch when uploading http://code.google.com/p/reviewboard/issues/detail?id=583 This appears to be fixed these days. I don't know when, but certainly in 1.5 it's no longer a problem. -- You

Re: Issue 821 in reviewboard: Updating a diff with a diff + parent diff does not work.

2010-02-21 Thread reviewboard
Comment #8 on issue 821 by chipx86: Updating a diff with a diff + parent diff does not work. http://code.google.com/p/reviewboard/issues/detail?id=821 The error display part of this bug is fixed on master (ab7ae7d) -- You received this message because you are listed in the owner or CC

Re: Issue 1451 in reviewboard: Base field should be stripped before using

2010-02-22 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 1451 by chipx86: Base field should be stripped before using http://code.google.com/p/reviewboard/issues/detail?id=1451 Fixed on master (3ca1e5a) -- You received this message because you are listed in the owner or CC fields of this issue

Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode

2010-02-22 Thread reviewboard
Updates: Status: Fixed Comment #15 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail?id=1476 (No comment was entered for this change.) -- You received this message because you are listed

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
://reviewserver.com/api/json/accounts/login/ curl --cookie cookies.txt --cookie-jar cookies.txt -X GET http://reviewserver.com/api/json/repositories/ }}} For more information: http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI -- You received this message because you are subscribed

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
=yyy http://reviewserver.com/api/json/accounts/login/ curl --cookie cookies.txt --cookie-jar cookies.txt -X GET http://reviewserver.com/api/json/repositories/ }}} For more information: http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI -- You received this message because you

Re: Comment on ReviewBoardAPI in reviewboard

2010-02-22 Thread reviewboard
password=yyy http://reviewserver.com/api/json/accounts/login/ curl --cookie cookies.txt --cookie-jar cookies.txt -X GET http://reviewserver.com/api/json/repositories/ }}} For more information: http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI -- You received this message because you

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-22 Thread reviewboard
Comment #4 on issue 1494 by gfbett: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 RC1 fixed the application data issue, but not the external diff command

Re: Issue 1281 in reviewboard: Adding comments in diff viewer can delete or overwrite existing comments.

2010-02-22 Thread reviewboard
Comment #3 on issue 1281 by kyle.getz: Adding comments in diff viewer can delete or overwrite existing comments. http://code.google.com/p/reviewboard/issues/detail?id=1281 I don't think the line numbers need to go into the thousands for this to be triggered. On the contrary, I perceive

Issue 1509 in reviewboard: Throws an exception upon a click on review request

2010-02-22 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1509 by kcgade: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 'm seeing this error for reviewboard.twitter.com when I click on a review request

Re: Issue 1509 in reviewboard: Throws an exception upon a click on review request

2010-02-22 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 1509 by trowbrds: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 Do you have the full traceback? -- You received this message because you are listed in the owner or CC fields

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-22 Thread reviewboard
Comment #2 on issue 1491 by psarmstr: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 To me at least, it feels like not wanting this is specific to certain setups (or small shops that don't have LDAP setup properly yet). Managing everything through a single

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-22 Thread reviewboard
Comment #3 on issue 1491 by chipx86: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 You may want groups for permission purposes, or for review groups, or neither. Some places map review groups to mailman lists, and not anything in LDAP. -- You received

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-22 Thread reviewboard
Comment #2 on issue 1506 by locomocogogo: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 Thanks for your help. Let me give you the info you need first before I try anything... Yes, on our installed copy

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-22 Thread reviewboard
Comment #3 on issue 1506 by chipx86: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 That should be new enough to migrate properly. Anything prior to evolutions (which is a few years old now) would

Issue 1510 in reviewboard: Exception thrown during post-review -- 'rsp' is used before being defined

2010-02-23 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1510 by richardt: Exception thrown during post-review -- 'rsp' is used before being defined http://code.google.com/p/reviewboard/issues/detail?id=1510 What version are you running? RBTools 0.2RC1 What is the expected

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-23 Thread reviewboard
Comment #4 on issue 1506 by locomocogogo: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 Thanks. I didn't use the upgrade option with rb-site. I just fresh install the new reviewboard and hook it up

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-23 Thread reviewboard
Updates: Status: NotABug Comment #5 on issue 1506 by trowbrds: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 The auth information is now stored in the siteconfig_siteconfiguration, which

Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade

2010-02-23 Thread reviewboard
Comment #6 on issue 1506 by chipx86: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 You can modify the auth info in Settings in the admin UI. The directory created by rb-site is meant to be small. It just

Re: Issue 1508 in reviewboard: Search does not search by changelist number

2010-02-23 Thread reviewboard
Updates: Status: Confirmed Labels: -Type-Defect Type-Enhancement Component-Search Comment #1 on issue 1508 by chipx86: Search does not search by changelist number http://code.google.com/p/reviewboard/issues/detail?id=1508 (No comment was entered for this change.) -- You

Re: Issue 1510 in reviewboard: Exception thrown during post-review -- 'rsp' is used before being defined

2010-02-23 Thread reviewboard
Updates: Status: PendingReview Labels: -Priority-Medium Priority-Critical Milestone-RBTools-Release1.0 Component-RBTools Comment #1 on issue 1510 by chipx86: Exception thrown during post-review -- 'rsp' is used before being defined http://code.google.com/p/reviewboard/issues

Re: Issue 1391 in reviewboard: TortoiseAct.exe should be used as a cvs.exe replacement

2010-02-23 Thread reviewboard
Updates: Summary: TortoiseAct.exe should be used as a cvs.exe replacement Labels: Component-SCMTools Comment #1 on issue 1391 by chipx86: TortoiseAct.exe should be used as a cvs.exe replacement http://code.google.com/p/reviewboard/issues/detail?id=1391 (No comment was entered

Re: Issue 1419 in reviewboard: Error uploading diff: The file was not found in the repository (207)

2010-02-23 Thread reviewboard
Comment #6 on issue 1419 by chipx86: Error uploading diff: The file was not found in the repository (207) http://code.google.com/p/reviewboard/issues/detail?id=1419 Yeah, you must point to the base of the repository, *not* a path inside of it. We will be enforcing this behavior for 1.5

Re: Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility

2010-02-23 Thread reviewboard
Updates: Status: NeedInfo Comment #2 on issue 1381 by chipx86: diff update doesn't work in web GUI and in post-review utility http://code.google.com/p/reviewboard/issues/detail?id=1381 I know this is old.. Is it still a problem? If so, we need more information. What type

Re: Issue 885 in reviewboard: IE 6 is hanging while clicking any button save -delete- the comment window

2010-02-23 Thread reviewboard
Updates: Status: NeedInfo Comment #10 on issue 885 by chipx86: IE 6 is hanging while clicking any button save -delete- the comment window http://code.google.com/p/reviewboard/issues/detail?id=885 Is this still reproduceable? Those scripts, I believe, have since changed. -- You

Re: Issue 1164 in reviewboard: Need to set permissions on database properly

2010-02-23 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Comment #1 on issue 1164 by chipx86: Need to set permissions on database properly http://code.google.com/p/reviewboard/issues/detail?id=1164 (No comment was entered for this change.) -- You received this message because

Re: Issue 885 in reviewboard: IE 6 is hanging while clicking any button save -delete- the comment window

2010-02-23 Thread reviewboard
Comment #11 on issue 885 by lonico: IE 6 is hanging while clicking any button save -delete- the comment window http://code.google.com/p/reviewboard/issues/detail?id=885 I just tried using http://demo.review-board.org/r/2643/diff/ and I still see the issue with IE. Looks like an infinite

Re: Issue 885 in reviewboard: IE 6 is hanging while clicking any button save -delete- the comment window

2010-02-23 Thread reviewboard
Comment #12 on issue 885 by lonico: IE 6 is hanging while clicking any button save -delete- the comment window http://code.google.com/p/reviewboard/issues/detail?id=885 I think the issue is around: var bgSrc = currentStyle.backgroundImage || style.backgroundImage; if ((bgSrc + this.src

Re: Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility

2010-02-23 Thread reviewboard
Comment #3 on issue 1381 by murr...@murrayc.com: diff update doesn't work in web GUI and in post-review utility http://code.google.com/p/reviewboard/issues/detail?id=1381 I haven't seen this problem recently. This was on Ubuntu Karmic. -- You received this message because you are listed

Re: Issue 643 in reviewboard: Getting Unable to find RCS line error while using svn

2010-02-24 Thread reviewboard
Comment #2 on issue 643 by arunbalaji1985: Getting Unable to find RCS line error while using svn http://code.google.com/p/reviewboard/issues/detail?id=643 Hello, I am facing this issue while trying to use reviewboard with svn. You'll need to fix the repository's configuration to use SVN

Re: Issue 643 in reviewboard: Getting Unable to find RCS line error while using svn

2010-02-24 Thread reviewboard
Comment #3 on issue 643 by arunbalaji1985: Getting Unable to find RCS line error while using svn http://code.google.com/p/reviewboard/issues/detail?id=643 Please read In the admin page I have set the repository type to be CVS only. as In the admin page I have set the repository type

Re: Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters

2010-02-24 Thread reviewboard
Comment #2 on issue 1359 by fiddur: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 There is error-handling to be set for unicode and encode-functions. See http://www.amk.ca/python/howto/unicode I had this problem in post-review

Issue 1511 in reviewboard: Diff is not visible, but downloadable

2010-02-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1511 by AaronJSherman: Diff is not visible, but downloadable http://code.google.com/p/reviewboard/issues/detail?id=1511 What version are you running? 1.0.5.1 What's the URL of the page containing the problem? Not public

Re: Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility

2010-02-24 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 1381 by trowbrds: diff update doesn't work in web GUI and in post-review utility http://code.google.com/p/reviewboard/issues/detail?id=1381 Going to assume fixed, then. -- You received this message because you are listed in the owner or CC

Re: Issue 1427 in reviewboard: Problems with post-review while uploading diffs

2010-02-24 Thread reviewboard
Comment #4 on issue 1427 by trowbrds: Problems with post-review while uploading diffs http://code.google.com/p/reviewboard/issues/detail?id=1427 The error really looks like it's trying to use the bzr SCMTool. It's possible that it's maybe confused indexing the tool into the database

Issue 1512 in reviewboard: after upgrade to 1.5 beta1 expand in the diff body has no effect

2010-02-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1512 by Dmitry.Litvintsev: after upgrade to 1.5 beta1 expand in the diff body has no effect http://code.google.com/p/reviewboard/issues/detail?id=1512 after upgrade to 1.5 beta1 expand in the diff body has no effect If I

Re: Issue 1512 in reviewboard: after upgrade to 1.5 beta1 expand in the diff body has no effect

2010-02-24 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1500 Comment #1 on issue 1512 by chipx86: after upgrade to 1.5 beta1 expand in the diff body has no effect http://code.google.com/p/reviewboard/issues/detail?id=1512 (No comment was entered for this change.) -- You received this message

Re: Issue 1500 in reviewboard: xx lines hidden [Expand] link stopped working

2010-02-24 Thread reviewboard
Comment #5 on issue 1500 by chipx86: xx lines hidden [Expand] link stopped working http://code.google.com/p/reviewboard/issues/detail?id=1500 Issue 1512 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because

Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty

2010-02-24 Thread reviewboard
viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 Okay, I've investigated this a little and it can basically be reproduced with a diff such as: --- filename.foo (...) +++ filename.foo (...) @@ ... @@ Some text Some text - Foo + Foo Blah blah - /Foo + /Foo

Issue 1513 in reviewboard: Update diff : Error: Saving the form failed due to a server error: 0 n/a

2010-02-25 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1513 by sylvain.desodt: Update diff : Error: Saving the form failed due to a server error: 0 n/a http://code.google.com/p/reviewboard/issues/detail?id=1513 *NOTE: Do not post confidential information in this bug report

Issue 1514 in reviewboard: post-review.py doesn't allow parameters for http username/password

2010-02-25 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1514 by stodge: post-review.py doesn't allow parameters for http username/password http://code.google.com/p/reviewboard/issues/detail?id=1514 *NOTE: If you have a patch, please submit it to http://reviews.review

Re: Issue 1514 in reviewboard: post-review.py doesn't allow parameters for http username/password

2010-02-25 Thread reviewboard
Comment #1 on issue 1514 by stodge: post-review.py doesn't allow parameters for http username/password http://code.google.com/p/reviewboard/issues/detail?id=1514 Sorry - attached the wrong patch. Here's the correct one. Attachments: post-review.patch 1.1 KB -- You received

Re: Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters

2010-02-25 Thread reviewboard
Comment #3 on issue 1359 by fiddur: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 Actually, that wasn't such a good idea after all; the diff was accepted but could not be applied :P Adding this to sitecustomize.py was better

Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-25 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 *NOTE: Do not post confidential information in this bug report.* What version

Re: Issue 1516 in reviewboard: post-review clearcase setup

2010-02-25 Thread reviewboard
Comment #1 on issue 1516 by locomocogogo: post-review clearcase setup http://code.google.com/p/reviewboard/issues/detail?id=1516 Ok, I can install RBTools with -Z option. So, should I edit the python code in the egg directory to set up clearcase and reviewboard server configuration? -- You

Re: Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters

2010-02-25 Thread reviewboard
Comment #4 on issue 1359 by lonico: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 I have a similar issue, but with post-review: Traceback (most recent call last): File /u/laurentn/p4/code-review-feb22/rbtools/postreview.py

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-25 Thread reviewboard
Comment #1 on issue 1515 by chipx86: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Can you post the patch at http://reviews.reviewboard.org/ ? We don't review patches on the bug tracker. -- You received

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-26 Thread reviewboard
Comment #2 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 I tried already but the site crashed with an exception that the patch was empty. I guess I need to diff against the git

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-26 Thread reviewboard
Comment #3 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Environment: Request Method: POST Request URL: http://reviews.reviewboard.org/r/new/ Django Version: 1.1.1 Python Version

Issue 1518 in reviewboard: new json api - get list of review requests created between date range

2010-02-26 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1518 by stodge: new json api - get list of review requests created between date range http://code.google.com/p/reviewboard/issues/detail?id=1518 *NOTE: If you have a patch, please submit it to http://reviews.review

Re: Issue 1518 in reviewboard: new json api - get list of review requests created between date range

2010-02-26 Thread reviewboard
Updates: Status: Confirmed Labels: Component-API Milestone-Release1.5 Comment #1 on issue 1518 by chipx86: new json api - get list of review requests created between date range http://code.google.com/p/reviewboard/issues/detail?id=1518 I really want date ranges on all

Re: Issue 1517 in reviewboard: Review Board needs a better error response when using short SHA1s with git diffs

2010-02-26 Thread reviewboard
with git diffs http://code.google.com/p/reviewboard/issues/detail?id=1517 This is due to git diff using short SHA1s by default. You need to either pass --full-index to git diff or, preferably, use post-review. Repurposing the bug. We really should make it clear what the problem actually

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-26 Thread reviewboard
Updates: Status: NeedInfo Comment #4 on issue 1515 by chipx86: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Are you using post-review? -- You received this message because you are listed in the owner

Re: Issue 1513 in reviewboard: Update diff : Error: Saving the form failed due to a server error: 0 n/a

2010-02-26 Thread reviewboard
Updates: Labels: Browser Comment #1 on issue 1513 by chipx86: Update diff : Error: Saving the form failed due to a server error: 0 n/a http://code.google.com/p/reviewboard/issues/detail?id=1513 Most likely this is a bug with this version of Opera and Review Board. -- You received

Re: Issue 1516 in reviewboard: ClearCase configuration in post-review should move to .reviewboardrc

2010-02-26 Thread reviewboard
to .reviewboardrc http://code.google.com/p/reviewboard/issues/detail?id=1516 Right now, yeah, that's what you need to do. By 0.2 final, I'd like this to move to .reviewboardrc. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-02-26 Thread reviewboard
Comment #5 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Not for the crash in comment 3. I think you explained this my other bug report. I'll try to get back to this next week

Re: Issue 1510 in reviewboard: Exception thrown during post-review -- 'rsp' is used before being defined

2010-02-26 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 1510 by chipx86: Exception thrown during post-review -- 'rsp' is used before being defined http://code.google.com/p/reviewboard/issues/detail?id=1510 This has been committed. The nightlies should have the fix. -- You received this message

Re: Issue 1519 in reviewboard: Ignore emails for a review

2010-02-26 Thread reviewboard
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Milestone-Release1.5 Component-EMail Comment #1 on issue 1519 by chipx86: Ignore emails for a review http://code.google.com/p/reviewboard/issues/detail?id=1519 Seems reasonable. I don't know that this is going

Issue 1520 in reviewboard: User Permission UI block is too small , user permissions are not readable since they are hide behind the selection box

2010-02-26 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1520 by asitjaiswal: User Permission UI block is too small , user permissions are not readable since they are hide behind the selection box http://code.google.com/p/reviewboard/issues/detail?id=1520 *NOTE: Do not post

Re: Issue 1089 in reviewboard: git differ doesn't support moves and renames

2010-02-27 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1235 Comment #1 on issue 1089 by trowbrds: git differ doesn't support moves and renames http://code.google.com/p/reviewboard/issues/detail?id=1089 Issue 1235 says it better. -- You received this message because you are listed

Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.

2010-02-27 Thread reviewboard
Comment #1 on issue 1235 by trowbrds: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Issue 1089 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue

Re: Issue 1375 in reviewboard: ClearCase scm does not support main\0 and main\1 diff

2010-02-27 Thread reviewboard
Updates: Summary: ClearCase scm does not support main\0 and main\1 diff Comment #2 on issue 1375 by trowbrds: ClearCase scm does not support main\0 and main\1 diff http://code.google.com/p/reviewboard/issues/detail?id=1375 (No comment was entered for this change.) -- You received

Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff

2010-03-01 Thread reviewboard
Comment #6 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Created review request http://reviews.reviewboard.org/r/1440/. -- You received this message because you are listed in the owner

Re: Issue 1514 in reviewboard: post-review.py doesn't allow parameters for http username/password

2010-03-01 Thread reviewboard
Comment #2 on issue 1514 by stodge: post-review.py doesn't allow parameters for http username/password http://code.google.com/p/reviewboard/issues/detail?id=1514 Created review request http://reviews.reviewboard.org/r/1441/. -- You received this message because you are listed in the owner

Issue 1521 in reviewboard: git format-patch/send-email equivalent workflow for post-review

2010-03-01 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1521 by emil.sit: git format-patch/send-email equivalent workflow for post-review http://code.google.com/p/reviewboard/issues/detail?id=1521 What version are you running? 1.5b1 Describe the enhancement

Re: Issue 1522 in reviewboard: SCMTool for Subversion fail to collapse 'keyword' correctly

2010-03-02 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1523 Comment #1 on issue 1522 by trowbrds: SCMTool for Subversion fail to collapse 'keyword' correctly http://code.google.com/p/reviewboard/issues/detail?id=1522 (No comment was entered for this change.) -- You received this message

Re: Issue 1523 in reviewboard: SCMTool for Subversion fail to collapse 'keyword' correctly

2010-03-02 Thread reviewboard
Comment #1 on issue 1523 by trowbrds: SCMTool for Subversion fail to collapse 'keyword' correctly http://code.google.com/p/reviewboard/issues/detail?id=1523 Issue 1522 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields

Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.

2010-03-02 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1524 by emil.sit: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 *NOTE: Do not post confidential information in this bug report.* What

Re: Issue 1191 in reviewboard: post-review with no arguments generated an empty review request

2010-03-02 Thread reviewboard
Comment #4 on issue 1191 by jamesdlin: post-review with no arguments generated an empty review request http://code.google.com/p/reviewboard/issues/detail?id=1191 BTW, similar stuff happens if I make a typo in the Perforce change number and no such changeset exists. -- You received

Issue 1525 in reviewboard: Function to expand hidden lines in a diff does not work for 1.5 Beta 1

2010-03-03 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1525 by jamesmcdougall: Function to expand hidden lines in a diff does not work for 1.5 Beta 1 http://code.google.com/p/reviewboard/issues/detail?id=1525 *NOTE: Do not post confidential information in this bug report

  1   2   3   4   5   6   7   8   9   10   >