headers for review groups in emails

2008-10-31 Thread Henry Andrews
Hi folks, Along the lines of issue #521 (http://code.google.com/p/reviewboard/issues/detail?id=521) but less extensive and intrusive, I have a patch to set an email header (currently X-ReviewBoard-Groups) to a comma-separated lists of the target groups. This allows email filtering without mu

Diff viewer problems

2008-10-31 Thread technofreak
I managed to successfully install review-board. I have created users and as a user I tried posting a new review request. Am successfully able to create a review request, where I attach a diff file taken from / (root dir) of my svn repsoitory. When I click on the "View Diff" tab in the review reque

Configuration for svn+ssh repository

2008-10-31 Thread Jim Lloyd
Hi, I've spent the last couple days installing and configuring reviewboard for the first time. We use a subversion repository and developers use the svn+ssh access method. My initial attempts to configure reviewboard to use svn+ssh failed. I was able to submit a change with post-review, and see th

Re: Configuration for svn+ssh repository

2008-10-31 Thread Jim Lloyd
FYI, I changed my configuration back to svn+ssh, with a 'reviewboard' user and password. I was able to submit a change with post-review, and see the new review request in reviewboard. But when I click through to see the diff, reviewboard shows me this stack crawl: Traceback (most recent call last)

Re: headers for review groups in emails

2008-10-31 Thread David Trowbridge
The best thing to do would be do post a review request on http://reviews.review-board.org/ If you want to add unit tests before posting the review, that would be awesome. I think this is only really documented as the "code reviews" link under "contributing" on the web site. We really need to wri

Re: headers for review groups in emails

2008-10-31 Thread Henry Andrews
Cool. I'll probably do it next week as it's a change I did for work and I'm off today :-) thanks, -henry - Original Message > From: David Trowbridge <[EMAIL PROTECTED]> > To: reviewboard@googlegroups.com > Sent: Friday, October 31, 2008 11:27:03 AM > Subject: Re: headers for review g