Re: Cannot enter text in popups

2008-12-30 Thread Ibmurai
s the case, just wait another half hour or so. The > next nightly should spin and 20081230 should fix it. > > A couple more things to verify though: > > 1) Are you using rb-site to install/maintain the site? If so, did you do > rb-site upgrade /path/to/site? > 2) Does clearing th

Minor installation nuisance

2008-12-30 Thread Ibmurai
I have a small problem with my ReviewBoard installation. I think it might be caused by a suboptimal apache2 configuration, but I'm not sure how to fix it. I have to put a symlink like so: #cd /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081228- py2.5.egg/reviewboard/ #ln -s /var/www/rev

Re: Submitted status is not intuitive

2008-12-30 Thread Ibmurai
My two cents: "Submitted" should be "Committed". To reflect the repo- lingo... On 23 Dec., 10:20, "Christian Hammond" wrote: > We're making this slightly less confusing in the upcoming UI rewrite. The > "Set Submitted" link is going away, and instead there will be a "Close" > drop-down with "Dis

Re: Minor installation nuisance

2008-12-30 Thread Christian Hammond
You definitely don't want a settings_local.py in the installed directory. This belongs only in the site directory. Your Apache configuration should be taking care of this if you used the template in conf/. What does your PythonPath line say? Christian -- Christian Hammond - chip...@chipx86.com

Re: Minor installation nuisance

2008-12-30 Thread Christian Hammond
Oops sorry, ignore that question. It's late here.. The problem is definitely that you used the wrong template. Your existing Apache config is using things like @pythondir@, which is from the template file in the Review Board source code used to generate the sample Apache config in your conf/ direc

Re: cache warning

2008-12-30 Thread Nithin Sujir
I see this warning as well when the review has about 15-20 or more files. For smaller reviews, it works. The warning prints the key and exception. In the log, the exception is blank. Nithin. On Dec 12, 6:28 am, TP wrote: > I see Djblets-0.4.dev_20081201-py2.4.egg under lib directory. > > Tam

Re: Minor installation nuisance

2008-12-30 Thread Ibmurai
Ah, sorry again... I must've changed it when I was trying to fix my installation. Copying the current apache-modpython.conf from the conf folder (which looks right, and doesn't have any @'s) in the site installation to sites-available fixed it :) On 30 Dec., 12:18, "Christian Hammond" wrote: >

Re: Minor installation nuisance

2008-12-30 Thread Christian Hammond
Not a problem. Glad to hear it's working :) Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Dec 30, 2008 at 3:41 AM, Ibmurai wrote: > > Ah, sorry again... > > I must've changed it when I was trying to fix my installation. > Copying the current apache-modpython.conf

Re: Get the latest diff from command line using ReviewBoard API

2008-12-30 Thread Jothiram
Hi Christian, The /r/{review_request_id}/diff/raw works from the web browser. But when I try to access it using the json API I get the following error: Unable to access http://172.16.98.82/api/json/reviewrequests/95/diff/raw (404). The host path may be invalid And so is the case with /r/{review

Re: Submitted status is not intuitive

2008-12-30 Thread Arthur Kalmenson
> My two cents: "Submitted" should be "Committed". To reflect the repo- > lingo... I agree... -- Arthur Kalmenson On Tue, Dec 30, 2008 at 5:53 AM, Ibmurai wrote: > > My two cents: "Submitted" should be "Committed". To reflect the repo- > lingo... > > On 23 Dec., 10:20, "Christian Hammond" w

Re: Get the latest diff from command line using ReviewBoard API

2008-12-30 Thread Jothiram
Hi Christian, Instead of getting the json object, I got the diff using http_get. Now it is working. Thanks, Jothiram On Dec 30, 8:47 am, Jothiram wrote: > Hi Christian, > > The /r/{review_request_id}/diff/raw works from the web browser. But > when I try to access it using the json API I get th

Re: Submitted status is not intuitive

2008-12-30 Thread Jeff Andros
Depends on which VCS you're using. CVS and SVN (and probably others) use the term "commit", but P4 at least uses the term "submit". I'm sure there are others as well. Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandr

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Tino Breddin
I agree, my question isn't exactly related to reviewboard and I should have been more specific. The vcs in this use-case is Subversion. Having multiple subversion checkouts might be a solution but suffers from a lot of overhead too. Thanks for the hint about the patch- management system Quilt, I'l

Re: New Review UI

2008-12-30 Thread ScottingItUp
Ok i manually updated djblets and reran the site upgrade and it is working now. The command "easy_install --upgrade ReviewBoard" does not auto upgrade djblets as the documentation says. On Dec 30, 12:35 am, "Christian Hammond" wrote: > This indicates your Djblets is out of date. Try to upgrade

Re: New Review UI

2008-12-30 Thread Christian Hammond
Yeah, setuptools seems inconsistent there. I'm working on a small wrapper that we'll eventually use that will handle all this correctly. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Dec 30, 2008 at 11:27 AM, ScottingItUp wrote: > > Ok i manually updated djblets an

Re: Submitted status is not intuitive

2008-12-30 Thread Christian Hammond
That's pretty much why we use Submit. This began as a small tool for use inside our team at VMware, where we used Perforce. I agree that Commit is more standard. We can make this change in the public UI, but the API and database will have to remain Submitted. I'm not loving the inconsistency there

Re: Submitted status is not intuitive

2008-12-30 Thread Jeff Andros
Christian Hammond wrote: > I agree that Commit is more standard. We can make this change in the > public UI, but the API and database will have to remain Submitted. I'm > not loving the inconsistency there, but there's not a great solution > to that. How much work would it be to make the UI d

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Christian Hammond
Hey Tino, What a lot of us are starting to do both at VMware and within Review Board is to use git as a form of patch management. Git can wrap around both SVN and Perforce, allowing us to do all our work within Git and then push to the proper VCS. My workflow is generally as follows: 1) Create a

Re: Submitted status is not intuitive

2008-12-30 Thread Christian Hammond
I'd rather not make it based on the VCS, because that just means two things to document and adds to confusion. We'd have to tell people which to click with examples of VCSs for each one, and that's a pain. If we renamed it in the UI, it'd be global. I'm actually leaning toward "Committed" just bec

Re: Get the latest diff from command line using ReviewBoard API

2008-12-30 Thread Christian Hammond
Hi Jothiram, At the moment, there's no API for the raw diff. We could add it, certainly. If someone wanted to work on a patch for it, it'd probably be really easy. Feel free to file a feature request on this. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Dec 30, 20

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Tino Breddin
Hi Christian, Thanks for the detailed explanation of your workflow. I was just looking into using git on the client side too, since I'm familiar with it and patch management is much easier just as you describe. Nevertheless I'd also like to see how other approaches which use subversion instead of

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Christian Hammond
Hi Tino, I'm working on user manuals for Review Board, which I'm hoping to finish up for 1.0. Right now, I'm about half way through a detailed Administration Guide. I'll try to keep in mind the workflows suggestion for the Users Guide. It would be interesting to hear from other people on this lis

Review Board with Beanstalk SVN?

2008-12-30 Thread georgetruong
Has anybody tried using Review Board with Beanstalk SVN? Trying it right now, but having issues getting the diff viewer to work correctly. http://www.beanstalkapp.com/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups