diff viewer character encoding

2010-02-23 Thread qhlonline
Hi, I am using the Reviewboard 1.0.5.1. Our Repository is CVS and language is simplified Chinese. I had found that some times, Reviewboard diff view will show unrecognizable Chinese characters. The RB1.5 said (Bug #1409) has been patched in this version, But I did not find difference about c

Re: Update dev build instructions

2010-02-23 Thread Raja
Thanks Christian, Filed http://reviews.reviewboard.org/r/1428 with the patch. On Feb 23, 12:45 am, Christian Hammond wrote: > Hi Raja, > > Would you mind filing a bug for tracking purposes? Or if you want to quickly > update them yourself, you could even modify the docs yourself > (reviewboard/do

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Raja
Doesnt the firstname, lastname and email set the values only on auth_user table? If its only setting it locally in the reviewboard database, wouldnt it be possible to include those variables even if the "auth_backend" is not "builtin"? The current preferences screen shows those 3 variables only i

About Reviewobard automation: Re-Generation of ReviewRequest

2010-02-23 Thread JohnHenry
Hi, all I am using RB1.0.5.1; We are making Reviewboard automation, So that after programmers commited code to CVS Repostitory, We will automatically generate ReviewRequest for them. I had made a script to call "post-review" to do this: = result =

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Stodge
I have a custom middleware: http://python.pastebin.com/wAcCNsTE I blank out the names and email address but this doesn't help. Is there something else I should be doing in my middleware? Thanks On Feb 22, 3:20 pm, Stephen Gallagher wrote: > On 02/22/2010 03:10 PM, Stodge wrote:> I'm using the

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Stodge
Ah - I think it's because I was still using the RemoteUserBackend. I disabled that and it seems to work ok. On Feb 23, 9:48 am, Stodge wrote: > I have a custom middleware: > > http://python.pastebin.com/wAcCNsTE > > I blank out the names and email address but this doesn't help. Is > there somethi

Re: ReviewBoard Error while posting review for GIT

2010-02-23 Thread Kunjal
Thanks ! The Path field should be the full path of the .git directory inside the checkout and this Path field is set in Admin GUI. How the user will keep update this path field in Admin GUI? That is not feasible right? Kunjal On Feb 22, 11:36 am, Christian Hammond wrote: > Never saw this e-ma

Re: ReviewBoard Error while posting review for GIT

2010-02-23 Thread Christian Hammond
The user never needs to deal with it. What will happen is that post-review will find the origin of whatever branch they're on (provided they have RBTools 0.2 RC1). It will find the repository path of that origin and look for that in Review Board. That's what must be in Path. As an example, let's

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Christian Hammond
Actually, it's probably okay to have it there for all backends. Ideally, we would stay in sync with the remote server (for LDAP, NIS and Active Directory) but we don't do that today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - htt

Re: About Reviewobard automation: Re-Generation of ReviewRequest

2010-02-23 Thread Christian Hammond
I don't know off-hand, and wouldn't necessarily be able to reproduce without actually messing with your system. I'd recommend that you run some tests using a modified copy of post-review with some extra logging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.revie

RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Pv
I have installed a fresh copy of Win7 x64 and VS2K8. I then installed Py2.6 + RBTools 0.2rc1. I create a new C# project, svn add, and then post-review the project. I get a "UnicodeDecodeError" on the Solution's/Project's xml/config files. There is a signature of "\xef\xbb\xbf" at the beginning of t

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Pv
NOTE: If I manually browse to my reviewboard server and upload the diff it accepts it no problem. I am not doing anything to intentionally encode these files beyond the default VS2K8 encoding. Pv On Feb 23, 4:20 pm, Pv wrote: > I have installed a fresh copy of Win7 x64 and VS2K8. > I then insta

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Christian Hammond
Hi Pv, Which version of Review Board is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Feb 23, 2010 at 4:26 PM, Pv wrote: > NOTE: If I manually browse to my reviewboard server and upload the >