Re: Mail features
> You can go ahead and join groups with this method and still not > receive emails. We only email people individually if there is no > mailing list associated with the group. People can join the group but > not the mailing list and shouldn't see the emails. We do not have an internal mailing list system, only lotus notes (sigh) groups which are created by the it-department. These are quite static and not something the individual users can change. I would therefore find it useful that users can configure this in review- board. -- Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Mail features
You can go ahead and join groups with this method and still not receive emails. We only email people individually if there is no mailing list associated with the group. People can join the group but not the mailing list and shouldn't see the emails. Now, if you are on the target reviewer list or you ever review the review request, you will be directly on the CC list. This we can make optional in a future version. Christian On Tuesday, June 2, 2009, Helder Ribeiro wrote: > > On Tue, Jun 2, 2009 at 3:52 PM, Chris Clark wrote: >> >> Vesterbaek wrote: >>> I would find it useful to to be able to configure this independently >>> for groups and people, such that a user can choose to be member of a >>> particular group, but not receive any emails from review requests to >>> that group, but only get emails if a review request is directed at the >>> user (listed in "people"). >>> >>> Usecase: >>> - We have a number of development teams, which each map to one or >>> more reviewboard groups. I've setup "default reviewers" for the >>> different groups based on the repository paths of the files in the >>> review requests. We do it this way to make sure that all developers >>> can easily stay orientated about different review requests that is >>> relevant for them, and possibly comment if they feel like doing so. >>> They should not (be forced to) receive emails about these group review >>> requests. Mandatory reviewers are put in the "peoples" field, and >>> these should normally receive emails. >>> >> >> The way we tackle this is with (Mailman) mailing lists. People join the >> mailing list and have the usual options; all emails, digest, or no emails. >> >> We then making the mailing-list-email-address the group email address >> and NEVER add anyone to the Reviewboard groups. >> >> Then when posting a review add the group, and the specific people. > > Great idea! So this way the review requests don't get listed on > people's reviewboard inbox right? Can they be browsed somewhere? I was > looking for a way to make review requests feel more "optional" as a > way to introduce code review in a company that's not used to it. This > way I could install a post-receive-hook that would create a review > request for every commit, but that wouldn't make anyone responsible > for it. This way people could just browse past commits and comment on > them if they felt like it. Hopefully feedback would increase to a > point where more formal adoption could be established. > >> >> Not exactly what you asked for but can accomplish the same thing. This >> works for us as we had an existing mailing list already in place, >> reviewboard simply makes life easier for the people that want to use >> Reviewboard, this use case may not work for everyone. >> >> Chris >> >> >> > >> > > > > -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Mail features
On Tue, Jun 2, 2009 at 3:52 PM, Chris Clark wrote: > > Vesterbaek wrote: >> I would find it useful to to be able to configure this independently >> for groups and people, such that a user can choose to be member of a >> particular group, but not receive any emails from review requests to >> that group, but only get emails if a review request is directed at the >> user (listed in "people"). >> >> Usecase: >> - We have a number of development teams, which each map to one or >> more reviewboard groups. I've setup "default reviewers" for the >> different groups based on the repository paths of the files in the >> review requests. We do it this way to make sure that all developers >> can easily stay orientated about different review requests that is >> relevant for them, and possibly comment if they feel like doing so. >> They should not (be forced to) receive emails about these group review >> requests. Mandatory reviewers are put in the "peoples" field, and >> these should normally receive emails. >> > > The way we tackle this is with (Mailman) mailing lists. People join the > mailing list and have the usual options; all emails, digest, or no emails. > > We then making the mailing-list-email-address the group email address > and NEVER add anyone to the Reviewboard groups. > > Then when posting a review add the group, and the specific people. Great idea! So this way the review requests don't get listed on people's reviewboard inbox right? Can they be browsed somewhere? I was looking for a way to make review requests feel more "optional" as a way to introduce code review in a company that's not used to it. This way I could install a post-receive-hook that would create a review request for every commit, but that wouldn't make anyone responsible for it. This way people could just browse past commits and comment on them if they felt like it. Hopefully feedback would increase to a point where more formal adoption could be established. > > Not exactly what you asked for but can accomplish the same thing. This > works for us as we had an existing mailing list already in place, > reviewboard simply makes life easier for the people that want to use > Reviewboard, this use case may not work for everyone. > > Chris > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Mail features
Vesterbaek wrote: > I would find it useful to to be able to configure this independently > for groups and people, such that a user can choose to be member of a > particular group, but not receive any emails from review requests to > that group, but only get emails if a review request is directed at the > user (listed in "people"). > > Usecase: > - We have a number of development teams, which each map to one or > more reviewboard groups. I've setup "default reviewers" for the > different groups based on the repository paths of the files in the > review requests. We do it this way to make sure that all developers > can easily stay orientated about different review requests that is > relevant for them, and possibly comment if they feel like doing so. > They should not (be forced to) receive emails about these group review > requests. Mandatory reviewers are put in the "peoples" field, and > these should normally receive emails. > The way we tackle this is with (Mailman) mailing lists. People join the mailing list and have the usual options; all emails, digest, or no emails. We then making the mailing-list-email-address the group email address and NEVER add anyone to the Reviewboard groups. Then when posting a review add the group, and the specific people. Not exactly what you asked for but can accomplish the same thing. This works for us as we had an existing mailing list already in place, reviewboard simply makes life easier for the people that want to use Reviewboard, this use case may not work for everyone. Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Mail features
I would find it useful to to be able to configure this independently for groups and people, such that a user can choose to be member of a particular group, but not receive any emails from review requests to that group, but only get emails if a review request is directed at the user (listed in "people"). Usecase: - We have a number of development teams, which each map to one or more reviewboard groups. I've setup "default reviewers" for the different groups based on the repository paths of the files in the review requests. We do it this way to make sure that all developers can easily stay orientated about different review requests that is relevant for them, and possibly comment if they feel like doing so. They should not (be forced to) receive emails about these group review requests. Mandatory reviewers are put in the "peoples" field, and these should normally receive emails. -- Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Mail features
Hello, I have been deploying Reviewboard within our environment, and it has gotten a good level of adoption and praise for its ease of use. One area that I have had some questions about is email. People would like to have more control over the amount of mail they receive. I was considering extending the accounts model to include boolean fields to control the following 4 things. 1. Receive email for my own actions. - This would allow people to not get an email for any action they perform in Review board that generates an email. The reasoning is that they know what they did, and don't need to see an email about it. 2. Receive review request emails 3. Receive review emails 4. Receive reply emails The reasoning on those 3 is that some individuals are using the tool heavily and as such are logging in and viewing the review requests assigned to them, and the reviews that they have posted, and don't more mail that they need to filter off. This change would involved updating the accounts model, the 'My account' view and some of the code in email.py mostly get_email_address_for_user and send_review_mail Thoughts/comments always appreciated. Scott Quesnelle --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
